Browse Source

Fixed #25204 -- Added missing space in runserver logging.

Tim Graham 9 years ago
parent
commit
1a76257b1b
2 changed files with 11 additions and 1 deletions
  1. 1 1
      django/core/servers/basehttp.py
  2. 10 0
      tests/servers/test_basehttp.py

+ 1 - 1
django/core/servers/basehttp.py

@@ -104,7 +104,7 @@ class WSGIRequestHandler(simple_server.WSGIRequestHandler, object):
 
     def log_message(self, format, *args):
 
-        msg = "[%s]" % self.log_date_time_string()
+        msg = "[%s] " % self.log_date_time_string()
         try:
             msg += "%s\n" % (format % args)
         except UnicodeDecodeError:

+ 10 - 0
tests/servers/test_basehttp.py

@@ -13,6 +13,16 @@ class Stub(object):
 
 
 class WSGIRequestHandlerTestCase(SimpleTestCase):
+
+    def test_log_message(self):
+        request = WSGIRequest(RequestFactory().get('/').environ)
+        request.makefile = lambda *args, **kwargs: BytesIO()
+        handler = WSGIRequestHandler(request, '192.168.0.2', None)
+
+        with captured_stderr() as stderr:
+            handler.log_message('GET %s %s', 'A', 'B')
+        self.assertIn('] GET A B', stderr.getvalue())
+
     def test_https(self):
         request = WSGIRequest(RequestFactory().get('/').environ)
         request.makefile = lambda *args, **kwargs: BytesIO()