Răsfoiți Sursa

Fixed #26357 -- Allowed admin popups to work on links added after page load.

Julian Andrews 9 ani în urmă
părinte
comite
adc93e8599

+ 1 - 1
django/contrib/admin/static/admin/js/admin/RelatedObjectLookups.js

@@ -162,7 +162,7 @@
             }
         });
         $('.related-widget-wrapper select').trigger('change');
-        $('.related-lookup').click(function(e) {
+        $('body').on('click', '.related-lookup', function(e) {
             e.preventDefault();
             var event = $.Event('django:lookup-related');
             $(this).trigger(event);

+ 1 - 1
django/contrib/admin/static/admin/js/change_form.js

@@ -4,7 +4,7 @@
     'use strict';
     $(document).ready(function() {
         var modelName = $('#django-admin-form-add-constants').data('modelName');
-        $('.add-another').click(function(e) {
+        $('body').on('click', '.add-another', function(e) {
             e.preventDefault();
             var event = $.Event('django:add-another-related');
             $(this).trigger(event);

+ 6 - 0
docs/internals/contributing/writing-code/javascript.txt

@@ -24,6 +24,12 @@ Code style
   JSHint will be run when you run the JavaScript tests. We also recommended
   installing a JSHint plugin in your text editor.
 
+* Where possible, write code that will work even if the page structure is later
+  changed with JavaScript. For instance, when binding a click handler, use
+  ``$('body').on('click', selector, func)`` instead of
+  ``$(selector).click(func)``. This makes it easier for projects to extend
+  Django's default behavior with JavaScript.
+
 .. _javascript-patches:
 
 JavaScript patches