Browse Source

Refs #26709 -- Added type check for models.Index fields argument.

Akshesh 8 years ago
parent
commit
c969b17ad8
2 changed files with 6 additions and 0 deletions
  1. 2 0
      django/db/models/indexes.py
  2. 4 0
      tests/model_indexes/tests.py

+ 2 - 0
django/db/models/indexes.py

@@ -14,6 +14,8 @@ class Index(object):
     suffix = 'idx'
     suffix = 'idx'
 
 
     def __init__(self, fields=[], name=None):
     def __init__(self, fields=[], name=None):
+        if not isinstance(fields, list):
+            raise ValueError('Index.fields must be a list.')
         if not fields:
         if not fields:
             raise ValueError('At least one field is required to define an index.')
             raise ValueError('At least one field is required to define an index.')
         self.fields = fields
         self.fields = fields

+ 4 - 0
tests/model_indexes/tests.py

@@ -22,6 +22,10 @@ class IndexesTests(TestCase):
         self.assertEqual(index, same_index)
         self.assertEqual(index, same_index)
         self.assertNotEqual(index, another_index)
         self.assertNotEqual(index, another_index)
 
 
+    def test_index_fields_type(self):
+        with self.assertRaisesMessage(ValueError, 'Index.fields must be a list.'):
+            models.Index(fields='title')
+
     def test_raises_error_without_field(self):
     def test_raises_error_without_field(self):
         msg = 'At least one field is required to define an index.'
         msg = 'At least one field is required to define an index.'
         with self.assertRaisesMessage(ValueError, msg):
         with self.assertRaisesMessage(ValueError, msg):