فهرست منبع

Fixed #27152 -- Supported comma delimiter in memcached LOCATION string.

Ed Morley 8 سال پیش
والد
کامیت
d8ef5b0e65
4فایلهای تغییر یافته به همراه14 افزوده شده و 3 حذف شده
  1. 2 1
      django/core/cache/backends/memcached.py
  2. 4 0
      docs/releases/1.11.txt
  3. 7 2
      docs/topics/cache.txt
  4. 1 0
      tests/cache/tests.py

+ 2 - 1
django/core/cache/backends/memcached.py

@@ -1,6 +1,7 @@
 "Memcached cache backend"
 
 import pickle
+import re
 import time
 import warnings
 
@@ -15,7 +16,7 @@ class BaseMemcachedCache(BaseCache):
     def __init__(self, server, params, library, value_not_found_exception):
         super(BaseMemcachedCache, self).__init__(params)
         if isinstance(server, six.string_types):
-            self._servers = server.split(';')
+            self._servers = re.split('[;,]', server)
         else:
             self._servers = server
 

+ 4 - 0
docs/releases/1.11.txt

@@ -173,6 +173,10 @@ Cache
   control of client behavior. See the :ref:`cache arguments <cache_arguments>`
   documentation for examples.
 
+* Memcached backends now allow defining multiple servers as a comma-delimited
+  string in :setting:`LOCATION <CACHES-LOCATION>`, for convenience with
+  third-party services that use such strings in environment variables.
+
 CSRF
 ~~~~
 

+ 7 - 2
docs/topics/cache.txt

@@ -128,8 +128,8 @@ multiple servers. This means you can run Memcached daemons on multiple
 machines, and the program will treat the group of machines as a *single*
 cache, without the need to duplicate cache values on each machine. To take
 advantage of this feature, include all server addresses in
-:setting:`LOCATION <CACHES-LOCATION>`, either separated by semicolons or as
-a list.
+:setting:`LOCATION <CACHES-LOCATION>`, either as a semicolon or comma
+delimited string, or as a list.
 
 In this example, the cache is shared over Memcached instances running on IP
 address 172.19.26.240 and 172.19.26.242, both on port 11211::
@@ -168,6 +168,11 @@ permanent storage -- they're all intended to be solutions for caching, not
 storage -- but we point this out here because memory-based caching is
 particularly temporary.
 
+.. versionchanged:: 1.11
+
+    The :setting:`LOCATION <CACHES-LOCATION>` setting now supports defining
+    multiple servers as a comma-delimited string.
+
 .. _database-caching:
 
 Database caching

+ 1 - 0
tests/cache/tests.py

@@ -1160,6 +1160,7 @@ class BaseMemcachedTests(BaseCacheTests):
         locations = [
             ['server1.tld', 'server2:11211'],
             'server1.tld;server2:11211',
+            'server1.tld,server2:11211',
         ]
         for location in locations:
             params = {'BACKEND': self.base_params['BACKEND'], 'LOCATION': location}