Browse Source

Fixed #31978 -- Added username hint to admin's password reset confirmation form.

Collin Anderson 4 years ago
parent
commit
daa26acc4e

+ 1 - 0
django/contrib/admin/templates/registration/password_reset_confirm.html

@@ -19,6 +19,7 @@
 
 <form method="post">{% csrf_token %}
 <fieldset class="module aligned">
+    <input style="display: none;" autocomplete="username" value="{{ form.user.username }}">
     <div class="form-row field-password1">
         {{ form.new_password1.errors }}
         <label for="id_new_password1">{% translate 'New password:' %}</label>

+ 6 - 0
tests/auth_tests/test_templates.py

@@ -52,6 +52,12 @@ class AuthTemplateTests(TestCase):
         response = client.get(url)
         self.assertContains(response, '<title>Enter new password</title>')
         self.assertContains(response, '<h1>Enter new password</h1>')
+        # The username is added to the password reset confirmation form to help
+        # browser's password managers.
+        self.assertContains(
+            response,
+            '<input style="display: none;" autocomplete="username" value="jsmith">',
+        )
 
     def test_PasswordResetCompleteView(self):
         response = PasswordResetCompleteView.as_view()(self.request)