Browse Source

Fixed ResourceWarning from unclosed test files.

When running Django tests with Python warnings enabled.
Jon Dufresne 6 years ago
parent
commit
e7d7d47b93
1 changed files with 4 additions and 2 deletions
  1. 4 2
      tests/file_storage/tests.py

+ 4 - 2
tests/file_storage/tests.py

@@ -595,12 +595,14 @@ class OverwritingStorageTests(FileStorageTests):
             self.assertEqual(stored_name_1, name)
             self.assertTrue(self.storage.exists(name))
             self.assertTrue(os.path.exists(os.path.join(self.temp_dir, name)))
-            self.assertEqual(self.storage.open(name).read(), content_1)
+            with self.storage.open(name) as fp:
+                self.assertEqual(fp.read(), content_1)
             stored_name_2 = self.storage.save(name, f_2)
             self.assertEqual(stored_name_2, name)
             self.assertTrue(self.storage.exists(name))
             self.assertTrue(os.path.exists(os.path.join(self.temp_dir, name)))
-            self.assertEqual(self.storage.open(name).read(), content_2)
+            with self.storage.open(name) as fp:
+                self.assertEqual(fp.read(), content_2)
         finally:
             self.storage.delete(name)