test_logentry.py 18 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454
  1. import json
  2. from datetime import datetime
  3. from django.contrib.admin.models import ADDITION, CHANGE, DELETION, LogEntry
  4. from django.contrib.admin.utils import quote
  5. from django.contrib.auth.models import User
  6. from django.contrib.contenttypes.models import ContentType
  7. from django.db.models.signals import post_save, pre_save
  8. from django.test import TestCase, override_settings
  9. from django.urls import reverse
  10. from django.utils import translation
  11. from django.utils.html import escape
  12. from .models import Article, ArticleProxy, Car, Site
  13. @override_settings(ROOT_URLCONF="admin_utils.urls")
  14. class LogEntryTests(TestCase):
  15. @classmethod
  16. def setUpTestData(cls):
  17. cls.user = User.objects.create_superuser(
  18. username="super", password="secret", email="super@example.com"
  19. )
  20. cls.site = Site.objects.create(domain="example.org")
  21. cls.a1 = Article.objects.create(
  22. site=cls.site,
  23. title="Title",
  24. created=datetime(2008, 3, 12, 11, 54),
  25. )
  26. cls.a2 = Article.objects.create(
  27. site=cls.site,
  28. title="Title 2",
  29. created=datetime(2009, 3, 12, 11, 54),
  30. )
  31. cls.a3 = Article.objects.create(
  32. site=cls.site,
  33. title="Title 3",
  34. created=datetime(2010, 3, 12, 11, 54),
  35. )
  36. LogEntry.objects.log_actions(
  37. cls.user.pk,
  38. [cls.a1],
  39. CHANGE,
  40. change_message="Changed something",
  41. )
  42. def setUp(self):
  43. self.client.force_login(self.user)
  44. self.signals = []
  45. pre_save.connect(self.pre_save_listener, sender=LogEntry)
  46. self.addCleanup(pre_save.disconnect, self.pre_save_listener, sender=LogEntry)
  47. post_save.connect(self.post_save_listener, sender=LogEntry)
  48. self.addCleanup(post_save.disconnect, self.post_save_listener, sender=LogEntry)
  49. def pre_save_listener(self, instance, **kwargs):
  50. self.signals.append(("pre_save", instance))
  51. def post_save_listener(self, instance, created, **kwargs):
  52. self.signals.append(("post_save", instance, created))
  53. def test_logentry_save(self):
  54. """
  55. LogEntry.action_time is a timestamp of the date when the entry was
  56. created. It shouldn't be updated on a subsequent save().
  57. """
  58. logentry = LogEntry.objects.get(content_type__model__iexact="article")
  59. action_time = logentry.action_time
  60. logentry.save()
  61. self.assertEqual(logentry.action_time, action_time)
  62. def test_logentry_change_message(self):
  63. """
  64. LogEntry.change_message is stored as a dumped JSON structure to be able
  65. to get the message dynamically translated at display time.
  66. """
  67. post_data = {
  68. "site": self.site.pk,
  69. "title": "Changed",
  70. "hist": "Some content",
  71. "created_0": "2008-03-12",
  72. "created_1": "11:54",
  73. }
  74. change_url = reverse(
  75. "admin:admin_utils_article_change", args=[quote(self.a1.pk)]
  76. )
  77. response = self.client.post(change_url, post_data)
  78. self.assertRedirects(response, reverse("admin:admin_utils_article_changelist"))
  79. logentry = LogEntry.objects.filter(
  80. content_type__model__iexact="article"
  81. ).latest("id")
  82. self.assertEqual(logentry.get_change_message(), "Changed Title and History.")
  83. with translation.override("fr"):
  84. self.assertEqual(
  85. logentry.get_change_message(), "Modification de Title et Historique."
  86. )
  87. add_url = reverse("admin:admin_utils_article_add")
  88. post_data["title"] = "New"
  89. response = self.client.post(add_url, post_data)
  90. self.assertRedirects(response, reverse("admin:admin_utils_article_changelist"))
  91. logentry = LogEntry.objects.filter(
  92. content_type__model__iexact="article"
  93. ).latest("id")
  94. self.assertEqual(logentry.get_change_message(), "Added.")
  95. with translation.override("fr"):
  96. self.assertEqual(logentry.get_change_message(), "Ajout.")
  97. def test_logentry_change_message_not_json(self):
  98. """LogEntry.change_message was a string before Django 1.10."""
  99. logentry = LogEntry(change_message="non-JSON string")
  100. self.assertEqual(logentry.get_change_message(), logentry.change_message)
  101. def test_logentry_change_message_localized_datetime_input(self):
  102. """
  103. Localized date/time inputs shouldn't affect changed form data detection.
  104. """
  105. post_data = {
  106. "site": self.site.pk,
  107. "title": "Changed",
  108. "hist": "Some content",
  109. "created_0": "12/03/2008",
  110. "created_1": "11:54",
  111. }
  112. with translation.override("fr"):
  113. change_url = reverse(
  114. "admin:admin_utils_article_change", args=[quote(self.a1.pk)]
  115. )
  116. response = self.client.post(change_url, post_data)
  117. self.assertRedirects(
  118. response, reverse("admin:admin_utils_article_changelist")
  119. )
  120. logentry = LogEntry.objects.filter(
  121. content_type__model__iexact="article"
  122. ).latest("id")
  123. self.assertEqual(logentry.get_change_message(), "Changed Title and History.")
  124. def test_logentry_change_message_formsets(self):
  125. """
  126. All messages for changed formsets are logged in a change message.
  127. """
  128. a2 = Article.objects.create(
  129. site=self.site,
  130. title="Title second article",
  131. created=datetime(2012, 3, 18, 11, 54),
  132. )
  133. post_data = {
  134. "domain": "example.com", # domain changed
  135. "admin_articles-TOTAL_FORMS": "5",
  136. "admin_articles-INITIAL_FORMS": "2",
  137. "admin_articles-MIN_NUM_FORMS": "0",
  138. "admin_articles-MAX_NUM_FORMS": "1000",
  139. # Changed title for 1st article
  140. "admin_articles-0-id": str(self.a1.pk),
  141. "admin_articles-0-site": str(self.site.pk),
  142. "admin_articles-0-title": "Changed Title",
  143. # Second article is deleted
  144. "admin_articles-1-id": str(a2.pk),
  145. "admin_articles-1-site": str(self.site.pk),
  146. "admin_articles-1-title": "Title second article",
  147. "admin_articles-1-DELETE": "on",
  148. # A new article is added
  149. "admin_articles-2-site": str(self.site.pk),
  150. "admin_articles-2-title": "Added article",
  151. }
  152. change_url = reverse(
  153. "admin:admin_utils_site_change", args=[quote(self.site.pk)]
  154. )
  155. response = self.client.post(change_url, post_data)
  156. self.assertRedirects(response, reverse("admin:admin_utils_site_changelist"))
  157. self.assertSequenceEqual(Article.objects.filter(pk=a2.pk), [])
  158. logentry = LogEntry.objects.filter(content_type__model__iexact="site").latest(
  159. "action_time"
  160. )
  161. self.assertEqual(
  162. json.loads(logentry.change_message),
  163. [
  164. {"changed": {"fields": ["Domain"]}},
  165. {"added": {"object": "Added article", "name": "article"}},
  166. {
  167. "changed": {
  168. "fields": ["Title", "not_a_form_field"],
  169. "object": "Changed Title",
  170. "name": "article",
  171. }
  172. },
  173. {"deleted": {"object": "Title second article", "name": "article"}},
  174. ],
  175. )
  176. self.assertEqual(
  177. logentry.get_change_message(),
  178. "Changed Domain. Added article “Added article”. "
  179. "Changed Title and not_a_form_field for article “Changed Title”. "
  180. "Deleted article “Title second article”.",
  181. )
  182. with translation.override("fr"):
  183. self.assertEqual(
  184. logentry.get_change_message(),
  185. "Modification de Domain. Ajout de article « Added article ». "
  186. "Modification de Title et not_a_form_field pour l'objet "
  187. "article « Changed Title ». "
  188. "Suppression de article « Title second article ».",
  189. )
  190. def test_logentry_get_edited_object(self):
  191. """
  192. LogEntry.get_edited_object() returns the edited object of a LogEntry
  193. object.
  194. """
  195. logentry = LogEntry.objects.get(content_type__model__iexact="article")
  196. edited_obj = logentry.get_edited_object()
  197. self.assertEqual(logentry.object_id, str(edited_obj.pk))
  198. def test_logentry_get_admin_url(self):
  199. """
  200. LogEntry.get_admin_url returns a URL to edit the entry's object or
  201. None for nonexistent (possibly deleted) models.
  202. """
  203. logentry = LogEntry.objects.get(content_type__model__iexact="article")
  204. expected_url = reverse(
  205. "admin:admin_utils_article_change", args=(quote(self.a1.pk),)
  206. )
  207. self.assertEqual(logentry.get_admin_url(), expected_url)
  208. self.assertIn("article/%d/change/" % self.a1.pk, logentry.get_admin_url())
  209. logentry.content_type.model = "nonexistent"
  210. self.assertIsNone(logentry.get_admin_url())
  211. def test_logentry_unicode(self):
  212. log_entry = LogEntry()
  213. log_entry.action_flag = ADDITION
  214. self.assertTrue(str(log_entry).startswith("Added "))
  215. log_entry.action_flag = CHANGE
  216. self.assertTrue(str(log_entry).startswith("Changed "))
  217. log_entry.action_flag = DELETION
  218. self.assertTrue(str(log_entry).startswith("Deleted "))
  219. # Make sure custom action_flags works
  220. log_entry.action_flag = 4
  221. self.assertEqual(str(log_entry), "LogEntry Object")
  222. def test_logentry_repr(self):
  223. logentry = LogEntry.objects.first()
  224. self.assertEqual(repr(logentry), str(logentry.action_time))
  225. def test_log_actions(self):
  226. queryset = Article.objects.all().order_by("-id")
  227. msg = "Deleted Something"
  228. content_type = ContentType.objects.get_for_model(self.a1)
  229. self.assertEqual(len(queryset), 3)
  230. with self.assertNumQueries(1):
  231. result = LogEntry.objects.log_actions(
  232. self.user.pk,
  233. queryset,
  234. DELETION,
  235. change_message=msg,
  236. )
  237. self.assertEqual(len(result), len(queryset))
  238. logs = (
  239. LogEntry.objects.filter(action_flag=DELETION)
  240. .order_by("id")
  241. .values_list(
  242. "user",
  243. "content_type",
  244. "object_id",
  245. "object_repr",
  246. "action_flag",
  247. "change_message",
  248. )
  249. )
  250. expected_log_values = [
  251. (
  252. self.user.pk,
  253. content_type.id,
  254. str(obj.pk),
  255. str(obj),
  256. DELETION,
  257. msg,
  258. )
  259. for obj in queryset
  260. ]
  261. result_logs = [
  262. (
  263. entry.user_id,
  264. entry.content_type_id,
  265. str(entry.object_id),
  266. entry.object_repr,
  267. entry.action_flag,
  268. entry.change_message,
  269. )
  270. for entry in result
  271. ]
  272. self.assertSequenceEqual(logs, result_logs)
  273. self.assertSequenceEqual(logs, expected_log_values)
  274. self.assertEqual(self.signals, [])
  275. def test_log_actions_single_object_param(self):
  276. queryset = Article.objects.filter(pk=self.a1.pk)
  277. msg = "Deleted Something"
  278. content_type = ContentType.objects.get_for_model(self.a1)
  279. self.assertEqual(len(queryset), 1)
  280. for single_object in (True, False):
  281. self.signals = []
  282. with self.subTest(single_object=single_object), self.assertNumQueries(1):
  283. result = LogEntry.objects.log_actions(
  284. self.user.pk,
  285. queryset,
  286. DELETION,
  287. change_message=msg,
  288. single_object=single_object,
  289. )
  290. if single_object:
  291. self.assertIsInstance(result, LogEntry)
  292. entry = result
  293. else:
  294. self.assertIsInstance(result, list)
  295. self.assertEqual(len(result), 1)
  296. entry = result[0]
  297. self.assertEqual(entry.user_id, self.user.pk)
  298. self.assertEqual(entry.content_type_id, content_type.id)
  299. self.assertEqual(str(entry.object_id), str(self.a1.pk))
  300. self.assertEqual(entry.object_repr, str(self.a1))
  301. self.assertEqual(entry.action_flag, DELETION)
  302. self.assertEqual(entry.change_message, msg)
  303. expected_signals = [
  304. ("pre_save", entry),
  305. ("post_save", entry, True),
  306. ]
  307. self.assertEqual(self.signals, expected_signals)
  308. def test_recentactions_without_content_type(self):
  309. """
  310. If a LogEntry is missing content_type it will not display it in span
  311. tag under the hyperlink.
  312. """
  313. response = self.client.get(reverse("admin:index"))
  314. link = reverse("admin:admin_utils_article_change", args=(quote(self.a1.pk),))
  315. should_contain = """<a href="%s">%s</a>""" % (
  316. escape(link),
  317. escape(str(self.a1)),
  318. )
  319. self.assertContains(response, should_contain)
  320. should_contain = "Article"
  321. self.assertContains(response, should_contain)
  322. logentry = LogEntry.objects.get(content_type__model__iexact="article")
  323. # If the log entry doesn't have a content type it should still be
  324. # possible to view the Recent Actions part (#10275).
  325. logentry.content_type = None
  326. logentry.save()
  327. should_contain = should_contain.encode()
  328. counted_presence_before = response.content.count(should_contain)
  329. response = self.client.get(reverse("admin:index"))
  330. counted_presence_after = response.content.count(should_contain)
  331. self.assertEqual(counted_presence_before - 1, counted_presence_after)
  332. def test_proxy_model_content_type_is_used_for_log_entries(self):
  333. """
  334. Log entries for proxy models should have the proxy model's contenttype
  335. (#21084).
  336. """
  337. proxy_content_type = ContentType.objects.get_for_model(
  338. ArticleProxy, for_concrete_model=False
  339. )
  340. post_data = {
  341. "site": self.site.pk,
  342. "title": "Foo",
  343. "hist": "Bar",
  344. "created_0": "2015-12-25",
  345. "created_1": "00:00",
  346. }
  347. changelist_url = reverse("admin:admin_utils_articleproxy_changelist")
  348. expected_signals = []
  349. self.assertEqual(self.signals, expected_signals)
  350. # add
  351. proxy_add_url = reverse("admin:admin_utils_articleproxy_add")
  352. response = self.client.post(proxy_add_url, post_data)
  353. self.assertRedirects(response, changelist_url)
  354. proxy_addition_log = LogEntry.objects.latest("id")
  355. self.assertEqual(proxy_addition_log.action_flag, ADDITION)
  356. self.assertEqual(proxy_addition_log.content_type, proxy_content_type)
  357. expected_signals.extend(
  358. [("pre_save", proxy_addition_log), ("post_save", proxy_addition_log, True)]
  359. )
  360. self.assertEqual(self.signals, expected_signals)
  361. # change
  362. article_id = proxy_addition_log.object_id
  363. proxy_change_url = reverse(
  364. "admin:admin_utils_articleproxy_change", args=(article_id,)
  365. )
  366. post_data["title"] = "New"
  367. response = self.client.post(proxy_change_url, post_data)
  368. self.assertRedirects(response, changelist_url)
  369. proxy_change_log = LogEntry.objects.latest("id")
  370. self.assertEqual(proxy_change_log.action_flag, CHANGE)
  371. self.assertEqual(proxy_change_log.content_type, proxy_content_type)
  372. expected_signals.extend(
  373. [("pre_save", proxy_change_log), ("post_save", proxy_change_log, True)]
  374. )
  375. self.assertEqual(self.signals, expected_signals)
  376. # delete
  377. proxy_delete_url = reverse(
  378. "admin:admin_utils_articleproxy_delete", args=(article_id,)
  379. )
  380. response = self.client.post(proxy_delete_url, {"post": "yes"})
  381. self.assertRedirects(response, changelist_url)
  382. proxy_delete_log = LogEntry.objects.latest("id")
  383. self.assertEqual(proxy_delete_log.action_flag, DELETION)
  384. self.assertEqual(proxy_delete_log.content_type, proxy_content_type)
  385. expected_signals.extend(
  386. [("pre_save", proxy_delete_log), ("post_save", proxy_delete_log, True)]
  387. )
  388. self.assertEqual(self.signals, expected_signals)
  389. def test_action_flag_choices(self):
  390. tests = ((1, "Addition"), (2, "Change"), (3, "Deletion"))
  391. for action_flag, display_name in tests:
  392. with self.subTest(action_flag=action_flag):
  393. log = LogEntry(action_flag=action_flag)
  394. self.assertEqual(log.get_action_flag_display(), display_name)
  395. def test_hook_get_log_entries(self):
  396. LogEntry.objects.log_actions(
  397. self.user.pk,
  398. [self.a1],
  399. CHANGE,
  400. change_message="Article changed message",
  401. )
  402. c1 = Car.objects.create()
  403. LogEntry.objects.log_actions(
  404. self.user.pk,
  405. [c1],
  406. ADDITION,
  407. change_message="Car created message",
  408. )
  409. exp_str_article = escape(str(self.a1))
  410. exp_str_car = escape(str(c1))
  411. response = self.client.get(reverse("admin:index"))
  412. self.assertContains(response, exp_str_article)
  413. self.assertContains(response, exp_str_car)
  414. # site "custom_admin" only renders log entries of registered models
  415. response = self.client.get(reverse("custom_admin:index"))
  416. self.assertContains(response, exp_str_article)
  417. self.assertNotContains(response, exp_str_car)