tests.py 38 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956
  1. # -*- coding: utf-8 -*-
  2. from __future__ import unicode_literals
  3. import errno
  4. import os
  5. import shutil
  6. import sys
  7. import tempfile
  8. import threading
  9. import time
  10. import unittest
  11. from datetime import datetime, timedelta
  12. from django.core.cache import cache
  13. from django.core.exceptions import SuspiciousFileOperation, SuspiciousOperation
  14. from django.core.files.base import ContentFile, File
  15. from django.core.files.storage import FileSystemStorage, get_storage_class
  16. from django.core.files.uploadedfile import (
  17. InMemoryUploadedFile, SimpleUploadedFile, TemporaryUploadedFile,
  18. )
  19. from django.db.models.fields.files import FileDescriptor
  20. from django.test import (
  21. LiveServerTestCase, SimpleTestCase, TestCase, override_settings,
  22. )
  23. from django.test.utils import requires_tz_support
  24. from django.urls import NoReverseMatch, reverse_lazy
  25. from django.utils import six, timezone
  26. from django.utils._os import upath
  27. from django.utils.six.moves.urllib.request import urlopen
  28. from .models import Storage, temp_storage, temp_storage_location
  29. FILE_SUFFIX_REGEX = '[A-Za-z0-9]{7}'
  30. class GetStorageClassTests(SimpleTestCase):
  31. def test_get_filesystem_storage(self):
  32. """
  33. get_storage_class returns the class for a storage backend name/path.
  34. """
  35. self.assertEqual(
  36. get_storage_class('django.core.files.storage.FileSystemStorage'),
  37. FileSystemStorage)
  38. def test_get_invalid_storage_module(self):
  39. """
  40. get_storage_class raises an error if the requested import don't exist.
  41. """
  42. with self.assertRaisesRegex(ImportError, "No module named '?storage'?"):
  43. get_storage_class('storage.NonExistingStorage')
  44. def test_get_nonexisting_storage_class(self):
  45. """
  46. get_storage_class raises an error if the requested class don't exist.
  47. """
  48. with self.assertRaises(ImportError):
  49. get_storage_class('django.core.files.storage.NonExistingStorage')
  50. def test_get_nonexisting_storage_module(self):
  51. """
  52. get_storage_class raises an error if the requested module don't exist.
  53. """
  54. # Error message may or may not be the fully qualified path.
  55. with self.assertRaisesRegex(ImportError, "No module named '?(django.core.files.)?non_existing_storage'?"):
  56. get_storage_class('django.core.files.non_existing_storage.NonExistingStorage')
  57. class FileSystemStorageTests(unittest.TestCase):
  58. def test_deconstruction(self):
  59. path, args, kwargs = temp_storage.deconstruct()
  60. self.assertEqual(path, "django.core.files.storage.FileSystemStorage")
  61. self.assertEqual(args, tuple())
  62. self.assertEqual(kwargs, {'location': temp_storage_location})
  63. kwargs_orig = {
  64. 'location': temp_storage_location,
  65. 'base_url': 'http://myfiles.example.com/'
  66. }
  67. storage = FileSystemStorage(**kwargs_orig)
  68. path, args, kwargs = storage.deconstruct()
  69. self.assertEqual(kwargs, kwargs_orig)
  70. def test_lazy_base_url_init(self):
  71. """
  72. FileSystemStorage.__init__() shouldn't evaluate base_url.
  73. """
  74. storage = FileSystemStorage(base_url=reverse_lazy('app:url'))
  75. with self.assertRaises(NoReverseMatch):
  76. storage.url(storage.base_url)
  77. class FileStorageTests(SimpleTestCase):
  78. storage_class = FileSystemStorage
  79. def setUp(self):
  80. self.temp_dir = tempfile.mkdtemp()
  81. self.storage = self.storage_class(location=self.temp_dir, base_url='/test_media_url/')
  82. # Set up a second temporary directory which is ensured to have a mixed
  83. # case name.
  84. self.temp_dir2 = tempfile.mkdtemp(suffix='aBc')
  85. def tearDown(self):
  86. shutil.rmtree(self.temp_dir)
  87. shutil.rmtree(self.temp_dir2)
  88. def test_empty_location(self):
  89. """
  90. Makes sure an exception is raised if the location is empty
  91. """
  92. storage = self.storage_class(location='')
  93. self.assertEqual(storage.base_location, '')
  94. self.assertEqual(storage.location, upath(os.getcwd()))
  95. def test_file_access_options(self):
  96. """
  97. Standard file access options are available, and work as expected.
  98. """
  99. self.assertFalse(self.storage.exists('storage_test'))
  100. f = self.storage.open('storage_test', 'w')
  101. f.write('storage contents')
  102. f.close()
  103. self.assertTrue(self.storage.exists('storage_test'))
  104. f = self.storage.open('storage_test', 'r')
  105. self.assertEqual(f.read(), 'storage contents')
  106. f.close()
  107. self.storage.delete('storage_test')
  108. self.assertFalse(self.storage.exists('storage_test'))
  109. def _test_file_time_getter(self, getter):
  110. # Check for correct behavior under both USE_TZ=True and USE_TZ=False.
  111. # The tests are similar since they both set up a situation where the
  112. # system time zone, Django's TIME_ZONE, and UTC are distinct.
  113. self._test_file_time_getter_tz_handling_on(getter)
  114. self._test_file_time_getter_tz_handling_off(getter)
  115. @override_settings(USE_TZ=True, TIME_ZONE='Africa/Algiers')
  116. def _test_file_time_getter_tz_handling_on(self, getter):
  117. # Django's TZ (and hence the system TZ) is set to Africa/Algiers which
  118. # is UTC+1 and has no DST change. We can set the Django TZ to something
  119. # else so that UTC, Django's TIME_ZONE, and the system timezone are all
  120. # different.
  121. now_in_algiers = timezone.make_aware(datetime.now())
  122. with timezone.override(timezone.get_fixed_timezone(-300)):
  123. # At this point the system TZ is +1 and the Django TZ
  124. # is -5. The following will be aware in UTC.
  125. now = timezone.now()
  126. self.assertFalse(self.storage.exists('test.file.tz.on'))
  127. f = ContentFile('custom contents')
  128. f_name = self.storage.save('test.file.tz.on', f)
  129. self.addCleanup(self.storage.delete, f_name)
  130. dt = getter(f_name)
  131. # dt should be aware, in UTC
  132. self.assertTrue(timezone.is_aware(dt))
  133. self.assertEqual(now.tzname(), dt.tzname())
  134. # The three timezones are indeed distinct.
  135. naive_now = datetime.now()
  136. algiers_offset = now_in_algiers.tzinfo.utcoffset(naive_now)
  137. django_offset = timezone.get_current_timezone().utcoffset(naive_now)
  138. utc_offset = timezone.utc.utcoffset(naive_now)
  139. self.assertGreater(algiers_offset, utc_offset)
  140. self.assertLess(django_offset, utc_offset)
  141. # dt and now should be the same effective time.
  142. self.assertLess(abs(dt - now), timedelta(seconds=2))
  143. @override_settings(USE_TZ=False, TIME_ZONE='Africa/Algiers')
  144. def _test_file_time_getter_tz_handling_off(self, getter):
  145. # Django's TZ (and hence the system TZ) is set to Africa/Algiers which
  146. # is UTC+1 and has no DST change. We can set the Django TZ to something
  147. # else so that UTC, Django's TIME_ZONE, and the system timezone are all
  148. # different.
  149. now_in_algiers = timezone.make_aware(datetime.now())
  150. with timezone.override(timezone.get_fixed_timezone(-300)):
  151. # At this point the system TZ is +1 and the Django TZ
  152. # is -5.
  153. self.assertFalse(self.storage.exists('test.file.tz.off'))
  154. f = ContentFile('custom contents')
  155. f_name = self.storage.save('test.file.tz.off', f)
  156. self.addCleanup(self.storage.delete, f_name)
  157. dt = getter(f_name)
  158. # dt should be naive, in system (+1) TZ
  159. self.assertTrue(timezone.is_naive(dt))
  160. # The three timezones are indeed distinct.
  161. naive_now = datetime.now()
  162. algiers_offset = now_in_algiers.tzinfo.utcoffset(naive_now)
  163. django_offset = timezone.get_current_timezone().utcoffset(naive_now)
  164. utc_offset = timezone.utc.utcoffset(naive_now)
  165. self.assertGreater(algiers_offset, utc_offset)
  166. self.assertLess(django_offset, utc_offset)
  167. # dt and naive_now should be the same effective time.
  168. self.assertLess(abs(dt - naive_now), timedelta(seconds=2))
  169. # If we convert dt to an aware object using the Algiers
  170. # timezone then it should be the same effective time to
  171. # now_in_algiers.
  172. _dt = timezone.make_aware(dt, now_in_algiers.tzinfo)
  173. self.assertLess(abs(_dt - now_in_algiers), timedelta(seconds=2))
  174. def test_file_get_accessed_time(self):
  175. """
  176. File storage returns a Datetime object for the last accessed time of
  177. a file.
  178. """
  179. self.assertFalse(self.storage.exists('test.file'))
  180. f = ContentFile('custom contents')
  181. f_name = self.storage.save('test.file', f)
  182. self.addCleanup(self.storage.delete, f_name)
  183. atime = self.storage.get_accessed_time(f_name)
  184. self.assertEqual(atime, datetime.fromtimestamp(os.path.getatime(self.storage.path(f_name))))
  185. self.assertLess(timezone.now() - self.storage.get_accessed_time(f_name), timedelta(seconds=2))
  186. @requires_tz_support
  187. def test_file_get_accessed_time_timezone(self):
  188. self._test_file_time_getter(self.storage.get_accessed_time)
  189. def test_file_get_created_time(self):
  190. """
  191. File storage returns a datetime for the creation time of a file.
  192. """
  193. self.assertFalse(self.storage.exists('test.file'))
  194. f = ContentFile('custom contents')
  195. f_name = self.storage.save('test.file', f)
  196. self.addCleanup(self.storage.delete, f_name)
  197. ctime = self.storage.get_created_time(f_name)
  198. self.assertEqual(ctime, datetime.fromtimestamp(os.path.getctime(self.storage.path(f_name))))
  199. self.assertLess(timezone.now() - self.storage.get_created_time(f_name), timedelta(seconds=2))
  200. @requires_tz_support
  201. def test_file_get_created_time_timezone(self):
  202. self._test_file_time_getter(self.storage.get_created_time)
  203. def test_file_get_modified_time(self):
  204. """
  205. File storage returns a datetime for the last modified time of a file.
  206. """
  207. self.assertFalse(self.storage.exists('test.file'))
  208. f = ContentFile('custom contents')
  209. f_name = self.storage.save('test.file', f)
  210. self.addCleanup(self.storage.delete, f_name)
  211. mtime = self.storage.get_modified_time(f_name)
  212. self.assertEqual(mtime, datetime.fromtimestamp(os.path.getmtime(self.storage.path(f_name))))
  213. self.assertLess(timezone.now() - self.storage.get_modified_time(f_name), timedelta(seconds=2))
  214. @requires_tz_support
  215. def test_file_get_modified_time_timezone(self):
  216. self._test_file_time_getter(self.storage.get_modified_time)
  217. def test_file_save_without_name(self):
  218. """
  219. File storage extracts the filename from the content object if no
  220. name is given explicitly.
  221. """
  222. self.assertFalse(self.storage.exists('test.file'))
  223. f = ContentFile('custom contents')
  224. f.name = 'test.file'
  225. storage_f_name = self.storage.save(None, f)
  226. self.assertEqual(storage_f_name, f.name)
  227. self.assertTrue(os.path.exists(os.path.join(self.temp_dir, f.name)))
  228. self.storage.delete(storage_f_name)
  229. def test_file_save_with_path(self):
  230. """
  231. Saving a pathname should create intermediate directories as necessary.
  232. """
  233. self.assertFalse(self.storage.exists('path/to'))
  234. self.storage.save('path/to/test.file', ContentFile('file saved with path'))
  235. self.assertTrue(self.storage.exists('path/to'))
  236. with self.storage.open('path/to/test.file') as f:
  237. self.assertEqual(f.read(), b'file saved with path')
  238. self.assertTrue(os.path.exists(
  239. os.path.join(self.temp_dir, 'path', 'to', 'test.file')))
  240. self.storage.delete('path/to/test.file')
  241. def test_save_doesnt_close(self):
  242. with TemporaryUploadedFile('test', 'text/plain', 1, 'utf8') as file:
  243. file.write(b'1')
  244. file.seek(0)
  245. self.assertFalse(file.closed)
  246. self.storage.save('path/to/test.file', file)
  247. self.assertFalse(file.closed)
  248. self.assertFalse(file.file.closed)
  249. file = InMemoryUploadedFile(six.StringIO('1'), '', 'test', 'text/plain', 1, 'utf8')
  250. with file:
  251. self.assertFalse(file.closed)
  252. self.storage.save('path/to/test.file', file)
  253. self.assertFalse(file.closed)
  254. self.assertFalse(file.file.closed)
  255. def test_file_path(self):
  256. """
  257. File storage returns the full path of a file
  258. """
  259. self.assertFalse(self.storage.exists('test.file'))
  260. f = ContentFile('custom contents')
  261. f_name = self.storage.save('test.file', f)
  262. self.assertEqual(self.storage.path(f_name), os.path.join(self.temp_dir, f_name))
  263. self.storage.delete(f_name)
  264. def test_file_url(self):
  265. """
  266. File storage returns a url to access a given file from the Web.
  267. """
  268. self.assertEqual(self.storage.url('test.file'), self.storage.base_url + 'test.file')
  269. # should encode special chars except ~!*()'
  270. # like encodeURIComponent() JavaScript function do
  271. self.assertEqual(
  272. self.storage.url(r"~!*()'@#$%^&*abc`+ =.file"),
  273. "/test_media_url/~!*()'%40%23%24%25%5E%26*abc%60%2B%20%3D.file"
  274. )
  275. self.assertEqual(self.storage.url("ab\0c"), "/test_media_url/ab%00c")
  276. # should translate os path separator(s) to the url path separator
  277. self.assertEqual(self.storage.url("""a/b\\c.file"""), "/test_media_url/a/b/c.file")
  278. # #25905: remove leading slashes from file names to prevent unsafe url output
  279. self.assertEqual(self.storage.url("/evil.com"), "/test_media_url/evil.com")
  280. self.assertEqual(self.storage.url(r"\evil.com"), "/test_media_url/evil.com")
  281. self.assertEqual(self.storage.url("///evil.com"), "/test_media_url/evil.com")
  282. self.assertEqual(self.storage.url(r"\\\evil.com"), "/test_media_url/evil.com")
  283. self.assertEqual(self.storage.url(None), "/test_media_url/")
  284. def test_base_url(self):
  285. """
  286. File storage returns a url even when its base_url is unset or modified.
  287. """
  288. self.storage.base_url = None
  289. with self.assertRaises(ValueError):
  290. self.storage.url('test.file')
  291. # #22717: missing ending slash in base_url should be auto-corrected
  292. storage = self.storage_class(location=self.temp_dir, base_url='/no_ending_slash')
  293. self.assertEqual(
  294. storage.url('test.file'),
  295. '%s%s' % (storage.base_url, 'test.file')
  296. )
  297. def test_listdir(self):
  298. """
  299. File storage returns a tuple containing directories and files.
  300. """
  301. self.assertFalse(self.storage.exists('storage_test_1'))
  302. self.assertFalse(self.storage.exists('storage_test_2'))
  303. self.assertFalse(self.storage.exists('storage_dir_1'))
  304. self.storage.save('storage_test_1', ContentFile('custom content'))
  305. self.storage.save('storage_test_2', ContentFile('custom content'))
  306. os.mkdir(os.path.join(self.temp_dir, 'storage_dir_1'))
  307. dirs, files = self.storage.listdir('')
  308. self.assertEqual(set(dirs), {'storage_dir_1'})
  309. self.assertEqual(set(files), {'storage_test_1', 'storage_test_2'})
  310. self.storage.delete('storage_test_1')
  311. self.storage.delete('storage_test_2')
  312. os.rmdir(os.path.join(self.temp_dir, 'storage_dir_1'))
  313. def test_file_storage_prevents_directory_traversal(self):
  314. """
  315. File storage prevents directory traversal (files can only be accessed if
  316. they're below the storage location).
  317. """
  318. with self.assertRaises(SuspiciousOperation):
  319. self.storage.exists('..')
  320. with self.assertRaises(SuspiciousOperation):
  321. self.storage.exists('/etc/passwd')
  322. def test_file_storage_preserves_filename_case(self):
  323. """The storage backend should preserve case of filenames."""
  324. # Create a storage backend associated with the mixed case name
  325. # directory.
  326. other_temp_storage = self.storage_class(location=self.temp_dir2)
  327. # Ask that storage backend to store a file with a mixed case filename.
  328. mixed_case = 'CaSe_SeNsItIvE'
  329. file = other_temp_storage.open(mixed_case, 'w')
  330. file.write('storage contents')
  331. file.close()
  332. self.assertEqual(os.path.join(self.temp_dir2, mixed_case), other_temp_storage.path(mixed_case))
  333. other_temp_storage.delete(mixed_case)
  334. def test_makedirs_race_handling(self):
  335. """
  336. File storage should be robust against directory creation race conditions.
  337. """
  338. real_makedirs = os.makedirs
  339. # Monkey-patch os.makedirs, to simulate a normal call, a raced call,
  340. # and an error.
  341. def fake_makedirs(path):
  342. if path == os.path.join(self.temp_dir, 'normal'):
  343. real_makedirs(path)
  344. elif path == os.path.join(self.temp_dir, 'raced'):
  345. real_makedirs(path)
  346. raise OSError(errno.EEXIST, 'simulated EEXIST')
  347. elif path == os.path.join(self.temp_dir, 'error'):
  348. raise OSError(errno.EACCES, 'simulated EACCES')
  349. else:
  350. self.fail('unexpected argument %r' % path)
  351. try:
  352. os.makedirs = fake_makedirs
  353. self.storage.save('normal/test.file', ContentFile('saved normally'))
  354. with self.storage.open('normal/test.file') as f:
  355. self.assertEqual(f.read(), b'saved normally')
  356. self.storage.save('raced/test.file', ContentFile('saved with race'))
  357. with self.storage.open('raced/test.file') as f:
  358. self.assertEqual(f.read(), b'saved with race')
  359. # OSErrors aside from EEXIST are still raised.
  360. with self.assertRaises(OSError):
  361. self.storage.save('error/test.file', ContentFile('not saved'))
  362. finally:
  363. os.makedirs = real_makedirs
  364. def test_remove_race_handling(self):
  365. """
  366. File storage should be robust against file removal race conditions.
  367. """
  368. real_remove = os.remove
  369. # Monkey-patch os.remove, to simulate a normal call, a raced call,
  370. # and an error.
  371. def fake_remove(path):
  372. if path == os.path.join(self.temp_dir, 'normal.file'):
  373. real_remove(path)
  374. elif path == os.path.join(self.temp_dir, 'raced.file'):
  375. real_remove(path)
  376. raise OSError(errno.ENOENT, 'simulated ENOENT')
  377. elif path == os.path.join(self.temp_dir, 'error.file'):
  378. raise OSError(errno.EACCES, 'simulated EACCES')
  379. else:
  380. self.fail('unexpected argument %r' % path)
  381. try:
  382. os.remove = fake_remove
  383. self.storage.save('normal.file', ContentFile('delete normally'))
  384. self.storage.delete('normal.file')
  385. self.assertFalse(self.storage.exists('normal.file'))
  386. self.storage.save('raced.file', ContentFile('delete with race'))
  387. self.storage.delete('raced.file')
  388. self.assertFalse(self.storage.exists('normal.file'))
  389. # OSErrors aside from ENOENT are still raised.
  390. self.storage.save('error.file', ContentFile('delete with error'))
  391. with self.assertRaises(OSError):
  392. self.storage.delete('error.file')
  393. finally:
  394. os.remove = real_remove
  395. def test_file_chunks_error(self):
  396. """
  397. Test behavior when file.chunks() is raising an error
  398. """
  399. f1 = ContentFile('chunks fails')
  400. def failing_chunks():
  401. raise IOError
  402. f1.chunks = failing_chunks
  403. with self.assertRaises(IOError):
  404. self.storage.save('error.file', f1)
  405. def test_delete_no_name(self):
  406. """
  407. Calling delete with an empty name should not try to remove the base
  408. storage directory, but fail loudly (#20660).
  409. """
  410. with self.assertRaises(AssertionError):
  411. self.storage.delete('')
  412. @override_settings(
  413. MEDIA_ROOT='media_root',
  414. MEDIA_URL='media_url/',
  415. FILE_UPLOAD_PERMISSIONS=0o777,
  416. FILE_UPLOAD_DIRECTORY_PERMISSIONS=0o777,
  417. )
  418. def test_setting_changed(self):
  419. """
  420. Properties using settings values as defaults should be updated on
  421. referenced settings change while specified values should be unchanged.
  422. """
  423. storage = self.storage_class(
  424. location='explicit_location',
  425. base_url='explicit_base_url/',
  426. file_permissions_mode=0o666,
  427. directory_permissions_mode=0o666,
  428. )
  429. defaults_storage = self.storage_class()
  430. settings = {
  431. 'MEDIA_ROOT': 'overriden_media_root',
  432. 'MEDIA_URL': 'overriden_media_url/',
  433. 'FILE_UPLOAD_PERMISSIONS': 0o333,
  434. 'FILE_UPLOAD_DIRECTORY_PERMISSIONS': 0o333,
  435. }
  436. with self.settings(**settings):
  437. self.assertEqual(storage.base_location, 'explicit_location')
  438. self.assertIn('explicit_location', storage.location)
  439. self.assertEqual(storage.base_url, 'explicit_base_url/')
  440. self.assertEqual(storage.file_permissions_mode, 0o666)
  441. self.assertEqual(storage.directory_permissions_mode, 0o666)
  442. self.assertEqual(defaults_storage.base_location, settings['MEDIA_ROOT'])
  443. self.assertIn(settings['MEDIA_ROOT'], defaults_storage.location)
  444. self.assertEqual(defaults_storage.base_url, settings['MEDIA_URL'])
  445. self.assertEqual(defaults_storage.file_permissions_mode, settings['FILE_UPLOAD_PERMISSIONS'])
  446. self.assertEqual(
  447. defaults_storage.directory_permissions_mode, settings['FILE_UPLOAD_DIRECTORY_PERMISSIONS']
  448. )
  449. class CustomStorage(FileSystemStorage):
  450. def get_available_name(self, name, max_length=None):
  451. """
  452. Append numbers to duplicate files rather than underscores, like Trac.
  453. """
  454. parts = name.split('.')
  455. basename, ext = parts[0], parts[1:]
  456. number = 2
  457. while self.exists(name):
  458. name = '.'.join([basename, str(number)] + ext)
  459. number += 1
  460. return name
  461. class CustomStorageTests(FileStorageTests):
  462. storage_class = CustomStorage
  463. def test_custom_get_available_name(self):
  464. first = self.storage.save('custom_storage', ContentFile('custom contents'))
  465. self.assertEqual(first, 'custom_storage')
  466. second = self.storage.save('custom_storage', ContentFile('more contents'))
  467. self.assertEqual(second, 'custom_storage.2')
  468. self.storage.delete(first)
  469. self.storage.delete(second)
  470. class DiscardingFalseContentStorage(FileSystemStorage):
  471. def _save(self, name, content):
  472. if content:
  473. return super(DiscardingFalseContentStorage, self)._save(name, content)
  474. return ''
  475. class DiscardingFalseContentStorageTests(FileStorageTests):
  476. storage_class = DiscardingFalseContentStorage
  477. def test_custom_storage_discarding_empty_content(self):
  478. """
  479. When Storage.save() wraps a file-like object in File, it should include
  480. the name argument so that bool(file) evaluates to True (#26495).
  481. """
  482. output = six.StringIO('content')
  483. self.storage.save('tests/stringio', output)
  484. self.assertTrue(self.storage.exists('tests/stringio'))
  485. with self.storage.open('tests/stringio') as f:
  486. self.assertEqual(f.read(), b'content')
  487. class FileFieldStorageTests(TestCase):
  488. def tearDown(self):
  489. shutil.rmtree(temp_storage_location)
  490. def _storage_max_filename_length(self, storage):
  491. """
  492. Query filesystem for maximum filename length (e.g. AUFS has 242).
  493. """
  494. dir_to_test = storage.location
  495. while not os.path.exists(dir_to_test):
  496. dir_to_test = os.path.dirname(dir_to_test)
  497. try:
  498. return os.pathconf(dir_to_test, 'PC_NAME_MAX')
  499. except Exception:
  500. return 255 # Should be safe on most backends
  501. def test_files(self):
  502. self.assertIsInstance(Storage.normal, FileDescriptor)
  503. # An object without a file has limited functionality.
  504. obj1 = Storage()
  505. self.assertEqual(obj1.normal.name, "")
  506. with self.assertRaises(ValueError):
  507. obj1.normal.size
  508. # Saving a file enables full functionality.
  509. obj1.normal.save("django_test.txt", ContentFile("content"))
  510. self.assertEqual(obj1.normal.name, "tests/django_test.txt")
  511. self.assertEqual(obj1.normal.size, 7)
  512. self.assertEqual(obj1.normal.read(), b"content")
  513. obj1.normal.close()
  514. # File objects can be assigned to FileField attributes, but shouldn't
  515. # get committed until the model it's attached to is saved.
  516. obj1.normal = SimpleUploadedFile("assignment.txt", b"content")
  517. dirs, files = temp_storage.listdir("tests")
  518. self.assertEqual(dirs, [])
  519. self.assertNotIn("assignment.txt", files)
  520. obj1.save()
  521. dirs, files = temp_storage.listdir("tests")
  522. self.assertEqual(sorted(files), ["assignment.txt", "django_test.txt"])
  523. # Save another file with the same name.
  524. obj2 = Storage()
  525. obj2.normal.save("django_test.txt", ContentFile("more content"))
  526. obj2_name = obj2.normal.name
  527. self.assertRegex(obj2_name, "tests/django_test_%s.txt" % FILE_SUFFIX_REGEX)
  528. self.assertEqual(obj2.normal.size, 12)
  529. obj2.normal.close()
  530. # Deleting an object does not delete the file it uses.
  531. obj2.delete()
  532. obj2.normal.save("django_test.txt", ContentFile("more content"))
  533. self.assertNotEqual(obj2_name, obj2.normal.name)
  534. self.assertRegex(obj2.normal.name, "tests/django_test_%s.txt" % FILE_SUFFIX_REGEX)
  535. obj2.normal.close()
  536. def test_filefield_read(self):
  537. # Files can be read in a little at a time, if necessary.
  538. obj = Storage.objects.create(
  539. normal=SimpleUploadedFile("assignment.txt", b"content"))
  540. obj.normal.open()
  541. self.assertEqual(obj.normal.read(3), b"con")
  542. self.assertEqual(obj.normal.read(), b"tent")
  543. self.assertEqual(list(obj.normal.chunks(chunk_size=2)), [b"co", b"nt", b"en", b"t"])
  544. obj.normal.close()
  545. def test_filefield_write(self):
  546. # Files can be written to.
  547. obj = Storage.objects.create(normal=SimpleUploadedFile('rewritten.txt', b'content'))
  548. with obj.normal as normal:
  549. normal.open('wb')
  550. normal.write(b'updated')
  551. obj.refresh_from_db()
  552. self.assertEqual(obj.normal.read(), b'updated')
  553. obj.normal.close()
  554. def test_filefield_reopen(self):
  555. obj = Storage.objects.create(normal=SimpleUploadedFile('reopen.txt', b'content'))
  556. with obj.normal as normal:
  557. normal.open()
  558. obj.normal.open()
  559. obj.normal.file.seek(0)
  560. obj.normal.close()
  561. def test_duplicate_filename(self):
  562. # Multiple files with the same name get _(7 random chars) appended to them.
  563. objs = [Storage() for i in range(2)]
  564. for o in objs:
  565. o.normal.save("multiple_files.txt", ContentFile("Same Content"))
  566. try:
  567. names = [o.normal.name for o in objs]
  568. self.assertEqual(names[0], "tests/multiple_files.txt")
  569. self.assertRegex(names[1], "tests/multiple_files_%s.txt" % FILE_SUFFIX_REGEX)
  570. finally:
  571. for o in objs:
  572. o.delete()
  573. def test_file_truncation(self):
  574. # Given the max_length is limited, when multiple files get uploaded
  575. # under the same name, then the filename get truncated in order to fit
  576. # in _(7 random chars). When most of the max_length is taken by
  577. # dirname + extension and there are not enough characters in the
  578. # filename to truncate, an exception should be raised.
  579. objs = [Storage() for i in range(2)]
  580. filename = 'filename.ext'
  581. for o in objs:
  582. o.limited_length.save(filename, ContentFile('Same Content'))
  583. try:
  584. # Testing truncation.
  585. names = [o.limited_length.name for o in objs]
  586. self.assertEqual(names[0], 'tests/%s' % filename)
  587. self.assertRegex(names[1], 'tests/fi_%s.ext' % FILE_SUFFIX_REGEX)
  588. # Testing exception is raised when filename is too short to truncate.
  589. filename = 'short.longext'
  590. objs[0].limited_length.save(filename, ContentFile('Same Content'))
  591. with self.assertRaisesMessage(SuspiciousFileOperation, 'Storage can not find an available filename'):
  592. objs[1].limited_length.save(*(filename, ContentFile('Same Content')))
  593. finally:
  594. for o in objs:
  595. o.delete()
  596. @unittest.skipIf(
  597. sys.platform.startswith('win'),
  598. "Windows supports at most 260 characters in a path.",
  599. )
  600. def test_extended_length_storage(self):
  601. # Testing FileField with max_length > 255. Most systems have filename
  602. # length limitation of 255. Path takes extra chars.
  603. filename = (self._storage_max_filename_length(temp_storage) - 4) * 'a' # 4 chars for extension.
  604. obj = Storage()
  605. obj.extended_length.save('%s.txt' % filename, ContentFile('Same Content'))
  606. self.assertEqual(obj.extended_length.name, 'tests/%s.txt' % filename)
  607. self.assertEqual(obj.extended_length.read(), b'Same Content')
  608. obj.extended_length.close()
  609. def test_filefield_default(self):
  610. # Default values allow an object to access a single file.
  611. temp_storage.save('tests/default.txt', ContentFile('default content'))
  612. obj = Storage.objects.create()
  613. self.assertEqual(obj.default.name, "tests/default.txt")
  614. self.assertEqual(obj.default.read(), b"default content")
  615. obj.default.close()
  616. # But it shouldn't be deleted, even if there are no more objects using
  617. # it.
  618. obj.delete()
  619. obj = Storage()
  620. self.assertEqual(obj.default.read(), b"default content")
  621. obj.default.close()
  622. def test_empty_upload_to(self):
  623. # upload_to can be empty, meaning it does not use subdirectory.
  624. obj = Storage()
  625. obj.empty.save('django_test.txt', ContentFile('more content'))
  626. self.assertEqual(obj.empty.name, "django_test.txt")
  627. self.assertEqual(obj.empty.read(), b"more content")
  628. obj.empty.close()
  629. def test_random_upload_to(self):
  630. # Verify the fix for #5655, making sure the directory is only
  631. # determined once.
  632. obj = Storage()
  633. obj.random.save("random_file", ContentFile("random content"))
  634. self.assertTrue(obj.random.name.endswith("/random_file"))
  635. obj.random.close()
  636. def test_custom_valid_name_callable_upload_to(self):
  637. """
  638. Storage.get_valid_name() should be called when upload_to is a callable.
  639. """
  640. obj = Storage()
  641. obj.custom_valid_name.save("random_file", ContentFile("random content"))
  642. # CustomValidNameStorage.get_valid_name() appends '_valid' to the name
  643. self.assertTrue(obj.custom_valid_name.name.endswith("/random_file_valid"))
  644. obj.custom_valid_name.close()
  645. def test_filefield_pickling(self):
  646. # Push an object into the cache to make sure it pickles properly
  647. obj = Storage()
  648. obj.normal.save("django_test.txt", ContentFile("more content"))
  649. obj.normal.close()
  650. cache.set("obj", obj)
  651. self.assertEqual(cache.get("obj").normal.name, "tests/django_test.txt")
  652. def test_file_object(self):
  653. # Create sample file
  654. temp_storage.save('tests/example.txt', ContentFile('some content'))
  655. # Load it as python file object
  656. with open(temp_storage.path('tests/example.txt')) as file_obj:
  657. # Save it using storage and read its content
  658. temp_storage.save('tests/file_obj', file_obj)
  659. self.assertTrue(temp_storage.exists('tests/file_obj'))
  660. with temp_storage.open('tests/file_obj') as f:
  661. self.assertEqual(f.read(), b'some content')
  662. def test_stringio(self):
  663. # Test passing StringIO instance as content argument to save
  664. output = six.StringIO()
  665. output.write('content')
  666. output.seek(0)
  667. # Save it and read written file
  668. temp_storage.save('tests/stringio', output)
  669. self.assertTrue(temp_storage.exists('tests/stringio'))
  670. with temp_storage.open('tests/stringio') as f:
  671. self.assertEqual(f.read(), b'content')
  672. # Tests for a race condition on file saving (#4948).
  673. # This is written in such a way that it'll always pass on platforms
  674. # without threading.
  675. class SlowFile(ContentFile):
  676. def chunks(self):
  677. time.sleep(1)
  678. return super(ContentFile, self).chunks()
  679. class FileSaveRaceConditionTest(SimpleTestCase):
  680. def setUp(self):
  681. self.storage_dir = tempfile.mkdtemp()
  682. self.storage = FileSystemStorage(self.storage_dir)
  683. self.thread = threading.Thread(target=self.save_file, args=['conflict'])
  684. def tearDown(self):
  685. shutil.rmtree(self.storage_dir)
  686. def save_file(self, name):
  687. name = self.storage.save(name, SlowFile(b"Data"))
  688. def test_race_condition(self):
  689. self.thread.start()
  690. self.save_file('conflict')
  691. self.thread.join()
  692. files = sorted(os.listdir(self.storage_dir))
  693. self.assertEqual(files[0], 'conflict')
  694. self.assertRegex(files[1], 'conflict_%s' % FILE_SUFFIX_REGEX)
  695. @unittest.skipIf(sys.platform.startswith('win'), "Windows only partially supports umasks and chmod.")
  696. class FileStoragePermissions(unittest.TestCase):
  697. def setUp(self):
  698. self.umask = 0o027
  699. self.old_umask = os.umask(self.umask)
  700. self.storage_dir = tempfile.mkdtemp()
  701. def tearDown(self):
  702. shutil.rmtree(self.storage_dir)
  703. os.umask(self.old_umask)
  704. @override_settings(FILE_UPLOAD_PERMISSIONS=0o654)
  705. def test_file_upload_permissions(self):
  706. self.storage = FileSystemStorage(self.storage_dir)
  707. name = self.storage.save("the_file", ContentFile("data"))
  708. actual_mode = os.stat(self.storage.path(name))[0] & 0o777
  709. self.assertEqual(actual_mode, 0o654)
  710. @override_settings(FILE_UPLOAD_PERMISSIONS=None)
  711. def test_file_upload_default_permissions(self):
  712. self.storage = FileSystemStorage(self.storage_dir)
  713. fname = self.storage.save("some_file", ContentFile("data"))
  714. mode = os.stat(self.storage.path(fname))[0] & 0o777
  715. self.assertEqual(mode, 0o666 & ~self.umask)
  716. @override_settings(FILE_UPLOAD_DIRECTORY_PERMISSIONS=0o765)
  717. def test_file_upload_directory_permissions(self):
  718. self.storage = FileSystemStorage(self.storage_dir)
  719. name = self.storage.save("the_directory/the_file", ContentFile("data"))
  720. dir_mode = os.stat(os.path.dirname(self.storage.path(name)))[0] & 0o777
  721. self.assertEqual(dir_mode, 0o765)
  722. @override_settings(FILE_UPLOAD_DIRECTORY_PERMISSIONS=None)
  723. def test_file_upload_directory_default_permissions(self):
  724. self.storage = FileSystemStorage(self.storage_dir)
  725. name = self.storage.save("the_directory/the_file", ContentFile("data"))
  726. dir_mode = os.stat(os.path.dirname(self.storage.path(name)))[0] & 0o777
  727. self.assertEqual(dir_mode, 0o777 & ~self.umask)
  728. class FileStoragePathParsing(SimpleTestCase):
  729. def setUp(self):
  730. self.storage_dir = tempfile.mkdtemp()
  731. self.storage = FileSystemStorage(self.storage_dir)
  732. def tearDown(self):
  733. shutil.rmtree(self.storage_dir)
  734. def test_directory_with_dot(self):
  735. """Regression test for #9610.
  736. If the directory name contains a dot and the file name doesn't, make
  737. sure we still mangle the file name instead of the directory name.
  738. """
  739. self.storage.save('dotted.path/test', ContentFile("1"))
  740. self.storage.save('dotted.path/test', ContentFile("2"))
  741. files = sorted(os.listdir(os.path.join(self.storage_dir, 'dotted.path')))
  742. self.assertFalse(os.path.exists(os.path.join(self.storage_dir, 'dotted_.path')))
  743. self.assertEqual(files[0], 'test')
  744. self.assertRegex(files[1], 'test_%s' % FILE_SUFFIX_REGEX)
  745. def test_first_character_dot(self):
  746. """
  747. File names with a dot as their first character don't have an extension,
  748. and the underscore should get added to the end.
  749. """
  750. self.storage.save('dotted.path/.test', ContentFile("1"))
  751. self.storage.save('dotted.path/.test', ContentFile("2"))
  752. files = sorted(os.listdir(os.path.join(self.storage_dir, 'dotted.path')))
  753. self.assertFalse(os.path.exists(os.path.join(self.storage_dir, 'dotted_.path')))
  754. self.assertEqual(files[0], '.test')
  755. self.assertRegex(files[1], '.test_%s' % FILE_SUFFIX_REGEX)
  756. class ContentFileStorageTestCase(unittest.TestCase):
  757. def setUp(self):
  758. self.storage_dir = tempfile.mkdtemp()
  759. self.storage = FileSystemStorage(self.storage_dir)
  760. def tearDown(self):
  761. shutil.rmtree(self.storage_dir)
  762. def test_content_saving(self):
  763. """
  764. ContentFile can be saved correctly with the filesystem storage,
  765. if it was initialized with either bytes or unicode content.
  766. """
  767. self.storage.save('bytes.txt', ContentFile(b"content"))
  768. self.storage.save('unicode.txt', ContentFile("español"))
  769. @override_settings(ROOT_URLCONF='file_storage.urls')
  770. class FileLikeObjectTestCase(LiveServerTestCase):
  771. """
  772. Test file-like objects (#15644).
  773. """
  774. available_apps = []
  775. def setUp(self):
  776. self.temp_dir = tempfile.mkdtemp()
  777. self.storage = FileSystemStorage(location=self.temp_dir)
  778. def tearDown(self):
  779. shutil.rmtree(self.temp_dir)
  780. def test_urllib2_urlopen(self):
  781. """
  782. Test the File storage API with a file like object coming from urllib2.urlopen()
  783. """
  784. file_like_object = urlopen(self.live_server_url + '/')
  785. f = File(file_like_object)
  786. stored_filename = self.storage.save("remote_file.html", f)
  787. remote_file = urlopen(self.live_server_url + '/')
  788. with self.storage.open(stored_filename) as stored_file:
  789. self.assertEqual(stored_file.read(), remote_file.read())