contributing.txt 5.4 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102
  1. FAQ: Contributing code
  2. ======================
  3. How can I get started contributing code to Django?
  4. --------------------------------------------------
  5. Thanks for asking! We've written an entire document devoted to this question.
  6. It's titled :doc:`Contributing to Django </internals/contributing/index>`.
  7. I submitted a bug fix in the ticket system several weeks ago. Why are you ignoring my patch?
  8. --------------------------------------------------------------------------------------------
  9. Don't worry: We're not ignoring you!
  10. It's important to understand there is a difference between "a ticket is being
  11. ignored" and "a ticket has not been attended to yet." Django's ticket system
  12. contains hundreds of open tickets, of various degrees of impact on end-user
  13. functionality, and Django's developers have to review and prioritize.
  14. On top of that: the people who work on Django are all volunteers. As a result,
  15. the amount of time that we have to work on the framework is limited and will
  16. vary from week to week depending on our spare time. If we're busy, we may not
  17. be able to spend as much time on Django as we might want.
  18. The best way to make sure tickets do not get hung up on the way to checkin is
  19. to make it dead easy, even for someone who may not be intimately familiar with
  20. that area of the code, to understand the problem and verify the fix:
  21. * Are there clear instructions on how to reproduce the bug? If this
  22. touches a dependency (such as Pillow/PIL), a contrib module, or a specific
  23. database, are those instructions clear enough even for someone not
  24. familiar with it?
  25. * If there are several patches attached to the ticket, is it clear what
  26. each one does, which ones can be ignored and which matter?
  27. * Does the patch include a unit test? If not, is there a very clear
  28. explanation why not? A test expresses succinctly what the problem is,
  29. and shows that the patch actually fixes it.
  30. If your patch stands no chance of inclusion in Django, we won't ignore it --
  31. we'll just close the ticket. So if your ticket is still open, it doesn't mean
  32. we're ignoring you; it just means we haven't had time to look at it yet.
  33. When and how might I remind the core team of a patch I care about?
  34. ------------------------------------------------------------------
  35. A polite, well-timed message to the mailing list is one way to get attention.
  36. To determine the right time, you need to keep an eye on the schedule. If you
  37. post your message when the core developers are trying to hit a feature
  38. deadline or manage a planning phase, you're not going to get the sort of
  39. attention you require. However, if you draw attention to a ticket when the
  40. core developers are paying particular attention to bugs -- just before a bug
  41. fixing sprint, or in the lead up to a beta release for example -- you're much
  42. more likely to get a productive response.
  43. Gentle IRC reminders can also work -- again, strategically timed if possible.
  44. During a bug sprint would be a very good time, for example.
  45. Another way to get traction is to pull several related tickets together. When
  46. the core developers sit down to fix a bug in an area they haven't touched for
  47. a while, it can take a few minutes to remember all the fine details of how
  48. that area of code works. If you collect several minor bug fixes together into
  49. a similarly themed group, you make an attractive target, as the cost of coming
  50. up to speed on an area of code can be spread over multiple tickets.
  51. Please refrain from emailing core developers personally, or repeatedly raising
  52. the same issue over and over. This sort of behavior will not gain you any
  53. additional attention -- certainly not the attention that you need in order to
  54. get your pet bug addressed.
  55. But I've reminded you several times and you keep ignoring my patch!
  56. -------------------------------------------------------------------
  57. Seriously - we're not ignoring you. If your patch stands no chance of
  58. inclusion in Django, we'll close the ticket. For all the other tickets, we
  59. need to prioritize our efforts, which means that some tickets will be
  60. addressed before others.
  61. One of the criteria that is used to prioritize bug fixes is the number of
  62. people that will likely be affected by a given bug. Bugs that have the
  63. potential to affect many people will generally get priority over those that
  64. are edge cases.
  65. Another reason that bugs might be ignored for while is if the bug is a symptom
  66. of a larger problem. While we can spend time writing, testing and applying
  67. lots of little patches, sometimes the right solution is to rebuild. If a
  68. rebuild or refactor of a particular component has been proposed or is
  69. underway, you may find that bugs affecting that component will not get as much
  70. attention. Again, this is just a matter of prioritizing scarce resources. By
  71. concentrating on the rebuild, we can close all the little bugs at once, and
  72. hopefully prevent other little bugs from appearing in the future.
  73. Whatever the reason, please keep in mind that while you may hit a particular
  74. bug regularly, it doesn't necessarily follow that every single Django user
  75. will hit the same bug. Different users use Django in different ways, stressing
  76. different parts of the code under different conditions. When we evaluate the
  77. relative priorities, we are generally trying to consider the needs of the
  78. entire community, not just the severity for one particular user. This doesn't
  79. mean that we think your problem is unimportant -- just that in the limited
  80. time we have available, we will always err on the side of making 10 people
  81. happy rather than making 1 person happy.