tests.py 41 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022
  1. # -*- coding: utf-8 -*-
  2. from __future__ import unicode_literals
  3. import errno
  4. import os
  5. import shutil
  6. import sys
  7. import tempfile
  8. import threading
  9. import time
  10. import unittest
  11. from datetime import datetime, timedelta
  12. from django.core.cache import cache
  13. from django.core.exceptions import SuspiciousFileOperation, SuspiciousOperation
  14. from django.core.files.base import ContentFile, File
  15. from django.core.files.storage import FileSystemStorage, get_storage_class
  16. from django.core.files.uploadedfile import (
  17. InMemoryUploadedFile, SimpleUploadedFile, TemporaryUploadedFile,
  18. )
  19. from django.db.models.fields.files import FileDescriptor
  20. from django.test import (
  21. LiveServerTestCase, SimpleTestCase, TestCase, ignore_warnings,
  22. override_settings,
  23. )
  24. from django.test.utils import requires_tz_support
  25. from django.urls import NoReverseMatch, reverse_lazy
  26. from django.utils import six, timezone
  27. from django.utils._os import upath
  28. from django.utils.deprecation import RemovedInDjango20Warning
  29. from django.utils.six.moves.urllib.request import urlopen
  30. from .models import Storage, temp_storage, temp_storage_location
  31. FILE_SUFFIX_REGEX = '[A-Za-z0-9]{7}'
  32. class GetStorageClassTests(SimpleTestCase):
  33. def test_get_filesystem_storage(self):
  34. """
  35. get_storage_class returns the class for a storage backend name/path.
  36. """
  37. self.assertEqual(
  38. get_storage_class('django.core.files.storage.FileSystemStorage'),
  39. FileSystemStorage)
  40. def test_get_invalid_storage_module(self):
  41. """
  42. get_storage_class raises an error if the requested import don't exist.
  43. """
  44. with six.assertRaisesRegex(self, ImportError, "No module named '?storage'?"):
  45. get_storage_class('storage.NonExistingStorage')
  46. def test_get_nonexisting_storage_class(self):
  47. """
  48. get_storage_class raises an error if the requested class don't exist.
  49. """
  50. with self.assertRaises(ImportError):
  51. get_storage_class('django.core.files.storage.NonExistingStorage')
  52. def test_get_nonexisting_storage_module(self):
  53. """
  54. get_storage_class raises an error if the requested module don't exist.
  55. """
  56. # Error message may or may not be the fully qualified path.
  57. with six.assertRaisesRegex(self, ImportError, "No module named '?(django.core.files.)?non_existing_storage'?"):
  58. get_storage_class('django.core.files.non_existing_storage.NonExistingStorage')
  59. class FileSystemStorageTests(unittest.TestCase):
  60. def test_deconstruction(self):
  61. path, args, kwargs = temp_storage.deconstruct()
  62. self.assertEqual(path, "django.core.files.storage.FileSystemStorage")
  63. self.assertEqual(args, tuple())
  64. self.assertEqual(kwargs, {'location': temp_storage_location})
  65. kwargs_orig = {
  66. 'location': temp_storage_location,
  67. 'base_url': 'http://myfiles.example.com/'
  68. }
  69. storage = FileSystemStorage(**kwargs_orig)
  70. path, args, kwargs = storage.deconstruct()
  71. self.assertEqual(kwargs, kwargs_orig)
  72. def test_lazy_base_url_init(self):
  73. """
  74. FileSystemStorage.__init__() shouldn't evaluate base_url.
  75. """
  76. storage = FileSystemStorage(base_url=reverse_lazy('app:url'))
  77. with self.assertRaises(NoReverseMatch):
  78. storage.url(storage.base_url)
  79. class FileStorageTests(SimpleTestCase):
  80. storage_class = FileSystemStorage
  81. def setUp(self):
  82. self.temp_dir = tempfile.mkdtemp()
  83. self.storage = self.storage_class(location=self.temp_dir, base_url='/test_media_url/')
  84. # Set up a second temporary directory which is ensured to have a mixed
  85. # case name.
  86. self.temp_dir2 = tempfile.mkdtemp(suffix='aBc')
  87. def tearDown(self):
  88. shutil.rmtree(self.temp_dir)
  89. shutil.rmtree(self.temp_dir2)
  90. def test_empty_location(self):
  91. """
  92. Makes sure an exception is raised if the location is empty
  93. """
  94. storage = self.storage_class(location='')
  95. self.assertEqual(storage.base_location, '')
  96. self.assertEqual(storage.location, upath(os.getcwd()))
  97. def test_file_access_options(self):
  98. """
  99. Standard file access options are available, and work as expected.
  100. """
  101. self.assertFalse(self.storage.exists('storage_test'))
  102. f = self.storage.open('storage_test', 'w')
  103. f.write('storage contents')
  104. f.close()
  105. self.assertTrue(self.storage.exists('storage_test'))
  106. f = self.storage.open('storage_test', 'r')
  107. self.assertEqual(f.read(), 'storage contents')
  108. f.close()
  109. self.storage.delete('storage_test')
  110. self.assertFalse(self.storage.exists('storage_test'))
  111. def _test_file_time_getter(self, getter):
  112. # Check for correct behavior under both USE_TZ=True and USE_TZ=False.
  113. # The tests are similar since they both set up a situation where the
  114. # system time zone, Django's TIME_ZONE, and UTC are distinct.
  115. self._test_file_time_getter_tz_handling_on(getter)
  116. self._test_file_time_getter_tz_handling_off(getter)
  117. @override_settings(USE_TZ=True, TIME_ZONE='Africa/Algiers')
  118. def _test_file_time_getter_tz_handling_on(self, getter):
  119. # Django's TZ (and hence the system TZ) is set to Africa/Algiers which
  120. # is UTC+1 and has no DST change. We can set the Django TZ to something
  121. # else so that UTC, Django's TIME_ZONE, and the system timezone are all
  122. # different.
  123. now_in_algiers = timezone.make_aware(datetime.now())
  124. with timezone.override(timezone.get_fixed_timezone(-300)):
  125. # At this point the system TZ is +1 and the Django TZ
  126. # is -5. The following will be aware in UTC.
  127. now = timezone.now()
  128. self.assertFalse(self.storage.exists('test.file.tz.on'))
  129. f = ContentFile('custom contents')
  130. f_name = self.storage.save('test.file.tz.on', f)
  131. self.addCleanup(self.storage.delete, f_name)
  132. dt = getter(f_name)
  133. # dt should be aware, in UTC
  134. self.assertTrue(timezone.is_aware(dt))
  135. self.assertEqual(now.tzname(), dt.tzname())
  136. # Check that the three timezones are indeed distinct.
  137. naive_now = datetime.now()
  138. algiers_offset = now_in_algiers.tzinfo.utcoffset(naive_now)
  139. django_offset = timezone.get_current_timezone().utcoffset(naive_now)
  140. utc_offset = timezone.utc.utcoffset(naive_now)
  141. self.assertGreater(algiers_offset, utc_offset)
  142. self.assertLess(django_offset, utc_offset)
  143. # dt and now should be the same effective time.
  144. self.assertLess(abs(dt - now), timedelta(seconds=2))
  145. @override_settings(USE_TZ=False, TIME_ZONE='Africa/Algiers')
  146. def _test_file_time_getter_tz_handling_off(self, getter):
  147. # Django's TZ (and hence the system TZ) is set to Africa/Algiers which
  148. # is UTC+1 and has no DST change. We can set the Django TZ to something
  149. # else so that UTC, Django's TIME_ZONE, and the system timezone are all
  150. # different.
  151. now_in_algiers = timezone.make_aware(datetime.now())
  152. with timezone.override(timezone.get_fixed_timezone(-300)):
  153. # At this point the system TZ is +1 and the Django TZ
  154. # is -5.
  155. self.assertFalse(self.storage.exists('test.file.tz.off'))
  156. f = ContentFile('custom contents')
  157. f_name = self.storage.save('test.file.tz.off', f)
  158. self.addCleanup(self.storage.delete, f_name)
  159. dt = getter(f_name)
  160. # dt should be naive, in system (+1) TZ
  161. self.assertTrue(timezone.is_naive(dt))
  162. # Check that the three timezones are indeed distinct.
  163. naive_now = datetime.now()
  164. algiers_offset = now_in_algiers.tzinfo.utcoffset(naive_now)
  165. django_offset = timezone.get_current_timezone().utcoffset(naive_now)
  166. utc_offset = timezone.utc.utcoffset(naive_now)
  167. self.assertGreater(algiers_offset, utc_offset)
  168. self.assertLess(django_offset, utc_offset)
  169. # dt and naive_now should be the same effective time.
  170. self.assertLess(abs(dt - naive_now), timedelta(seconds=2))
  171. # If we convert dt to an aware object using the Algiers
  172. # timezone then it should be the same effective time to
  173. # now_in_algiers.
  174. _dt = timezone.make_aware(dt, now_in_algiers.tzinfo)
  175. self.assertLess(abs(_dt - now_in_algiers), timedelta(seconds=2))
  176. def test_file_get_accessed_time(self):
  177. """
  178. File storage returns a Datetime object for the last accessed time of
  179. a file.
  180. """
  181. self.assertFalse(self.storage.exists('test.file'))
  182. f = ContentFile('custom contents')
  183. f_name = self.storage.save('test.file', f)
  184. self.addCleanup(self.storage.delete, f_name)
  185. atime = self.storage.get_accessed_time(f_name)
  186. self.assertEqual(atime, datetime.fromtimestamp(os.path.getatime(self.storage.path(f_name))))
  187. self.assertLess(timezone.now() - self.storage.get_accessed_time(f_name), timedelta(seconds=2))
  188. @requires_tz_support
  189. def test_file_get_accessed_time_timezone(self):
  190. self._test_file_time_getter(self.storage.get_accessed_time)
  191. @ignore_warnings(category=RemovedInDjango20Warning)
  192. def test_file_accessed_time(self):
  193. """
  194. File storage returns a datetime for the last accessed time of a file.
  195. """
  196. self.assertFalse(self.storage.exists('test.file'))
  197. f = ContentFile('custom contents')
  198. f_name = self.storage.save('test.file', f)
  199. self.addCleanup(self.storage.delete, f_name)
  200. atime = self.storage.accessed_time(f_name)
  201. self.assertEqual(atime, datetime.fromtimestamp(os.path.getatime(self.storage.path(f_name))))
  202. self.assertLess(datetime.now() - self.storage.accessed_time(f_name), timedelta(seconds=2))
  203. def test_file_get_created_time(self):
  204. """
  205. File storage returns a datetime for the creation time of a file.
  206. """
  207. self.assertFalse(self.storage.exists('test.file'))
  208. f = ContentFile('custom contents')
  209. f_name = self.storage.save('test.file', f)
  210. self.addCleanup(self.storage.delete, f_name)
  211. ctime = self.storage.get_created_time(f_name)
  212. self.assertEqual(ctime, datetime.fromtimestamp(os.path.getctime(self.storage.path(f_name))))
  213. self.assertLess(timezone.now() - self.storage.get_created_time(f_name), timedelta(seconds=2))
  214. @requires_tz_support
  215. def test_file_get_created_time_timezone(self):
  216. self._test_file_time_getter(self.storage.get_created_time)
  217. @ignore_warnings(category=RemovedInDjango20Warning)
  218. def test_file_created_time(self):
  219. """
  220. File storage returns a datetime for the creation time of a file.
  221. """
  222. self.assertFalse(self.storage.exists('test.file'))
  223. f = ContentFile('custom contents')
  224. f_name = self.storage.save('test.file', f)
  225. ctime = self.storage.created_time(f_name)
  226. self.addCleanup(self.storage.delete, f_name)
  227. self.assertEqual(ctime, datetime.fromtimestamp(os.path.getctime(self.storage.path(f_name))))
  228. self.assertLess(datetime.now() - self.storage.created_time(f_name), timedelta(seconds=2))
  229. def test_file_get_modified_time(self):
  230. """
  231. File storage returns a datetime for the last modified time of a file.
  232. """
  233. self.assertFalse(self.storage.exists('test.file'))
  234. f = ContentFile('custom contents')
  235. f_name = self.storage.save('test.file', f)
  236. self.addCleanup(self.storage.delete, f_name)
  237. mtime = self.storage.get_modified_time(f_name)
  238. self.assertEqual(mtime, datetime.fromtimestamp(os.path.getmtime(self.storage.path(f_name))))
  239. self.assertLess(timezone.now() - self.storage.get_modified_time(f_name), timedelta(seconds=2))
  240. @requires_tz_support
  241. def test_file_get_modified_time_timezone(self):
  242. self._test_file_time_getter(self.storage.get_modified_time)
  243. @ignore_warnings(category=RemovedInDjango20Warning)
  244. def test_file_modified_time(self):
  245. """
  246. File storage returns a datetime for the last modified time of a file.
  247. """
  248. self.assertFalse(self.storage.exists('test.file'))
  249. f = ContentFile('custom contents')
  250. f_name = self.storage.save('test.file', f)
  251. self.addCleanup(self.storage.delete, f_name)
  252. mtime = self.storage.modified_time(f_name)
  253. self.assertEqual(mtime, datetime.fromtimestamp(os.path.getmtime(self.storage.path(f_name))))
  254. self.assertLess(datetime.now() - self.storage.modified_time(f_name), timedelta(seconds=2))
  255. def test_file_save_without_name(self):
  256. """
  257. File storage extracts the filename from the content object if no
  258. name is given explicitly.
  259. """
  260. self.assertFalse(self.storage.exists('test.file'))
  261. f = ContentFile('custom contents')
  262. f.name = 'test.file'
  263. storage_f_name = self.storage.save(None, f)
  264. self.assertEqual(storage_f_name, f.name)
  265. self.assertTrue(os.path.exists(os.path.join(self.temp_dir, f.name)))
  266. self.storage.delete(storage_f_name)
  267. def test_file_save_with_path(self):
  268. """
  269. Saving a pathname should create intermediate directories as necessary.
  270. """
  271. self.assertFalse(self.storage.exists('path/to'))
  272. self.storage.save('path/to/test.file', ContentFile('file saved with path'))
  273. self.assertTrue(self.storage.exists('path/to'))
  274. with self.storage.open('path/to/test.file') as f:
  275. self.assertEqual(f.read(), b'file saved with path')
  276. self.assertTrue(os.path.exists(
  277. os.path.join(self.temp_dir, 'path', 'to', 'test.file')))
  278. self.storage.delete('path/to/test.file')
  279. def test_save_doesnt_close(self):
  280. with TemporaryUploadedFile('test', 'text/plain', 1, 'utf8') as file:
  281. file.write(b'1')
  282. file.seek(0)
  283. self.assertFalse(file.closed)
  284. self.storage.save('path/to/test.file', file)
  285. self.assertFalse(file.closed)
  286. self.assertFalse(file.file.closed)
  287. file = InMemoryUploadedFile(six.StringIO('1'), '', 'test', 'text/plain', 1, 'utf8')
  288. with file:
  289. self.assertFalse(file.closed)
  290. self.storage.save('path/to/test.file', file)
  291. self.assertFalse(file.closed)
  292. self.assertFalse(file.file.closed)
  293. def test_file_path(self):
  294. """
  295. File storage returns the full path of a file
  296. """
  297. self.assertFalse(self.storage.exists('test.file'))
  298. f = ContentFile('custom contents')
  299. f_name = self.storage.save('test.file', f)
  300. self.assertEqual(self.storage.path(f_name), os.path.join(self.temp_dir, f_name))
  301. self.storage.delete(f_name)
  302. def test_file_url(self):
  303. """
  304. File storage returns a url to access a given file from the Web.
  305. """
  306. self.assertEqual(self.storage.url('test.file'), self.storage.base_url + 'test.file')
  307. # should encode special chars except ~!*()'
  308. # like encodeURIComponent() JavaScript function do
  309. self.assertEqual(
  310. self.storage.url(r"~!*()'@#$%^&*abc`+ =.file"),
  311. "/test_media_url/~!*()'%40%23%24%25%5E%26*abc%60%2B%20%3D.file"
  312. )
  313. self.assertEqual(self.storage.url("ab\0c"), "/test_media_url/ab%00c")
  314. # should translate os path separator(s) to the url path separator
  315. self.assertEqual(self.storage.url("""a/b\\c.file"""), "/test_media_url/a/b/c.file")
  316. # #25905: remove leading slashes from file names to prevent unsafe url output
  317. self.assertEqual(self.storage.url("/evil.com"), "/test_media_url/evil.com")
  318. self.assertEqual(self.storage.url(r"\evil.com"), "/test_media_url/evil.com")
  319. self.assertEqual(self.storage.url("///evil.com"), "/test_media_url/evil.com")
  320. self.assertEqual(self.storage.url(r"\\\evil.com"), "/test_media_url/evil.com")
  321. self.assertEqual(self.storage.url(None), "/test_media_url/")
  322. def test_base_url(self):
  323. """
  324. File storage returns a url even when its base_url is unset or modified.
  325. """
  326. self.storage.base_url = None
  327. with self.assertRaises(ValueError):
  328. self.storage.url('test.file')
  329. # #22717: missing ending slash in base_url should be auto-corrected
  330. storage = self.storage_class(location=self.temp_dir, base_url='/no_ending_slash')
  331. self.assertEqual(
  332. storage.url('test.file'),
  333. '%s%s' % (storage.base_url, 'test.file')
  334. )
  335. def test_listdir(self):
  336. """
  337. File storage returns a tuple containing directories and files.
  338. """
  339. self.assertFalse(self.storage.exists('storage_test_1'))
  340. self.assertFalse(self.storage.exists('storage_test_2'))
  341. self.assertFalse(self.storage.exists('storage_dir_1'))
  342. self.storage.save('storage_test_1', ContentFile('custom content'))
  343. self.storage.save('storage_test_2', ContentFile('custom content'))
  344. os.mkdir(os.path.join(self.temp_dir, 'storage_dir_1'))
  345. dirs, files = self.storage.listdir('')
  346. self.assertEqual(set(dirs), {'storage_dir_1'})
  347. self.assertEqual(set(files), {'storage_test_1', 'storage_test_2'})
  348. self.storage.delete('storage_test_1')
  349. self.storage.delete('storage_test_2')
  350. os.rmdir(os.path.join(self.temp_dir, 'storage_dir_1'))
  351. def test_file_storage_prevents_directory_traversal(self):
  352. """
  353. File storage prevents directory traversal (files can only be accessed if
  354. they're below the storage location).
  355. """
  356. with self.assertRaises(SuspiciousOperation):
  357. self.storage.exists('..')
  358. with self.assertRaises(SuspiciousOperation):
  359. self.storage.exists('/etc/passwd')
  360. def test_file_storage_preserves_filename_case(self):
  361. """The storage backend should preserve case of filenames."""
  362. # Create a storage backend associated with the mixed case name
  363. # directory.
  364. other_temp_storage = self.storage_class(location=self.temp_dir2)
  365. # Ask that storage backend to store a file with a mixed case filename.
  366. mixed_case = 'CaSe_SeNsItIvE'
  367. file = other_temp_storage.open(mixed_case, 'w')
  368. file.write('storage contents')
  369. file.close()
  370. self.assertEqual(os.path.join(self.temp_dir2, mixed_case), other_temp_storage.path(mixed_case))
  371. other_temp_storage.delete(mixed_case)
  372. def test_makedirs_race_handling(self):
  373. """
  374. File storage should be robust against directory creation race conditions.
  375. """
  376. real_makedirs = os.makedirs
  377. # Monkey-patch os.makedirs, to simulate a normal call, a raced call,
  378. # and an error.
  379. def fake_makedirs(path):
  380. if path == os.path.join(self.temp_dir, 'normal'):
  381. real_makedirs(path)
  382. elif path == os.path.join(self.temp_dir, 'raced'):
  383. real_makedirs(path)
  384. raise OSError(errno.EEXIST, 'simulated EEXIST')
  385. elif path == os.path.join(self.temp_dir, 'error'):
  386. raise OSError(errno.EACCES, 'simulated EACCES')
  387. else:
  388. self.fail('unexpected argument %r' % path)
  389. try:
  390. os.makedirs = fake_makedirs
  391. self.storage.save('normal/test.file', ContentFile('saved normally'))
  392. with self.storage.open('normal/test.file') as f:
  393. self.assertEqual(f.read(), b'saved normally')
  394. self.storage.save('raced/test.file', ContentFile('saved with race'))
  395. with self.storage.open('raced/test.file') as f:
  396. self.assertEqual(f.read(), b'saved with race')
  397. # Check that OSErrors aside from EEXIST are still raised.
  398. with self.assertRaises(OSError):
  399. self.storage.save('error/test.file', ContentFile('not saved'))
  400. finally:
  401. os.makedirs = real_makedirs
  402. def test_remove_race_handling(self):
  403. """
  404. File storage should be robust against file removal race conditions.
  405. """
  406. real_remove = os.remove
  407. # Monkey-patch os.remove, to simulate a normal call, a raced call,
  408. # and an error.
  409. def fake_remove(path):
  410. if path == os.path.join(self.temp_dir, 'normal.file'):
  411. real_remove(path)
  412. elif path == os.path.join(self.temp_dir, 'raced.file'):
  413. real_remove(path)
  414. raise OSError(errno.ENOENT, 'simulated ENOENT')
  415. elif path == os.path.join(self.temp_dir, 'error.file'):
  416. raise OSError(errno.EACCES, 'simulated EACCES')
  417. else:
  418. self.fail('unexpected argument %r' % path)
  419. try:
  420. os.remove = fake_remove
  421. self.storage.save('normal.file', ContentFile('delete normally'))
  422. self.storage.delete('normal.file')
  423. self.assertFalse(self.storage.exists('normal.file'))
  424. self.storage.save('raced.file', ContentFile('delete with race'))
  425. self.storage.delete('raced.file')
  426. self.assertFalse(self.storage.exists('normal.file'))
  427. # Check that OSErrors aside from ENOENT are still raised.
  428. self.storage.save('error.file', ContentFile('delete with error'))
  429. with self.assertRaises(OSError):
  430. self.storage.delete('error.file')
  431. finally:
  432. os.remove = real_remove
  433. def test_file_chunks_error(self):
  434. """
  435. Test behavior when file.chunks() is raising an error
  436. """
  437. f1 = ContentFile('chunks fails')
  438. def failing_chunks():
  439. raise IOError
  440. f1.chunks = failing_chunks
  441. with self.assertRaises(IOError):
  442. self.storage.save('error.file', f1)
  443. def test_delete_no_name(self):
  444. """
  445. Calling delete with an empty name should not try to remove the base
  446. storage directory, but fail loudly (#20660).
  447. """
  448. with self.assertRaises(AssertionError):
  449. self.storage.delete('')
  450. @override_settings(
  451. MEDIA_ROOT='media_root',
  452. MEDIA_URL='media_url/',
  453. FILE_UPLOAD_PERMISSIONS=0o777,
  454. FILE_UPLOAD_DIRECTORY_PERMISSIONS=0o777,
  455. )
  456. def test_setting_changed(self):
  457. """
  458. Properties using settings values as defaults should be updated on
  459. referenced settings change while specified values should be unchanged.
  460. """
  461. storage = self.storage_class(
  462. location='explicit_location',
  463. base_url='explicit_base_url/',
  464. file_permissions_mode=0o666,
  465. directory_permissions_mode=0o666,
  466. )
  467. defaults_storage = self.storage_class()
  468. settings = {
  469. 'MEDIA_ROOT': 'overriden_media_root',
  470. 'MEDIA_URL': 'overriden_media_url/',
  471. 'FILE_UPLOAD_PERMISSIONS': 0o333,
  472. 'FILE_UPLOAD_DIRECTORY_PERMISSIONS': 0o333,
  473. }
  474. with self.settings(**settings):
  475. self.assertEqual(storage.base_location, 'explicit_location')
  476. self.assertIn('explicit_location', storage.location)
  477. self.assertEqual(storage.base_url, 'explicit_base_url/')
  478. self.assertEqual(storage.file_permissions_mode, 0o666)
  479. self.assertEqual(storage.directory_permissions_mode, 0o666)
  480. self.assertEqual(defaults_storage.base_location, settings['MEDIA_ROOT'])
  481. self.assertIn(settings['MEDIA_ROOT'], defaults_storage.location)
  482. self.assertEqual(defaults_storage.base_url, settings['MEDIA_URL'])
  483. self.assertEqual(defaults_storage.file_permissions_mode, settings['FILE_UPLOAD_PERMISSIONS'])
  484. self.assertEqual(
  485. defaults_storage.directory_permissions_mode, settings['FILE_UPLOAD_DIRECTORY_PERMISSIONS']
  486. )
  487. class CustomStorage(FileSystemStorage):
  488. def get_available_name(self, name, max_length=None):
  489. """
  490. Append numbers to duplicate files rather than underscores, like Trac.
  491. """
  492. parts = name.split('.')
  493. basename, ext = parts[0], parts[1:]
  494. number = 2
  495. while self.exists(name):
  496. name = '.'.join([basename, str(number)] + ext)
  497. number += 1
  498. return name
  499. class CustomStorageTests(FileStorageTests):
  500. storage_class = CustomStorage
  501. def test_custom_get_available_name(self):
  502. first = self.storage.save('custom_storage', ContentFile('custom contents'))
  503. self.assertEqual(first, 'custom_storage')
  504. second = self.storage.save('custom_storage', ContentFile('more contents'))
  505. self.assertEqual(second, 'custom_storage.2')
  506. self.storage.delete(first)
  507. self.storage.delete(second)
  508. class CustomStorageLegacyDatetimeHandling(FileSystemStorage):
  509. # Use the legacy accessed_time() et al from FileSystemStorage and the
  510. # shim get_accessed_time() et al from the Storage baseclass. Both of those
  511. # raise warnings, so the testcase class ignores them all.
  512. def get_accessed_time(self, name):
  513. return super(FileSystemStorage, self).get_accessed_time(name)
  514. def get_created_time(self, name):
  515. return super(FileSystemStorage, self).get_created_time(name)
  516. def get_modified_time(self, name):
  517. return super(FileSystemStorage, self).get_modified_time(name)
  518. @ignore_warnings(category=RemovedInDjango20Warning)
  519. class CustomStorageLegacyDatetimeHandlingTests(FileStorageTests):
  520. storage_class = CustomStorageLegacyDatetimeHandling
  521. class DiscardingFalseContentStorage(FileSystemStorage):
  522. def _save(self, name, content):
  523. if content:
  524. return super(DiscardingFalseContentStorage, self)._save(name, content)
  525. return ''
  526. class DiscardingFalseContentStorageTests(FileStorageTests):
  527. storage_class = DiscardingFalseContentStorage
  528. def test_custom_storage_discarding_empty_content(self):
  529. """
  530. When Storage.save() wraps a file-like object in File, it should include
  531. the name argument so that bool(file) evaluates to True (#26495).
  532. """
  533. output = six.StringIO('content')
  534. self.storage.save('tests/stringio', output)
  535. self.assertTrue(self.storage.exists('tests/stringio'))
  536. with self.storage.open('tests/stringio') as f:
  537. self.assertEqual(f.read(), b'content')
  538. class FileFieldStorageTests(TestCase):
  539. def tearDown(self):
  540. shutil.rmtree(temp_storage_location)
  541. def _storage_max_filename_length(self, storage):
  542. """
  543. Query filesystem for maximum filename length (e.g. AUFS has 242).
  544. """
  545. dir_to_test = storage.location
  546. while not os.path.exists(dir_to_test):
  547. dir_to_test = os.path.dirname(dir_to_test)
  548. try:
  549. return os.pathconf(dir_to_test, 'PC_NAME_MAX')
  550. except Exception:
  551. return 255 # Should be safe on most backends
  552. def test_files(self):
  553. self.assertIsInstance(Storage.normal, FileDescriptor)
  554. # An object without a file has limited functionality.
  555. obj1 = Storage()
  556. self.assertEqual(obj1.normal.name, "")
  557. with self.assertRaises(ValueError):
  558. obj1.normal.size
  559. # Saving a file enables full functionality.
  560. obj1.normal.save("django_test.txt", ContentFile("content"))
  561. self.assertEqual(obj1.normal.name, "tests/django_test.txt")
  562. self.assertEqual(obj1.normal.size, 7)
  563. self.assertEqual(obj1.normal.read(), b"content")
  564. obj1.normal.close()
  565. # File objects can be assigned to FileField attributes, but shouldn't
  566. # get committed until the model it's attached to is saved.
  567. obj1.normal = SimpleUploadedFile("assignment.txt", b"content")
  568. dirs, files = temp_storage.listdir("tests")
  569. self.assertEqual(dirs, [])
  570. self.assertNotIn("assignment.txt", files)
  571. obj1.save()
  572. dirs, files = temp_storage.listdir("tests")
  573. self.assertEqual(sorted(files), ["assignment.txt", "django_test.txt"])
  574. # Save another file with the same name.
  575. obj2 = Storage()
  576. obj2.normal.save("django_test.txt", ContentFile("more content"))
  577. obj2_name = obj2.normal.name
  578. six.assertRegex(self, obj2_name, "tests/django_test_%s.txt" % FILE_SUFFIX_REGEX)
  579. self.assertEqual(obj2.normal.size, 12)
  580. obj2.normal.close()
  581. # Deleting an object does not delete the file it uses.
  582. obj2.delete()
  583. obj2.normal.save("django_test.txt", ContentFile("more content"))
  584. self.assertNotEqual(obj2_name, obj2.normal.name)
  585. six.assertRegex(self, obj2.normal.name, "tests/django_test_%s.txt" % FILE_SUFFIX_REGEX)
  586. obj2.normal.close()
  587. def test_filefield_read(self):
  588. # Files can be read in a little at a time, if necessary.
  589. obj = Storage.objects.create(
  590. normal=SimpleUploadedFile("assignment.txt", b"content"))
  591. obj.normal.open()
  592. self.assertEqual(obj.normal.read(3), b"con")
  593. self.assertEqual(obj.normal.read(), b"tent")
  594. self.assertEqual(list(obj.normal.chunks(chunk_size=2)), [b"co", b"nt", b"en", b"t"])
  595. obj.normal.close()
  596. def test_filefield_write(self):
  597. # Files can be written to.
  598. obj = Storage.objects.create(normal=SimpleUploadedFile('rewritten.txt', b'content'))
  599. with obj.normal as normal:
  600. normal.open('wb')
  601. normal.write(b'updated')
  602. obj.refresh_from_db()
  603. self.assertEqual(obj.normal.read(), b'updated')
  604. obj.normal.close()
  605. def test_filefield_reopen(self):
  606. obj = Storage.objects.create(normal=SimpleUploadedFile('reopen.txt', b'content'))
  607. with obj.normal as normal:
  608. normal.open()
  609. obj.normal.open()
  610. obj.normal.file.seek(0)
  611. obj.normal.close()
  612. def test_duplicate_filename(self):
  613. # Multiple files with the same name get _(7 random chars) appended to them.
  614. objs = [Storage() for i in range(2)]
  615. for o in objs:
  616. o.normal.save("multiple_files.txt", ContentFile("Same Content"))
  617. try:
  618. names = [o.normal.name for o in objs]
  619. self.assertEqual(names[0], "tests/multiple_files.txt")
  620. six.assertRegex(self, names[1], "tests/multiple_files_%s.txt" % FILE_SUFFIX_REGEX)
  621. finally:
  622. for o in objs:
  623. o.delete()
  624. def test_file_truncation(self):
  625. # Given the max_length is limited, when multiple files get uploaded
  626. # under the same name, then the filename get truncated in order to fit
  627. # in _(7 random chars). When most of the max_length is taken by
  628. # dirname + extension and there are not enough characters in the
  629. # filename to truncate, an exception should be raised.
  630. objs = [Storage() for i in range(2)]
  631. filename = 'filename.ext'
  632. for o in objs:
  633. o.limited_length.save(filename, ContentFile('Same Content'))
  634. try:
  635. # Testing truncation.
  636. names = [o.limited_length.name for o in objs]
  637. self.assertEqual(names[0], 'tests/%s' % filename)
  638. six.assertRegex(self, names[1], 'tests/fi_%s.ext' % FILE_SUFFIX_REGEX)
  639. # Testing exception is raised when filename is too short to truncate.
  640. filename = 'short.longext'
  641. objs[0].limited_length.save(filename, ContentFile('Same Content'))
  642. with self.assertRaisesMessage(SuspiciousFileOperation, 'Storage can not find an available filename'):
  643. objs[1].limited_length.save(*(filename, ContentFile('Same Content')))
  644. finally:
  645. for o in objs:
  646. o.delete()
  647. @unittest.skipIf(
  648. sys.platform.startswith('win'),
  649. "Windows supports at most 260 characters in a path.",
  650. )
  651. def test_extended_length_storage(self):
  652. # Testing FileField with max_length > 255. Most systems have filename
  653. # length limitation of 255. Path takes extra chars.
  654. filename = (self._storage_max_filename_length(temp_storage) - 4) * 'a' # 4 chars for extension.
  655. obj = Storage()
  656. obj.extended_length.save('%s.txt' % filename, ContentFile('Same Content'))
  657. self.assertEqual(obj.extended_length.name, 'tests/%s.txt' % filename)
  658. self.assertEqual(obj.extended_length.read(), b'Same Content')
  659. obj.extended_length.close()
  660. def test_filefield_default(self):
  661. # Default values allow an object to access a single file.
  662. temp_storage.save('tests/default.txt', ContentFile('default content'))
  663. obj = Storage.objects.create()
  664. self.assertEqual(obj.default.name, "tests/default.txt")
  665. self.assertEqual(obj.default.read(), b"default content")
  666. obj.default.close()
  667. # But it shouldn't be deleted, even if there are no more objects using
  668. # it.
  669. obj.delete()
  670. obj = Storage()
  671. self.assertEqual(obj.default.read(), b"default content")
  672. obj.default.close()
  673. def test_empty_upload_to(self):
  674. # upload_to can be empty, meaning it does not use subdirectory.
  675. obj = Storage()
  676. obj.empty.save('django_test.txt', ContentFile('more content'))
  677. self.assertEqual(obj.empty.name, "django_test.txt")
  678. self.assertEqual(obj.empty.read(), b"more content")
  679. obj.empty.close()
  680. def test_random_upload_to(self):
  681. # Verify the fix for #5655, making sure the directory is only
  682. # determined once.
  683. obj = Storage()
  684. obj.random.save("random_file", ContentFile("random content"))
  685. self.assertTrue(obj.random.name.endswith("/random_file"))
  686. obj.random.close()
  687. def test_custom_valid_name_callable_upload_to(self):
  688. """
  689. Storage.get_valid_name() should be called when upload_to is a callable.
  690. """
  691. obj = Storage()
  692. obj.custom_valid_name.save("random_file", ContentFile("random content"))
  693. # CustomValidNameStorage.get_valid_name() appends '_valid' to the name
  694. self.assertTrue(obj.custom_valid_name.name.endswith("/random_file_valid"))
  695. obj.custom_valid_name.close()
  696. def test_filefield_pickling(self):
  697. # Push an object into the cache to make sure it pickles properly
  698. obj = Storage()
  699. obj.normal.save("django_test.txt", ContentFile("more content"))
  700. obj.normal.close()
  701. cache.set("obj", obj)
  702. self.assertEqual(cache.get("obj").normal.name, "tests/django_test.txt")
  703. def test_file_object(self):
  704. # Create sample file
  705. temp_storage.save('tests/example.txt', ContentFile('some content'))
  706. # Load it as python file object
  707. with open(temp_storage.path('tests/example.txt')) as file_obj:
  708. # Save it using storage and read its content
  709. temp_storage.save('tests/file_obj', file_obj)
  710. self.assertTrue(temp_storage.exists('tests/file_obj'))
  711. with temp_storage.open('tests/file_obj') as f:
  712. self.assertEqual(f.read(), b'some content')
  713. def test_stringio(self):
  714. # Test passing StringIO instance as content argument to save
  715. output = six.StringIO()
  716. output.write('content')
  717. output.seek(0)
  718. # Save it and read written file
  719. temp_storage.save('tests/stringio', output)
  720. self.assertTrue(temp_storage.exists('tests/stringio'))
  721. with temp_storage.open('tests/stringio') as f:
  722. self.assertEqual(f.read(), b'content')
  723. # Tests for a race condition on file saving (#4948).
  724. # This is written in such a way that it'll always pass on platforms
  725. # without threading.
  726. class SlowFile(ContentFile):
  727. def chunks(self):
  728. time.sleep(1)
  729. return super(ContentFile, self).chunks()
  730. class FileSaveRaceConditionTest(unittest.TestCase):
  731. def setUp(self):
  732. self.storage_dir = tempfile.mkdtemp()
  733. self.storage = FileSystemStorage(self.storage_dir)
  734. self.thread = threading.Thread(target=self.save_file, args=['conflict'])
  735. def tearDown(self):
  736. shutil.rmtree(self.storage_dir)
  737. def save_file(self, name):
  738. name = self.storage.save(name, SlowFile(b"Data"))
  739. def test_race_condition(self):
  740. self.thread.start()
  741. self.save_file('conflict')
  742. self.thread.join()
  743. files = sorted(os.listdir(self.storage_dir))
  744. self.assertEqual(files[0], 'conflict')
  745. six.assertRegex(self, files[1], 'conflict_%s' % FILE_SUFFIX_REGEX)
  746. @unittest.skipIf(sys.platform.startswith('win'), "Windows only partially supports umasks and chmod.")
  747. class FileStoragePermissions(unittest.TestCase):
  748. def setUp(self):
  749. self.umask = 0o027
  750. self.old_umask = os.umask(self.umask)
  751. self.storage_dir = tempfile.mkdtemp()
  752. def tearDown(self):
  753. shutil.rmtree(self.storage_dir)
  754. os.umask(self.old_umask)
  755. @override_settings(FILE_UPLOAD_PERMISSIONS=0o654)
  756. def test_file_upload_permissions(self):
  757. self.storage = FileSystemStorage(self.storage_dir)
  758. name = self.storage.save("the_file", ContentFile("data"))
  759. actual_mode = os.stat(self.storage.path(name))[0] & 0o777
  760. self.assertEqual(actual_mode, 0o654)
  761. @override_settings(FILE_UPLOAD_PERMISSIONS=None)
  762. def test_file_upload_default_permissions(self):
  763. self.storage = FileSystemStorage(self.storage_dir)
  764. fname = self.storage.save("some_file", ContentFile("data"))
  765. mode = os.stat(self.storage.path(fname))[0] & 0o777
  766. self.assertEqual(mode, 0o666 & ~self.umask)
  767. @override_settings(FILE_UPLOAD_DIRECTORY_PERMISSIONS=0o765)
  768. def test_file_upload_directory_permissions(self):
  769. self.storage = FileSystemStorage(self.storage_dir)
  770. name = self.storage.save("the_directory/the_file", ContentFile("data"))
  771. dir_mode = os.stat(os.path.dirname(self.storage.path(name)))[0] & 0o777
  772. self.assertEqual(dir_mode, 0o765)
  773. @override_settings(FILE_UPLOAD_DIRECTORY_PERMISSIONS=None)
  774. def test_file_upload_directory_default_permissions(self):
  775. self.storage = FileSystemStorage(self.storage_dir)
  776. name = self.storage.save("the_directory/the_file", ContentFile("data"))
  777. dir_mode = os.stat(os.path.dirname(self.storage.path(name)))[0] & 0o777
  778. self.assertEqual(dir_mode, 0o777 & ~self.umask)
  779. class FileStoragePathParsing(unittest.TestCase):
  780. def setUp(self):
  781. self.storage_dir = tempfile.mkdtemp()
  782. self.storage = FileSystemStorage(self.storage_dir)
  783. def tearDown(self):
  784. shutil.rmtree(self.storage_dir)
  785. def test_directory_with_dot(self):
  786. """Regression test for #9610.
  787. If the directory name contains a dot and the file name doesn't, make
  788. sure we still mangle the file name instead of the directory name.
  789. """
  790. self.storage.save('dotted.path/test', ContentFile("1"))
  791. self.storage.save('dotted.path/test', ContentFile("2"))
  792. files = sorted(os.listdir(os.path.join(self.storage_dir, 'dotted.path')))
  793. self.assertFalse(os.path.exists(os.path.join(self.storage_dir, 'dotted_.path')))
  794. self.assertEqual(files[0], 'test')
  795. six.assertRegex(self, files[1], 'test_%s' % FILE_SUFFIX_REGEX)
  796. def test_first_character_dot(self):
  797. """
  798. File names with a dot as their first character don't have an extension,
  799. and the underscore should get added to the end.
  800. """
  801. self.storage.save('dotted.path/.test', ContentFile("1"))
  802. self.storage.save('dotted.path/.test', ContentFile("2"))
  803. files = sorted(os.listdir(os.path.join(self.storage_dir, 'dotted.path')))
  804. self.assertFalse(os.path.exists(os.path.join(self.storage_dir, 'dotted_.path')))
  805. self.assertEqual(files[0], '.test')
  806. six.assertRegex(self, files[1], '.test_%s' % FILE_SUFFIX_REGEX)
  807. class ContentFileStorageTestCase(unittest.TestCase):
  808. def setUp(self):
  809. self.storage_dir = tempfile.mkdtemp()
  810. self.storage = FileSystemStorage(self.storage_dir)
  811. def tearDown(self):
  812. shutil.rmtree(self.storage_dir)
  813. def test_content_saving(self):
  814. """
  815. Test that ContentFile can be saved correctly with the filesystem storage,
  816. both if it was initialized with string or unicode content"""
  817. self.storage.save('bytes.txt', ContentFile(b"content"))
  818. self.storage.save('unicode.txt', ContentFile("español"))
  819. @override_settings(ROOT_URLCONF='file_storage.urls')
  820. class FileLikeObjectTestCase(LiveServerTestCase):
  821. """
  822. Test file-like objects (#15644).
  823. """
  824. available_apps = []
  825. def setUp(self):
  826. self.temp_dir = tempfile.mkdtemp()
  827. self.storage = FileSystemStorage(location=self.temp_dir)
  828. def tearDown(self):
  829. shutil.rmtree(self.temp_dir)
  830. def test_urllib2_urlopen(self):
  831. """
  832. Test the File storage API with a file like object coming from urllib2.urlopen()
  833. """
  834. file_like_object = urlopen(self.live_server_url + '/')
  835. f = File(file_like_object)
  836. stored_filename = self.storage.save("remote_file.html", f)
  837. remote_file = urlopen(self.live_server_url + '/')
  838. with self.storage.open(stored_filename) as stored_file:
  839. self.assertEqual(stored_file.read(), remote_file.read())