tests.py 32 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808
  1. import re
  2. from django.conf import settings
  3. from django.contrib.sessions.backends.cache import SessionStore
  4. from django.core.exceptions import ImproperlyConfigured
  5. from django.http import HttpRequest, HttpResponse
  6. from django.middleware.csrf import (
  7. CSRF_SESSION_KEY, CSRF_TOKEN_LENGTH, REASON_BAD_TOKEN,
  8. REASON_NO_CSRF_COOKIE, CsrfViewMiddleware,
  9. _compare_salted_tokens as equivalent_tokens, get_token,
  10. )
  11. from django.test import SimpleTestCase, override_settings
  12. from django.views.decorators.csrf import csrf_exempt, requires_csrf_token
  13. from .views import (
  14. ensure_csrf_cookie_view, non_token_view_using_request_processor,
  15. post_form_view, token_view,
  16. )
  17. class TestingHttpRequest(HttpRequest):
  18. """
  19. A version of HttpRequest that allows us to change some things
  20. more easily
  21. """
  22. def __init__(self):
  23. super().__init__()
  24. self.session = SessionStore()
  25. def is_secure(self):
  26. return getattr(self, '_is_secure_override', False)
  27. class CsrfViewMiddlewareTestMixin:
  28. """
  29. Shared methods and tests for session-based and cookie-based tokens.
  30. """
  31. _csrf_id = _csrf_id_cookie = '1bcdefghij2bcdefghij3bcdefghij4bcdefghij5bcdefghij6bcdefghijABCD'
  32. def _get_GET_no_csrf_cookie_request(self):
  33. return TestingHttpRequest()
  34. def _get_GET_csrf_cookie_request(self):
  35. raise NotImplementedError('This method must be implemented by a subclass.')
  36. def _get_POST_csrf_cookie_request(self):
  37. req = self._get_GET_csrf_cookie_request()
  38. req.method = "POST"
  39. return req
  40. def _get_POST_no_csrf_cookie_request(self):
  41. req = self._get_GET_no_csrf_cookie_request()
  42. req.method = "POST"
  43. return req
  44. def _get_POST_request_with_token(self):
  45. req = self._get_POST_csrf_cookie_request()
  46. req.POST['csrfmiddlewaretoken'] = self._csrf_id
  47. return req
  48. def _check_token_present(self, response, csrf_id=None):
  49. text = str(response.content, response.charset)
  50. match = re.search('name="csrfmiddlewaretoken" value="(.*?)"', text)
  51. csrf_token = csrf_id or self._csrf_id
  52. self.assertTrue(
  53. match and equivalent_tokens(csrf_token, match.group(1)),
  54. "Could not find csrfmiddlewaretoken to match %s" % csrf_token
  55. )
  56. def test_process_response_get_token_not_used(self):
  57. """
  58. If get_token() is not called, the view middleware does not
  59. add a cookie.
  60. """
  61. # This is important to make pages cacheable. Pages which do call
  62. # get_token(), assuming they use the token, are not cacheable because
  63. # the token is specific to the user
  64. req = self._get_GET_no_csrf_cookie_request()
  65. # non_token_view_using_request_processor does not call get_token(), but
  66. # does use the csrf request processor. By using this, we are testing
  67. # that the view processor is properly lazy and doesn't call get_token()
  68. # until needed.
  69. mw = CsrfViewMiddleware(non_token_view_using_request_processor)
  70. mw.process_request(req)
  71. mw.process_view(req, non_token_view_using_request_processor, (), {})
  72. resp = mw(req)
  73. csrf_cookie = resp.cookies.get(settings.CSRF_COOKIE_NAME, False)
  74. self.assertIs(csrf_cookie, False)
  75. # Check the request processing
  76. def test_process_request_no_csrf_cookie(self):
  77. """
  78. If no CSRF cookies is present, the middleware rejects the incoming
  79. request. This will stop login CSRF.
  80. """
  81. req = self._get_POST_no_csrf_cookie_request()
  82. mw = CsrfViewMiddleware(post_form_view)
  83. mw.process_request(req)
  84. with self.assertLogs('django.security.csrf', 'WARNING') as cm:
  85. resp = mw.process_view(req, post_form_view, (), {})
  86. self.assertEqual(403, resp.status_code)
  87. self.assertEqual(cm.records[0].getMessage(), 'Forbidden (%s): ' % REASON_NO_CSRF_COOKIE)
  88. def test_process_request_csrf_cookie_no_token(self):
  89. """
  90. If a CSRF cookie is present but no token, the middleware rejects
  91. the incoming request.
  92. """
  93. req = self._get_POST_csrf_cookie_request()
  94. mw = CsrfViewMiddleware(post_form_view)
  95. mw.process_request(req)
  96. with self.assertLogs('django.security.csrf', 'WARNING') as cm:
  97. resp = mw.process_view(req, post_form_view, (), {})
  98. self.assertEqual(403, resp.status_code)
  99. self.assertEqual(cm.records[0].getMessage(), 'Forbidden (%s): ' % REASON_BAD_TOKEN)
  100. def test_process_request_csrf_cookie_and_token(self):
  101. """
  102. If both a cookie and a token is present, the middleware lets it through.
  103. """
  104. req = self._get_POST_request_with_token()
  105. mw = CsrfViewMiddleware(post_form_view)
  106. mw.process_request(req)
  107. resp = mw.process_view(req, post_form_view, (), {})
  108. self.assertIsNone(resp)
  109. def test_process_request_csrf_cookie_no_token_exempt_view(self):
  110. """
  111. If a CSRF cookie is present and no token, but the csrf_exempt decorator
  112. has been applied to the view, the middleware lets it through
  113. """
  114. req = self._get_POST_csrf_cookie_request()
  115. mw = CsrfViewMiddleware(post_form_view)
  116. mw.process_request(req)
  117. resp = mw.process_view(req, csrf_exempt(post_form_view), (), {})
  118. self.assertIsNone(resp)
  119. def test_csrf_token_in_header(self):
  120. """
  121. The token may be passed in a header instead of in the form.
  122. """
  123. req = self._get_POST_csrf_cookie_request()
  124. req.META['HTTP_X_CSRFTOKEN'] = self._csrf_id
  125. mw = CsrfViewMiddleware(post_form_view)
  126. mw.process_request(req)
  127. resp = mw.process_view(req, post_form_view, (), {})
  128. self.assertIsNone(resp)
  129. @override_settings(CSRF_HEADER_NAME='HTTP_X_CSRFTOKEN_CUSTOMIZED')
  130. def test_csrf_token_in_header_with_customized_name(self):
  131. """
  132. settings.CSRF_HEADER_NAME can be used to customize the CSRF header name
  133. """
  134. req = self._get_POST_csrf_cookie_request()
  135. req.META['HTTP_X_CSRFTOKEN_CUSTOMIZED'] = self._csrf_id
  136. mw = CsrfViewMiddleware(post_form_view)
  137. mw.process_request(req)
  138. resp = mw.process_view(req, post_form_view, (), {})
  139. self.assertIsNone(resp)
  140. def test_put_and_delete_rejected(self):
  141. """
  142. HTTP PUT and DELETE methods have protection
  143. """
  144. req = TestingHttpRequest()
  145. req.method = 'PUT'
  146. mw = CsrfViewMiddleware(post_form_view)
  147. with self.assertLogs('django.security.csrf', 'WARNING') as cm:
  148. resp = mw.process_view(req, post_form_view, (), {})
  149. self.assertEqual(403, resp.status_code)
  150. self.assertEqual(cm.records[0].getMessage(), 'Forbidden (%s): ' % REASON_NO_CSRF_COOKIE)
  151. req = TestingHttpRequest()
  152. req.method = 'DELETE'
  153. with self.assertLogs('django.security.csrf', 'WARNING') as cm:
  154. resp = mw.process_view(req, post_form_view, (), {})
  155. self.assertEqual(403, resp.status_code)
  156. self.assertEqual(cm.records[0].getMessage(), 'Forbidden (%s): ' % REASON_NO_CSRF_COOKIE)
  157. def test_put_and_delete_allowed(self):
  158. """
  159. HTTP PUT and DELETE can get through with X-CSRFToken and a cookie.
  160. """
  161. req = self._get_GET_csrf_cookie_request()
  162. req.method = 'PUT'
  163. req.META['HTTP_X_CSRFTOKEN'] = self._csrf_id
  164. mw = CsrfViewMiddleware(post_form_view)
  165. mw.process_request(req)
  166. resp = mw.process_view(req, post_form_view, (), {})
  167. self.assertIsNone(resp)
  168. req = self._get_GET_csrf_cookie_request()
  169. req.method = 'DELETE'
  170. req.META['HTTP_X_CSRFTOKEN'] = self._csrf_id
  171. mw.process_request(req)
  172. resp = mw.process_view(req, post_form_view, (), {})
  173. self.assertIsNone(resp)
  174. # Tests for the template tag method
  175. def test_token_node_no_csrf_cookie(self):
  176. """
  177. CsrfTokenNode works when no CSRF cookie is set.
  178. """
  179. req = self._get_GET_no_csrf_cookie_request()
  180. resp = token_view(req)
  181. token = get_token(req)
  182. self.assertIsNotNone(token)
  183. self._check_token_present(resp, token)
  184. def test_token_node_empty_csrf_cookie(self):
  185. """
  186. A new token is sent if the csrf_cookie is the empty string.
  187. """
  188. req = self._get_GET_no_csrf_cookie_request()
  189. req.COOKIES[settings.CSRF_COOKIE_NAME] = ""
  190. mw = CsrfViewMiddleware(token_view)
  191. mw.process_view(req, token_view, (), {})
  192. resp = token_view(req)
  193. token = get_token(req)
  194. self.assertIsNotNone(token)
  195. self._check_token_present(resp, token)
  196. def test_token_node_with_csrf_cookie(self):
  197. """
  198. CsrfTokenNode works when a CSRF cookie is set.
  199. """
  200. req = self._get_GET_csrf_cookie_request()
  201. mw = CsrfViewMiddleware(token_view)
  202. mw.process_request(req)
  203. mw.process_view(req, token_view, (), {})
  204. resp = token_view(req)
  205. self._check_token_present(resp)
  206. def test_get_token_for_exempt_view(self):
  207. """
  208. get_token still works for a view decorated with 'csrf_exempt'.
  209. """
  210. req = self._get_GET_csrf_cookie_request()
  211. mw = CsrfViewMiddleware(token_view)
  212. mw.process_request(req)
  213. mw.process_view(req, csrf_exempt(token_view), (), {})
  214. resp = token_view(req)
  215. self._check_token_present(resp)
  216. def test_get_token_for_requires_csrf_token_view(self):
  217. """
  218. get_token() works for a view decorated solely with requires_csrf_token.
  219. """
  220. req = self._get_GET_csrf_cookie_request()
  221. resp = requires_csrf_token(token_view)(req)
  222. self._check_token_present(resp)
  223. def test_token_node_with_new_csrf_cookie(self):
  224. """
  225. CsrfTokenNode works when a CSRF cookie is created by
  226. the middleware (when one was not already present)
  227. """
  228. req = self._get_GET_no_csrf_cookie_request()
  229. mw = CsrfViewMiddleware(token_view)
  230. mw.process_view(req, token_view, (), {})
  231. resp = mw(req)
  232. csrf_cookie = resp.cookies[settings.CSRF_COOKIE_NAME]
  233. self._check_token_present(resp, csrf_id=csrf_cookie.value)
  234. def test_cookie_not_reset_on_accepted_request(self):
  235. """
  236. The csrf token used in posts is changed on every request (although
  237. stays equivalent). The csrf cookie should not change on accepted
  238. requests. If it appears in the response, it should keep its value.
  239. """
  240. req = self._get_POST_request_with_token()
  241. mw = CsrfViewMiddleware(token_view)
  242. mw.process_request(req)
  243. mw.process_view(req, token_view, (), {})
  244. resp = mw(req)
  245. csrf_cookie = resp.cookies.get(settings.CSRF_COOKIE_NAME, None)
  246. if csrf_cookie:
  247. self.assertEqual(
  248. csrf_cookie.value, self._csrf_id_cookie,
  249. "CSRF cookie was changed on an accepted request"
  250. )
  251. @override_settings(DEBUG=True, ALLOWED_HOSTS=['www.example.com'])
  252. def test_https_bad_referer(self):
  253. """
  254. A POST HTTPS request with a bad referer is rejected
  255. """
  256. req = self._get_POST_request_with_token()
  257. req._is_secure_override = True
  258. req.META['HTTP_HOST'] = 'www.example.com'
  259. req.META['HTTP_REFERER'] = 'https://www.evil.org/somepage'
  260. req.META['SERVER_PORT'] = '443'
  261. mw = CsrfViewMiddleware(post_form_view)
  262. response = mw.process_view(req, post_form_view, (), {})
  263. self.assertContains(
  264. response,
  265. 'Referer checking failed - https://www.evil.org/somepage does not '
  266. 'match any trusted origins.',
  267. status_code=403,
  268. )
  269. def test_https_malformed_host(self):
  270. """
  271. CsrfViewMiddleware generates a 403 response if it receives an HTTPS
  272. request with a bad host.
  273. """
  274. req = self._get_GET_no_csrf_cookie_request()
  275. req._is_secure_override = True
  276. req.META['HTTP_HOST'] = '@malformed'
  277. req.META['HTTP_REFERER'] = 'https://www.evil.org/somepage'
  278. req.META['SERVER_PORT'] = '443'
  279. mw = CsrfViewMiddleware(token_view)
  280. response = mw.process_view(req, token_view, (), {})
  281. self.assertEqual(response.status_code, 403)
  282. @override_settings(DEBUG=True)
  283. def test_https_malformed_referer(self):
  284. """
  285. A POST HTTPS request with a bad referer is rejected.
  286. """
  287. malformed_referer_msg = 'Referer checking failed - Referer is malformed.'
  288. req = self._get_POST_request_with_token()
  289. req._is_secure_override = True
  290. req.META['HTTP_REFERER'] = 'http://http://www.example.com/'
  291. mw = CsrfViewMiddleware(post_form_view)
  292. response = mw.process_view(req, post_form_view, (), {})
  293. self.assertContains(
  294. response,
  295. 'Referer checking failed - Referer is insecure while host is secure.',
  296. status_code=403,
  297. )
  298. # Empty
  299. req.META['HTTP_REFERER'] = ''
  300. response = mw.process_view(req, post_form_view, (), {})
  301. self.assertContains(response, malformed_referer_msg, status_code=403)
  302. # Non-ASCII
  303. req.META['HTTP_REFERER'] = 'ØBöIß'
  304. response = mw.process_view(req, post_form_view, (), {})
  305. self.assertContains(response, malformed_referer_msg, status_code=403)
  306. # missing scheme
  307. # >>> urlparse('//example.com/')
  308. # ParseResult(scheme='', netloc='example.com', path='/', params='', query='', fragment='')
  309. req.META['HTTP_REFERER'] = '//example.com/'
  310. response = mw.process_view(req, post_form_view, (), {})
  311. self.assertContains(response, malformed_referer_msg, status_code=403)
  312. # missing netloc
  313. # >>> urlparse('https://')
  314. # ParseResult(scheme='https', netloc='', path='', params='', query='', fragment='')
  315. req.META['HTTP_REFERER'] = 'https://'
  316. response = mw.process_view(req, post_form_view, (), {})
  317. self.assertContains(response, malformed_referer_msg, status_code=403)
  318. @override_settings(ALLOWED_HOSTS=['www.example.com'])
  319. def test_https_good_referer(self):
  320. """
  321. A POST HTTPS request with a good referer is accepted.
  322. """
  323. req = self._get_POST_request_with_token()
  324. req._is_secure_override = True
  325. req.META['HTTP_HOST'] = 'www.example.com'
  326. req.META['HTTP_REFERER'] = 'https://www.example.com/somepage'
  327. mw = CsrfViewMiddleware(post_form_view)
  328. mw.process_request(req)
  329. resp = mw.process_view(req, post_form_view, (), {})
  330. self.assertIsNone(resp)
  331. @override_settings(ALLOWED_HOSTS=['www.example.com'])
  332. def test_https_good_referer_2(self):
  333. """
  334. A POST HTTPS request with a good referer is accepted where the referer
  335. contains no trailing slash.
  336. """
  337. # See ticket #15617
  338. req = self._get_POST_request_with_token()
  339. req._is_secure_override = True
  340. req.META['HTTP_HOST'] = 'www.example.com'
  341. req.META['HTTP_REFERER'] = 'https://www.example.com'
  342. mw = CsrfViewMiddleware(post_form_view)
  343. mw.process_request(req)
  344. resp = mw.process_view(req, post_form_view, (), {})
  345. self.assertIsNone(resp)
  346. def _test_https_good_referer_behind_proxy(self):
  347. req = self._get_POST_request_with_token()
  348. req._is_secure_override = True
  349. req.META.update({
  350. 'HTTP_HOST': '10.0.0.2',
  351. 'HTTP_REFERER': 'https://www.example.com/somepage',
  352. 'SERVER_PORT': '8080',
  353. 'HTTP_X_FORWARDED_HOST': 'www.example.com',
  354. 'HTTP_X_FORWARDED_PORT': '443',
  355. })
  356. mw = CsrfViewMiddleware(post_form_view)
  357. mw.process_request(req)
  358. resp = mw.process_view(req, post_form_view, (), {})
  359. self.assertIsNone(resp)
  360. @override_settings(ALLOWED_HOSTS=['www.example.com'], CSRF_TRUSTED_ORIGINS=['dashboard.example.com'])
  361. def test_https_csrf_trusted_origin_allowed(self):
  362. """
  363. A POST HTTPS request with a referer added to the CSRF_TRUSTED_ORIGINS
  364. setting is accepted.
  365. """
  366. req = self._get_POST_request_with_token()
  367. req._is_secure_override = True
  368. req.META['HTTP_HOST'] = 'www.example.com'
  369. req.META['HTTP_REFERER'] = 'https://dashboard.example.com'
  370. mw = CsrfViewMiddleware(post_form_view)
  371. mw.process_request(req)
  372. resp = mw.process_view(req, post_form_view, (), {})
  373. self.assertIsNone(resp)
  374. @override_settings(ALLOWED_HOSTS=['www.example.com'], CSRF_TRUSTED_ORIGINS=['.example.com'])
  375. def test_https_csrf_wildcard_trusted_origin_allowed(self):
  376. """
  377. A POST HTTPS request with a referer that matches a CSRF_TRUSTED_ORIGINS
  378. wildcard is accepted.
  379. """
  380. req = self._get_POST_request_with_token()
  381. req._is_secure_override = True
  382. req.META['HTTP_HOST'] = 'www.example.com'
  383. req.META['HTTP_REFERER'] = 'https://dashboard.example.com'
  384. mw = CsrfViewMiddleware(post_form_view)
  385. mw.process_request(req)
  386. response = mw.process_view(req, post_form_view, (), {})
  387. self.assertIsNone(response)
  388. def _test_https_good_referer_matches_cookie_domain(self):
  389. req = self._get_POST_request_with_token()
  390. req._is_secure_override = True
  391. req.META['HTTP_REFERER'] = 'https://foo.example.com/'
  392. req.META['SERVER_PORT'] = '443'
  393. mw = CsrfViewMiddleware(post_form_view)
  394. mw.process_request(req)
  395. response = mw.process_view(req, post_form_view, (), {})
  396. self.assertIsNone(response)
  397. def _test_https_good_referer_matches_cookie_domain_with_different_port(self):
  398. req = self._get_POST_request_with_token()
  399. req._is_secure_override = True
  400. req.META['HTTP_HOST'] = 'www.example.com'
  401. req.META['HTTP_REFERER'] = 'https://foo.example.com:4443/'
  402. req.META['SERVER_PORT'] = '4443'
  403. mw = CsrfViewMiddleware(post_form_view)
  404. mw.process_request(req)
  405. response = mw.process_view(req, post_form_view, (), {})
  406. self.assertIsNone(response)
  407. def test_ensures_csrf_cookie_no_logging(self):
  408. """
  409. ensure_csrf_cookie() doesn't log warnings (#19436).
  410. """
  411. with self.assertRaisesMessage(AssertionError, 'no logs'):
  412. with self.assertLogs('django.request', 'WARNING'):
  413. req = self._get_GET_no_csrf_cookie_request()
  414. ensure_csrf_cookie_view(req)
  415. def test_post_data_read_failure(self):
  416. """
  417. OSErrors during POST data reading are caught and treated as if the
  418. POST data wasn't there (#20128).
  419. """
  420. class CsrfPostRequest(HttpRequest):
  421. """
  422. HttpRequest that can raise an OSError when accessing POST data
  423. """
  424. def __init__(self, token, raise_error):
  425. super().__init__()
  426. self.method = 'POST'
  427. self.raise_error = False
  428. self.COOKIES[settings.CSRF_COOKIE_NAME] = token
  429. # Handle both cases here to prevent duplicate code in the
  430. # session tests.
  431. self.session = {}
  432. self.session[CSRF_SESSION_KEY] = token
  433. self.POST['csrfmiddlewaretoken'] = token
  434. self.raise_error = raise_error
  435. def _load_post_and_files(self):
  436. raise OSError('error reading input data')
  437. def _get_post(self):
  438. if self.raise_error:
  439. self._load_post_and_files()
  440. return self._post
  441. def _set_post(self, post):
  442. self._post = post
  443. POST = property(_get_post, _set_post)
  444. token = ('ABC' + self._csrf_id)[:CSRF_TOKEN_LENGTH]
  445. req = CsrfPostRequest(token, raise_error=False)
  446. mw = CsrfViewMiddleware(post_form_view)
  447. mw.process_request(req)
  448. resp = mw.process_view(req, post_form_view, (), {})
  449. self.assertIsNone(resp)
  450. req = CsrfPostRequest(token, raise_error=True)
  451. mw.process_request(req)
  452. with self.assertLogs('django.security.csrf', 'WARNING') as cm:
  453. resp = mw.process_view(req, post_form_view, (), {})
  454. self.assertEqual(resp.status_code, 403)
  455. self.assertEqual(cm.records[0].getMessage(), 'Forbidden (%s): ' % REASON_BAD_TOKEN)
  456. class CsrfViewMiddlewareTests(CsrfViewMiddlewareTestMixin, SimpleTestCase):
  457. def _get_GET_csrf_cookie_request(self):
  458. req = TestingHttpRequest()
  459. req.COOKIES[settings.CSRF_COOKIE_NAME] = self._csrf_id_cookie
  460. return req
  461. def _get_POST_bare_secret_csrf_cookie_request(self):
  462. req = self._get_POST_no_csrf_cookie_request()
  463. req.COOKIES[settings.CSRF_COOKIE_NAME] = self._csrf_id_cookie[:32]
  464. return req
  465. def _get_POST_bare_secret_csrf_cookie_request_with_token(self):
  466. req = self._get_POST_bare_secret_csrf_cookie_request()
  467. req.POST['csrfmiddlewaretoken'] = self._csrf_id_cookie[:32]
  468. return req
  469. def test_ensures_csrf_cookie_no_middleware(self):
  470. """
  471. The ensure_csrf_cookie() decorator works without middleware.
  472. """
  473. req = self._get_GET_no_csrf_cookie_request()
  474. resp = ensure_csrf_cookie_view(req)
  475. self.assertTrue(resp.cookies.get(settings.CSRF_COOKIE_NAME, False))
  476. self.assertIn('Cookie', resp.get('Vary', ''))
  477. def test_ensures_csrf_cookie_with_middleware(self):
  478. """
  479. The ensure_csrf_cookie() decorator works with the CsrfViewMiddleware
  480. enabled.
  481. """
  482. req = self._get_GET_no_csrf_cookie_request()
  483. mw = CsrfViewMiddleware(ensure_csrf_cookie_view)
  484. mw.process_view(req, ensure_csrf_cookie_view, (), {})
  485. resp = mw(req)
  486. self.assertTrue(resp.cookies.get(settings.CSRF_COOKIE_NAME, False))
  487. self.assertIn('Cookie', resp.get('Vary', ''))
  488. def test_csrf_cookie_age(self):
  489. """
  490. CSRF cookie age can be set using settings.CSRF_COOKIE_AGE.
  491. """
  492. req = self._get_GET_no_csrf_cookie_request()
  493. MAX_AGE = 123
  494. with self.settings(CSRF_COOKIE_NAME='csrfcookie',
  495. CSRF_COOKIE_DOMAIN='.example.com',
  496. CSRF_COOKIE_AGE=MAX_AGE,
  497. CSRF_COOKIE_PATH='/test/',
  498. CSRF_COOKIE_SECURE=True,
  499. CSRF_COOKIE_HTTPONLY=True):
  500. # token_view calls get_token() indirectly
  501. mw = CsrfViewMiddleware(token_view)
  502. mw.process_view(req, token_view, (), {})
  503. resp = mw(req)
  504. max_age = resp.cookies.get('csrfcookie').get('max-age')
  505. self.assertEqual(max_age, MAX_AGE)
  506. def test_csrf_cookie_age_none(self):
  507. """
  508. CSRF cookie age does not have max age set and therefore uses
  509. session-based cookies.
  510. """
  511. req = self._get_GET_no_csrf_cookie_request()
  512. MAX_AGE = None
  513. with self.settings(CSRF_COOKIE_NAME='csrfcookie',
  514. CSRF_COOKIE_DOMAIN='.example.com',
  515. CSRF_COOKIE_AGE=MAX_AGE,
  516. CSRF_COOKIE_PATH='/test/',
  517. CSRF_COOKIE_SECURE=True,
  518. CSRF_COOKIE_HTTPONLY=True):
  519. # token_view calls get_token() indirectly
  520. mw = CsrfViewMiddleware(token_view)
  521. mw.process_view(req, token_view, (), {})
  522. resp = mw(req)
  523. max_age = resp.cookies.get('csrfcookie').get('max-age')
  524. self.assertEqual(max_age, '')
  525. def test_csrf_cookie_samesite(self):
  526. req = self._get_GET_no_csrf_cookie_request()
  527. with self.settings(CSRF_COOKIE_NAME='csrfcookie', CSRF_COOKIE_SAMESITE='Strict'):
  528. mw = CsrfViewMiddleware(token_view)
  529. mw.process_view(req, token_view, (), {})
  530. resp = mw(req)
  531. self.assertEqual(resp.cookies['csrfcookie']['samesite'], 'Strict')
  532. def test_process_view_token_too_long(self):
  533. """
  534. If the token is longer than expected, it is ignored and a new token is
  535. created.
  536. """
  537. req = self._get_GET_no_csrf_cookie_request()
  538. req.COOKIES[settings.CSRF_COOKIE_NAME] = 'x' * 100000
  539. mw = CsrfViewMiddleware(token_view)
  540. mw.process_view(req, token_view, (), {})
  541. resp = mw(req)
  542. csrf_cookie = resp.cookies.get(settings.CSRF_COOKIE_NAME, False)
  543. self.assertEqual(len(csrf_cookie.value), CSRF_TOKEN_LENGTH)
  544. def test_process_view_token_invalid_chars(self):
  545. """
  546. If the token contains non-alphanumeric characters, it is ignored and a
  547. new token is created.
  548. """
  549. token = ('!@#' + self._csrf_id)[:CSRF_TOKEN_LENGTH]
  550. req = self._get_GET_no_csrf_cookie_request()
  551. req.COOKIES[settings.CSRF_COOKIE_NAME] = token
  552. mw = CsrfViewMiddleware(token_view)
  553. mw.process_view(req, token_view, (), {})
  554. resp = mw(req)
  555. csrf_cookie = resp.cookies.get(settings.CSRF_COOKIE_NAME, False)
  556. self.assertEqual(len(csrf_cookie.value), CSRF_TOKEN_LENGTH)
  557. self.assertNotEqual(csrf_cookie.value, token)
  558. def test_bare_secret_accepted_and_replaced(self):
  559. """
  560. The csrf token is reset from a bare secret.
  561. """
  562. req = self._get_POST_bare_secret_csrf_cookie_request_with_token()
  563. mw = CsrfViewMiddleware(token_view)
  564. mw.process_request(req)
  565. resp = mw.process_view(req, token_view, (), {})
  566. self.assertIsNone(resp)
  567. resp = mw(req)
  568. self.assertIn(settings.CSRF_COOKIE_NAME, resp.cookies, "Cookie was not reset from bare secret")
  569. csrf_cookie = resp.cookies[settings.CSRF_COOKIE_NAME]
  570. self.assertEqual(len(csrf_cookie.value), CSRF_TOKEN_LENGTH)
  571. self._check_token_present(resp, csrf_id=csrf_cookie.value)
  572. @override_settings(ALLOWED_HOSTS=['www.example.com'], CSRF_COOKIE_DOMAIN='.example.com', USE_X_FORWARDED_PORT=True)
  573. def test_https_good_referer_behind_proxy(self):
  574. """
  575. A POST HTTPS request is accepted when USE_X_FORWARDED_PORT=True.
  576. """
  577. self._test_https_good_referer_behind_proxy()
  578. @override_settings(ALLOWED_HOSTS=['www.example.com'], CSRF_COOKIE_DOMAIN='.example.com')
  579. def test_https_good_referer_matches_cookie_domain(self):
  580. """
  581. A POST HTTPS request with a good referer should be accepted from a
  582. subdomain that's allowed by CSRF_COOKIE_DOMAIN.
  583. """
  584. self._test_https_good_referer_matches_cookie_domain()
  585. @override_settings(ALLOWED_HOSTS=['www.example.com'], CSRF_COOKIE_DOMAIN='.example.com')
  586. def test_https_good_referer_matches_cookie_domain_with_different_port(self):
  587. """
  588. A POST HTTPS request with a good referer should be accepted from a
  589. subdomain that's allowed by CSRF_COOKIE_DOMAIN and a non-443 port.
  590. """
  591. self._test_https_good_referer_matches_cookie_domain_with_different_port()
  592. @override_settings(CSRF_COOKIE_DOMAIN='.example.com', DEBUG=True)
  593. def test_https_reject_insecure_referer(self):
  594. """
  595. A POST HTTPS request from an insecure referer should be rejected.
  596. """
  597. req = self._get_POST_request_with_token()
  598. req._is_secure_override = True
  599. req.META['HTTP_REFERER'] = 'http://example.com/'
  600. req.META['SERVER_PORT'] = '443'
  601. mw = CsrfViewMiddleware(post_form_view)
  602. response = mw.process_view(req, post_form_view, (), {})
  603. self.assertContains(
  604. response,
  605. 'Referer checking failed - Referer is insecure while host is secure.',
  606. status_code=403,
  607. )
  608. @override_settings(CSRF_USE_SESSIONS=True, CSRF_COOKIE_DOMAIN=None)
  609. class CsrfViewMiddlewareUseSessionsTests(CsrfViewMiddlewareTestMixin, SimpleTestCase):
  610. """
  611. CSRF tests with CSRF_USE_SESSIONS=True.
  612. """
  613. def _get_POST_bare_secret_csrf_cookie_request(self):
  614. req = self._get_POST_no_csrf_cookie_request()
  615. req.session[CSRF_SESSION_KEY] = self._csrf_id_cookie[:32]
  616. return req
  617. def _get_GET_csrf_cookie_request(self):
  618. req = TestingHttpRequest()
  619. req.session[CSRF_SESSION_KEY] = self._csrf_id_cookie
  620. return req
  621. def test_no_session_on_request(self):
  622. msg = (
  623. 'CSRF_USE_SESSIONS is enabled, but request.session is not set. '
  624. 'SessionMiddleware must appear before CsrfViewMiddleware in MIDDLEWARE.'
  625. )
  626. with self.assertRaisesMessage(ImproperlyConfigured, msg):
  627. mw = CsrfViewMiddleware(lambda req: HttpResponse())
  628. mw.process_request(HttpRequest())
  629. def test_process_response_get_token_used(self):
  630. """The ensure_csrf_cookie() decorator works without middleware."""
  631. req = self._get_GET_no_csrf_cookie_request()
  632. ensure_csrf_cookie_view(req)
  633. self.assertTrue(req.session.get(CSRF_SESSION_KEY, False))
  634. def test_session_modify(self):
  635. """The session isn't saved if the CSRF cookie is unchanged."""
  636. req = self._get_GET_no_csrf_cookie_request()
  637. mw = CsrfViewMiddleware(ensure_csrf_cookie_view)
  638. mw.process_view(req, ensure_csrf_cookie_view, (), {})
  639. mw(req)
  640. self.assertIsNotNone(req.session.get(CSRF_SESSION_KEY))
  641. req.session.modified = False
  642. mw.process_view(req, ensure_csrf_cookie_view, (), {})
  643. mw(req)
  644. self.assertFalse(req.session.modified)
  645. def test_ensures_csrf_cookie_with_middleware(self):
  646. """
  647. The ensure_csrf_cookie() decorator works with the CsrfViewMiddleware
  648. enabled.
  649. """
  650. req = self._get_GET_no_csrf_cookie_request()
  651. mw = CsrfViewMiddleware(ensure_csrf_cookie_view)
  652. mw.process_view(req, ensure_csrf_cookie_view, (), {})
  653. mw(req)
  654. self.assertTrue(req.session.get(CSRF_SESSION_KEY, False))
  655. def test_token_node_with_new_csrf_cookie(self):
  656. """
  657. CsrfTokenNode works when a CSRF cookie is created by the middleware
  658. (when one was not already present).
  659. """
  660. req = self._get_GET_no_csrf_cookie_request()
  661. mw = CsrfViewMiddleware(token_view)
  662. mw.process_view(req, token_view, (), {})
  663. resp = mw(req)
  664. csrf_cookie = req.session[CSRF_SESSION_KEY]
  665. self._check_token_present(resp, csrf_id=csrf_cookie)
  666. @override_settings(
  667. ALLOWED_HOSTS=['www.example.com'],
  668. SESSION_COOKIE_DOMAIN='.example.com',
  669. USE_X_FORWARDED_PORT=True,
  670. DEBUG=True,
  671. )
  672. def test_https_good_referer_behind_proxy(self):
  673. """
  674. A POST HTTPS request is accepted when USE_X_FORWARDED_PORT=True.
  675. """
  676. self._test_https_good_referer_behind_proxy()
  677. @override_settings(ALLOWED_HOSTS=['www.example.com'], SESSION_COOKIE_DOMAIN='.example.com')
  678. def test_https_good_referer_matches_cookie_domain(self):
  679. """
  680. A POST HTTPS request with a good referer should be accepted from a
  681. subdomain that's allowed by SESSION_COOKIE_DOMAIN.
  682. """
  683. self._test_https_good_referer_matches_cookie_domain()
  684. @override_settings(ALLOWED_HOSTS=['www.example.com'], SESSION_COOKIE_DOMAIN='.example.com')
  685. def test_https_good_referer_matches_cookie_domain_with_different_port(self):
  686. """
  687. A POST HTTPS request with a good referer should be accepted from a
  688. subdomain that's allowed by SESSION_COOKIE_DOMAIN and a non-443 port.
  689. """
  690. self._test_https_good_referer_matches_cookie_domain_with_different_port()
  691. @override_settings(SESSION_COOKIE_DOMAIN='.example.com', DEBUG=True)
  692. def test_https_reject_insecure_referer(self):
  693. """
  694. A POST HTTPS request from an insecure referer should be rejected.
  695. """
  696. req = self._get_POST_request_with_token()
  697. req._is_secure_override = True
  698. req.META['HTTP_REFERER'] = 'http://example.com/'
  699. req.META['SERVER_PORT'] = '443'
  700. mw = CsrfViewMiddleware(post_form_view)
  701. response = mw.process_view(req, post_form_view, (), {})
  702. self.assertContains(
  703. response,
  704. 'Referer checking failed - Referer is insecure while host is secure.',
  705. status_code=403,
  706. )
  707. @override_settings(ROOT_URLCONF='csrf_tests.csrf_token_error_handler_urls', DEBUG=False)
  708. class CsrfInErrorHandlingViewsTests(SimpleTestCase):
  709. def test_csrf_token_on_404_stays_constant(self):
  710. response = self.client.get('/does not exist/')
  711. # The error handler returns status code 599.
  712. self.assertEqual(response.status_code, 599)
  713. token1 = response.content
  714. response = self.client.get('/does not exist/')
  715. self.assertEqual(response.status_code, 599)
  716. token2 = response.content
  717. self.assertTrue(equivalent_tokens(token1.decode('ascii'), token2.decode('ascii')))