test_integerfield.py 13 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335
  1. from unittest import SkipTest
  2. from django.core import validators
  3. from django.core.exceptions import ValidationError
  4. from django.db import IntegrityError, connection, models
  5. from django.test import SimpleTestCase, TestCase
  6. from .models import (
  7. BigIntegerModel,
  8. IntegerModel,
  9. PositiveBigIntegerModel,
  10. PositiveIntegerModel,
  11. PositiveSmallIntegerModel,
  12. SmallIntegerModel,
  13. )
  14. class IntegerFieldTests(TestCase):
  15. model = IntegerModel
  16. documented_range = (-2147483648, 2147483647)
  17. rel_db_type_class = models.IntegerField
  18. @property
  19. def backend_range(self):
  20. field = self.model._meta.get_field("value")
  21. internal_type = field.get_internal_type()
  22. return connection.ops.integer_field_range(internal_type)
  23. def test_documented_range(self):
  24. """
  25. Values within the documented safe range pass validation, and can be
  26. saved and retrieved without corruption.
  27. """
  28. min_value, max_value = self.documented_range
  29. instance = self.model(value=min_value)
  30. instance.full_clean()
  31. instance.save()
  32. qs = self.model.objects.filter(value__lte=min_value)
  33. self.assertEqual(qs.count(), 1)
  34. self.assertEqual(qs[0].value, min_value)
  35. instance = self.model(value=max_value)
  36. instance.full_clean()
  37. instance.save()
  38. qs = self.model.objects.filter(value__gte=max_value)
  39. self.assertEqual(qs.count(), 1)
  40. self.assertEqual(qs[0].value, max_value)
  41. def test_backend_range_save(self):
  42. """
  43. Backend specific ranges can be saved without corruption.
  44. """
  45. min_value, max_value = self.backend_range
  46. if min_value is not None:
  47. instance = self.model(value=min_value)
  48. instance.full_clean()
  49. instance.save()
  50. qs = self.model.objects.filter(value__lte=min_value)
  51. self.assertEqual(qs.count(), 1)
  52. self.assertEqual(qs[0].value, min_value)
  53. if max_value is not None:
  54. instance = self.model(value=max_value)
  55. instance.full_clean()
  56. instance.save()
  57. qs = self.model.objects.filter(value__gte=max_value)
  58. self.assertEqual(qs.count(), 1)
  59. self.assertEqual(qs[0].value, max_value)
  60. def test_backend_range_validation(self):
  61. """
  62. Backend specific ranges are enforced at the model validation level
  63. (#12030).
  64. """
  65. min_value, max_value = self.backend_range
  66. if min_value is not None:
  67. instance = self.model(value=min_value - 1)
  68. expected_message = validators.MinValueValidator.message % {
  69. "limit_value": min_value,
  70. }
  71. with self.assertRaisesMessage(ValidationError, expected_message):
  72. instance.full_clean()
  73. instance.value = min_value
  74. instance.full_clean()
  75. if max_value is not None:
  76. instance = self.model(value=max_value + 1)
  77. expected_message = validators.MaxValueValidator.message % {
  78. "limit_value": max_value,
  79. }
  80. with self.assertRaisesMessage(ValidationError, expected_message):
  81. instance.full_clean()
  82. instance.value = max_value
  83. instance.full_clean()
  84. def test_backend_range_min_value_lookups(self):
  85. min_value = self.backend_range[0]
  86. if min_value is None:
  87. raise SkipTest("Backend doesn't define an integer min value.")
  88. underflow_value = min_value - 1
  89. self.model.objects.create(value=min_value)
  90. # A refresh of obj is necessary because last_insert_id() is bugged
  91. # on MySQL and returns invalid values.
  92. obj = self.model.objects.get(value=min_value)
  93. with self.assertNumQueries(0), self.assertRaises(self.model.DoesNotExist):
  94. self.model.objects.get(value=underflow_value)
  95. with self.assertNumQueries(1):
  96. self.assertEqual(self.model.objects.get(value__gt=underflow_value), obj)
  97. with self.assertNumQueries(1):
  98. self.assertEqual(self.model.objects.get(value__gte=underflow_value), obj)
  99. with self.assertNumQueries(0), self.assertRaises(self.model.DoesNotExist):
  100. self.model.objects.get(value__lt=underflow_value)
  101. with self.assertNumQueries(0), self.assertRaises(self.model.DoesNotExist):
  102. self.model.objects.get(value__lte=underflow_value)
  103. def test_backend_range_max_value_lookups(self):
  104. max_value = self.backend_range[-1]
  105. if max_value is None:
  106. raise SkipTest("Backend doesn't define an integer max value.")
  107. overflow_value = max_value + 1
  108. obj = self.model.objects.create(value=max_value)
  109. with self.assertNumQueries(0), self.assertRaises(self.model.DoesNotExist):
  110. self.model.objects.get(value=overflow_value)
  111. with self.assertNumQueries(0), self.assertRaises(self.model.DoesNotExist):
  112. self.model.objects.get(value__gt=overflow_value)
  113. with self.assertNumQueries(0), self.assertRaises(self.model.DoesNotExist):
  114. self.model.objects.get(value__gte=overflow_value)
  115. with self.assertNumQueries(1):
  116. self.assertEqual(self.model.objects.get(value__lt=overflow_value), obj)
  117. with self.assertNumQueries(1):
  118. self.assertEqual(self.model.objects.get(value__lte=overflow_value), obj)
  119. def test_redundant_backend_range_validators(self):
  120. """
  121. If there are stricter validators than the ones from the database
  122. backend then the backend validators aren't added.
  123. """
  124. min_backend_value, max_backend_value = self.backend_range
  125. for callable_limit in (True, False):
  126. with self.subTest(callable_limit=callable_limit):
  127. if min_backend_value is not None:
  128. min_custom_value = min_backend_value + 1
  129. limit_value = (
  130. (lambda: min_custom_value)
  131. if callable_limit
  132. else min_custom_value
  133. )
  134. ranged_value_field = self.model._meta.get_field("value").__class__(
  135. validators=[validators.MinValueValidator(limit_value)]
  136. )
  137. field_range_message = validators.MinValueValidator.message % {
  138. "limit_value": min_custom_value,
  139. }
  140. with self.assertRaisesMessage(
  141. ValidationError, "[%r]" % field_range_message
  142. ):
  143. ranged_value_field.run_validators(min_backend_value - 1)
  144. if max_backend_value is not None:
  145. max_custom_value = max_backend_value - 1
  146. limit_value = (
  147. (lambda: max_custom_value)
  148. if callable_limit
  149. else max_custom_value
  150. )
  151. ranged_value_field = self.model._meta.get_field("value").__class__(
  152. validators=[validators.MaxValueValidator(limit_value)]
  153. )
  154. field_range_message = validators.MaxValueValidator.message % {
  155. "limit_value": max_custom_value,
  156. }
  157. with self.assertRaisesMessage(
  158. ValidationError, "[%r]" % field_range_message
  159. ):
  160. ranged_value_field.run_validators(max_backend_value + 1)
  161. def test_types(self):
  162. instance = self.model(value=1)
  163. self.assertIsInstance(instance.value, int)
  164. instance.save()
  165. self.assertIsInstance(instance.value, int)
  166. instance = self.model.objects.get()
  167. self.assertIsInstance(instance.value, int)
  168. def test_coercing(self):
  169. self.model.objects.create(value="10")
  170. instance = self.model.objects.get(value="10")
  171. self.assertEqual(instance.value, 10)
  172. def test_invalid_value(self):
  173. tests = [
  174. (TypeError, ()),
  175. (TypeError, []),
  176. (TypeError, {}),
  177. (TypeError, set()),
  178. (TypeError, object()),
  179. (TypeError, complex()),
  180. (ValueError, "non-numeric string"),
  181. (ValueError, b"non-numeric byte-string"),
  182. ]
  183. for exception, value in tests:
  184. with self.subTest(value):
  185. msg = "Field 'value' expected a number but got %r." % (value,)
  186. with self.assertRaisesMessage(exception, msg):
  187. self.model.objects.create(value=value)
  188. def test_rel_db_type(self):
  189. field = self.model._meta.get_field("value")
  190. rel_db_type = field.rel_db_type(connection)
  191. self.assertEqual(rel_db_type, self.rel_db_type_class().db_type(connection))
  192. class SmallIntegerFieldTests(IntegerFieldTests):
  193. model = SmallIntegerModel
  194. documented_range = (-32768, 32767)
  195. rel_db_type_class = models.SmallIntegerField
  196. class BigIntegerFieldTests(IntegerFieldTests):
  197. model = BigIntegerModel
  198. documented_range = (-9223372036854775808, 9223372036854775807)
  199. rel_db_type_class = models.BigIntegerField
  200. class PositiveSmallIntegerFieldTests(IntegerFieldTests):
  201. model = PositiveSmallIntegerModel
  202. documented_range = (0, 32767)
  203. rel_db_type_class = (
  204. models.PositiveSmallIntegerField
  205. if connection.features.related_fields_match_type
  206. else models.SmallIntegerField
  207. )
  208. class PositiveIntegerFieldTests(IntegerFieldTests):
  209. model = PositiveIntegerModel
  210. documented_range = (0, 2147483647)
  211. rel_db_type_class = (
  212. models.PositiveIntegerField
  213. if connection.features.related_fields_match_type
  214. else models.IntegerField
  215. )
  216. def test_negative_values(self):
  217. p = PositiveIntegerModel.objects.create(value=0)
  218. p.value = models.F("value") - 1
  219. with self.assertRaises(IntegrityError):
  220. p.save()
  221. class PositiveBigIntegerFieldTests(IntegerFieldTests):
  222. model = PositiveBigIntegerModel
  223. documented_range = (0, 9223372036854775807)
  224. rel_db_type_class = (
  225. models.PositiveBigIntegerField
  226. if connection.features.related_fields_match_type
  227. else models.BigIntegerField
  228. )
  229. class ValidationTests(SimpleTestCase):
  230. class Choices(models.IntegerChoices):
  231. A = 1
  232. def test_integerfield_cleans_valid_string(self):
  233. f = models.IntegerField()
  234. self.assertEqual(f.clean("2", None), 2)
  235. def test_integerfield_raises_error_on_invalid_intput(self):
  236. f = models.IntegerField()
  237. with self.assertRaises(ValidationError):
  238. f.clean("a", None)
  239. def test_choices_validation_supports_named_groups(self):
  240. f = models.IntegerField(choices=(("group", ((10, "A"), (20, "B"))), (30, "C")))
  241. self.assertEqual(10, f.clean(10, None))
  242. def test_choices_validation_supports_named_groups_dicts(self):
  243. f = models.IntegerField(choices={"group": ((10, "A"), (20, "B")), 30: "C"})
  244. self.assertEqual(10, f.clean(10, None))
  245. def test_choices_validation_supports_named_groups_nested_dicts(self):
  246. f = models.IntegerField(choices={"group": {10: "A", 20: "B"}, 30: "C"})
  247. self.assertEqual(10, f.clean(10, None))
  248. def test_nullable_integerfield_raises_error_with_blank_false(self):
  249. f = models.IntegerField(null=True, blank=False)
  250. with self.assertRaises(ValidationError):
  251. f.clean(None, None)
  252. def test_nullable_integerfield_cleans_none_on_null_and_blank_true(self):
  253. f = models.IntegerField(null=True, blank=True)
  254. self.assertIsNone(f.clean(None, None))
  255. def test_integerfield_raises_error_on_empty_input(self):
  256. f = models.IntegerField(null=False)
  257. with self.assertRaises(ValidationError):
  258. f.clean(None, None)
  259. with self.assertRaises(ValidationError):
  260. f.clean("", None)
  261. def test_integerfield_validates_zero_against_choices(self):
  262. f = models.IntegerField(choices=((1, 1),))
  263. with self.assertRaises(ValidationError):
  264. f.clean("0", None)
  265. def test_enum_choices_cleans_valid_string(self):
  266. f = models.IntegerField(choices=self.Choices)
  267. self.assertEqual(f.clean("1", None), 1)
  268. def test_enum_choices_invalid_input(self):
  269. f = models.IntegerField(choices=self.Choices)
  270. with self.assertRaises(ValidationError):
  271. f.clean("A", None)
  272. with self.assertRaises(ValidationError):
  273. f.clean("3", None)
  274. def test_callable_choices(self):
  275. def get_choices():
  276. return {i: str(i) for i in range(3)}
  277. f = models.IntegerField(choices=get_choices)
  278. for i in get_choices():
  279. with self.subTest(i=i):
  280. self.assertEqual(i, f.clean(i, None))
  281. with self.assertRaises(ValidationError):
  282. f.clean("A", None)
  283. with self.assertRaises(ValidationError):
  284. f.clean("3", None)