test_optimizer.py 48 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403
  1. from django.db import migrations, models
  2. from django.db.migrations import operations
  3. from django.db.migrations.optimizer import MigrationOptimizer
  4. from django.db.migrations.serializer import serializer_factory
  5. from django.db.models.functions import Abs
  6. from django.test import SimpleTestCase
  7. from .models import EmptyManager, UnicodeModel
  8. class OptimizerTests(SimpleTestCase):
  9. """
  10. Tests the migration autodetector.
  11. """
  12. def optimize(self, operations, app_label):
  13. """
  14. Handy shortcut for getting results + number of loops
  15. """
  16. optimizer = MigrationOptimizer()
  17. return optimizer.optimize(operations, app_label), optimizer._iterations
  18. def serialize(self, value):
  19. return serializer_factory(value).serialize()[0]
  20. def assertOptimizesTo(
  21. self, operations, expected, exact=None, less_than=None, app_label=None
  22. ):
  23. result, iterations = self.optimize(operations, app_label or "migrations")
  24. result = [self.serialize(f) for f in result]
  25. expected = [self.serialize(f) for f in expected]
  26. self.assertEqual(expected, result)
  27. if exact is not None and iterations != exact:
  28. raise self.failureException(
  29. "Optimization did not take exactly %s iterations (it took %s)"
  30. % (exact, iterations)
  31. )
  32. if less_than is not None and iterations >= less_than:
  33. raise self.failureException(
  34. "Optimization did not take less than %s iterations (it took %s)"
  35. % (less_than, iterations)
  36. )
  37. def assertDoesNotOptimize(self, operations, **kwargs):
  38. self.assertOptimizesTo(operations, operations, **kwargs)
  39. def test_none_app_label(self):
  40. optimizer = MigrationOptimizer()
  41. with self.assertRaisesMessage(TypeError, "app_label must be a str"):
  42. optimizer.optimize([], None)
  43. def test_single(self):
  44. """
  45. The optimizer does nothing on a single operation,
  46. and that it does it in just one pass.
  47. """
  48. self.assertOptimizesTo(
  49. [migrations.DeleteModel("Foo")],
  50. [migrations.DeleteModel("Foo")],
  51. exact=1,
  52. )
  53. def test_create_delete_model(self):
  54. """
  55. CreateModel and DeleteModel should collapse into nothing.
  56. """
  57. self.assertOptimizesTo(
  58. [
  59. migrations.CreateModel(
  60. "Foo", [("name", models.CharField(max_length=255))]
  61. ),
  62. migrations.DeleteModel("Foo"),
  63. ],
  64. [],
  65. )
  66. def test_create_rename_model(self):
  67. """
  68. CreateModel should absorb RenameModels.
  69. """
  70. managers = [("objects", EmptyManager())]
  71. self.assertOptimizesTo(
  72. [
  73. migrations.CreateModel(
  74. name="Foo",
  75. fields=[("name", models.CharField(max_length=255))],
  76. options={"verbose_name": "Foo"},
  77. bases=(UnicodeModel,),
  78. managers=managers,
  79. ),
  80. migrations.RenameModel("Foo", "Bar"),
  81. ],
  82. [
  83. migrations.CreateModel(
  84. "Bar",
  85. [("name", models.CharField(max_length=255))],
  86. options={"verbose_name": "Foo"},
  87. bases=(UnicodeModel,),
  88. managers=managers,
  89. )
  90. ],
  91. )
  92. def test_rename_model_self(self):
  93. """
  94. RenameModels should absorb themselves.
  95. """
  96. self.assertOptimizesTo(
  97. [
  98. migrations.RenameModel("Foo", "Baa"),
  99. migrations.RenameModel("Baa", "Bar"),
  100. ],
  101. [
  102. migrations.RenameModel("Foo", "Bar"),
  103. ],
  104. )
  105. def test_create_alter_model_options(self):
  106. self.assertOptimizesTo(
  107. [
  108. migrations.CreateModel("Foo", fields=[]),
  109. migrations.AlterModelOptions(
  110. name="Foo", options={"verbose_name_plural": "Foozes"}
  111. ),
  112. ],
  113. [
  114. migrations.CreateModel(
  115. "Foo", fields=[], options={"verbose_name_plural": "Foozes"}
  116. ),
  117. ],
  118. )
  119. def test_create_alter_model_managers(self):
  120. self.assertOptimizesTo(
  121. [
  122. migrations.CreateModel("Foo", fields=[]),
  123. migrations.AlterModelManagers(
  124. name="Foo",
  125. managers=[
  126. ("objects", models.Manager()),
  127. ("things", models.Manager()),
  128. ],
  129. ),
  130. ],
  131. [
  132. migrations.CreateModel(
  133. "Foo",
  134. fields=[],
  135. managers=[
  136. ("objects", models.Manager()),
  137. ("things", models.Manager()),
  138. ],
  139. ),
  140. ],
  141. )
  142. def test_create_model_and_remove_model_options(self):
  143. self.assertOptimizesTo(
  144. [
  145. migrations.CreateModel(
  146. "MyModel",
  147. fields=[],
  148. options={"verbose_name": "My Model"},
  149. ),
  150. migrations.AlterModelOptions("MyModel", options={}),
  151. ],
  152. [migrations.CreateModel("MyModel", fields=[])],
  153. )
  154. self.assertOptimizesTo(
  155. [
  156. migrations.CreateModel(
  157. "MyModel",
  158. fields=[],
  159. options={
  160. "verbose_name": "My Model",
  161. "verbose_name_plural": "My Model plural",
  162. },
  163. ),
  164. migrations.AlterModelOptions(
  165. "MyModel",
  166. options={"verbose_name": "My Model"},
  167. ),
  168. ],
  169. [
  170. migrations.CreateModel(
  171. "MyModel",
  172. fields=[],
  173. options={"verbose_name": "My Model"},
  174. ),
  175. ],
  176. )
  177. def _test_create_alter_foo_delete_model(self, alter_foo):
  178. """
  179. CreateModel, AlterModelTable, AlterUniqueTogether/AlterIndexTogether/
  180. AlterOrderWithRespectTo, and DeleteModel should collapse into nothing.
  181. """
  182. self.assertOptimizesTo(
  183. [
  184. migrations.CreateModel(
  185. "Foo", [("name", models.CharField(max_length=255))]
  186. ),
  187. migrations.AlterModelTable("Foo", "woohoo"),
  188. alter_foo,
  189. migrations.DeleteModel("Foo"),
  190. ],
  191. [],
  192. )
  193. def test_create_alter_unique_delete_model(self):
  194. self._test_create_alter_foo_delete_model(
  195. migrations.AlterUniqueTogether("Foo", [["a", "b"]])
  196. )
  197. def test_create_alter_index_delete_model(self):
  198. self._test_create_alter_foo_delete_model(
  199. migrations.AlterIndexTogether("Foo", [["a", "b"]])
  200. )
  201. def test_create_alter_owrt_delete_model(self):
  202. self._test_create_alter_foo_delete_model(
  203. migrations.AlterOrderWithRespectTo("Foo", "a")
  204. )
  205. def _test_alter_alter(self, alter_foo, alter_bar):
  206. """
  207. Two AlterUniqueTogether/AlterIndexTogether/AlterOrderWithRespectTo
  208. /AlterField should collapse into the second.
  209. """
  210. self.assertOptimizesTo(
  211. [
  212. alter_foo,
  213. alter_bar,
  214. ],
  215. [
  216. alter_bar,
  217. ],
  218. )
  219. def test_alter_alter_table_model(self):
  220. self._test_alter_alter(
  221. migrations.AlterModelTable("Foo", "a"),
  222. migrations.AlterModelTable("Foo", "b"),
  223. )
  224. def test_alter_alter_unique_model(self):
  225. self._test_alter_alter(
  226. migrations.AlterUniqueTogether("Foo", [["a", "b"]]),
  227. migrations.AlterUniqueTogether("Foo", [["a", "c"]]),
  228. )
  229. def test_alter_alter_index_model(self):
  230. self._test_alter_alter(
  231. migrations.AlterIndexTogether("Foo", [["a", "b"]]),
  232. migrations.AlterIndexTogether("Foo", [["a", "c"]]),
  233. )
  234. def test_alter_alter_owrt_model(self):
  235. self._test_alter_alter(
  236. migrations.AlterOrderWithRespectTo("Foo", "a"),
  237. migrations.AlterOrderWithRespectTo("Foo", "b"),
  238. )
  239. def test_alter_alter_field(self):
  240. self._test_alter_alter(
  241. migrations.AlterField("Foo", "name", models.IntegerField()),
  242. migrations.AlterField("Foo", "name", models.IntegerField(help_text="help")),
  243. )
  244. def test_optimize_through_create(self):
  245. """
  246. We should be able to optimize away create/delete through a create or
  247. delete of a different model, but only if the create operation does not
  248. mention the model at all.
  249. """
  250. # These should work
  251. self.assertOptimizesTo(
  252. [
  253. migrations.CreateModel(
  254. "Foo", [("name", models.CharField(max_length=255))]
  255. ),
  256. migrations.CreateModel("Bar", [("size", models.IntegerField())]),
  257. migrations.DeleteModel("Foo"),
  258. ],
  259. [
  260. migrations.CreateModel("Bar", [("size", models.IntegerField())]),
  261. ],
  262. )
  263. self.assertOptimizesTo(
  264. [
  265. migrations.CreateModel(
  266. "Foo", [("name", models.CharField(max_length=255))]
  267. ),
  268. migrations.CreateModel("Bar", [("size", models.IntegerField())]),
  269. migrations.DeleteModel("Bar"),
  270. migrations.DeleteModel("Foo"),
  271. ],
  272. [],
  273. )
  274. self.assertOptimizesTo(
  275. [
  276. migrations.CreateModel(
  277. "Foo", [("name", models.CharField(max_length=255))]
  278. ),
  279. migrations.CreateModel("Bar", [("size", models.IntegerField())]),
  280. migrations.DeleteModel("Foo"),
  281. migrations.DeleteModel("Bar"),
  282. ],
  283. [],
  284. )
  285. # Operations should be optimized if the FK references a model from the
  286. # other app.
  287. self.assertOptimizesTo(
  288. [
  289. migrations.CreateModel(
  290. "Foo", [("name", models.CharField(max_length=255))]
  291. ),
  292. migrations.CreateModel(
  293. "Bar", [("other", models.ForeignKey("testapp.Foo", models.CASCADE))]
  294. ),
  295. migrations.DeleteModel("Foo"),
  296. ],
  297. [
  298. migrations.CreateModel(
  299. "Bar", [("other", models.ForeignKey("testapp.Foo", models.CASCADE))]
  300. ),
  301. ],
  302. app_label="otherapp",
  303. )
  304. # But it shouldn't work if a FK references a model with the same
  305. # app_label.
  306. self.assertDoesNotOptimize(
  307. [
  308. migrations.CreateModel(
  309. "Foo", [("name", models.CharField(max_length=255))]
  310. ),
  311. migrations.CreateModel(
  312. "Bar", [("other", models.ForeignKey("Foo", models.CASCADE))]
  313. ),
  314. migrations.DeleteModel("Foo"),
  315. ],
  316. )
  317. self.assertDoesNotOptimize(
  318. [
  319. migrations.CreateModel(
  320. "Foo", [("name", models.CharField(max_length=255))]
  321. ),
  322. migrations.CreateModel(
  323. "Bar", [("other", models.ForeignKey("testapp.Foo", models.CASCADE))]
  324. ),
  325. migrations.DeleteModel("Foo"),
  326. ],
  327. app_label="testapp",
  328. )
  329. # This should not work - bases should block it
  330. self.assertDoesNotOptimize(
  331. [
  332. migrations.CreateModel(
  333. "Foo", [("name", models.CharField(max_length=255))]
  334. ),
  335. migrations.CreateModel(
  336. "Bar", [("size", models.IntegerField())], bases=("Foo",)
  337. ),
  338. migrations.DeleteModel("Foo"),
  339. ],
  340. )
  341. self.assertDoesNotOptimize(
  342. [
  343. migrations.CreateModel(
  344. "Foo", [("name", models.CharField(max_length=255))]
  345. ),
  346. migrations.CreateModel(
  347. "Bar", [("size", models.IntegerField())], bases=("testapp.Foo",)
  348. ),
  349. migrations.DeleteModel("Foo"),
  350. ],
  351. app_label="testapp",
  352. )
  353. # The same operations should be optimized if app_label and none of
  354. # bases belong to that app.
  355. self.assertOptimizesTo(
  356. [
  357. migrations.CreateModel(
  358. "Foo", [("name", models.CharField(max_length=255))]
  359. ),
  360. migrations.CreateModel(
  361. "Bar", [("size", models.IntegerField())], bases=("testapp.Foo",)
  362. ),
  363. migrations.DeleteModel("Foo"),
  364. ],
  365. [
  366. migrations.CreateModel(
  367. "Bar", [("size", models.IntegerField())], bases=("testapp.Foo",)
  368. ),
  369. ],
  370. app_label="otherapp",
  371. )
  372. # But it shouldn't work if some of bases belongs to the specified app.
  373. self.assertDoesNotOptimize(
  374. [
  375. migrations.CreateModel(
  376. "Foo", [("name", models.CharField(max_length=255))]
  377. ),
  378. migrations.CreateModel(
  379. "Bar", [("size", models.IntegerField())], bases=("testapp.Foo",)
  380. ),
  381. migrations.DeleteModel("Foo"),
  382. ],
  383. app_label="testapp",
  384. )
  385. self.assertOptimizesTo(
  386. [
  387. migrations.CreateModel(
  388. "Book", [("name", models.CharField(max_length=255))]
  389. ),
  390. migrations.CreateModel(
  391. "Person", [("name", models.CharField(max_length=255))]
  392. ),
  393. migrations.AddField(
  394. "book",
  395. "author",
  396. models.ForeignKey("test_app.Person", models.CASCADE),
  397. ),
  398. migrations.CreateModel(
  399. "Review",
  400. [("book", models.ForeignKey("test_app.Book", models.CASCADE))],
  401. ),
  402. migrations.CreateModel(
  403. "Reviewer", [("name", models.CharField(max_length=255))]
  404. ),
  405. migrations.AddField(
  406. "review",
  407. "reviewer",
  408. models.ForeignKey("test_app.Reviewer", models.CASCADE),
  409. ),
  410. migrations.RemoveField("book", "author"),
  411. migrations.DeleteModel("Person"),
  412. ],
  413. [
  414. migrations.CreateModel(
  415. "Book", [("name", models.CharField(max_length=255))]
  416. ),
  417. migrations.CreateModel(
  418. "Reviewer", [("name", models.CharField(max_length=255))]
  419. ),
  420. migrations.CreateModel(
  421. "Review",
  422. [
  423. ("book", models.ForeignKey("test_app.Book", models.CASCADE)),
  424. (
  425. "reviewer",
  426. models.ForeignKey("test_app.Reviewer", models.CASCADE),
  427. ),
  428. ],
  429. ),
  430. ],
  431. app_label="test_app",
  432. )
  433. def test_create_model_add_field(self):
  434. """
  435. AddField should optimize into CreateModel.
  436. """
  437. managers = [("objects", EmptyManager())]
  438. self.assertOptimizesTo(
  439. [
  440. migrations.CreateModel(
  441. name="Foo",
  442. fields=[("name", models.CharField(max_length=255))],
  443. options={"verbose_name": "Foo"},
  444. bases=(UnicodeModel,),
  445. managers=managers,
  446. ),
  447. migrations.AddField("Foo", "age", models.IntegerField()),
  448. ],
  449. [
  450. migrations.CreateModel(
  451. name="Foo",
  452. fields=[
  453. ("name", models.CharField(max_length=255)),
  454. ("age", models.IntegerField()),
  455. ],
  456. options={"verbose_name": "Foo"},
  457. bases=(UnicodeModel,),
  458. managers=managers,
  459. ),
  460. ],
  461. )
  462. def test_create_model_reordering(self):
  463. """
  464. AddField optimizes into CreateModel if it's a FK to a model that's
  465. between them (and there's no FK in the other direction), by changing
  466. the order of the CreateModel operations.
  467. """
  468. self.assertOptimizesTo(
  469. [
  470. migrations.CreateModel(
  471. "Foo", [("name", models.CharField(max_length=255))]
  472. ),
  473. migrations.CreateModel("Link", [("url", models.TextField())]),
  474. migrations.AddField(
  475. "Foo", "link", models.ForeignKey("migrations.Link", models.CASCADE)
  476. ),
  477. ],
  478. [
  479. migrations.CreateModel("Link", [("url", models.TextField())]),
  480. migrations.CreateModel(
  481. "Foo",
  482. [
  483. ("name", models.CharField(max_length=255)),
  484. ("link", models.ForeignKey("migrations.Link", models.CASCADE)),
  485. ],
  486. ),
  487. ],
  488. )
  489. def test_create_model_reordering_circular_fk(self):
  490. """
  491. CreateModel reordering behavior doesn't result in an infinite loop if
  492. there are FKs in both directions.
  493. """
  494. self.assertOptimizesTo(
  495. [
  496. migrations.CreateModel("Bar", [("url", models.TextField())]),
  497. migrations.CreateModel(
  498. "Foo", [("name", models.CharField(max_length=255))]
  499. ),
  500. migrations.AddField(
  501. "Bar", "foo_fk", models.ForeignKey("migrations.Foo", models.CASCADE)
  502. ),
  503. migrations.AddField(
  504. "Foo", "bar_fk", models.ForeignKey("migrations.Bar", models.CASCADE)
  505. ),
  506. ],
  507. [
  508. migrations.CreateModel(
  509. "Foo", [("name", models.CharField(max_length=255))]
  510. ),
  511. migrations.CreateModel(
  512. "Bar",
  513. [
  514. ("url", models.TextField()),
  515. ("foo_fk", models.ForeignKey("migrations.Foo", models.CASCADE)),
  516. ],
  517. ),
  518. migrations.AddField(
  519. "Foo", "bar_fk", models.ForeignKey("migrations.Bar", models.CASCADE)
  520. ),
  521. ],
  522. )
  523. def test_create_model_no_reordering_for_unrelated_fk(self):
  524. """
  525. CreateModel order remains unchanged if the later AddField operation
  526. isn't a FK between them.
  527. """
  528. self.assertDoesNotOptimize(
  529. [
  530. migrations.CreateModel(
  531. "Foo", [("name", models.CharField(max_length=255))]
  532. ),
  533. migrations.CreateModel("Link", [("url", models.TextField())]),
  534. migrations.AddField(
  535. "Other",
  536. "link",
  537. models.ForeignKey("migrations.Link", models.CASCADE),
  538. ),
  539. ],
  540. )
  541. def test_create_model_no_reordering_of_inherited_model(self):
  542. """
  543. A CreateModel that inherits from another isn't reordered to avoid
  544. moving it earlier than its parent CreateModel operation.
  545. """
  546. self.assertOptimizesTo(
  547. [
  548. migrations.CreateModel(
  549. "Other", [("foo", models.CharField(max_length=255))]
  550. ),
  551. migrations.CreateModel(
  552. "ParentModel", [("bar", models.CharField(max_length=255))]
  553. ),
  554. migrations.CreateModel(
  555. "ChildModel",
  556. [("baz", models.CharField(max_length=255))],
  557. bases=("migrations.parentmodel",),
  558. ),
  559. migrations.AddField(
  560. "Other",
  561. "fk",
  562. models.ForeignKey("migrations.ChildModel", models.CASCADE),
  563. ),
  564. ],
  565. [
  566. migrations.CreateModel(
  567. "ParentModel", [("bar", models.CharField(max_length=255))]
  568. ),
  569. migrations.CreateModel(
  570. "ChildModel",
  571. [("baz", models.CharField(max_length=255))],
  572. bases=("migrations.parentmodel",),
  573. ),
  574. migrations.CreateModel(
  575. "Other",
  576. [
  577. ("foo", models.CharField(max_length=255)),
  578. (
  579. "fk",
  580. models.ForeignKey("migrations.ChildModel", models.CASCADE),
  581. ),
  582. ],
  583. ),
  584. ],
  585. )
  586. def test_create_model_add_field_not_through_m2m_through(self):
  587. """
  588. AddField should NOT optimize into CreateModel if it's an M2M using a
  589. through that's created between them.
  590. """
  591. self.assertDoesNotOptimize(
  592. [
  593. migrations.CreateModel("Employee", []),
  594. migrations.CreateModel("Employer", []),
  595. migrations.CreateModel(
  596. "Employment",
  597. [
  598. (
  599. "employee",
  600. models.ForeignKey("migrations.Employee", models.CASCADE),
  601. ),
  602. (
  603. "employment",
  604. models.ForeignKey("migrations.Employer", models.CASCADE),
  605. ),
  606. ],
  607. ),
  608. migrations.AddField(
  609. "Employer",
  610. "employees",
  611. models.ManyToManyField(
  612. "migrations.Employee",
  613. through="migrations.Employment",
  614. ),
  615. ),
  616. ],
  617. )
  618. def test_create_model_alter_field(self):
  619. """
  620. AlterField should optimize into CreateModel.
  621. """
  622. managers = [("objects", EmptyManager())]
  623. self.assertOptimizesTo(
  624. [
  625. migrations.CreateModel(
  626. name="Foo",
  627. fields=[("name", models.CharField(max_length=255))],
  628. options={"verbose_name": "Foo"},
  629. bases=(UnicodeModel,),
  630. managers=managers,
  631. ),
  632. migrations.AlterField("Foo", "name", models.IntegerField()),
  633. ],
  634. [
  635. migrations.CreateModel(
  636. name="Foo",
  637. fields=[
  638. ("name", models.IntegerField()),
  639. ],
  640. options={"verbose_name": "Foo"},
  641. bases=(UnicodeModel,),
  642. managers=managers,
  643. ),
  644. ],
  645. )
  646. def test_create_model_rename_field(self):
  647. """
  648. RenameField should optimize into CreateModel.
  649. """
  650. managers = [("objects", EmptyManager())]
  651. self.assertOptimizesTo(
  652. [
  653. migrations.CreateModel(
  654. name="Foo",
  655. fields=[("name", models.CharField(max_length=255))],
  656. options={"verbose_name": "Foo"},
  657. bases=(UnicodeModel,),
  658. managers=managers,
  659. ),
  660. migrations.RenameField("Foo", "name", "title"),
  661. ],
  662. [
  663. migrations.CreateModel(
  664. name="Foo",
  665. fields=[
  666. ("title", models.CharField(max_length=255)),
  667. ],
  668. options={"verbose_name": "Foo"},
  669. bases=(UnicodeModel,),
  670. managers=managers,
  671. ),
  672. ],
  673. )
  674. def test_add_field_rename_field(self):
  675. """
  676. RenameField should optimize into AddField
  677. """
  678. self.assertOptimizesTo(
  679. [
  680. migrations.AddField("Foo", "name", models.CharField(max_length=255)),
  681. migrations.RenameField("Foo", "name", "title"),
  682. ],
  683. [
  684. migrations.AddField("Foo", "title", models.CharField(max_length=255)),
  685. ],
  686. )
  687. def test_alter_field_rename_field(self):
  688. """
  689. RenameField should optimize to the other side of AlterField,
  690. and into itself.
  691. """
  692. self.assertOptimizesTo(
  693. [
  694. migrations.AlterField("Foo", "name", models.CharField(max_length=255)),
  695. migrations.RenameField("Foo", "name", "title"),
  696. migrations.RenameField("Foo", "title", "nom"),
  697. ],
  698. [
  699. migrations.RenameField("Foo", "name", "nom"),
  700. migrations.AlterField("Foo", "nom", models.CharField(max_length=255)),
  701. ],
  702. )
  703. def test_swapping_fields_names(self):
  704. self.assertDoesNotOptimize(
  705. [
  706. migrations.CreateModel(
  707. "MyModel",
  708. [
  709. ("field_a", models.IntegerField()),
  710. ("field_b", models.IntegerField()),
  711. ],
  712. ),
  713. migrations.RunPython(migrations.RunPython.noop),
  714. migrations.RenameField("MyModel", "field_a", "field_c"),
  715. migrations.RenameField("MyModel", "field_b", "field_a"),
  716. migrations.RenameField("MyModel", "field_c", "field_b"),
  717. ],
  718. )
  719. def test_create_model_remove_field(self):
  720. """
  721. RemoveField should optimize into CreateModel.
  722. """
  723. managers = [("objects", EmptyManager())]
  724. self.assertOptimizesTo(
  725. [
  726. migrations.CreateModel(
  727. name="Foo",
  728. fields=[
  729. ("name", models.CharField(max_length=255)),
  730. ("age", models.IntegerField()),
  731. ],
  732. options={"verbose_name": "Foo"},
  733. bases=(UnicodeModel,),
  734. managers=managers,
  735. ),
  736. migrations.RemoveField("Foo", "age"),
  737. ],
  738. [
  739. migrations.CreateModel(
  740. name="Foo",
  741. fields=[
  742. ("name", models.CharField(max_length=255)),
  743. ],
  744. options={"verbose_name": "Foo"},
  745. bases=(UnicodeModel,),
  746. managers=managers,
  747. ),
  748. ],
  749. )
  750. def test_add_field_alter_field(self):
  751. """
  752. AlterField should optimize into AddField.
  753. """
  754. self.assertOptimizesTo(
  755. [
  756. migrations.AddField("Foo", "age", models.IntegerField()),
  757. migrations.AlterField("Foo", "age", models.FloatField(default=2.4)),
  758. ],
  759. [
  760. migrations.AddField(
  761. "Foo", name="age", field=models.FloatField(default=2.4)
  762. ),
  763. ],
  764. )
  765. def test_add_field_delete_field(self):
  766. """
  767. RemoveField should cancel AddField
  768. """
  769. self.assertOptimizesTo(
  770. [
  771. migrations.AddField("Foo", "age", models.IntegerField()),
  772. migrations.RemoveField("Foo", "age"),
  773. ],
  774. [],
  775. )
  776. def test_alter_field_delete_field(self):
  777. """
  778. RemoveField should absorb AlterField
  779. """
  780. self.assertOptimizesTo(
  781. [
  782. migrations.AlterField("Foo", "age", models.IntegerField()),
  783. migrations.RemoveField("Foo", "age"),
  784. ],
  785. [
  786. migrations.RemoveField("Foo", "age"),
  787. ],
  788. )
  789. def _test_create_alter_foo_field(self, alter):
  790. """
  791. CreateModel, AlterFooTogether/AlterOrderWithRespectTo followed by an
  792. add/alter/rename field should optimize to CreateModel with options.
  793. """
  794. option_value = getattr(alter, alter.option_name)
  795. options = {alter.option_name: option_value}
  796. # AddField
  797. self.assertOptimizesTo(
  798. [
  799. migrations.CreateModel(
  800. "Foo",
  801. [
  802. ("a", models.IntegerField()),
  803. ("b", models.IntegerField()),
  804. ],
  805. ),
  806. alter,
  807. migrations.AddField("Foo", "c", models.IntegerField()),
  808. ],
  809. [
  810. migrations.CreateModel(
  811. "Foo",
  812. [
  813. ("a", models.IntegerField()),
  814. ("b", models.IntegerField()),
  815. ("c", models.IntegerField()),
  816. ],
  817. options=options,
  818. ),
  819. ],
  820. )
  821. # AlterField
  822. self.assertOptimizesTo(
  823. [
  824. migrations.CreateModel(
  825. "Foo",
  826. [
  827. ("a", models.IntegerField()),
  828. ("b", models.IntegerField()),
  829. ],
  830. ),
  831. alter,
  832. migrations.AlterField("Foo", "b", models.CharField(max_length=255)),
  833. ],
  834. [
  835. migrations.CreateModel(
  836. "Foo",
  837. [
  838. ("a", models.IntegerField()),
  839. ("b", models.CharField(max_length=255)),
  840. ],
  841. options=options,
  842. ),
  843. ],
  844. )
  845. self.assertOptimizesTo(
  846. [
  847. migrations.CreateModel(
  848. "Foo",
  849. [
  850. ("a", models.IntegerField()),
  851. ("b", models.IntegerField()),
  852. ("c", models.IntegerField()),
  853. ],
  854. ),
  855. alter,
  856. migrations.AlterField("Foo", "c", models.CharField(max_length=255)),
  857. ],
  858. [
  859. migrations.CreateModel(
  860. "Foo",
  861. [
  862. ("a", models.IntegerField()),
  863. ("b", models.IntegerField()),
  864. ("c", models.CharField(max_length=255)),
  865. ],
  866. options=options,
  867. ),
  868. ],
  869. )
  870. # RenameField
  871. if isinstance(option_value, str):
  872. renamed_options = {alter.option_name: "c"}
  873. else:
  874. renamed_options = {
  875. alter.option_name: {
  876. tuple("c" if value == "b" else value for value in item)
  877. for item in option_value
  878. }
  879. }
  880. self.assertOptimizesTo(
  881. [
  882. migrations.CreateModel(
  883. "Foo",
  884. [
  885. ("a", models.IntegerField()),
  886. ("b", models.IntegerField()),
  887. ],
  888. ),
  889. alter,
  890. migrations.RenameField("Foo", "b", "c"),
  891. ],
  892. [
  893. migrations.CreateModel(
  894. "Foo",
  895. [
  896. ("a", models.IntegerField()),
  897. ("c", models.IntegerField()),
  898. ],
  899. options=renamed_options,
  900. ),
  901. ],
  902. )
  903. self.assertOptimizesTo(
  904. [
  905. migrations.CreateModel(
  906. "Foo",
  907. [
  908. ("a", models.IntegerField()),
  909. ("b", models.IntegerField()),
  910. ],
  911. ),
  912. alter,
  913. migrations.RenameField("Foo", "b", "x"),
  914. migrations.RenameField("Foo", "x", "c"),
  915. ],
  916. [
  917. migrations.CreateModel(
  918. "Foo",
  919. [
  920. ("a", models.IntegerField()),
  921. ("c", models.IntegerField()),
  922. ],
  923. options=renamed_options,
  924. ),
  925. ],
  926. )
  927. self.assertOptimizesTo(
  928. [
  929. migrations.CreateModel(
  930. "Foo",
  931. [
  932. ("a", models.IntegerField()),
  933. ("b", models.IntegerField()),
  934. ("c", models.IntegerField()),
  935. ],
  936. ),
  937. alter,
  938. migrations.RenameField("Foo", "c", "d"),
  939. ],
  940. [
  941. migrations.CreateModel(
  942. "Foo",
  943. [
  944. ("a", models.IntegerField()),
  945. ("b", models.IntegerField()),
  946. ("d", models.IntegerField()),
  947. ],
  948. options=options,
  949. ),
  950. ],
  951. )
  952. # RemoveField
  953. if isinstance(option_value, str):
  954. removed_options = None
  955. else:
  956. removed_options = {
  957. alter.option_name: {
  958. tuple(value for value in item if value != "b")
  959. for item in option_value
  960. }
  961. }
  962. self.assertOptimizesTo(
  963. [
  964. migrations.CreateModel(
  965. "Foo",
  966. [
  967. ("a", models.IntegerField()),
  968. ("b", models.IntegerField()),
  969. ],
  970. ),
  971. alter,
  972. migrations.RemoveField("Foo", "b"),
  973. ],
  974. [
  975. migrations.CreateModel(
  976. "Foo",
  977. [
  978. ("a", models.IntegerField()),
  979. ],
  980. options=removed_options,
  981. ),
  982. ],
  983. )
  984. self.assertOptimizesTo(
  985. [
  986. migrations.CreateModel(
  987. "Foo",
  988. [
  989. ("a", models.IntegerField()),
  990. ("b", models.IntegerField()),
  991. ("c", models.IntegerField()),
  992. ],
  993. ),
  994. alter,
  995. migrations.RemoveField("Foo", "c"),
  996. ],
  997. [
  998. migrations.CreateModel(
  999. "Foo",
  1000. [
  1001. ("a", models.IntegerField()),
  1002. ("b", models.IntegerField()),
  1003. ],
  1004. options=options,
  1005. ),
  1006. ],
  1007. )
  1008. def test_create_alter_unique_field(self):
  1009. self._test_create_alter_foo_field(
  1010. migrations.AlterUniqueTogether("Foo", [["a", "b"]])
  1011. )
  1012. def test_create_alter_index_field(self):
  1013. self._test_create_alter_foo_field(
  1014. migrations.AlterIndexTogether("Foo", [["a", "b"]])
  1015. )
  1016. def test_create_alter_owrt_field(self):
  1017. self._test_create_alter_foo_field(
  1018. migrations.AlterOrderWithRespectTo("Foo", "b")
  1019. )
  1020. def test_optimize_through_fields(self):
  1021. """
  1022. field-level through checking is working. This should manage to collapse
  1023. model Foo to nonexistence, and model Bar to a single IntegerField
  1024. called "width".
  1025. """
  1026. self.assertOptimizesTo(
  1027. [
  1028. migrations.CreateModel(
  1029. "Foo", [("name", models.CharField(max_length=255))]
  1030. ),
  1031. migrations.CreateModel("Bar", [("size", models.IntegerField())]),
  1032. migrations.AddField("Foo", "age", models.IntegerField()),
  1033. migrations.AddField("Bar", "width", models.IntegerField()),
  1034. migrations.AlterField("Foo", "age", models.IntegerField()),
  1035. migrations.RenameField("Bar", "size", "dimensions"),
  1036. migrations.RemoveField("Foo", "age"),
  1037. migrations.RenameModel("Foo", "Phou"),
  1038. migrations.RemoveField("Bar", "dimensions"),
  1039. migrations.RenameModel("Phou", "Fou"),
  1040. migrations.DeleteModel("Fou"),
  1041. ],
  1042. [
  1043. migrations.CreateModel("Bar", [("width", models.IntegerField())]),
  1044. ],
  1045. )
  1046. def test_optimize_elidable_operation(self):
  1047. elidable_operation = operations.base.Operation()
  1048. elidable_operation.elidable = True
  1049. self.assertOptimizesTo(
  1050. [
  1051. elidable_operation,
  1052. migrations.CreateModel(
  1053. "Foo", [("name", models.CharField(max_length=255))]
  1054. ),
  1055. elidable_operation,
  1056. migrations.CreateModel("Bar", [("size", models.IntegerField())]),
  1057. elidable_operation,
  1058. migrations.RenameModel("Foo", "Phou"),
  1059. migrations.DeleteModel("Bar"),
  1060. elidable_operation,
  1061. ],
  1062. [
  1063. migrations.CreateModel(
  1064. "Phou", [("name", models.CharField(max_length=255))]
  1065. ),
  1066. ],
  1067. )
  1068. def test_rename_index(self):
  1069. self.assertOptimizesTo(
  1070. [
  1071. migrations.RenameIndex(
  1072. "Pony", new_name="mid_name", old_fields=("weight", "pink")
  1073. ),
  1074. migrations.RenameIndex(
  1075. "Pony", new_name="new_name", old_name="mid_name"
  1076. ),
  1077. ],
  1078. [
  1079. migrations.RenameIndex(
  1080. "Pony", new_name="new_name", old_fields=("weight", "pink")
  1081. ),
  1082. ],
  1083. )
  1084. self.assertOptimizesTo(
  1085. [
  1086. migrations.RenameIndex(
  1087. "Pony", new_name="mid_name", old_name="old_name"
  1088. ),
  1089. migrations.RenameIndex(
  1090. "Pony", new_name="new_name", old_name="mid_name"
  1091. ),
  1092. ],
  1093. [migrations.RenameIndex("Pony", new_name="new_name", old_name="old_name")],
  1094. )
  1095. self.assertDoesNotOptimize(
  1096. [
  1097. migrations.RenameIndex(
  1098. "Pony", new_name="mid_name", old_name="old_name"
  1099. ),
  1100. migrations.RenameIndex(
  1101. "Pony", new_name="new_name", old_fields=("weight", "pink")
  1102. ),
  1103. ]
  1104. )
  1105. def test_add_rename_index(self):
  1106. tests = [
  1107. models.Index(fields=["weight", "pink"], name="mid_name"),
  1108. models.Index(Abs("weight"), name="mid_name"),
  1109. models.Index(
  1110. Abs("weight"), name="mid_name", condition=models.Q(weight__gt=0)
  1111. ),
  1112. ]
  1113. for index in tests:
  1114. with self.subTest(index=index):
  1115. renamed_index = index.clone()
  1116. renamed_index.name = "new_name"
  1117. self.assertOptimizesTo(
  1118. [
  1119. migrations.AddIndex("Pony", index),
  1120. migrations.RenameIndex(
  1121. "Pony", new_name="new_name", old_name="mid_name"
  1122. ),
  1123. ],
  1124. [
  1125. migrations.AddIndex("Pony", renamed_index),
  1126. ],
  1127. )
  1128. self.assertDoesNotOptimize(
  1129. [
  1130. migrations.AddIndex("Pony", index),
  1131. migrations.RenameIndex(
  1132. "Pony", new_name="new_name", old_name="other_name"
  1133. ),
  1134. ],
  1135. )
  1136. def test_add_remove_index(self):
  1137. self.assertOptimizesTo(
  1138. [
  1139. migrations.AddIndex(
  1140. "Pony",
  1141. models.Index(
  1142. fields=["weight", "pink"], name="idx_pony_weight_pink"
  1143. ),
  1144. ),
  1145. migrations.RemoveIndex("Pony", "idx_pony_weight_pink"),
  1146. ],
  1147. [],
  1148. )
  1149. def test_add_remove_constraint(self):
  1150. gt_constraint = models.CheckConstraint(
  1151. check=models.Q(pink__gt=2), name="constraint_pony_pink_gt_2"
  1152. )
  1153. self.assertOptimizesTo(
  1154. [
  1155. migrations.AddConstraint("Pony", gt_constraint),
  1156. migrations.RemoveConstraint("Pony", gt_constraint.name),
  1157. ],
  1158. [],
  1159. )
  1160. self.assertDoesNotOptimize(
  1161. [
  1162. migrations.AddConstraint("Pony", gt_constraint),
  1163. migrations.RemoveConstraint("Pony", "other_name"),
  1164. ],
  1165. )
  1166. def test_create_model_add_index(self):
  1167. self.assertOptimizesTo(
  1168. [
  1169. migrations.CreateModel(
  1170. name="Pony",
  1171. fields=[
  1172. ("weight", models.IntegerField()),
  1173. ("age", models.IntegerField()),
  1174. ],
  1175. options={
  1176. "indexes": [models.Index(fields=["age"], name="idx_pony_age")],
  1177. },
  1178. ),
  1179. migrations.AddIndex(
  1180. "Pony",
  1181. models.Index(fields=["weight"], name="idx_pony_weight"),
  1182. ),
  1183. ],
  1184. [
  1185. migrations.CreateModel(
  1186. name="Pony",
  1187. fields=[
  1188. ("weight", models.IntegerField()),
  1189. ("age", models.IntegerField()),
  1190. ],
  1191. options={
  1192. "indexes": [
  1193. models.Index(fields=["age"], name="idx_pony_age"),
  1194. models.Index(fields=["weight"], name="idx_pony_weight"),
  1195. ],
  1196. },
  1197. ),
  1198. ],
  1199. )
  1200. def test_create_model_remove_index(self):
  1201. self.assertOptimizesTo(
  1202. [
  1203. migrations.CreateModel(
  1204. name="Pony",
  1205. fields=[
  1206. ("weight", models.IntegerField()),
  1207. ("age", models.IntegerField()),
  1208. ],
  1209. options={
  1210. "indexes": [
  1211. models.Index(fields=["age"], name="idx_pony_age"),
  1212. models.Index(fields=["weight"], name="idx_pony_weight"),
  1213. ],
  1214. },
  1215. ),
  1216. migrations.RemoveIndex("Pony", "idx_pony_age"),
  1217. ],
  1218. [
  1219. migrations.CreateModel(
  1220. name="Pony",
  1221. fields=[
  1222. ("weight", models.IntegerField()),
  1223. ("age", models.IntegerField()),
  1224. ],
  1225. options={
  1226. "indexes": [
  1227. models.Index(fields=["weight"], name="idx_pony_weight"),
  1228. ],
  1229. },
  1230. ),
  1231. ],
  1232. )
  1233. def test_create_model_remove_index_together_rename_index(self):
  1234. self.assertOptimizesTo(
  1235. [
  1236. migrations.CreateModel(
  1237. name="Pony",
  1238. fields=[
  1239. ("weight", models.IntegerField()),
  1240. ("age", models.IntegerField()),
  1241. ],
  1242. options={
  1243. "index_together": [("age", "weight")],
  1244. },
  1245. ),
  1246. migrations.RenameIndex(
  1247. "Pony", new_name="idx_pony_age_weight", old_fields=("age", "weight")
  1248. ),
  1249. ],
  1250. [
  1251. migrations.CreateModel(
  1252. name="Pony",
  1253. fields=[
  1254. ("weight", models.IntegerField()),
  1255. ("age", models.IntegerField()),
  1256. ],
  1257. options={
  1258. "indexes": [
  1259. models.Index(
  1260. fields=["age", "weight"], name="idx_pony_age_weight"
  1261. ),
  1262. ],
  1263. },
  1264. ),
  1265. ],
  1266. )
  1267. def test_create_model_index_together_rename_index(self):
  1268. self.assertOptimizesTo(
  1269. [
  1270. migrations.CreateModel(
  1271. name="Pony",
  1272. fields=[
  1273. ("weight", models.IntegerField()),
  1274. ("age", models.IntegerField()),
  1275. ("height", models.IntegerField()),
  1276. ("rank", models.IntegerField()),
  1277. ],
  1278. options={
  1279. "index_together": [("age", "weight"), ("height", "rank")],
  1280. },
  1281. ),
  1282. migrations.RenameIndex(
  1283. "Pony", new_name="idx_pony_age_weight", old_fields=("age", "weight")
  1284. ),
  1285. ],
  1286. [
  1287. migrations.CreateModel(
  1288. name="Pony",
  1289. fields=[
  1290. ("weight", models.IntegerField()),
  1291. ("age", models.IntegerField()),
  1292. ("height", models.IntegerField()),
  1293. ("rank", models.IntegerField()),
  1294. ],
  1295. options={
  1296. "index_together": {("height", "rank")},
  1297. "indexes": [
  1298. models.Index(
  1299. fields=["age", "weight"], name="idx_pony_age_weight"
  1300. ),
  1301. ],
  1302. },
  1303. ),
  1304. ],
  1305. )
  1306. def test_create_model_rename_index_no_old_fields(self):
  1307. self.assertOptimizesTo(
  1308. [
  1309. migrations.CreateModel(
  1310. name="Pony",
  1311. fields=[
  1312. ("weight", models.IntegerField()),
  1313. ("age", models.IntegerField()),
  1314. ],
  1315. options={
  1316. "indexes": [models.Index(fields=["age"], name="idx_pony_age")],
  1317. },
  1318. ),
  1319. migrations.RenameIndex(
  1320. "Pony", new_name="idx_pony_age_new", old_name="idx_pony_age"
  1321. ),
  1322. ],
  1323. [
  1324. migrations.CreateModel(
  1325. name="Pony",
  1326. fields=[
  1327. ("weight", models.IntegerField()),
  1328. ("age", models.IntegerField()),
  1329. ],
  1330. options={
  1331. "indexes": [models.Index(fields=["age"], name="idx_pony_age")],
  1332. },
  1333. ),
  1334. migrations.RenameIndex(
  1335. "Pony", new_name="idx_pony_age_new", old_name="idx_pony_age"
  1336. ),
  1337. ],
  1338. )