tests.py 32 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788
  1. import logging
  2. import re
  3. from django.conf import settings
  4. from django.core.exceptions import ImproperlyConfigured
  5. from django.http import HttpRequest
  6. from django.middleware.csrf import (
  7. CSRF_SESSION_KEY, CSRF_TOKEN_LENGTH, REASON_BAD_TOKEN,
  8. REASON_NO_CSRF_COOKIE, CsrfViewMiddleware,
  9. _compare_salted_tokens as equivalent_tokens, get_token,
  10. )
  11. from django.test import SimpleTestCase, override_settings
  12. from django.test.utils import patch_logger
  13. from django.views.decorators.csrf import csrf_exempt, requires_csrf_token
  14. from .views import (
  15. ensure_csrf_cookie_view, non_token_view_using_request_processor,
  16. post_form_view, token_view,
  17. )
  18. class TestingHttpRequest(HttpRequest):
  19. """
  20. A version of HttpRequest that allows us to change some things
  21. more easily
  22. """
  23. def __init__(self):
  24. super().__init__()
  25. # A real session backend isn't needed.
  26. self.session = {}
  27. def is_secure(self):
  28. return getattr(self, '_is_secure_override', False)
  29. class CsrfViewMiddlewareTestMixin:
  30. """
  31. Shared methods and tests for session-based and cookie-based tokens.
  32. """
  33. _csrf_id = _csrf_id_cookie = '1bcdefghij2bcdefghij3bcdefghij4bcdefghij5bcdefghij6bcdefghijABCD'
  34. mw = CsrfViewMiddleware()
  35. def _get_GET_no_csrf_cookie_request(self):
  36. return TestingHttpRequest()
  37. def _get_GET_csrf_cookie_request(self):
  38. raise NotImplementedError('This method must be implemented by a subclass.')
  39. def _get_POST_csrf_cookie_request(self):
  40. req = self._get_GET_csrf_cookie_request()
  41. req.method = "POST"
  42. return req
  43. def _get_POST_no_csrf_cookie_request(self):
  44. req = self._get_GET_no_csrf_cookie_request()
  45. req.method = "POST"
  46. return req
  47. def _get_POST_request_with_token(self):
  48. req = self._get_POST_csrf_cookie_request()
  49. req.POST['csrfmiddlewaretoken'] = self._csrf_id
  50. return req
  51. def _check_token_present(self, response, csrf_id=None):
  52. text = str(response.content, response.charset)
  53. match = re.search("name='csrfmiddlewaretoken' value='(.*?)'", text)
  54. csrf_token = csrf_id or self._csrf_id
  55. self.assertTrue(
  56. match and equivalent_tokens(csrf_token, match.group(1)),
  57. "Could not find csrfmiddlewaretoken to match %s" % csrf_token
  58. )
  59. def test_process_response_get_token_not_used(self):
  60. """
  61. If get_token() is not called, the view middleware does not
  62. add a cookie.
  63. """
  64. # This is important to make pages cacheable. Pages which do call
  65. # get_token(), assuming they use the token, are not cacheable because
  66. # the token is specific to the user
  67. req = self._get_GET_no_csrf_cookie_request()
  68. # non_token_view_using_request_processor does not call get_token(), but
  69. # does use the csrf request processor. By using this, we are testing
  70. # that the view processor is properly lazy and doesn't call get_token()
  71. # until needed.
  72. self.mw.process_request(req)
  73. self.mw.process_view(req, non_token_view_using_request_processor, (), {})
  74. resp = non_token_view_using_request_processor(req)
  75. resp2 = self.mw.process_response(req, resp)
  76. csrf_cookie = resp2.cookies.get(settings.CSRF_COOKIE_NAME, False)
  77. self.assertIs(csrf_cookie, False)
  78. # Check the request processing
  79. def test_process_request_no_csrf_cookie(self):
  80. """
  81. If no CSRF cookies is present, the middleware rejects the incoming
  82. request. This will stop login CSRF.
  83. """
  84. with patch_logger('django.security.csrf', 'warning') as logger_calls:
  85. req = self._get_POST_no_csrf_cookie_request()
  86. self.mw.process_request(req)
  87. req2 = self.mw.process_view(req, post_form_view, (), {})
  88. self.assertEqual(403, req2.status_code)
  89. self.assertEqual(logger_calls[0], 'Forbidden (%s): ' % REASON_NO_CSRF_COOKIE)
  90. def test_process_request_csrf_cookie_no_token(self):
  91. """
  92. If a CSRF cookie is present but no token, the middleware rejects
  93. the incoming request.
  94. """
  95. with patch_logger('django.security.csrf', 'warning') as logger_calls:
  96. req = self._get_POST_csrf_cookie_request()
  97. self.mw.process_request(req)
  98. req2 = self.mw.process_view(req, post_form_view, (), {})
  99. self.assertEqual(403, req2.status_code)
  100. self.assertEqual(logger_calls[0], 'Forbidden (%s): ' % REASON_BAD_TOKEN)
  101. def test_process_request_csrf_cookie_and_token(self):
  102. """
  103. If both a cookie and a token is present, the middleware lets it through.
  104. """
  105. req = self._get_POST_request_with_token()
  106. self.mw.process_request(req)
  107. req2 = self.mw.process_view(req, post_form_view, (), {})
  108. self.assertIsNone(req2)
  109. def test_process_request_csrf_cookie_no_token_exempt_view(self):
  110. """
  111. If a CSRF cookie is present and no token, but the csrf_exempt decorator
  112. has been applied to the view, the middleware lets it through
  113. """
  114. req = self._get_POST_csrf_cookie_request()
  115. self.mw.process_request(req)
  116. req2 = self.mw.process_view(req, csrf_exempt(post_form_view), (), {})
  117. self.assertIsNone(req2)
  118. def test_csrf_token_in_header(self):
  119. """
  120. The token may be passed in a header instead of in the form.
  121. """
  122. req = self._get_POST_csrf_cookie_request()
  123. req.META['HTTP_X_CSRFTOKEN'] = self._csrf_id
  124. self.mw.process_request(req)
  125. req2 = self.mw.process_view(req, post_form_view, (), {})
  126. self.assertIsNone(req2)
  127. @override_settings(CSRF_HEADER_NAME='HTTP_X_CSRFTOKEN_CUSTOMIZED')
  128. def test_csrf_token_in_header_with_customized_name(self):
  129. """
  130. settings.CSRF_HEADER_NAME can be used to customize the CSRF header name
  131. """
  132. req = self._get_POST_csrf_cookie_request()
  133. req.META['HTTP_X_CSRFTOKEN_CUSTOMIZED'] = self._csrf_id
  134. self.mw.process_request(req)
  135. req2 = self.mw.process_view(req, post_form_view, (), {})
  136. self.assertIsNone(req2)
  137. def test_put_and_delete_rejected(self):
  138. """
  139. HTTP PUT and DELETE methods have protection
  140. """
  141. req = TestingHttpRequest()
  142. req.method = 'PUT'
  143. with patch_logger('django.security.csrf', 'warning') as logger_calls:
  144. req2 = self.mw.process_view(req, post_form_view, (), {})
  145. self.assertEqual(403, req2.status_code)
  146. self.assertEqual(logger_calls[0], 'Forbidden (%s): ' % REASON_NO_CSRF_COOKIE)
  147. req = TestingHttpRequest()
  148. req.method = 'DELETE'
  149. with patch_logger('django.security.csrf', 'warning') as logger_calls:
  150. req2 = self.mw.process_view(req, post_form_view, (), {})
  151. self.assertEqual(403, req2.status_code)
  152. self.assertEqual(logger_calls[0], 'Forbidden (%s): ' % REASON_NO_CSRF_COOKIE)
  153. def test_put_and_delete_allowed(self):
  154. """
  155. HTTP PUT and DELETE can get through with X-CSRFToken and a cookie.
  156. """
  157. req = self._get_GET_csrf_cookie_request()
  158. req.method = 'PUT'
  159. req.META['HTTP_X_CSRFTOKEN'] = self._csrf_id
  160. self.mw.process_request(req)
  161. req2 = self.mw.process_view(req, post_form_view, (), {})
  162. self.assertIsNone(req2)
  163. req = self._get_GET_csrf_cookie_request()
  164. req.method = 'DELETE'
  165. req.META['HTTP_X_CSRFTOKEN'] = self._csrf_id
  166. self.mw.process_request(req)
  167. req2 = self.mw.process_view(req, post_form_view, (), {})
  168. self.assertIsNone(req2)
  169. # Tests for the template tag method
  170. def test_token_node_no_csrf_cookie(self):
  171. """
  172. CsrfTokenNode works when no CSRF cookie is set.
  173. """
  174. req = self._get_GET_no_csrf_cookie_request()
  175. resp = token_view(req)
  176. token = get_token(req)
  177. self.assertIsNotNone(token)
  178. self._check_token_present(resp, token)
  179. def test_token_node_empty_csrf_cookie(self):
  180. """
  181. A new token is sent if the csrf_cookie is the empty string.
  182. """
  183. req = self._get_GET_no_csrf_cookie_request()
  184. req.COOKIES[settings.CSRF_COOKIE_NAME] = ""
  185. self.mw.process_view(req, token_view, (), {})
  186. resp = token_view(req)
  187. token = get_token(req)
  188. self.assertIsNotNone(token)
  189. self._check_token_present(resp, token)
  190. def test_token_node_with_csrf_cookie(self):
  191. """
  192. CsrfTokenNode works when a CSRF cookie is set.
  193. """
  194. req = self._get_GET_csrf_cookie_request()
  195. self.mw.process_request(req)
  196. self.mw.process_view(req, token_view, (), {})
  197. resp = token_view(req)
  198. self._check_token_present(resp)
  199. def test_get_token_for_exempt_view(self):
  200. """
  201. get_token still works for a view decorated with 'csrf_exempt'.
  202. """
  203. req = self._get_GET_csrf_cookie_request()
  204. self.mw.process_request(req)
  205. self.mw.process_view(req, csrf_exempt(token_view), (), {})
  206. resp = token_view(req)
  207. self._check_token_present(resp)
  208. def test_get_token_for_requires_csrf_token_view(self):
  209. """
  210. get_token() works for a view decorated solely with requires_csrf_token.
  211. """
  212. req = self._get_GET_csrf_cookie_request()
  213. resp = requires_csrf_token(token_view)(req)
  214. self._check_token_present(resp)
  215. def test_token_node_with_new_csrf_cookie(self):
  216. """
  217. CsrfTokenNode works when a CSRF cookie is created by
  218. the middleware (when one was not already present)
  219. """
  220. req = self._get_GET_no_csrf_cookie_request()
  221. self.mw.process_view(req, token_view, (), {})
  222. resp = token_view(req)
  223. resp2 = self.mw.process_response(req, resp)
  224. csrf_cookie = resp2.cookies[settings.CSRF_COOKIE_NAME]
  225. self._check_token_present(resp, csrf_id=csrf_cookie.value)
  226. def test_cookie_not_reset_on_accepted_request(self):
  227. """
  228. The csrf token used in posts is changed on every request (although
  229. stays equivalent). The csrf cookie should not change on accepted
  230. requests. If it appears in the response, it should keep its value.
  231. """
  232. req = self._get_POST_request_with_token()
  233. self.mw.process_request(req)
  234. self.mw.process_view(req, token_view, (), {})
  235. resp = token_view(req)
  236. resp = self.mw.process_response(req, resp)
  237. csrf_cookie = resp.cookies.get(settings.CSRF_COOKIE_NAME, None)
  238. if csrf_cookie:
  239. self.assertEqual(
  240. csrf_cookie.value, self._csrf_id_cookie,
  241. "CSRF cookie was changed on an accepted request"
  242. )
  243. @override_settings(DEBUG=True, ALLOWED_HOSTS=['www.example.com'])
  244. def test_https_bad_referer(self):
  245. """
  246. A POST HTTPS request with a bad referer is rejected
  247. """
  248. req = self._get_POST_request_with_token()
  249. req._is_secure_override = True
  250. req.META['HTTP_HOST'] = 'www.example.com'
  251. req.META['HTTP_REFERER'] = 'https://www.evil.org/somepage'
  252. req.META['SERVER_PORT'] = '443'
  253. response = self.mw.process_view(req, post_form_view, (), {})
  254. self.assertContains(
  255. response,
  256. 'Referer checking failed - https://www.evil.org/somepage does not '
  257. 'match any trusted origins.',
  258. status_code=403,
  259. )
  260. def test_https_malformed_host(self):
  261. """
  262. CsrfViewMiddleware generates a 403 response if it receives an HTTPS
  263. request with a bad host.
  264. """
  265. req = self._get_GET_no_csrf_cookie_request()
  266. req._is_secure_override = True
  267. req.META['HTTP_HOST'] = '@malformed'
  268. req.META['HTTP_REFERER'] = 'https://www.evil.org/somepage'
  269. req.META['SERVER_PORT'] = '443'
  270. response = self.mw.process_view(req, token_view, (), {})
  271. self.assertEqual(response.status_code, 403)
  272. @override_settings(DEBUG=True)
  273. def test_https_malformed_referer(self):
  274. """
  275. A POST HTTPS request with a bad referer is rejected.
  276. """
  277. malformed_referer_msg = 'Referer checking failed - Referer is malformed.'
  278. req = self._get_POST_request_with_token()
  279. req._is_secure_override = True
  280. req.META['HTTP_REFERER'] = 'http://http://www.example.com/'
  281. response = self.mw.process_view(req, post_form_view, (), {})
  282. self.assertContains(
  283. response,
  284. 'Referer checking failed - Referer is insecure while host is secure.',
  285. status_code=403,
  286. )
  287. # Empty
  288. req.META['HTTP_REFERER'] = ''
  289. response = self.mw.process_view(req, post_form_view, (), {})
  290. self.assertContains(response, malformed_referer_msg, status_code=403)
  291. # Non-ASCII
  292. req.META['HTTP_REFERER'] = 'ØBöIß'
  293. response = self.mw.process_view(req, post_form_view, (), {})
  294. self.assertContains(response, malformed_referer_msg, status_code=403)
  295. # missing scheme
  296. # >>> urlparse('//example.com/')
  297. # ParseResult(scheme='', netloc='example.com', path='/', params='', query='', fragment='')
  298. req.META['HTTP_REFERER'] = '//example.com/'
  299. response = self.mw.process_view(req, post_form_view, (), {})
  300. self.assertContains(response, malformed_referer_msg, status_code=403)
  301. # missing netloc
  302. # >>> urlparse('https://')
  303. # ParseResult(scheme='https', netloc='', path='', params='', query='', fragment='')
  304. req.META['HTTP_REFERER'] = 'https://'
  305. response = self.mw.process_view(req, post_form_view, (), {})
  306. self.assertContains(response, malformed_referer_msg, status_code=403)
  307. @override_settings(ALLOWED_HOSTS=['www.example.com'])
  308. def test_https_good_referer(self):
  309. """
  310. A POST HTTPS request with a good referer is accepted.
  311. """
  312. req = self._get_POST_request_with_token()
  313. req._is_secure_override = True
  314. req.META['HTTP_HOST'] = 'www.example.com'
  315. req.META['HTTP_REFERER'] = 'https://www.example.com/somepage'
  316. self.mw.process_request(req)
  317. req2 = self.mw.process_view(req, post_form_view, (), {})
  318. self.assertIsNone(req2)
  319. @override_settings(ALLOWED_HOSTS=['www.example.com'])
  320. def test_https_good_referer_2(self):
  321. """
  322. A POST HTTPS request with a good referer is accepted where the referer
  323. contains no trailing slash.
  324. """
  325. # See ticket #15617
  326. req = self._get_POST_request_with_token()
  327. req._is_secure_override = True
  328. req.META['HTTP_HOST'] = 'www.example.com'
  329. req.META['HTTP_REFERER'] = 'https://www.example.com'
  330. self.mw.process_request(req)
  331. req2 = self.mw.process_view(req, post_form_view, (), {})
  332. self.assertIsNone(req2)
  333. def _test_https_good_referer_behind_proxy(self):
  334. req = self._get_POST_request_with_token()
  335. req._is_secure_override = True
  336. req.META.update({
  337. 'HTTP_HOST': '10.0.0.2',
  338. 'HTTP_REFERER': 'https://www.example.com/somepage',
  339. 'SERVER_PORT': '8080',
  340. 'HTTP_X_FORWARDED_HOST': 'www.example.com',
  341. 'HTTP_X_FORWARDED_PORT': '443',
  342. })
  343. self.mw.process_request(req)
  344. req2 = self.mw.process_view(req, post_form_view, (), {})
  345. self.assertIsNone(req2)
  346. @override_settings(ALLOWED_HOSTS=['www.example.com'], CSRF_TRUSTED_ORIGINS=['dashboard.example.com'])
  347. def test_https_csrf_trusted_origin_allowed(self):
  348. """
  349. A POST HTTPS request with a referer added to the CSRF_TRUSTED_ORIGINS
  350. setting is accepted.
  351. """
  352. req = self._get_POST_request_with_token()
  353. req._is_secure_override = True
  354. req.META['HTTP_HOST'] = 'www.example.com'
  355. req.META['HTTP_REFERER'] = 'https://dashboard.example.com'
  356. self.mw.process_request(req)
  357. req2 = self.mw.process_view(req, post_form_view, (), {})
  358. self.assertIsNone(req2)
  359. @override_settings(ALLOWED_HOSTS=['www.example.com'], CSRF_TRUSTED_ORIGINS=['.example.com'])
  360. def test_https_csrf_wildcard_trusted_origin_allowed(self):
  361. """
  362. A POST HTTPS request with a referer that matches a CSRF_TRUSTED_ORIGINS
  363. wildcard is accepted.
  364. """
  365. req = self._get_POST_request_with_token()
  366. req._is_secure_override = True
  367. req.META['HTTP_HOST'] = 'www.example.com'
  368. req.META['HTTP_REFERER'] = 'https://dashboard.example.com'
  369. self.mw.process_request(req)
  370. response = self.mw.process_view(req, post_form_view, (), {})
  371. self.assertIsNone(response)
  372. def _test_https_good_referer_matches_cookie_domain(self):
  373. req = self._get_POST_request_with_token()
  374. req._is_secure_override = True
  375. req.META['HTTP_REFERER'] = 'https://foo.example.com/'
  376. req.META['SERVER_PORT'] = '443'
  377. self.mw.process_request(req)
  378. response = self.mw.process_view(req, post_form_view, (), {})
  379. self.assertIsNone(response)
  380. def _test_https_good_referer_matches_cookie_domain_with_different_port(self):
  381. req = self._get_POST_request_with_token()
  382. req._is_secure_override = True
  383. req.META['HTTP_HOST'] = 'www.example.com'
  384. req.META['HTTP_REFERER'] = 'https://foo.example.com:4443/'
  385. req.META['SERVER_PORT'] = '4443'
  386. self.mw.process_request(req)
  387. response = self.mw.process_view(req, post_form_view, (), {})
  388. self.assertIsNone(response)
  389. def test_ensures_csrf_cookie_no_logging(self):
  390. """
  391. ensure_csrf_cookie() doesn't log warnings (#19436).
  392. """
  393. class TestHandler(logging.Handler):
  394. def emit(self, record):
  395. raise Exception("This shouldn't have happened!")
  396. logger = logging.getLogger('django.request')
  397. test_handler = TestHandler()
  398. old_log_level = logger.level
  399. try:
  400. logger.addHandler(test_handler)
  401. logger.setLevel(logging.WARNING)
  402. req = self._get_GET_no_csrf_cookie_request()
  403. ensure_csrf_cookie_view(req)
  404. finally:
  405. logger.removeHandler(test_handler)
  406. logger.setLevel(old_log_level)
  407. def test_post_data_read_failure(self):
  408. """
  409. #20128 -- IOErrors during POST data reading should be caught and
  410. treated as if the POST data wasn't there.
  411. """
  412. class CsrfPostRequest(HttpRequest):
  413. """
  414. HttpRequest that can raise an IOError when accessing POST data
  415. """
  416. def __init__(self, token, raise_error):
  417. super().__init__()
  418. self.method = 'POST'
  419. self.raise_error = False
  420. self.COOKIES[settings.CSRF_COOKIE_NAME] = token
  421. # Handle both cases here to prevent duplicate code in the
  422. # session tests.
  423. self.session = {}
  424. self.session[CSRF_SESSION_KEY] = token
  425. self.POST['csrfmiddlewaretoken'] = token
  426. self.raise_error = raise_error
  427. def _load_post_and_files(self):
  428. raise IOError('error reading input data')
  429. def _get_post(self):
  430. if self.raise_error:
  431. self._load_post_and_files()
  432. return self._post
  433. def _set_post(self, post):
  434. self._post = post
  435. POST = property(_get_post, _set_post)
  436. token = ('ABC' + self._csrf_id)[:CSRF_TOKEN_LENGTH]
  437. req = CsrfPostRequest(token, raise_error=False)
  438. self.mw.process_request(req)
  439. resp = self.mw.process_view(req, post_form_view, (), {})
  440. self.assertIsNone(resp)
  441. req = CsrfPostRequest(token, raise_error=True)
  442. with patch_logger('django.security.csrf', 'warning') as logger_calls:
  443. self.mw.process_request(req)
  444. resp = self.mw.process_view(req, post_form_view, (), {})
  445. self.assertEqual(resp.status_code, 403)
  446. self.assertEqual(logger_calls[0], 'Forbidden (%s): ' % REASON_BAD_TOKEN)
  447. class CsrfViewMiddlewareTests(CsrfViewMiddlewareTestMixin, SimpleTestCase):
  448. def _get_GET_csrf_cookie_request(self):
  449. req = TestingHttpRequest()
  450. req.COOKIES[settings.CSRF_COOKIE_NAME] = self._csrf_id_cookie
  451. return req
  452. def _get_POST_bare_secret_csrf_cookie_request(self):
  453. req = self._get_POST_no_csrf_cookie_request()
  454. req.COOKIES[settings.CSRF_COOKIE_NAME] = self._csrf_id_cookie[:32]
  455. return req
  456. def _get_POST_bare_secret_csrf_cookie_request_with_token(self):
  457. req = self._get_POST_bare_secret_csrf_cookie_request()
  458. req.POST['csrfmiddlewaretoken'] = self._csrf_id_cookie[:32]
  459. return req
  460. def test_ensures_csrf_cookie_no_middleware(self):
  461. """
  462. The ensure_csrf_cookie() decorator works without middleware.
  463. """
  464. req = self._get_GET_no_csrf_cookie_request()
  465. resp = ensure_csrf_cookie_view(req)
  466. self.assertTrue(resp.cookies.get(settings.CSRF_COOKIE_NAME, False))
  467. self.assertIn('Cookie', resp.get('Vary', ''))
  468. def test_ensures_csrf_cookie_with_middleware(self):
  469. """
  470. The ensure_csrf_cookie() decorator works with the CsrfViewMiddleware
  471. enabled.
  472. """
  473. req = self._get_GET_no_csrf_cookie_request()
  474. self.mw.process_view(req, ensure_csrf_cookie_view, (), {})
  475. resp = ensure_csrf_cookie_view(req)
  476. resp2 = self.mw.process_response(req, resp)
  477. self.assertTrue(resp2.cookies.get(settings.CSRF_COOKIE_NAME, False))
  478. self.assertIn('Cookie', resp2.get('Vary', ''))
  479. def test_csrf_cookie_age(self):
  480. """
  481. CSRF cookie age can be set using settings.CSRF_COOKIE_AGE.
  482. """
  483. req = self._get_GET_no_csrf_cookie_request()
  484. MAX_AGE = 123
  485. with self.settings(CSRF_COOKIE_NAME='csrfcookie',
  486. CSRF_COOKIE_DOMAIN='.example.com',
  487. CSRF_COOKIE_AGE=MAX_AGE,
  488. CSRF_COOKIE_PATH='/test/',
  489. CSRF_COOKIE_SECURE=True,
  490. CSRF_COOKIE_HTTPONLY=True):
  491. # token_view calls get_token() indirectly
  492. self.mw.process_view(req, token_view, (), {})
  493. resp = token_view(req)
  494. resp2 = self.mw.process_response(req, resp)
  495. max_age = resp2.cookies.get('csrfcookie').get('max-age')
  496. self.assertEqual(max_age, MAX_AGE)
  497. def test_csrf_cookie_age_none(self):
  498. """
  499. CSRF cookie age does not have max age set and therefore uses
  500. session-based cookies.
  501. """
  502. req = self._get_GET_no_csrf_cookie_request()
  503. MAX_AGE = None
  504. with self.settings(CSRF_COOKIE_NAME='csrfcookie',
  505. CSRF_COOKIE_DOMAIN='.example.com',
  506. CSRF_COOKIE_AGE=MAX_AGE,
  507. CSRF_COOKIE_PATH='/test/',
  508. CSRF_COOKIE_SECURE=True,
  509. CSRF_COOKIE_HTTPONLY=True):
  510. # token_view calls get_token() indirectly
  511. self.mw.process_view(req, token_view, (), {})
  512. resp = token_view(req)
  513. resp2 = self.mw.process_response(req, resp)
  514. max_age = resp2.cookies.get('csrfcookie').get('max-age')
  515. self.assertEqual(max_age, '')
  516. def test_csrf_cookie_samesite(self):
  517. req = self._get_GET_no_csrf_cookie_request()
  518. with self.settings(CSRF_COOKIE_NAME='csrfcookie', CSRF_COOKIE_SAMESITE='Strict'):
  519. self.mw.process_view(req, token_view, (), {})
  520. resp = token_view(req)
  521. resp2 = self.mw.process_response(req, resp)
  522. self.assertEqual(resp2.cookies['csrfcookie']['samesite'], 'Strict')
  523. def test_process_view_token_too_long(self):
  524. """
  525. If the token is longer than expected, it is ignored and a new token is
  526. created.
  527. """
  528. req = self._get_GET_no_csrf_cookie_request()
  529. req.COOKIES[settings.CSRF_COOKIE_NAME] = 'x' * 100000
  530. self.mw.process_view(req, token_view, (), {})
  531. resp = token_view(req)
  532. resp2 = self.mw.process_response(req, resp)
  533. csrf_cookie = resp2.cookies.get(settings.CSRF_COOKIE_NAME, False)
  534. self.assertEqual(len(csrf_cookie.value), CSRF_TOKEN_LENGTH)
  535. def test_process_view_token_invalid_chars(self):
  536. """
  537. If the token contains non-alphanumeric characters, it is ignored and a
  538. new token is created.
  539. """
  540. token = ('!@#' + self._csrf_id)[:CSRF_TOKEN_LENGTH]
  541. req = self._get_GET_no_csrf_cookie_request()
  542. req.COOKIES[settings.CSRF_COOKIE_NAME] = token
  543. self.mw.process_view(req, token_view, (), {})
  544. resp = token_view(req)
  545. resp2 = self.mw.process_response(req, resp)
  546. csrf_cookie = resp2.cookies.get(settings.CSRF_COOKIE_NAME, False)
  547. self.assertEqual(len(csrf_cookie.value), CSRF_TOKEN_LENGTH)
  548. self.assertNotEqual(csrf_cookie.value, token)
  549. def test_bare_secret_accepted_and_replaced(self):
  550. """
  551. The csrf token is reset from a bare secret.
  552. """
  553. req = self._get_POST_bare_secret_csrf_cookie_request_with_token()
  554. self.mw.process_request(req)
  555. req2 = self.mw.process_view(req, token_view, (), {})
  556. self.assertIsNone(req2)
  557. resp = token_view(req)
  558. resp = self.mw.process_response(req, resp)
  559. self.assertIn(settings.CSRF_COOKIE_NAME, resp.cookies, "Cookie was not reset from bare secret")
  560. csrf_cookie = resp.cookies[settings.CSRF_COOKIE_NAME]
  561. self.assertEqual(len(csrf_cookie.value), CSRF_TOKEN_LENGTH)
  562. self._check_token_present(resp, csrf_id=csrf_cookie.value)
  563. @override_settings(ALLOWED_HOSTS=['www.example.com'], CSRF_COOKIE_DOMAIN='.example.com', USE_X_FORWARDED_PORT=True)
  564. def test_https_good_referer_behind_proxy(self):
  565. """
  566. A POST HTTPS request is accepted when USE_X_FORWARDED_PORT=True.
  567. """
  568. self._test_https_good_referer_behind_proxy()
  569. @override_settings(ALLOWED_HOSTS=['www.example.com'], CSRF_COOKIE_DOMAIN='.example.com')
  570. def test_https_good_referer_matches_cookie_domain(self):
  571. """
  572. A POST HTTPS request with a good referer should be accepted from a
  573. subdomain that's allowed by CSRF_COOKIE_DOMAIN.
  574. """
  575. self._test_https_good_referer_matches_cookie_domain()
  576. @override_settings(ALLOWED_HOSTS=['www.example.com'], CSRF_COOKIE_DOMAIN='.example.com')
  577. def test_https_good_referer_matches_cookie_domain_with_different_port(self):
  578. """
  579. A POST HTTPS request with a good referer should be accepted from a
  580. subdomain that's allowed by CSRF_COOKIE_DOMAIN and a non-443 port.
  581. """
  582. self._test_https_good_referer_matches_cookie_domain_with_different_port()
  583. @override_settings(CSRF_COOKIE_DOMAIN='.example.com', DEBUG=True)
  584. def test_https_reject_insecure_referer(self):
  585. """
  586. A POST HTTPS request from an insecure referer should be rejected.
  587. """
  588. req = self._get_POST_request_with_token()
  589. req._is_secure_override = True
  590. req.META['HTTP_REFERER'] = 'http://example.com/'
  591. req.META['SERVER_PORT'] = '443'
  592. response = self.mw.process_view(req, post_form_view, (), {})
  593. self.assertContains(
  594. response,
  595. 'Referer checking failed - Referer is insecure while host is secure.',
  596. status_code=403,
  597. )
  598. @override_settings(CSRF_USE_SESSIONS=True, CSRF_COOKIE_DOMAIN=None)
  599. class CsrfViewMiddlewareUseSessionsTests(CsrfViewMiddlewareTestMixin, SimpleTestCase):
  600. """
  601. CSRF tests with CSRF_USE_SESSIONS=True.
  602. """
  603. def _get_POST_bare_secret_csrf_cookie_request(self):
  604. req = self._get_POST_no_csrf_cookie_request()
  605. req.session[CSRF_SESSION_KEY] = self._csrf_id_cookie[:32]
  606. return req
  607. def _get_GET_csrf_cookie_request(self):
  608. req = TestingHttpRequest()
  609. req.session[CSRF_SESSION_KEY] = self._csrf_id_cookie
  610. return req
  611. def test_no_session_on_request(self):
  612. msg = (
  613. 'CSRF_USE_SESSIONS is enabled, but request.session is not set. '
  614. 'SessionMiddleware must appear before CsrfViewMiddleware in MIDDLEWARE.'
  615. )
  616. with self.assertRaisesMessage(ImproperlyConfigured, msg):
  617. self.mw.process_request(HttpRequest())
  618. def test_process_response_get_token_used(self):
  619. """The ensure_csrf_cookie() decorator works without middleware."""
  620. req = self._get_GET_no_csrf_cookie_request()
  621. ensure_csrf_cookie_view(req)
  622. self.assertTrue(req.session.get(CSRF_SESSION_KEY, False))
  623. def test_ensures_csrf_cookie_with_middleware(self):
  624. """
  625. The ensure_csrf_cookie() decorator works with the CsrfViewMiddleware
  626. enabled.
  627. """
  628. req = self._get_GET_no_csrf_cookie_request()
  629. self.mw.process_view(req, ensure_csrf_cookie_view, (), {})
  630. resp = ensure_csrf_cookie_view(req)
  631. self.mw.process_response(req, resp)
  632. self.assertTrue(req.session.get(CSRF_SESSION_KEY, False))
  633. def test_token_node_with_new_csrf_cookie(self):
  634. """
  635. CsrfTokenNode works when a CSRF cookie is created by the middleware
  636. (when one was not already present).
  637. """
  638. req = self._get_GET_no_csrf_cookie_request()
  639. self.mw.process_view(req, token_view, (), {})
  640. resp = token_view(req)
  641. self.mw.process_response(req, resp)
  642. csrf_cookie = req.session[CSRF_SESSION_KEY]
  643. self._check_token_present(resp, csrf_id=csrf_cookie)
  644. @override_settings(
  645. ALLOWED_HOSTS=['www.example.com'],
  646. SESSION_COOKIE_DOMAIN='.example.com',
  647. USE_X_FORWARDED_PORT=True,
  648. DEBUG=True,
  649. )
  650. def test_https_good_referer_behind_proxy(self):
  651. """
  652. A POST HTTPS request is accepted when USE_X_FORWARDED_PORT=True.
  653. """
  654. self._test_https_good_referer_behind_proxy()
  655. @override_settings(ALLOWED_HOSTS=['www.example.com'], SESSION_COOKIE_DOMAIN='.example.com')
  656. def test_https_good_referer_matches_cookie_domain(self):
  657. """
  658. A POST HTTPS request with a good referer should be accepted from a
  659. subdomain that's allowed by SESSION_COOKIE_DOMAIN.
  660. """
  661. self._test_https_good_referer_matches_cookie_domain()
  662. @override_settings(ALLOWED_HOSTS=['www.example.com'], SESSION_COOKIE_DOMAIN='.example.com')
  663. def test_https_good_referer_matches_cookie_domain_with_different_port(self):
  664. """
  665. A POST HTTPS request with a good referer should be accepted from a
  666. subdomain that's allowed by SESSION_COOKIE_DOMAIN and a non-443 port.
  667. """
  668. self._test_https_good_referer_matches_cookie_domain_with_different_port()
  669. @override_settings(SESSION_COOKIE_DOMAIN='.example.com', DEBUG=True)
  670. def test_https_reject_insecure_referer(self):
  671. """
  672. A POST HTTPS request from an insecure referer should be rejected.
  673. """
  674. req = self._get_POST_request_with_token()
  675. req._is_secure_override = True
  676. req.META['HTTP_REFERER'] = 'http://example.com/'
  677. req.META['SERVER_PORT'] = '443'
  678. response = self.mw.process_view(req, post_form_view, (), {})
  679. self.assertContains(
  680. response,
  681. 'Referer checking failed - Referer is insecure while host is secure.',
  682. status_code=403,
  683. )
  684. @override_settings(ROOT_URLCONF='csrf_tests.csrf_token_error_handler_urls', DEBUG=False)
  685. class CsrfInErrorHandlingViewsTests(SimpleTestCase):
  686. def test_csrf_token_on_404_stays_constant(self):
  687. response = self.client.get('/does not exist/')
  688. # The error handler returns status code 599.
  689. self.assertEqual(response.status_code, 599)
  690. token1 = response.content
  691. response = self.client.get('/does not exist/')
  692. self.assertEqual(response.status_code, 599)
  693. token2 = response.content
  694. self.assertTrue(equivalent_tokens(token1.decode('ascii'), token2.decode('ascii')))