tests.py 43 KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078
  1. import gzip
  2. import random
  3. import re
  4. import struct
  5. from io import BytesIO
  6. from unittest import mock
  7. from urllib.parse import quote
  8. from django.conf import settings
  9. from django.core import mail
  10. from django.core.exceptions import PermissionDenied
  11. from django.http import (
  12. FileResponse,
  13. HttpRequest,
  14. HttpResponse,
  15. HttpResponseNotFound,
  16. HttpResponsePermanentRedirect,
  17. HttpResponseRedirect,
  18. StreamingHttpResponse,
  19. )
  20. from django.middleware.clickjacking import XFrameOptionsMiddleware
  21. from django.middleware.common import BrokenLinkEmailsMiddleware, CommonMiddleware
  22. from django.middleware.gzip import GZipMiddleware
  23. from django.middleware.http import ConditionalGetMiddleware
  24. from django.test import RequestFactory, SimpleTestCase, override_settings
  25. int2byte = struct.Struct(">B").pack
  26. def get_response_empty(request):
  27. return HttpResponse()
  28. def get_response_404(request):
  29. return HttpResponseNotFound()
  30. @override_settings(ROOT_URLCONF="middleware.urls")
  31. class CommonMiddlewareTest(SimpleTestCase):
  32. rf = RequestFactory()
  33. @override_settings(APPEND_SLASH=True)
  34. def test_append_slash_have_slash(self):
  35. """
  36. URLs with slashes should go unmolested.
  37. """
  38. request = self.rf.get("/slash/")
  39. self.assertIsNone(CommonMiddleware(get_response_404).process_request(request))
  40. self.assertEqual(CommonMiddleware(get_response_404)(request).status_code, 404)
  41. @override_settings(APPEND_SLASH=True)
  42. def test_append_slash_slashless_resource(self):
  43. """
  44. Matches to explicit slashless URLs should go unmolested.
  45. """
  46. def get_response(req):
  47. return HttpResponse("Here's the text of the web page.")
  48. request = self.rf.get("/noslash")
  49. self.assertIsNone(CommonMiddleware(get_response).process_request(request))
  50. self.assertEqual(
  51. CommonMiddleware(get_response)(request).content,
  52. b"Here's the text of the web page.",
  53. )
  54. @override_settings(APPEND_SLASH=True)
  55. def test_append_slash_slashless_unknown(self):
  56. """
  57. APPEND_SLASH should not redirect to unknown resources.
  58. """
  59. request = self.rf.get("/unknown")
  60. response = CommonMiddleware(get_response_404)(request)
  61. self.assertEqual(response.status_code, 404)
  62. @override_settings(APPEND_SLASH=True)
  63. def test_append_slash_redirect(self):
  64. """
  65. APPEND_SLASH should redirect slashless URLs to a valid pattern.
  66. """
  67. request = self.rf.get("/slash")
  68. r = CommonMiddleware(get_response_empty).process_request(request)
  69. self.assertIsNone(r)
  70. response = HttpResponseNotFound()
  71. r = CommonMiddleware(get_response_empty).process_response(request, response)
  72. self.assertEqual(r.status_code, 301)
  73. self.assertEqual(r.url, "/slash/")
  74. @override_settings(APPEND_SLASH=True)
  75. def test_append_slash_redirect_querystring(self):
  76. """
  77. APPEND_SLASH should preserve querystrings when redirecting.
  78. """
  79. request = self.rf.get("/slash?test=1")
  80. resp = CommonMiddleware(get_response_404)(request)
  81. self.assertEqual(resp.url, "/slash/?test=1")
  82. @override_settings(APPEND_SLASH=True)
  83. def test_append_slash_redirect_querystring_have_slash(self):
  84. """
  85. APPEND_SLASH should append slash to path when redirecting a request
  86. with a querystring ending with slash.
  87. """
  88. request = self.rf.get("/slash?test=slash/")
  89. resp = CommonMiddleware(get_response_404)(request)
  90. self.assertIsInstance(resp, HttpResponsePermanentRedirect)
  91. self.assertEqual(resp.url, "/slash/?test=slash/")
  92. @override_settings(APPEND_SLASH=True, DEBUG=True)
  93. def test_append_slash_no_redirect_on_POST_in_DEBUG(self):
  94. """
  95. While in debug mode, an exception is raised with a warning
  96. when a failed attempt is made to POST, PUT, or PATCH to an URL which
  97. would normally be redirected to a slashed version.
  98. """
  99. msg = "maintaining %s data. Change your form to point to testserver/slash/"
  100. request = self.rf.get("/slash")
  101. request.method = "POST"
  102. with self.assertRaisesMessage(RuntimeError, msg % request.method):
  103. CommonMiddleware(get_response_404)(request)
  104. request = self.rf.get("/slash")
  105. request.method = "PUT"
  106. with self.assertRaisesMessage(RuntimeError, msg % request.method):
  107. CommonMiddleware(get_response_404)(request)
  108. request = self.rf.get("/slash")
  109. request.method = "PATCH"
  110. with self.assertRaisesMessage(RuntimeError, msg % request.method):
  111. CommonMiddleware(get_response_404)(request)
  112. @override_settings(APPEND_SLASH=False)
  113. def test_append_slash_disabled(self):
  114. """
  115. Disabling append slash functionality should leave slashless URLs alone.
  116. """
  117. request = self.rf.get("/slash")
  118. self.assertEqual(CommonMiddleware(get_response_404)(request).status_code, 404)
  119. @override_settings(APPEND_SLASH=True)
  120. def test_append_slash_opt_out(self):
  121. """
  122. Views marked with @no_append_slash should be left alone.
  123. """
  124. request = self.rf.get("/sensitive_fbv")
  125. self.assertEqual(CommonMiddleware(get_response_404)(request).status_code, 404)
  126. request = self.rf.get("/sensitive_cbv")
  127. self.assertEqual(CommonMiddleware(get_response_404)(request).status_code, 404)
  128. @override_settings(APPEND_SLASH=True)
  129. def test_append_slash_quoted(self):
  130. """
  131. URLs which require quoting should be redirected to their slash version.
  132. """
  133. request = self.rf.get(quote("/needsquoting#"))
  134. r = CommonMiddleware(get_response_404)(request)
  135. self.assertEqual(r.status_code, 301)
  136. self.assertEqual(r.url, "/needsquoting%23/")
  137. @override_settings(APPEND_SLASH=True)
  138. def test_append_slash_leading_slashes(self):
  139. """
  140. Paths starting with two slashes are escaped to prevent open redirects.
  141. If there's a URL pattern that allows paths to start with two slashes, a
  142. request with path //evil.com must not redirect to //evil.com/ (appended
  143. slash) which is a schemaless absolute URL. The browser would navigate
  144. to evil.com/.
  145. """
  146. # Use 4 slashes because of RequestFactory behavior.
  147. request = self.rf.get("////evil.com/security")
  148. r = CommonMiddleware(get_response_404).process_request(request)
  149. self.assertIsNone(r)
  150. response = HttpResponseNotFound()
  151. r = CommonMiddleware(get_response_404).process_response(request, response)
  152. self.assertEqual(r.status_code, 301)
  153. self.assertEqual(r.url, "/%2Fevil.com/security/")
  154. r = CommonMiddleware(get_response_404)(request)
  155. self.assertEqual(r.status_code, 301)
  156. self.assertEqual(r.url, "/%2Fevil.com/security/")
  157. @override_settings(APPEND_SLASH=False, PREPEND_WWW=True)
  158. def test_prepend_www(self):
  159. request = self.rf.get("/path/")
  160. r = CommonMiddleware(get_response_empty).process_request(request)
  161. self.assertEqual(r.status_code, 301)
  162. self.assertEqual(r.url, "http://www.testserver/path/")
  163. @override_settings(APPEND_SLASH=True, PREPEND_WWW=True)
  164. def test_prepend_www_append_slash_have_slash(self):
  165. request = self.rf.get("/slash/")
  166. r = CommonMiddleware(get_response_empty).process_request(request)
  167. self.assertEqual(r.status_code, 301)
  168. self.assertEqual(r.url, "http://www.testserver/slash/")
  169. @override_settings(APPEND_SLASH=True, PREPEND_WWW=True)
  170. def test_prepend_www_append_slash_slashless(self):
  171. request = self.rf.get("/slash")
  172. r = CommonMiddleware(get_response_empty).process_request(request)
  173. self.assertEqual(r.status_code, 301)
  174. self.assertEqual(r.url, "http://www.testserver/slash/")
  175. # The following tests examine expected behavior given a custom URLconf that
  176. # overrides the default one through the request object.
  177. @override_settings(APPEND_SLASH=True)
  178. def test_append_slash_have_slash_custom_urlconf(self):
  179. """
  180. URLs with slashes should go unmolested.
  181. """
  182. request = self.rf.get("/customurlconf/slash/")
  183. request.urlconf = "middleware.extra_urls"
  184. self.assertIsNone(CommonMiddleware(get_response_404).process_request(request))
  185. self.assertEqual(CommonMiddleware(get_response_404)(request).status_code, 404)
  186. @override_settings(APPEND_SLASH=True)
  187. def test_append_slash_slashless_resource_custom_urlconf(self):
  188. """
  189. Matches to explicit slashless URLs should go unmolested.
  190. """
  191. def get_response(req):
  192. return HttpResponse("web content")
  193. request = self.rf.get("/customurlconf/noslash")
  194. request.urlconf = "middleware.extra_urls"
  195. self.assertIsNone(CommonMiddleware(get_response).process_request(request))
  196. self.assertEqual(
  197. CommonMiddleware(get_response)(request).content, b"web content"
  198. )
  199. @override_settings(APPEND_SLASH=True)
  200. def test_append_slash_slashless_unknown_custom_urlconf(self):
  201. """
  202. APPEND_SLASH should not redirect to unknown resources.
  203. """
  204. request = self.rf.get("/customurlconf/unknown")
  205. request.urlconf = "middleware.extra_urls"
  206. self.assertIsNone(CommonMiddleware(get_response_404).process_request(request))
  207. self.assertEqual(CommonMiddleware(get_response_404)(request).status_code, 404)
  208. @override_settings(APPEND_SLASH=True)
  209. def test_append_slash_redirect_custom_urlconf(self):
  210. """
  211. APPEND_SLASH should redirect slashless URLs to a valid pattern.
  212. """
  213. request = self.rf.get("/customurlconf/slash")
  214. request.urlconf = "middleware.extra_urls"
  215. r = CommonMiddleware(get_response_404)(request)
  216. self.assertIsNotNone(
  217. r,
  218. "CommonMiddleware failed to return APPEND_SLASH redirect using "
  219. "request.urlconf",
  220. )
  221. self.assertEqual(r.status_code, 301)
  222. self.assertEqual(r.url, "/customurlconf/slash/")
  223. @override_settings(APPEND_SLASH=True, DEBUG=True)
  224. def test_append_slash_no_redirect_on_POST_in_DEBUG_custom_urlconf(self):
  225. """
  226. While in debug mode, an exception is raised with a warning
  227. when a failed attempt is made to POST to an URL which would normally be
  228. redirected to a slashed version.
  229. """
  230. request = self.rf.get("/customurlconf/slash")
  231. request.urlconf = "middleware.extra_urls"
  232. request.method = "POST"
  233. with self.assertRaisesMessage(RuntimeError, "end in a slash"):
  234. CommonMiddleware(get_response_404)(request)
  235. @override_settings(APPEND_SLASH=False)
  236. def test_append_slash_disabled_custom_urlconf(self):
  237. """
  238. Disabling append slash functionality should leave slashless URLs alone.
  239. """
  240. request = self.rf.get("/customurlconf/slash")
  241. request.urlconf = "middleware.extra_urls"
  242. self.assertIsNone(CommonMiddleware(get_response_404).process_request(request))
  243. self.assertEqual(CommonMiddleware(get_response_404)(request).status_code, 404)
  244. @override_settings(APPEND_SLASH=True)
  245. def test_append_slash_quoted_custom_urlconf(self):
  246. """
  247. URLs which require quoting should be redirected to their slash version.
  248. """
  249. request = self.rf.get(quote("/customurlconf/needsquoting#"))
  250. request.urlconf = "middleware.extra_urls"
  251. r = CommonMiddleware(get_response_404)(request)
  252. self.assertIsNotNone(
  253. r,
  254. "CommonMiddleware failed to return APPEND_SLASH redirect using "
  255. "request.urlconf",
  256. )
  257. self.assertEqual(r.status_code, 301)
  258. self.assertEqual(r.url, "/customurlconf/needsquoting%23/")
  259. @override_settings(APPEND_SLASH=False, PREPEND_WWW=True)
  260. def test_prepend_www_custom_urlconf(self):
  261. request = self.rf.get("/customurlconf/path/")
  262. request.urlconf = "middleware.extra_urls"
  263. r = CommonMiddleware(get_response_empty).process_request(request)
  264. self.assertEqual(r.status_code, 301)
  265. self.assertEqual(r.url, "http://www.testserver/customurlconf/path/")
  266. @override_settings(APPEND_SLASH=True, PREPEND_WWW=True)
  267. def test_prepend_www_append_slash_have_slash_custom_urlconf(self):
  268. request = self.rf.get("/customurlconf/slash/")
  269. request.urlconf = "middleware.extra_urls"
  270. r = CommonMiddleware(get_response_empty).process_request(request)
  271. self.assertEqual(r.status_code, 301)
  272. self.assertEqual(r.url, "http://www.testserver/customurlconf/slash/")
  273. @override_settings(APPEND_SLASH=True, PREPEND_WWW=True)
  274. def test_prepend_www_append_slash_slashless_custom_urlconf(self):
  275. request = self.rf.get("/customurlconf/slash")
  276. request.urlconf = "middleware.extra_urls"
  277. r = CommonMiddleware(get_response_empty).process_request(request)
  278. self.assertEqual(r.status_code, 301)
  279. self.assertEqual(r.url, "http://www.testserver/customurlconf/slash/")
  280. # Tests for the Content-Length header
  281. def test_content_length_header_added(self):
  282. def get_response(req):
  283. response = HttpResponse("content")
  284. self.assertNotIn("Content-Length", response)
  285. return response
  286. response = CommonMiddleware(get_response)(self.rf.get("/"))
  287. self.assertEqual(int(response.headers["Content-Length"]), len(response.content))
  288. def test_content_length_header_not_added_for_streaming_response(self):
  289. def get_response(req):
  290. response = StreamingHttpResponse("content")
  291. self.assertNotIn("Content-Length", response)
  292. return response
  293. response = CommonMiddleware(get_response)(self.rf.get("/"))
  294. self.assertNotIn("Content-Length", response)
  295. def test_content_length_header_not_changed(self):
  296. bad_content_length = 500
  297. def get_response(req):
  298. response = HttpResponse()
  299. response.headers["Content-Length"] = bad_content_length
  300. return response
  301. response = CommonMiddleware(get_response)(self.rf.get("/"))
  302. self.assertEqual(int(response.headers["Content-Length"]), bad_content_length)
  303. # Other tests
  304. @override_settings(DISALLOWED_USER_AGENTS=[re.compile(r"foo")])
  305. def test_disallowed_user_agents(self):
  306. request = self.rf.get("/slash")
  307. request.META["HTTP_USER_AGENT"] = "foo"
  308. with self.assertRaisesMessage(PermissionDenied, "Forbidden user agent"):
  309. CommonMiddleware(get_response_empty).process_request(request)
  310. def test_non_ascii_query_string_does_not_crash(self):
  311. """Regression test for #15152"""
  312. request = self.rf.get("/slash")
  313. request.META["QUERY_STRING"] = "drink=café"
  314. r = CommonMiddleware(get_response_empty).process_request(request)
  315. self.assertIsNone(r)
  316. response = HttpResponseNotFound()
  317. r = CommonMiddleware(get_response_empty).process_response(request, response)
  318. self.assertEqual(r.status_code, 301)
  319. def test_response_redirect_class(self):
  320. request = self.rf.get("/slash")
  321. r = CommonMiddleware(get_response_404)(request)
  322. self.assertEqual(r.status_code, 301)
  323. self.assertEqual(r.url, "/slash/")
  324. self.assertIsInstance(r, HttpResponsePermanentRedirect)
  325. def test_response_redirect_class_subclass(self):
  326. class MyCommonMiddleware(CommonMiddleware):
  327. response_redirect_class = HttpResponseRedirect
  328. request = self.rf.get("/slash")
  329. r = MyCommonMiddleware(get_response_404)(request)
  330. self.assertEqual(r.status_code, 302)
  331. self.assertEqual(r.url, "/slash/")
  332. self.assertIsInstance(r, HttpResponseRedirect)
  333. @override_settings(
  334. IGNORABLE_404_URLS=[re.compile(r"foo")],
  335. MANAGERS=[("PHD", "PHB@dilbert.com")],
  336. )
  337. class BrokenLinkEmailsMiddlewareTest(SimpleTestCase):
  338. rf = RequestFactory()
  339. def setUp(self):
  340. self.req = self.rf.get("/regular_url/that/does/not/exist")
  341. def get_response(self, req):
  342. return self.client.get(req.path)
  343. def test_404_error_reporting(self):
  344. self.req.META["HTTP_REFERER"] = "/another/url/"
  345. BrokenLinkEmailsMiddleware(self.get_response)(self.req)
  346. self.assertEqual(len(mail.outbox), 1)
  347. self.assertIn("Broken", mail.outbox[0].subject)
  348. def test_404_error_reporting_no_referer(self):
  349. BrokenLinkEmailsMiddleware(self.get_response)(self.req)
  350. self.assertEqual(len(mail.outbox), 0)
  351. def test_404_error_reporting_ignored_url(self):
  352. self.req.path = self.req.path_info = "foo_url/that/does/not/exist"
  353. BrokenLinkEmailsMiddleware(self.get_response)(self.req)
  354. self.assertEqual(len(mail.outbox), 0)
  355. def test_custom_request_checker(self):
  356. class SubclassedMiddleware(BrokenLinkEmailsMiddleware):
  357. ignored_user_agent_patterns = (
  358. re.compile(r"Spider.*"),
  359. re.compile(r"Robot.*"),
  360. )
  361. def is_ignorable_request(self, request, uri, domain, referer):
  362. """Check user-agent in addition to normal checks."""
  363. if super().is_ignorable_request(request, uri, domain, referer):
  364. return True
  365. user_agent = request.META["HTTP_USER_AGENT"]
  366. return any(
  367. pattern.search(user_agent)
  368. for pattern in self.ignored_user_agent_patterns
  369. )
  370. self.req.META["HTTP_REFERER"] = "/another/url/"
  371. self.req.META["HTTP_USER_AGENT"] = "Spider machine 3.4"
  372. SubclassedMiddleware(self.get_response)(self.req)
  373. self.assertEqual(len(mail.outbox), 0)
  374. self.req.META["HTTP_USER_AGENT"] = "My user agent"
  375. SubclassedMiddleware(self.get_response)(self.req)
  376. self.assertEqual(len(mail.outbox), 1)
  377. def test_referer_equal_to_requested_url(self):
  378. """
  379. Some bots set the referer to the current URL to avoid being blocked by
  380. an referer check (#25302).
  381. """
  382. self.req.META["HTTP_REFERER"] = self.req.path
  383. BrokenLinkEmailsMiddleware(self.get_response)(self.req)
  384. self.assertEqual(len(mail.outbox), 0)
  385. # URL with scheme and domain should also be ignored
  386. self.req.META["HTTP_REFERER"] = "http://testserver%s" % self.req.path
  387. BrokenLinkEmailsMiddleware(self.get_response)(self.req)
  388. self.assertEqual(len(mail.outbox), 0)
  389. # URL with a different scheme should be ignored as well because bots
  390. # tend to use http:// in referers even when browsing HTTPS websites.
  391. self.req.META["HTTP_X_PROTO"] = "https"
  392. self.req.META["SERVER_PORT"] = 443
  393. with self.settings(SECURE_PROXY_SSL_HEADER=("HTTP_X_PROTO", "https")):
  394. BrokenLinkEmailsMiddleware(self.get_response)(self.req)
  395. self.assertEqual(len(mail.outbox), 0)
  396. def test_referer_equal_to_requested_url_on_another_domain(self):
  397. self.req.META["HTTP_REFERER"] = "http://anotherserver%s" % self.req.path
  398. BrokenLinkEmailsMiddleware(self.get_response)(self.req)
  399. self.assertEqual(len(mail.outbox), 1)
  400. @override_settings(APPEND_SLASH=True)
  401. def test_referer_equal_to_requested_url_without_trailing_slash_with_append_slash(
  402. self,
  403. ):
  404. self.req.path = self.req.path_info = "/regular_url/that/does/not/exist/"
  405. self.req.META["HTTP_REFERER"] = self.req.path_info[:-1]
  406. BrokenLinkEmailsMiddleware(self.get_response)(self.req)
  407. self.assertEqual(len(mail.outbox), 0)
  408. @override_settings(APPEND_SLASH=False)
  409. def test_referer_equal_to_requested_url_without_trailing_slash_with_no_append_slash(
  410. self,
  411. ):
  412. self.req.path = self.req.path_info = "/regular_url/that/does/not/exist/"
  413. self.req.META["HTTP_REFERER"] = self.req.path_info[:-1]
  414. BrokenLinkEmailsMiddleware(self.get_response)(self.req)
  415. self.assertEqual(len(mail.outbox), 1)
  416. @override_settings(ROOT_URLCONF="middleware.cond_get_urls")
  417. class ConditionalGetMiddlewareTest(SimpleTestCase):
  418. request_factory = RequestFactory()
  419. def setUp(self):
  420. self.req = self.request_factory.get("/")
  421. self.resp_headers = {}
  422. def get_response(self, req):
  423. resp = self.client.get(req.path_info)
  424. for key, value in self.resp_headers.items():
  425. resp[key] = value
  426. return resp
  427. # Tests for the ETag header
  428. def test_middleware_calculates_etag(self):
  429. resp = ConditionalGetMiddleware(self.get_response)(self.req)
  430. self.assertEqual(resp.status_code, 200)
  431. self.assertNotEqual("", resp["ETag"])
  432. def test_middleware_wont_overwrite_etag(self):
  433. self.resp_headers["ETag"] = "eggs"
  434. resp = ConditionalGetMiddleware(self.get_response)(self.req)
  435. self.assertEqual(resp.status_code, 200)
  436. self.assertEqual("eggs", resp["ETag"])
  437. def test_no_etag_streaming_response(self):
  438. def get_response(req):
  439. return StreamingHttpResponse(["content"])
  440. self.assertFalse(
  441. ConditionalGetMiddleware(get_response)(self.req).has_header("ETag")
  442. )
  443. def test_no_etag_response_empty_content(self):
  444. def get_response(req):
  445. return HttpResponse()
  446. self.assertFalse(
  447. ConditionalGetMiddleware(get_response)(self.req).has_header("ETag")
  448. )
  449. def test_no_etag_no_store_cache(self):
  450. self.resp_headers["Cache-Control"] = "No-Cache, No-Store, Max-age=0"
  451. self.assertFalse(
  452. ConditionalGetMiddleware(self.get_response)(self.req).has_header("ETag")
  453. )
  454. def test_etag_extended_cache_control(self):
  455. self.resp_headers["Cache-Control"] = 'my-directive="my-no-store"'
  456. self.assertTrue(
  457. ConditionalGetMiddleware(self.get_response)(self.req).has_header("ETag")
  458. )
  459. def test_if_none_match_and_no_etag(self):
  460. self.req.META["HTTP_IF_NONE_MATCH"] = "spam"
  461. resp = ConditionalGetMiddleware(self.get_response)(self.req)
  462. self.assertEqual(resp.status_code, 200)
  463. def test_no_if_none_match_and_etag(self):
  464. self.resp_headers["ETag"] = "eggs"
  465. resp = ConditionalGetMiddleware(self.get_response)(self.req)
  466. self.assertEqual(resp.status_code, 200)
  467. def test_if_none_match_and_same_etag(self):
  468. self.req.META["HTTP_IF_NONE_MATCH"] = '"spam"'
  469. self.resp_headers["ETag"] = '"spam"'
  470. resp = ConditionalGetMiddleware(self.get_response)(self.req)
  471. self.assertEqual(resp.status_code, 304)
  472. def test_if_none_match_and_different_etag(self):
  473. self.req.META["HTTP_IF_NONE_MATCH"] = "spam"
  474. self.resp_headers["ETag"] = "eggs"
  475. resp = ConditionalGetMiddleware(self.get_response)(self.req)
  476. self.assertEqual(resp.status_code, 200)
  477. def test_if_none_match_and_redirect(self):
  478. def get_response(req):
  479. resp = self.client.get(req.path_info)
  480. resp["ETag"] = "spam"
  481. resp["Location"] = "/"
  482. resp.status_code = 301
  483. return resp
  484. self.req.META["HTTP_IF_NONE_MATCH"] = "spam"
  485. resp = ConditionalGetMiddleware(get_response)(self.req)
  486. self.assertEqual(resp.status_code, 301)
  487. def test_if_none_match_and_client_error(self):
  488. def get_response(req):
  489. resp = self.client.get(req.path_info)
  490. resp["ETag"] = "spam"
  491. resp.status_code = 400
  492. return resp
  493. self.req.META["HTTP_IF_NONE_MATCH"] = "spam"
  494. resp = ConditionalGetMiddleware(get_response)(self.req)
  495. self.assertEqual(resp.status_code, 400)
  496. # Tests for the Last-Modified header
  497. def test_if_modified_since_and_no_last_modified(self):
  498. self.req.META["HTTP_IF_MODIFIED_SINCE"] = "Sat, 12 Feb 2011 17:38:44 GMT"
  499. resp = ConditionalGetMiddleware(self.get_response)(self.req)
  500. self.assertEqual(resp.status_code, 200)
  501. def test_no_if_modified_since_and_last_modified(self):
  502. self.resp_headers["Last-Modified"] = "Sat, 12 Feb 2011 17:38:44 GMT"
  503. resp = ConditionalGetMiddleware(self.get_response)(self.req)
  504. self.assertEqual(resp.status_code, 200)
  505. def test_if_modified_since_and_same_last_modified(self):
  506. self.req.META["HTTP_IF_MODIFIED_SINCE"] = "Sat, 12 Feb 2011 17:38:44 GMT"
  507. self.resp_headers["Last-Modified"] = "Sat, 12 Feb 2011 17:38:44 GMT"
  508. self.resp = ConditionalGetMiddleware(self.get_response)(self.req)
  509. self.assertEqual(self.resp.status_code, 304)
  510. def test_if_modified_since_and_last_modified_in_the_past(self):
  511. self.req.META["HTTP_IF_MODIFIED_SINCE"] = "Sat, 12 Feb 2011 17:38:44 GMT"
  512. self.resp_headers["Last-Modified"] = "Sat, 12 Feb 2011 17:35:44 GMT"
  513. resp = ConditionalGetMiddleware(self.get_response)(self.req)
  514. self.assertEqual(resp.status_code, 304)
  515. def test_if_modified_since_and_last_modified_in_the_future(self):
  516. self.req.META["HTTP_IF_MODIFIED_SINCE"] = "Sat, 12 Feb 2011 17:38:44 GMT"
  517. self.resp_headers["Last-Modified"] = "Sat, 12 Feb 2011 17:41:44 GMT"
  518. self.resp = ConditionalGetMiddleware(self.get_response)(self.req)
  519. self.assertEqual(self.resp.status_code, 200)
  520. def test_if_modified_since_and_redirect(self):
  521. def get_response(req):
  522. resp = self.client.get(req.path_info)
  523. resp["Last-Modified"] = "Sat, 12 Feb 2011 17:35:44 GMT"
  524. resp["Location"] = "/"
  525. resp.status_code = 301
  526. return resp
  527. self.req.META["HTTP_IF_MODIFIED_SINCE"] = "Sat, 12 Feb 2011 17:38:44 GMT"
  528. resp = ConditionalGetMiddleware(get_response)(self.req)
  529. self.assertEqual(resp.status_code, 301)
  530. def test_if_modified_since_and_client_error(self):
  531. def get_response(req):
  532. resp = self.client.get(req.path_info)
  533. resp["Last-Modified"] = "Sat, 12 Feb 2011 17:35:44 GMT"
  534. resp.status_code = 400
  535. return resp
  536. self.req.META["HTTP_IF_MODIFIED_SINCE"] = "Sat, 12 Feb 2011 17:38:44 GMT"
  537. resp = ConditionalGetMiddleware(get_response)(self.req)
  538. self.assertEqual(resp.status_code, 400)
  539. def test_not_modified_headers(self):
  540. """
  541. The 304 Not Modified response should include only the headers required
  542. by RFC 9110 Section 15.4.5, Last-Modified, and the cookies.
  543. """
  544. def get_response(req):
  545. resp = self.client.get(req.path_info)
  546. resp["Date"] = "Sat, 12 Feb 2011 17:35:44 GMT"
  547. resp["Last-Modified"] = "Sat, 12 Feb 2011 17:35:44 GMT"
  548. resp["Expires"] = "Sun, 13 Feb 2011 17:35:44 GMT"
  549. resp["Vary"] = "Cookie"
  550. resp["Cache-Control"] = "public"
  551. resp["Content-Location"] = "/alt"
  552. resp["Content-Language"] = "en" # shouldn't be preserved
  553. resp["ETag"] = '"spam"'
  554. resp.set_cookie("key", "value")
  555. return resp
  556. self.req.META["HTTP_IF_NONE_MATCH"] = '"spam"'
  557. new_response = ConditionalGetMiddleware(get_response)(self.req)
  558. self.assertEqual(new_response.status_code, 304)
  559. base_response = get_response(self.req)
  560. for header in (
  561. "Cache-Control",
  562. "Content-Location",
  563. "Date",
  564. "ETag",
  565. "Expires",
  566. "Last-Modified",
  567. "Vary",
  568. ):
  569. self.assertEqual(
  570. new_response.headers[header], base_response.headers[header]
  571. )
  572. self.assertEqual(new_response.cookies, base_response.cookies)
  573. self.assertNotIn("Content-Language", new_response)
  574. def test_no_unsafe(self):
  575. """
  576. ConditionalGetMiddleware shouldn't return a conditional response on an
  577. unsafe request. A response has already been generated by the time
  578. ConditionalGetMiddleware is called, so it's too late to return a 412
  579. Precondition Failed.
  580. """
  581. def get_200_response(req):
  582. return HttpResponse(status=200)
  583. response = ConditionalGetMiddleware(self.get_response)(self.req)
  584. etag = response.headers["ETag"]
  585. put_request = self.request_factory.put("/", HTTP_IF_MATCH=etag)
  586. conditional_get_response = ConditionalGetMiddleware(get_200_response)(
  587. put_request
  588. )
  589. self.assertEqual(
  590. conditional_get_response.status_code, 200
  591. ) # should never be a 412
  592. def test_no_head(self):
  593. """
  594. ConditionalGetMiddleware shouldn't compute and return an ETag on a
  595. HEAD request since it can't do so accurately without access to the
  596. response body of the corresponding GET.
  597. """
  598. def get_200_response(req):
  599. return HttpResponse(status=200)
  600. request = self.request_factory.head("/")
  601. conditional_get_response = ConditionalGetMiddleware(get_200_response)(request)
  602. self.assertNotIn("ETag", conditional_get_response)
  603. class XFrameOptionsMiddlewareTest(SimpleTestCase):
  604. """
  605. Tests for the X-Frame-Options clickjacking prevention middleware.
  606. """
  607. def test_same_origin(self):
  608. """
  609. The X_FRAME_OPTIONS setting can be set to SAMEORIGIN to have the
  610. middleware use that value for the HTTP header.
  611. """
  612. with override_settings(X_FRAME_OPTIONS="SAMEORIGIN"):
  613. r = XFrameOptionsMiddleware(get_response_empty)(HttpRequest())
  614. self.assertEqual(r.headers["X-Frame-Options"], "SAMEORIGIN")
  615. with override_settings(X_FRAME_OPTIONS="sameorigin"):
  616. r = XFrameOptionsMiddleware(get_response_empty)(HttpRequest())
  617. self.assertEqual(r.headers["X-Frame-Options"], "SAMEORIGIN")
  618. def test_deny(self):
  619. """
  620. The X_FRAME_OPTIONS setting can be set to DENY to have the middleware
  621. use that value for the HTTP header.
  622. """
  623. with override_settings(X_FRAME_OPTIONS="DENY"):
  624. r = XFrameOptionsMiddleware(get_response_empty)(HttpRequest())
  625. self.assertEqual(r.headers["X-Frame-Options"], "DENY")
  626. with override_settings(X_FRAME_OPTIONS="deny"):
  627. r = XFrameOptionsMiddleware(get_response_empty)(HttpRequest())
  628. self.assertEqual(r.headers["X-Frame-Options"], "DENY")
  629. def test_defaults_sameorigin(self):
  630. """
  631. If the X_FRAME_OPTIONS setting is not set then it defaults to
  632. DENY.
  633. """
  634. with override_settings(X_FRAME_OPTIONS=None):
  635. del settings.X_FRAME_OPTIONS # restored by override_settings
  636. r = XFrameOptionsMiddleware(get_response_empty)(HttpRequest())
  637. self.assertEqual(r.headers["X-Frame-Options"], "DENY")
  638. def test_dont_set_if_set(self):
  639. """
  640. If the X-Frame-Options header is already set then the middleware does
  641. not attempt to override it.
  642. """
  643. def same_origin_response(request):
  644. response = HttpResponse()
  645. response.headers["X-Frame-Options"] = "SAMEORIGIN"
  646. return response
  647. def deny_response(request):
  648. response = HttpResponse()
  649. response.headers["X-Frame-Options"] = "DENY"
  650. return response
  651. with override_settings(X_FRAME_OPTIONS="DENY"):
  652. r = XFrameOptionsMiddleware(same_origin_response)(HttpRequest())
  653. self.assertEqual(r.headers["X-Frame-Options"], "SAMEORIGIN")
  654. with override_settings(X_FRAME_OPTIONS="SAMEORIGIN"):
  655. r = XFrameOptionsMiddleware(deny_response)(HttpRequest())
  656. self.assertEqual(r.headers["X-Frame-Options"], "DENY")
  657. def test_response_exempt(self):
  658. """
  659. If the response has an xframe_options_exempt attribute set to False
  660. then it still sets the header, but if it's set to True then it doesn't.
  661. """
  662. def xframe_exempt_response(request):
  663. response = HttpResponse()
  664. response.xframe_options_exempt = True
  665. return response
  666. def xframe_not_exempt_response(request):
  667. response = HttpResponse()
  668. response.xframe_options_exempt = False
  669. return response
  670. with override_settings(X_FRAME_OPTIONS="SAMEORIGIN"):
  671. r = XFrameOptionsMiddleware(xframe_not_exempt_response)(HttpRequest())
  672. self.assertEqual(r.headers["X-Frame-Options"], "SAMEORIGIN")
  673. r = XFrameOptionsMiddleware(xframe_exempt_response)(HttpRequest())
  674. self.assertIsNone(r.headers.get("X-Frame-Options"))
  675. def test_is_extendable(self):
  676. """
  677. The XFrameOptionsMiddleware method that determines the X-Frame-Options
  678. header value can be overridden based on something in the request or
  679. response.
  680. """
  681. class OtherXFrameOptionsMiddleware(XFrameOptionsMiddleware):
  682. # This is just an example for testing purposes...
  683. def get_xframe_options_value(self, request, response):
  684. if getattr(request, "sameorigin", False):
  685. return "SAMEORIGIN"
  686. if getattr(response, "sameorigin", False):
  687. return "SAMEORIGIN"
  688. return "DENY"
  689. def same_origin_response(request):
  690. response = HttpResponse()
  691. response.sameorigin = True
  692. return response
  693. with override_settings(X_FRAME_OPTIONS="DENY"):
  694. r = OtherXFrameOptionsMiddleware(same_origin_response)(HttpRequest())
  695. self.assertEqual(r.headers["X-Frame-Options"], "SAMEORIGIN")
  696. request = HttpRequest()
  697. request.sameorigin = True
  698. r = OtherXFrameOptionsMiddleware(get_response_empty)(request)
  699. self.assertEqual(r.headers["X-Frame-Options"], "SAMEORIGIN")
  700. with override_settings(X_FRAME_OPTIONS="SAMEORIGIN"):
  701. r = OtherXFrameOptionsMiddleware(get_response_empty)(HttpRequest())
  702. self.assertEqual(r.headers["X-Frame-Options"], "DENY")
  703. class GZipMiddlewareTest(SimpleTestCase):
  704. """
  705. Tests the GZipMiddleware.
  706. """
  707. short_string = b"This string is too short to be worth compressing."
  708. compressible_string = b"a" * 500
  709. incompressible_string = b"".join(
  710. int2byte(random.randint(0, 255)) for _ in range(500)
  711. )
  712. sequence = [b"a" * 500, b"b" * 200, b"a" * 300]
  713. sequence_unicode = ["a" * 500, "é" * 200, "a" * 300]
  714. request_factory = RequestFactory()
  715. def setUp(self):
  716. self.req = self.request_factory.get("/")
  717. self.req.META["HTTP_ACCEPT_ENCODING"] = "gzip, deflate"
  718. self.req.META[
  719. "HTTP_USER_AGENT"
  720. ] = "Mozilla/5.0 (Windows NT 5.1; rv:9.0.1) Gecko/20100101 Firefox/9.0.1"
  721. self.resp = HttpResponse()
  722. self.resp.status_code = 200
  723. self.resp.content = self.compressible_string
  724. self.resp["Content-Type"] = "text/html; charset=UTF-8"
  725. def get_response(self, request):
  726. return self.resp
  727. @staticmethod
  728. def decompress(gzipped_string):
  729. with gzip.GzipFile(mode="rb", fileobj=BytesIO(gzipped_string)) as f:
  730. return f.read()
  731. @staticmethod
  732. def get_mtime(gzipped_string):
  733. with gzip.GzipFile(mode="rb", fileobj=BytesIO(gzipped_string)) as f:
  734. f.read() # must read the data before accessing the header
  735. return f.mtime
  736. def test_compress_response(self):
  737. """
  738. Compression is performed on responses with compressible content.
  739. """
  740. r = GZipMiddleware(self.get_response)(self.req)
  741. self.assertEqual(self.decompress(r.content), self.compressible_string)
  742. self.assertEqual(r.get("Content-Encoding"), "gzip")
  743. self.assertEqual(r.get("Content-Length"), str(len(r.content)))
  744. def test_compress_streaming_response(self):
  745. """
  746. Compression is performed on responses with streaming content.
  747. """
  748. def get_stream_response(request):
  749. resp = StreamingHttpResponse(self.sequence)
  750. resp["Content-Type"] = "text/html; charset=UTF-8"
  751. return resp
  752. r = GZipMiddleware(get_stream_response)(self.req)
  753. self.assertEqual(self.decompress(b"".join(r)), b"".join(self.sequence))
  754. self.assertEqual(r.get("Content-Encoding"), "gzip")
  755. self.assertFalse(r.has_header("Content-Length"))
  756. def test_compress_streaming_response_unicode(self):
  757. """
  758. Compression is performed on responses with streaming Unicode content.
  759. """
  760. def get_stream_response_unicode(request):
  761. resp = StreamingHttpResponse(self.sequence_unicode)
  762. resp["Content-Type"] = "text/html; charset=UTF-8"
  763. return resp
  764. r = GZipMiddleware(get_stream_response_unicode)(self.req)
  765. self.assertEqual(
  766. self.decompress(b"".join(r)),
  767. b"".join(x.encode() for x in self.sequence_unicode),
  768. )
  769. self.assertEqual(r.get("Content-Encoding"), "gzip")
  770. self.assertFalse(r.has_header("Content-Length"))
  771. def test_compress_file_response(self):
  772. """
  773. Compression is performed on FileResponse.
  774. """
  775. with open(__file__, "rb") as file1:
  776. def get_response(req):
  777. file_resp = FileResponse(file1)
  778. file_resp["Content-Type"] = "text/html; charset=UTF-8"
  779. return file_resp
  780. r = GZipMiddleware(get_response)(self.req)
  781. with open(__file__, "rb") as file2:
  782. self.assertEqual(self.decompress(b"".join(r)), file2.read())
  783. self.assertEqual(r.get("Content-Encoding"), "gzip")
  784. self.assertIsNot(r.file_to_stream, file1)
  785. def test_compress_non_200_response(self):
  786. """
  787. Compression is performed on responses with a status other than 200
  788. (#10762).
  789. """
  790. self.resp.status_code = 404
  791. r = GZipMiddleware(self.get_response)(self.req)
  792. self.assertEqual(self.decompress(r.content), self.compressible_string)
  793. self.assertEqual(r.get("Content-Encoding"), "gzip")
  794. def test_no_compress_short_response(self):
  795. """
  796. Compression isn't performed on responses with short content.
  797. """
  798. self.resp.content = self.short_string
  799. r = GZipMiddleware(self.get_response)(self.req)
  800. self.assertEqual(r.content, self.short_string)
  801. self.assertIsNone(r.get("Content-Encoding"))
  802. def test_no_compress_compressed_response(self):
  803. """
  804. Compression isn't performed on responses that are already compressed.
  805. """
  806. self.resp["Content-Encoding"] = "deflate"
  807. r = GZipMiddleware(self.get_response)(self.req)
  808. self.assertEqual(r.content, self.compressible_string)
  809. self.assertEqual(r.get("Content-Encoding"), "deflate")
  810. def test_no_compress_incompressible_response(self):
  811. """
  812. Compression isn't performed on responses with incompressible content.
  813. """
  814. self.resp.content = self.incompressible_string
  815. r = GZipMiddleware(self.get_response)(self.req)
  816. self.assertEqual(r.content, self.incompressible_string)
  817. self.assertIsNone(r.get("Content-Encoding"))
  818. def test_compress_deterministic(self):
  819. """
  820. Compression results are the same for the same content and don't
  821. include a modification time (since that would make the results
  822. of compression non-deterministic and prevent
  823. ConditionalGetMiddleware from recognizing conditional matches
  824. on gzipped content).
  825. """
  826. class DeterministicGZipMiddleware(GZipMiddleware):
  827. max_random_bytes = 0
  828. r1 = DeterministicGZipMiddleware(self.get_response)(self.req)
  829. r2 = DeterministicGZipMiddleware(self.get_response)(self.req)
  830. self.assertEqual(r1.content, r2.content)
  831. self.assertEqual(self.get_mtime(r1.content), 0)
  832. self.assertEqual(self.get_mtime(r2.content), 0)
  833. def test_random_bytes(self):
  834. """A random number of bytes is added to mitigate the BREACH attack."""
  835. with mock.patch(
  836. "django.utils.text.secrets.randbelow", autospec=True, return_value=3
  837. ):
  838. r = GZipMiddleware(self.get_response)(self.req)
  839. # The fourth byte of a gzip stream contains flags.
  840. self.assertEqual(r.content[3], gzip.FNAME)
  841. # A 3 byte filename "aaa" and a null byte are added.
  842. self.assertEqual(r.content[10:14], b"aaa\x00")
  843. self.assertEqual(self.decompress(r.content), self.compressible_string)
  844. def test_random_bytes_streaming_response(self):
  845. """A random number of bytes is added to mitigate the BREACH attack."""
  846. def get_stream_response(request):
  847. resp = StreamingHttpResponse(self.sequence)
  848. resp["Content-Type"] = "text/html; charset=UTF-8"
  849. return resp
  850. with mock.patch(
  851. "django.utils.text.secrets.randbelow", autospec=True, return_value=3
  852. ):
  853. r = GZipMiddleware(get_stream_response)(self.req)
  854. content = b"".join(r)
  855. # The fourth byte of a gzip stream contains flags.
  856. self.assertEqual(content[3], gzip.FNAME)
  857. # A 3 byte filename "aaa" and a null byte are added.
  858. self.assertEqual(content[10:14], b"aaa\x00")
  859. self.assertEqual(self.decompress(content), b"".join(self.sequence))
  860. class ETagGZipMiddlewareTest(SimpleTestCase):
  861. """
  862. ETags are handled properly by GZipMiddleware.
  863. """
  864. rf = RequestFactory()
  865. compressible_string = b"a" * 500
  866. def test_strong_etag_modified(self):
  867. """
  868. GZipMiddleware makes a strong ETag weak.
  869. """
  870. def get_response(req):
  871. response = HttpResponse(self.compressible_string)
  872. response.headers["ETag"] = '"eggs"'
  873. return response
  874. request = self.rf.get("/", HTTP_ACCEPT_ENCODING="gzip, deflate")
  875. gzip_response = GZipMiddleware(get_response)(request)
  876. self.assertEqual(gzip_response.headers["ETag"], 'W/"eggs"')
  877. def test_weak_etag_not_modified(self):
  878. """
  879. GZipMiddleware doesn't modify a weak ETag.
  880. """
  881. def get_response(req):
  882. response = HttpResponse(self.compressible_string)
  883. response.headers["ETag"] = 'W/"eggs"'
  884. return response
  885. request = self.rf.get("/", HTTP_ACCEPT_ENCODING="gzip, deflate")
  886. gzip_response = GZipMiddleware(get_response)(request)
  887. self.assertEqual(gzip_response.headers["ETag"], 'W/"eggs"')
  888. def test_etag_match(self):
  889. """
  890. GZipMiddleware allows 304 Not Modified responses.
  891. """
  892. def get_response(req):
  893. return HttpResponse(self.compressible_string)
  894. def get_cond_response(req):
  895. return ConditionalGetMiddleware(get_response)(req)
  896. request = self.rf.get("/", HTTP_ACCEPT_ENCODING="gzip, deflate")
  897. response = GZipMiddleware(get_cond_response)(request)
  898. gzip_etag = response.headers["ETag"]
  899. next_request = self.rf.get(
  900. "/", HTTP_ACCEPT_ENCODING="gzip, deflate", HTTP_IF_NONE_MATCH=gzip_etag
  901. )
  902. next_response = ConditionalGetMiddleware(get_response)(next_request)
  903. self.assertEqual(next_response.status_code, 304)