123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740174117421743174417451746174717481749175017511752175317541755175617571758175917601761176217631764176517661767176817691770177117721773177417751776177717781779178017811782178317841785178617871788178917901791179217931794179517961797179817991800180118021803180418051806180718081809181018111812181318141815181618171818181918201821182218231824182518261827182818291830183118321833183418351836183718381839184018411842184318441845184618471848184918501851185218531854185518561857185818591860186118621863186418651866186718681869187018711872187318741875187618771878187918801881188218831884188518861887188818891890189118921893189418951896189718981899190019011902190319041905190619071908190919101911191219131914191519161917191819191920192119221923192419251926192719281929193019311932193319341935193619371938193919401941194219431944194519461947194819491950195119521953195419551956195719581959196019611962196319641965196619671968196919701971197219731974197519761977197819791980198119821983198419851986198719881989199019911992199319941995199619971998199920002001200220032004200520062007200820092010201120122013201420152016201720182019202020212022202320242025202620272028202920302031203220332034203520362037203820392040204120422043204420452046204720482049205020512052205320542055205620572058205920602061206220632064206520662067206820692070207120722073207420752076207720782079208020812082208320842085208620872088208920902091209220932094209520962097209820992100210121022103210421052106210721082109211021112112211321142115211621172118211921202121212221232124212521262127212821292130213121322133213421352136213721382139214021412142214321442145214621472148214921502151215221532154215521562157215821592160216121622163216421652166216721682169217021712172217321742175217621772178217921802181218221832184218521862187 |
- from unittest import mock
- from django.core.checks import Error
- from django.core.checks import Warning as DjangoWarning
- from django.db import connection, models
- from django.test.testcases import SimpleTestCase
- from django.test.utils import isolate_apps, modify_settings, override_settings
- @isolate_apps("invalid_models_tests")
- class RelativeFieldTests(SimpleTestCase):
- def test_valid_foreign_key_without_accessor(self):
- class Target(models.Model):
- # There would be a clash if Model.field installed an accessor.
- model = models.IntegerField()
- class Model(models.Model):
- field = models.ForeignKey(Target, models.CASCADE, related_name="+")
- field = Model._meta.get_field("field")
- self.assertEqual(field.check(), [])
- def test_foreign_key_to_missing_model(self):
- # Model names are resolved when a model is being created, so we cannot
- # test relative fields in isolation and we need to attach them to a
- # model.
- class Model(models.Model):
- foreign_key = models.ForeignKey("Rel1", models.CASCADE)
- field = Model._meta.get_field("foreign_key")
- self.assertEqual(
- field.check(),
- [
- Error(
- "Field defines a relation with model 'Rel1', "
- "which is either not installed, or is abstract.",
- obj=field,
- id="fields.E300",
- ),
- ],
- )
- @isolate_apps("invalid_models_tests")
- def test_foreign_key_to_isolate_apps_model(self):
- """
- #25723 - Referenced model registration lookup should be run against the
- field's model registry.
- """
- class OtherModel(models.Model):
- pass
- class Model(models.Model):
- foreign_key = models.ForeignKey("OtherModel", models.CASCADE)
- field = Model._meta.get_field("foreign_key")
- self.assertEqual(field.check(from_model=Model), [])
- def test_many_to_many_to_missing_model(self):
- class Model(models.Model):
- m2m = models.ManyToManyField("Rel2")
- field = Model._meta.get_field("m2m")
- self.assertEqual(
- field.check(from_model=Model),
- [
- Error(
- "Field defines a relation with model 'Rel2', "
- "which is either not installed, or is abstract.",
- obj=field,
- id="fields.E300",
- ),
- ],
- )
- @isolate_apps("invalid_models_tests")
- def test_many_to_many_to_isolate_apps_model(self):
- """
- #25723 - Referenced model registration lookup should be run against the
- field's model registry.
- """
- class OtherModel(models.Model):
- pass
- class Model(models.Model):
- m2m = models.ManyToManyField("OtherModel")
- field = Model._meta.get_field("m2m")
- self.assertEqual(field.check(from_model=Model), [])
- @isolate_apps("invalid_models_tests")
- def test_auto_created_through_model(self):
- class OtherModel(models.Model):
- pass
- class M2MModel(models.Model):
- many_to_many_rel = models.ManyToManyField(OtherModel)
- class O2OModel(models.Model):
- one_to_one_rel = models.OneToOneField(
- "invalid_models_tests.M2MModel_many_to_many_rel",
- on_delete=models.CASCADE,
- )
- field = O2OModel._meta.get_field("one_to_one_rel")
- self.assertEqual(field.check(from_model=O2OModel), [])
- def test_many_to_many_with_useless_options(self):
- class Model(models.Model):
- name = models.CharField(max_length=20)
- class ModelM2M(models.Model):
- m2m = models.ManyToManyField(
- Model, null=True, validators=[lambda x: x], db_comment="Column comment"
- )
- field = ModelM2M._meta.get_field("m2m")
- self.assertEqual(
- ModelM2M.check(),
- [
- DjangoWarning(
- "null has no effect on ManyToManyField.",
- obj=field,
- id="fields.W340",
- ),
- DjangoWarning(
- "ManyToManyField does not support validators.",
- obj=field,
- id="fields.W341",
- ),
- DjangoWarning(
- "db_comment has no effect on ManyToManyField.",
- obj=field,
- id="fields.W346",
- ),
- ],
- )
- def test_many_to_many_with_useless_related_name(self):
- class ModelM2M(models.Model):
- m2m = models.ManyToManyField("self", related_name="children")
- field = ModelM2M._meta.get_field("m2m")
- self.assertEqual(
- ModelM2M.check(),
- [
- DjangoWarning(
- "related_name has no effect on ManyToManyField with "
- 'a symmetrical relationship, e.g. to "self".',
- obj=field,
- id="fields.W345",
- ),
- ],
- )
- def test_ambiguous_relationship_model_from(self):
- class Person(models.Model):
- pass
- class Group(models.Model):
- field = models.ManyToManyField("Person", through="AmbiguousRelationship")
- class AmbiguousRelationship(models.Model):
- person = models.ForeignKey(Person, models.CASCADE)
- first_group = models.ForeignKey(Group, models.CASCADE, related_name="first")
- second_group = models.ForeignKey(
- Group, models.CASCADE, related_name="second"
- )
- field = Group._meta.get_field("field")
- self.assertEqual(
- field.check(from_model=Group),
- [
- Error(
- "The model is used as an intermediate model by "
- "'invalid_models_tests.Group.field', but it has more than one "
- "foreign key from 'Group', which is ambiguous. You must "
- "specify which foreign key Django should use via the "
- "through_fields keyword argument.",
- hint=(
- "If you want to create a recursive relationship, use "
- 'ManyToManyField("self", through="AmbiguousRelationship").'
- ),
- obj=field,
- id="fields.E334",
- ),
- ],
- )
- def test_ambiguous_relationship_model_to(self):
- class Person(models.Model):
- pass
- class Group(models.Model):
- field = models.ManyToManyField(
- "Person", through="AmbiguousRelationship", related_name="tertiary"
- )
- class AmbiguousRelationship(models.Model):
- # Too much foreign keys to Person.
- first_person = models.ForeignKey(
- Person, models.CASCADE, related_name="first"
- )
- second_person = models.ForeignKey(
- Person, models.CASCADE, related_name="second"
- )
- second_model = models.ForeignKey(Group, models.CASCADE)
- field = Group._meta.get_field("field")
- self.assertEqual(
- field.check(from_model=Group),
- [
- Error(
- "The model is used as an intermediate model by "
- "'invalid_models_tests.Group.field', but it has more than one "
- "foreign key to 'Person', which is ambiguous. You must specify "
- "which foreign key Django should use via the through_fields "
- "keyword argument.",
- hint=(
- "If you want to create a recursive relationship, use "
- 'ManyToManyField("self", through="AmbiguousRelationship").'
- ),
- obj=field,
- id="fields.E335",
- ),
- ],
- )
- def test_relationship_model_with_foreign_key_to_wrong_model(self):
- class WrongModel(models.Model):
- pass
- class Person(models.Model):
- pass
- class Group(models.Model):
- members = models.ManyToManyField("Person", through="InvalidRelationship")
- class InvalidRelationship(models.Model):
- person = models.ForeignKey(Person, models.CASCADE)
- wrong_foreign_key = models.ForeignKey(WrongModel, models.CASCADE)
- # The last foreign key should point to Group model.
- field = Group._meta.get_field("members")
- self.assertEqual(
- field.check(from_model=Group),
- [
- Error(
- "The model is used as an intermediate model by "
- "'invalid_models_tests.Group.members', but it does not "
- "have a foreign key to 'Group' or 'Person'.",
- obj=InvalidRelationship,
- id="fields.E336",
- ),
- ],
- )
- def test_relationship_model_missing_foreign_key(self):
- class Person(models.Model):
- pass
- class Group(models.Model):
- members = models.ManyToManyField("Person", through="InvalidRelationship")
- class InvalidRelationship(models.Model):
- group = models.ForeignKey(Group, models.CASCADE)
- # No foreign key to Person
- field = Group._meta.get_field("members")
- self.assertEqual(
- field.check(from_model=Group),
- [
- Error(
- "The model is used as an intermediate model by "
- "'invalid_models_tests.Group.members', but it does not have "
- "a foreign key to 'Group' or 'Person'.",
- obj=InvalidRelationship,
- id="fields.E336",
- ),
- ],
- )
- def test_missing_relationship_model(self):
- class Person(models.Model):
- pass
- class Group(models.Model):
- members = models.ManyToManyField("Person", through="MissingM2MModel")
- field = Group._meta.get_field("members")
- self.assertEqual(
- field.check(from_model=Group),
- [
- Error(
- "Field specifies a many-to-many relation through model "
- "'MissingM2MModel', which has not been installed.",
- obj=field,
- id="fields.E331",
- ),
- ],
- )
- def test_missing_relationship_model_on_model_check(self):
- class Person(models.Model):
- pass
- class Group(models.Model):
- members = models.ManyToManyField("Person", through="MissingM2MModel")
- self.assertEqual(
- Group.check(),
- [
- Error(
- "Field specifies a many-to-many relation through model "
- "'MissingM2MModel', which has not been installed.",
- obj=Group._meta.get_field("members"),
- id="fields.E331",
- ),
- ],
- )
- @isolate_apps("invalid_models_tests")
- def test_many_to_many_through_isolate_apps_model(self):
- """
- #25723 - Through model registration lookup should be run against the
- field's model registry.
- """
- class GroupMember(models.Model):
- person = models.ForeignKey("Person", models.CASCADE)
- group = models.ForeignKey("Group", models.CASCADE)
- class Person(models.Model):
- pass
- class Group(models.Model):
- members = models.ManyToManyField("Person", through="GroupMember")
- field = Group._meta.get_field("members")
- self.assertEqual(field.check(from_model=Group), [])
- def test_too_many_foreign_keys_in_self_referential_model(self):
- class Person(models.Model):
- friends = models.ManyToManyField(
- "self", through="InvalidRelationship", symmetrical=False
- )
- class InvalidRelationship(models.Model):
- first = models.ForeignKey(
- Person, models.CASCADE, related_name="rel_from_set_2"
- )
- second = models.ForeignKey(
- Person, models.CASCADE, related_name="rel_to_set_2"
- )
- third = models.ForeignKey(
- Person, models.CASCADE, related_name="too_many_by_far"
- )
- field = Person._meta.get_field("friends")
- self.assertEqual(
- field.check(from_model=Person),
- [
- Error(
- "The model is used as an intermediate model by "
- "'invalid_models_tests.Person.friends', but it has more than two "
- "foreign keys to 'Person', which is ambiguous. You must specify "
- "which two foreign keys Django should use via the through_fields "
- "keyword argument.",
- hint=(
- "Use through_fields to specify which two foreign keys Django "
- "should use."
- ),
- obj=InvalidRelationship,
- id="fields.E333",
- ),
- ],
- )
- def test_foreign_key_to_abstract_model(self):
- class AbstractModel(models.Model):
- class Meta:
- abstract = True
- class Model(models.Model):
- rel_string_foreign_key = models.ForeignKey("AbstractModel", models.CASCADE)
- rel_class_foreign_key = models.ForeignKey(AbstractModel, models.CASCADE)
- fields = [
- Model._meta.get_field("rel_string_foreign_key"),
- Model._meta.get_field("rel_class_foreign_key"),
- ]
- expected_error = Error(
- "Field defines a relation with model 'AbstractModel', "
- "which is either not installed, or is abstract.",
- id="fields.E300",
- )
- for field in fields:
- expected_error.obj = field
- self.assertEqual(field.check(), [expected_error])
- def test_m2m_to_abstract_model(self):
- class AbstractModel(models.Model):
- class Meta:
- abstract = True
- class Model(models.Model):
- rel_string_m2m = models.ManyToManyField("AbstractModel")
- rel_class_m2m = models.ManyToManyField(AbstractModel)
- fields = [
- Model._meta.get_field("rel_string_m2m"),
- Model._meta.get_field("rel_class_m2m"),
- ]
- expected_error = Error(
- "Field defines a relation with model 'AbstractModel', "
- "which is either not installed, or is abstract.",
- id="fields.E300",
- )
- for field in fields:
- expected_error.obj = field
- self.assertEqual(field.check(from_model=Model), [expected_error])
- def test_unique_m2m(self):
- class Person(models.Model):
- name = models.CharField(max_length=5)
- class Group(models.Model):
- members = models.ManyToManyField("Person", unique=True)
- field = Group._meta.get_field("members")
- self.assertEqual(
- field.check(from_model=Group),
- [
- Error(
- "ManyToManyFields cannot be unique.",
- obj=field,
- id="fields.E330",
- ),
- ],
- )
- def test_foreignkey_to_model_with_composite_primary_key(self):
- class Parent(models.Model):
- pk = models.CompositePrimaryKey("version", "name")
- version = models.IntegerField()
- name = models.CharField(max_length=20)
- class Child(models.Model):
- rel_class_parent = models.ForeignKey(
- Parent, on_delete=models.CASCADE, related_name="child_class_set"
- )
- rel_string_parent = models.ForeignKey(
- "Parent", on_delete=models.CASCADE, related_name="child_string_set"
- )
- field = Child._meta.get_field("rel_string_parent")
- self.assertEqual(
- field.check(),
- [
- Error(
- "Field defines a relation to the CompositePrimaryKey of model "
- "'Parent' which is not supported.",
- obj=field,
- id="fields.E347",
- ),
- ],
- )
- field = Child._meta.get_field("rel_class_parent")
- self.assertEqual(
- field.check(),
- [
- Error(
- "Field defines a relation to the CompositePrimaryKey of model "
- "'Parent' which is not supported.",
- obj=field,
- id="fields.E347",
- ),
- ],
- )
- def test_many_to_many_to_model_with_composite_primary_key(self):
- class Parent(models.Model):
- pk = models.CompositePrimaryKey("version", "name")
- version = models.IntegerField()
- name = models.CharField(max_length=20)
- class Child(models.Model):
- rel_class_parent = models.ManyToManyField(
- Parent, related_name="child_class_set"
- )
- rel_string_parent = models.ManyToManyField(
- "Parent", related_name="child_string_set"
- )
- field = Child._meta.get_field("rel_string_parent")
- self.assertEqual(
- field.check(from_model=Child),
- [
- Error(
- "Field defines a relation to the CompositePrimaryKey of model "
- "'Parent' which is not supported.",
- obj=field,
- id="fields.E347",
- ),
- ],
- )
- field = Child._meta.get_field("rel_class_parent")
- self.assertEqual(
- field.check(from_model=Child),
- [
- Error(
- "Field defines a relation to the CompositePrimaryKey of model "
- "'Parent' which is not supported.",
- obj=field,
- id="fields.E347",
- ),
- ],
- )
- def test_foreign_key_to_non_unique_field(self):
- class Target(models.Model):
- bad = models.IntegerField() # No unique=True
- class Model(models.Model):
- foreign_key = models.ForeignKey("Target", models.CASCADE, to_field="bad")
- field = Model._meta.get_field("foreign_key")
- self.assertEqual(
- field.check(),
- [
- Error(
- "'Target.bad' must be unique because it is referenced by a foreign "
- "key.",
- hint=(
- "Add unique=True to this field or add a UniqueConstraint "
- "(without condition) in the model Meta.constraints."
- ),
- obj=field,
- id="fields.E311",
- ),
- ],
- )
- def test_foreign_key_to_non_unique_field_under_explicit_model(self):
- class Target(models.Model):
- bad = models.IntegerField()
- class Model(models.Model):
- field = models.ForeignKey(Target, models.CASCADE, to_field="bad")
- field = Model._meta.get_field("field")
- self.assertEqual(
- field.check(),
- [
- Error(
- "'Target.bad' must be unique because it is referenced by a foreign "
- "key.",
- hint=(
- "Add unique=True to this field or add a UniqueConstraint "
- "(without condition) in the model Meta.constraints."
- ),
- obj=field,
- id="fields.E311",
- ),
- ],
- )
- def test_foreign_key_to_partially_unique_field(self):
- class Target(models.Model):
- source = models.IntegerField()
- class Meta:
- constraints = [
- models.UniqueConstraint(
- fields=["source"],
- name="tfktpuf_partial_unique",
- condition=models.Q(pk__gt=2),
- ),
- ]
- class Model(models.Model):
- field = models.ForeignKey(Target, models.CASCADE, to_field="source")
- field = Model._meta.get_field("field")
- self.assertEqual(
- field.check(),
- [
- Error(
- "'Target.source' must be unique because it is referenced by a "
- "foreign key.",
- hint=(
- "Add unique=True to this field or add a UniqueConstraint "
- "(without condition) in the model Meta.constraints."
- ),
- obj=field,
- id="fields.E311",
- ),
- ],
- )
- def test_foreign_key_to_unique_field_with_meta_constraint(self):
- class Target(models.Model):
- source = models.IntegerField()
- class Meta:
- constraints = [
- models.UniqueConstraint(
- fields=["source"],
- name="tfktufwmc_unique",
- ),
- ]
- class Model(models.Model):
- field = models.ForeignKey(Target, models.CASCADE, to_field="source")
- field = Model._meta.get_field("field")
- self.assertEqual(field.check(), [])
- def test_foreign_object_to_non_unique_fields(self):
- class Person(models.Model):
- # Note that both fields are not unique.
- country_id = models.IntegerField()
- city_id = models.IntegerField()
- class MMembership(models.Model):
- person_country_id = models.IntegerField()
- person_city_id = models.IntegerField()
- person = models.ForeignObject(
- Person,
- on_delete=models.CASCADE,
- from_fields=["person_country_id", "person_city_id"],
- to_fields=["country_id", "city_id"],
- )
- field = MMembership._meta.get_field("person")
- self.assertEqual(
- field.check(),
- [
- Error(
- "No subset of the fields 'country_id', 'city_id' on model 'Person' "
- "is unique.",
- hint=(
- "Mark a single field as unique=True or add a set of "
- "fields to a unique constraint (via unique_together or a "
- "UniqueConstraint (without condition) in the model "
- "Meta.constraints)."
- ),
- obj=field,
- id="fields.E310",
- )
- ],
- )
- def test_foreign_object_to_partially_unique_field(self):
- class Person(models.Model):
- country_id = models.IntegerField()
- city_id = models.IntegerField()
- class Meta:
- constraints = [
- models.UniqueConstraint(
- fields=["country_id", "city_id"],
- name="tfotpuf_partial_unique",
- condition=models.Q(pk__gt=2),
- ),
- ]
- class MMembership(models.Model):
- person_country_id = models.IntegerField()
- person_city_id = models.IntegerField()
- person = models.ForeignObject(
- Person,
- on_delete=models.CASCADE,
- from_fields=["person_country_id", "person_city_id"],
- to_fields=["country_id", "city_id"],
- )
- field = MMembership._meta.get_field("person")
- self.assertEqual(
- field.check(),
- [
- Error(
- "No subset of the fields 'country_id', 'city_id' on model "
- "'Person' is unique.",
- hint=(
- "Mark a single field as unique=True or add a set of "
- "fields to a unique constraint (via unique_together or a "
- "UniqueConstraint (without condition) in the model "
- "Meta.constraints)."
- ),
- obj=field,
- id="fields.E310",
- ),
- ],
- )
- def test_foreign_object_to_unique_field_with_meta_constraint(self):
- class Person(models.Model):
- country_id = models.IntegerField()
- city_id = models.IntegerField()
- class Meta:
- constraints = [
- models.UniqueConstraint(
- fields=["country_id", "city_id"],
- name="tfotpuf_unique",
- ),
- ]
- class MMembership(models.Model):
- person_country_id = models.IntegerField()
- person_city_id = models.IntegerField()
- person = models.ForeignObject(
- Person,
- on_delete=models.CASCADE,
- from_fields=["person_country_id", "person_city_id"],
- to_fields=["country_id", "city_id"],
- )
- field = MMembership._meta.get_field("person")
- self.assertEqual(field.check(), [])
- def test_on_delete_set_null_on_non_nullable_field(self):
- class Person(models.Model):
- pass
- class Model(models.Model):
- foreign_key = models.ForeignKey("Person", models.SET_NULL)
- field = Model._meta.get_field("foreign_key")
- self.assertEqual(
- field.check(),
- [
- Error(
- "Field specifies on_delete=SET_NULL, but cannot be null.",
- hint=(
- "Set null=True argument on the field, or change the on_delete "
- "rule."
- ),
- obj=field,
- id="fields.E320",
- ),
- ],
- )
- def test_on_delete_set_default_without_default_value(self):
- class Person(models.Model):
- pass
- class Model(models.Model):
- foreign_key = models.ForeignKey("Person", models.SET_DEFAULT)
- field = Model._meta.get_field("foreign_key")
- self.assertEqual(
- field.check(),
- [
- Error(
- "Field specifies on_delete=SET_DEFAULT, but has no default value.",
- hint="Set a default value, or change the on_delete rule.",
- obj=field,
- id="fields.E321",
- ),
- ],
- )
- def test_nullable_primary_key(self):
- class Model(models.Model):
- field = models.IntegerField(primary_key=True, null=True)
- field = Model._meta.get_field("field")
- with mock.patch.object(
- connection.features, "interprets_empty_strings_as_nulls", False
- ):
- results = field.check()
- self.assertEqual(
- results,
- [
- Error(
- "Primary keys must not have null=True.",
- hint=(
- "Set null=False on the field, or remove primary_key=True "
- "argument."
- ),
- obj=field,
- id="fields.E007",
- ),
- ],
- )
- def test_not_swapped_model(self):
- class SwappableModel(models.Model):
- # A model that can be, but isn't swapped out. References to this
- # model should *not* raise any validation error.
- class Meta:
- swappable = "TEST_SWAPPABLE_MODEL"
- class Model(models.Model):
- explicit_fk = models.ForeignKey(
- SwappableModel,
- models.CASCADE,
- related_name="explicit_fk",
- )
- implicit_fk = models.ForeignKey(
- "invalid_models_tests.SwappableModel",
- models.CASCADE,
- related_name="implicit_fk",
- )
- explicit_m2m = models.ManyToManyField(
- SwappableModel, related_name="explicit_m2m"
- )
- implicit_m2m = models.ManyToManyField(
- "invalid_models_tests.SwappableModel",
- related_name="implicit_m2m",
- )
- explicit_fk = Model._meta.get_field("explicit_fk")
- self.assertEqual(explicit_fk.check(), [])
- implicit_fk = Model._meta.get_field("implicit_fk")
- self.assertEqual(implicit_fk.check(), [])
- explicit_m2m = Model._meta.get_field("explicit_m2m")
- self.assertEqual(explicit_m2m.check(from_model=Model), [])
- implicit_m2m = Model._meta.get_field("implicit_m2m")
- self.assertEqual(implicit_m2m.check(from_model=Model), [])
- @override_settings(TEST_SWAPPED_MODEL="invalid_models_tests.Replacement")
- def test_referencing_to_swapped_model(self):
- class Replacement(models.Model):
- pass
- class SwappedModel(models.Model):
- class Meta:
- swappable = "TEST_SWAPPED_MODEL"
- class Model(models.Model):
- explicit_fk = models.ForeignKey(
- SwappedModel,
- models.CASCADE,
- related_name="explicit_fk",
- )
- implicit_fk = models.ForeignKey(
- "invalid_models_tests.SwappedModel",
- models.CASCADE,
- related_name="implicit_fk",
- )
- explicit_m2m = models.ManyToManyField(
- SwappedModel, related_name="explicit_m2m"
- )
- implicit_m2m = models.ManyToManyField(
- "invalid_models_tests.SwappedModel",
- related_name="implicit_m2m",
- )
- fields = [
- Model._meta.get_field("explicit_fk"),
- Model._meta.get_field("implicit_fk"),
- Model._meta.get_field("explicit_m2m"),
- Model._meta.get_field("implicit_m2m"),
- ]
- expected_error = Error(
- (
- "Field defines a relation with the model "
- "'invalid_models_tests.SwappedModel', which has been swapped out."
- ),
- hint="Update the relation to point at 'settings.TEST_SWAPPED_MODEL'.",
- id="fields.E301",
- )
- for field in fields:
- expected_error.obj = field
- self.assertEqual(field.check(from_model=Model), [expected_error])
- def test_related_field_has_invalid_related_name(self):
- digit = 0
- illegal_non_alphanumeric = "!"
- whitespace = "\t"
- invalid_related_names = [
- "%s_begins_with_digit" % digit,
- "%s_begins_with_illegal_non_alphanumeric" % illegal_non_alphanumeric,
- "%s_begins_with_whitespace" % whitespace,
- "contains_%s_illegal_non_alphanumeric" % illegal_non_alphanumeric,
- "contains_%s_whitespace" % whitespace,
- "ends_with_with_illegal_non_alphanumeric_%s" % illegal_non_alphanumeric,
- "ends_with_whitespace_%s" % whitespace,
- "with", # a Python keyword
- "related_name\n",
- "",
- ",", # non-ASCII
- ]
- class Parent(models.Model):
- pass
- for invalid_related_name in invalid_related_names:
- Child = type(
- "Child%s" % invalid_related_name,
- (models.Model,),
- {
- "parent": models.ForeignKey(
- "Parent", models.CASCADE, related_name=invalid_related_name
- ),
- "__module__": Parent.__module__,
- },
- )
- field = Child._meta.get_field("parent")
- self.assertEqual(
- Child.check(),
- [
- Error(
- "The name '%s' is invalid related_name for field Child%s.parent"
- % (invalid_related_name, invalid_related_name),
- hint=(
- "Related name must be a valid Python identifier or end "
- "with a '+'"
- ),
- obj=field,
- id="fields.E306",
- ),
- ],
- )
- def test_related_field_has_valid_related_name(self):
- lowercase = "a"
- uppercase = "A"
- digit = 0
- related_names = [
- "%s_starts_with_lowercase" % lowercase,
- "%s_tarts_with_uppercase" % uppercase,
- "_starts_with_underscore",
- "contains_%s_digit" % digit,
- "ends_with_plus+",
- "_+",
- "+",
- "試",
- "試驗+",
- ]
- class Parent(models.Model):
- pass
- for related_name in related_names:
- Child = type(
- "Child%s" % related_name,
- (models.Model,),
- {
- "parent": models.ForeignKey(
- "Parent", models.CASCADE, related_name=related_name
- ),
- "__module__": Parent.__module__,
- },
- )
- self.assertEqual(Child.check(), [])
- def test_to_fields_exist(self):
- class Parent(models.Model):
- pass
- class Child(models.Model):
- a = models.PositiveIntegerField()
- b = models.PositiveIntegerField()
- parent = models.ForeignObject(
- Parent,
- on_delete=models.SET_NULL,
- from_fields=("a", "b"),
- to_fields=("a", "b"),
- )
- field = Child._meta.get_field("parent")
- self.assertEqual(
- field.check(),
- [
- Error(
- "The to_field 'a' doesn't exist on the related model "
- "'invalid_models_tests.Parent'.",
- obj=field,
- id="fields.E312",
- ),
- Error(
- "The to_field 'b' doesn't exist on the related model "
- "'invalid_models_tests.Parent'.",
- obj=field,
- id="fields.E312",
- ),
- ],
- )
- def test_to_fields_not_checked_if_related_model_doesnt_exist(self):
- class Child(models.Model):
- a = models.PositiveIntegerField()
- b = models.PositiveIntegerField()
- parent = models.ForeignObject(
- "invalid_models_tests.Parent",
- on_delete=models.SET_NULL,
- from_fields=("a", "b"),
- to_fields=("a", "b"),
- )
- field = Child._meta.get_field("parent")
- self.assertEqual(
- field.check(),
- [
- Error(
- "Field defines a relation with model "
- "'invalid_models_tests.Parent', which is either not installed, or "
- "is abstract.",
- id="fields.E300",
- obj=field,
- ),
- ],
- )
- def test_to_fields_with_composite_primary_key(self):
- class Parent(models.Model):
- pk = models.CompositePrimaryKey("version", "name")
- version = models.IntegerField()
- name = models.CharField(max_length=20)
- class Child(models.Model):
- a = models.IntegerField()
- b = models.IntegerField()
- parent = models.ForeignObject(
- Parent,
- on_delete=models.SET_NULL,
- from_fields=("a", "b"),
- to_fields=("pk", "version"),
- )
- field = Child._meta.get_field("parent")
- self.assertEqual(
- field.check(),
- [
- Error(
- "Field defines a relation to the CompositePrimaryKey of model "
- "'Parent' which is not supported.",
- obj=field,
- id="fields.E347",
- ),
- ],
- )
- def test_to_field_to_composite_primery_key(self):
- class Parent(models.Model):
- pk = models.CompositePrimaryKey("version", "name")
- version = models.IntegerField()
- name = models.CharField(max_length=20)
- class Child(models.Model):
- parent = models.ForeignKey(Parent, on_delete=models.CASCADE, to_field="pk")
- field = Child._meta.get_field("parent")
- self.assertEqual(
- field.check(),
- [
- Error(
- "Field defines a relation to the CompositePrimaryKey of model "
- "'Parent' which is not supported.",
- obj=field,
- id="fields.E347",
- ),
- ],
- )
- def test_invalid_related_query_name(self):
- class Target(models.Model):
- pass
- class Model(models.Model):
- first = models.ForeignKey(
- Target, models.CASCADE, related_name="contains__double"
- )
- second = models.ForeignKey(
- Target, models.CASCADE, related_query_name="ends_underscore_"
- )
- self.assertEqual(
- Model.check(),
- [
- Error(
- "Reverse query name 'contains__double' must not contain '__'.",
- hint=(
- "Add or change a related_name or related_query_name "
- "argument for this field."
- ),
- obj=Model._meta.get_field("first"),
- id="fields.E309",
- ),
- Error(
- "Reverse query name 'ends_underscore_' must not end with an "
- "underscore.",
- hint=(
- "Add or change a related_name or related_query_name "
- "argument for this field."
- ),
- obj=Model._meta.get_field("second"),
- id="fields.E308",
- ),
- ],
- )
- @isolate_apps("invalid_models_tests")
- class AccessorClashTests(SimpleTestCase):
- def test_fk_to_integer(self):
- self._test_accessor_clash(
- target=models.IntegerField(),
- relative=models.ForeignKey("Target", models.CASCADE),
- )
- def test_fk_to_fk(self):
- self._test_accessor_clash(
- target=models.ForeignKey("Another", models.CASCADE),
- relative=models.ForeignKey("Target", models.CASCADE),
- )
- def test_fk_to_m2m(self):
- self._test_accessor_clash(
- target=models.ManyToManyField("Another"),
- relative=models.ForeignKey("Target", models.CASCADE),
- )
- def test_m2m_to_integer(self):
- self._test_accessor_clash(
- target=models.IntegerField(), relative=models.ManyToManyField("Target")
- )
- def test_m2m_to_fk(self):
- self._test_accessor_clash(
- target=models.ForeignKey("Another", models.CASCADE),
- relative=models.ManyToManyField("Target"),
- )
- def test_m2m_to_m2m(self):
- self._test_accessor_clash(
- target=models.ManyToManyField("Another"),
- relative=models.ManyToManyField("Target"),
- )
- def _test_accessor_clash(self, target, relative):
- class Another(models.Model):
- pass
- class Target(models.Model):
- model_set = target
- class Model(models.Model):
- rel = relative
- self.assertEqual(
- Model.check(),
- [
- Error(
- "Reverse accessor 'Target.model_set' for "
- "'invalid_models_tests.Model.rel' clashes with field name "
- "'invalid_models_tests.Target.model_set'.",
- hint=(
- "Rename field 'invalid_models_tests.Target.model_set', or "
- "add/change a related_name argument to the definition for "
- "field 'invalid_models_tests.Model.rel'."
- ),
- obj=Model._meta.get_field("rel"),
- id="fields.E302",
- ),
- ],
- )
- def test_clash_between_accessors(self):
- class Target(models.Model):
- pass
- class Model(models.Model):
- foreign = models.ForeignKey(Target, models.CASCADE)
- m2m = models.ManyToManyField(Target)
- self.assertEqual(
- Model.check(),
- [
- Error(
- "Reverse accessor 'Target.model_set' for "
- "'invalid_models_tests.Model.foreign' clashes with reverse "
- "accessor for 'invalid_models_tests.Model.m2m'.",
- hint=(
- "Add or change a related_name argument to the definition "
- "for 'invalid_models_tests.Model.foreign' or "
- "'invalid_models_tests.Model.m2m'."
- ),
- obj=Model._meta.get_field("foreign"),
- id="fields.E304",
- ),
- Error(
- "Reverse accessor 'Target.model_set' for "
- "'invalid_models_tests.Model.m2m' clashes with reverse "
- "accessor for 'invalid_models_tests.Model.foreign'.",
- hint=(
- "Add or change a related_name argument to the definition "
- "for 'invalid_models_tests.Model.m2m' or "
- "'invalid_models_tests.Model.foreign'."
- ),
- obj=Model._meta.get_field("m2m"),
- id="fields.E304",
- ),
- ],
- )
- def test_m2m_to_m2m_with_inheritance(self):
- """Ref #22047."""
- class Target(models.Model):
- pass
- class Model(models.Model):
- children = models.ManyToManyField(
- "Child", related_name="m2m_clash", related_query_name="no_clash"
- )
- class Parent(models.Model):
- m2m_clash = models.ManyToManyField("Target")
- class Child(Parent):
- pass
- self.assertEqual(
- Model.check(),
- [
- Error(
- "Reverse accessor 'Child.m2m_clash' for "
- "'invalid_models_tests.Model.children' clashes with field "
- "name 'invalid_models_tests.Child.m2m_clash'.",
- hint=(
- "Rename field 'invalid_models_tests.Child.m2m_clash', or "
- "add/change a related_name argument to the definition for "
- "field 'invalid_models_tests.Model.children'."
- ),
- obj=Model._meta.get_field("children"),
- id="fields.E302",
- )
- ],
- )
- def test_no_clash_for_hidden_related_name(self):
- class Stub(models.Model):
- pass
- class ManyToManyRel(models.Model):
- thing1 = models.ManyToManyField(Stub, related_name="+")
- thing2 = models.ManyToManyField(Stub, related_name="+")
- class FKRel(models.Model):
- thing1 = models.ForeignKey(Stub, models.CASCADE, related_name="+")
- thing2 = models.ForeignKey(Stub, models.CASCADE, related_name="+")
- self.assertEqual(ManyToManyRel.check(), [])
- self.assertEqual(FKRel.check(), [])
- @isolate_apps("invalid_models_tests")
- class ReverseQueryNameClashTests(SimpleTestCase):
- def test_fk_to_integer(self):
- self._test_reverse_query_name_clash(
- target=models.IntegerField(),
- relative=models.ForeignKey("Target", models.CASCADE),
- )
- def test_fk_to_fk(self):
- self._test_reverse_query_name_clash(
- target=models.ForeignKey("Another", models.CASCADE),
- relative=models.ForeignKey("Target", models.CASCADE),
- )
- def test_fk_to_m2m(self):
- self._test_reverse_query_name_clash(
- target=models.ManyToManyField("Another"),
- relative=models.ForeignKey("Target", models.CASCADE),
- )
- def test_m2m_to_integer(self):
- self._test_reverse_query_name_clash(
- target=models.IntegerField(), relative=models.ManyToManyField("Target")
- )
- def test_m2m_to_fk(self):
- self._test_reverse_query_name_clash(
- target=models.ForeignKey("Another", models.CASCADE),
- relative=models.ManyToManyField("Target"),
- )
- def test_m2m_to_m2m(self):
- self._test_reverse_query_name_clash(
- target=models.ManyToManyField("Another"),
- relative=models.ManyToManyField("Target"),
- )
- def _test_reverse_query_name_clash(self, target, relative):
- class Another(models.Model):
- pass
- class Target(models.Model):
- model = target
- class Model(models.Model):
- rel = relative
- self.assertEqual(
- Model.check(),
- [
- Error(
- "Reverse query name for 'invalid_models_tests.Model.rel' "
- "clashes with field name 'invalid_models_tests.Target.model'.",
- hint=(
- "Rename field 'invalid_models_tests.Target.model', or "
- "add/change a related_name argument to the definition for "
- "field 'invalid_models_tests.Model.rel'."
- ),
- obj=Model._meta.get_field("rel"),
- id="fields.E303",
- ),
- ],
- )
- @modify_settings(INSTALLED_APPS={"append": "basic"})
- @isolate_apps("basic", "invalid_models_tests")
- def test_no_clash_across_apps_without_accessor(self):
- class Target(models.Model):
- class Meta:
- app_label = "invalid_models_tests"
- class Model(models.Model):
- m2m = models.ManyToManyField(Target, related_name="+")
- class Meta:
- app_label = "basic"
- def _test():
- # Define model with the same name.
- class Model(models.Model):
- m2m = models.ManyToManyField(Target, related_name="+")
- class Meta:
- app_label = "invalid_models_tests"
- self.assertEqual(Model.check(), [])
- _test()
- self.assertEqual(Model.check(), [])
- @isolate_apps("invalid_models_tests")
- class ExplicitRelatedNameClashTests(SimpleTestCase):
- def test_fk_to_integer(self):
- self._test_explicit_related_name_clash(
- target=models.IntegerField(),
- relative=models.ForeignKey("Target", models.CASCADE, related_name="clash"),
- )
- def test_fk_to_fk(self):
- self._test_explicit_related_name_clash(
- target=models.ForeignKey("Another", models.CASCADE),
- relative=models.ForeignKey("Target", models.CASCADE, related_name="clash"),
- )
- def test_fk_to_m2m(self):
- self._test_explicit_related_name_clash(
- target=models.ManyToManyField("Another"),
- relative=models.ForeignKey("Target", models.CASCADE, related_name="clash"),
- )
- def test_m2m_to_integer(self):
- self._test_explicit_related_name_clash(
- target=models.IntegerField(),
- relative=models.ManyToManyField("Target", related_name="clash"),
- )
- def test_m2m_to_fk(self):
- self._test_explicit_related_name_clash(
- target=models.ForeignKey("Another", models.CASCADE),
- relative=models.ManyToManyField("Target", related_name="clash"),
- )
- def test_m2m_to_m2m(self):
- self._test_explicit_related_name_clash(
- target=models.ManyToManyField("Another"),
- relative=models.ManyToManyField("Target", related_name="clash"),
- )
- def _test_explicit_related_name_clash(self, target, relative):
- class Another(models.Model):
- pass
- class Target(models.Model):
- clash = target
- class Model(models.Model):
- rel = relative
- self.assertEqual(
- Model.check(),
- [
- Error(
- "Reverse accessor 'Target.clash' for "
- "'invalid_models_tests.Model.rel' clashes with field name "
- "'invalid_models_tests.Target.clash'.",
- hint=(
- "Rename field 'invalid_models_tests.Target.clash', or "
- "add/change a related_name argument to the definition for "
- "field 'invalid_models_tests.Model.rel'."
- ),
- obj=Model._meta.get_field("rel"),
- id="fields.E302",
- ),
- Error(
- "Reverse query name for 'invalid_models_tests.Model.rel' "
- "clashes with field name 'invalid_models_tests.Target.clash'.",
- hint=(
- "Rename field 'invalid_models_tests.Target.clash', or "
- "add/change a related_name argument to the definition for "
- "field 'invalid_models_tests.Model.rel'."
- ),
- obj=Model._meta.get_field("rel"),
- id="fields.E303",
- ),
- ],
- )
- @isolate_apps("invalid_models_tests")
- class ExplicitRelatedQueryNameClashTests(SimpleTestCase):
- def test_fk_to_integer(self, related_name=None):
- self._test_explicit_related_query_name_clash(
- target=models.IntegerField(),
- relative=models.ForeignKey(
- "Target",
- models.CASCADE,
- related_name=related_name,
- related_query_name="clash",
- ),
- )
- def test_hidden_fk_to_integer(self, related_name=None):
- self.test_fk_to_integer(related_name="+")
- def test_fk_to_fk(self, related_name=None):
- self._test_explicit_related_query_name_clash(
- target=models.ForeignKey("Another", models.CASCADE),
- relative=models.ForeignKey(
- "Target",
- models.CASCADE,
- related_name=related_name,
- related_query_name="clash",
- ),
- )
- def test_hidden_fk_to_fk(self):
- self.test_fk_to_fk(related_name="+")
- def test_fk_to_m2m(self, related_name=None):
- self._test_explicit_related_query_name_clash(
- target=models.ManyToManyField("Another"),
- relative=models.ForeignKey(
- "Target",
- models.CASCADE,
- related_name=related_name,
- related_query_name="clash",
- ),
- )
- def test_hidden_fk_to_m2m(self):
- self.test_fk_to_m2m(related_name="+")
- def test_m2m_to_integer(self, related_name=None):
- self._test_explicit_related_query_name_clash(
- target=models.IntegerField(),
- relative=models.ManyToManyField(
- "Target", related_name=related_name, related_query_name="clash"
- ),
- )
- def test_hidden_m2m_to_integer(self):
- self.test_m2m_to_integer(related_name="+")
- def test_m2m_to_fk(self, related_name=None):
- self._test_explicit_related_query_name_clash(
- target=models.ForeignKey("Another", models.CASCADE),
- relative=models.ManyToManyField(
- "Target", related_name=related_name, related_query_name="clash"
- ),
- )
- def test_hidden_m2m_to_fk(self):
- self.test_m2m_to_fk(related_name="+")
- def test_m2m_to_m2m(self, related_name=None):
- self._test_explicit_related_query_name_clash(
- target=models.ManyToManyField("Another"),
- relative=models.ManyToManyField(
- "Target",
- related_name=related_name,
- related_query_name="clash",
- ),
- )
- def test_hidden_m2m_to_m2m(self):
- self.test_m2m_to_m2m(related_name="+")
- def _test_explicit_related_query_name_clash(self, target, relative):
- class Another(models.Model):
- pass
- class Target(models.Model):
- clash = target
- class Model(models.Model):
- rel = relative
- self.assertEqual(
- Model.check(),
- [
- Error(
- "Reverse query name for 'invalid_models_tests.Model.rel' "
- "clashes with field name 'invalid_models_tests.Target.clash'.",
- hint=(
- "Rename field 'invalid_models_tests.Target.clash', or "
- "add/change a related_name argument to the definition for "
- "field 'invalid_models_tests.Model.rel'."
- ),
- obj=Model._meta.get_field("rel"),
- id="fields.E303",
- ),
- ],
- )
- @isolate_apps("invalid_models_tests")
- class SelfReferentialM2MClashTests(SimpleTestCase):
- def test_clash_between_accessors(self):
- class Model(models.Model):
- first_m2m = models.ManyToManyField("self", symmetrical=False)
- second_m2m = models.ManyToManyField("self", symmetrical=False)
- self.assertEqual(
- Model.check(),
- [
- Error(
- "Reverse accessor 'Model.model_set' for "
- "'invalid_models_tests.Model.first_m2m' clashes with reverse "
- "accessor for 'invalid_models_tests.Model.second_m2m'.",
- hint=(
- "Add or change a related_name argument to the definition "
- "for 'invalid_models_tests.Model.first_m2m' or "
- "'invalid_models_tests.Model.second_m2m'."
- ),
- obj=Model._meta.get_field("first_m2m"),
- id="fields.E304",
- ),
- Error(
- "Reverse accessor 'Model.model_set' for "
- "'invalid_models_tests.Model.second_m2m' clashes with reverse "
- "accessor for 'invalid_models_tests.Model.first_m2m'.",
- hint=(
- "Add or change a related_name argument to the definition "
- "for 'invalid_models_tests.Model.second_m2m' or "
- "'invalid_models_tests.Model.first_m2m'."
- ),
- obj=Model._meta.get_field("second_m2m"),
- id="fields.E304",
- ),
- ],
- )
- def test_accessor_clash(self):
- class Model(models.Model):
- model_set = models.ManyToManyField("self", symmetrical=False)
- self.assertEqual(
- Model.check(),
- [
- Error(
- "Reverse accessor 'Model.model_set' for "
- "'invalid_models_tests.Model.model_set' clashes with field "
- "name 'invalid_models_tests.Model.model_set'.",
- hint=(
- "Rename field 'invalid_models_tests.Model.model_set', or "
- "add/change a related_name argument to the definition for "
- "field 'invalid_models_tests.Model.model_set'."
- ),
- obj=Model._meta.get_field("model_set"),
- id="fields.E302",
- ),
- ],
- )
- def test_reverse_query_name_clash(self):
- class Model(models.Model):
- model = models.ManyToManyField("self", symmetrical=False)
- self.assertEqual(
- Model.check(),
- [
- Error(
- "Reverse query name for 'invalid_models_tests.Model.model' "
- "clashes with field name 'invalid_models_tests.Model.model'.",
- hint=(
- "Rename field 'invalid_models_tests.Model.model', or "
- "add/change a related_name argument to the definition for "
- "field 'invalid_models_tests.Model.model'."
- ),
- obj=Model._meta.get_field("model"),
- id="fields.E303",
- ),
- ],
- )
- def test_clash_under_explicit_related_name(self):
- class Model(models.Model):
- clash = models.IntegerField()
- m2m = models.ManyToManyField(
- "self", symmetrical=False, related_name="clash"
- )
- self.assertEqual(
- Model.check(),
- [
- Error(
- "Reverse accessor 'Model.clash' for "
- "'invalid_models_tests.Model.m2m' clashes with field name "
- "'invalid_models_tests.Model.clash'.",
- hint=(
- "Rename field 'invalid_models_tests.Model.clash', or "
- "add/change a related_name argument to the definition for "
- "field 'invalid_models_tests.Model.m2m'."
- ),
- obj=Model._meta.get_field("m2m"),
- id="fields.E302",
- ),
- Error(
- "Reverse query name for 'invalid_models_tests.Model.m2m' "
- "clashes with field name 'invalid_models_tests.Model.clash'.",
- hint=(
- "Rename field 'invalid_models_tests.Model.clash', or "
- "add/change a related_name argument to the definition for "
- "field 'invalid_models_tests.Model.m2m'."
- ),
- obj=Model._meta.get_field("m2m"),
- id="fields.E303",
- ),
- ],
- )
- def test_valid_model(self):
- class Model(models.Model):
- first = models.ManyToManyField(
- "self", symmetrical=False, related_name="first_accessor"
- )
- second = models.ManyToManyField(
- "self", symmetrical=False, related_name="second_accessor"
- )
- self.assertEqual(Model.check(), [])
- @isolate_apps("invalid_models_tests")
- class SelfReferentialFKClashTests(SimpleTestCase):
- def test_accessor_clash(self):
- class Model(models.Model):
- model_set = models.ForeignKey("Model", models.CASCADE)
- self.assertEqual(
- Model.check(),
- [
- Error(
- "Reverse accessor 'Model.model_set' for "
- "'invalid_models_tests.Model.model_set' clashes with field "
- "name 'invalid_models_tests.Model.model_set'.",
- hint=(
- "Rename field 'invalid_models_tests.Model.model_set', or "
- "add/change a related_name argument to the definition for "
- "field 'invalid_models_tests.Model.model_set'."
- ),
- obj=Model._meta.get_field("model_set"),
- id="fields.E302",
- ),
- ],
- )
- def test_reverse_query_name_clash(self):
- class Model(models.Model):
- model = models.ForeignKey("Model", models.CASCADE)
- self.assertEqual(
- Model.check(),
- [
- Error(
- "Reverse query name for 'invalid_models_tests.Model.model' "
- "clashes with field name 'invalid_models_tests.Model.model'.",
- hint=(
- "Rename field 'invalid_models_tests.Model.model', or "
- "add/change a related_name argument to the definition for "
- "field 'invalid_models_tests.Model.model'."
- ),
- obj=Model._meta.get_field("model"),
- id="fields.E303",
- ),
- ],
- )
- def test_clash_under_explicit_related_name(self):
- class Model(models.Model):
- clash = models.CharField(max_length=10)
- foreign = models.ForeignKey("Model", models.CASCADE, related_name="clash")
- self.assertEqual(
- Model.check(),
- [
- Error(
- "Reverse accessor 'Model.clash' for "
- "'invalid_models_tests.Model.foreign' clashes with field name "
- "'invalid_models_tests.Model.clash'.",
- hint=(
- "Rename field 'invalid_models_tests.Model.clash', or "
- "add/change a related_name argument to the definition for "
- "field 'invalid_models_tests.Model.foreign'."
- ),
- obj=Model._meta.get_field("foreign"),
- id="fields.E302",
- ),
- Error(
- "Reverse query name for 'invalid_models_tests.Model.foreign' "
- "clashes with field name 'invalid_models_tests.Model.clash'.",
- hint=(
- "Rename field 'invalid_models_tests.Model.clash', or "
- "add/change a related_name argument to the definition for "
- "field 'invalid_models_tests.Model.foreign'."
- ),
- obj=Model._meta.get_field("foreign"),
- id="fields.E303",
- ),
- ],
- )
- @isolate_apps("invalid_models_tests")
- class ComplexClashTests(SimpleTestCase):
- # New tests should not be included here, because this is a single,
- # self-contained sanity check, not a test of everything.
- def test_complex_clash(self):
- class Target(models.Model):
- tgt_safe = models.CharField(max_length=10)
- clash = models.CharField(max_length=10)
- model = models.CharField(max_length=10)
- clash1_set = models.CharField(max_length=10)
- class Model(models.Model):
- src_safe = models.CharField(max_length=10)
- foreign_1 = models.ForeignKey(Target, models.CASCADE, related_name="id")
- foreign_2 = models.ForeignKey(
- Target, models.CASCADE, related_name="src_safe"
- )
- m2m_1 = models.ManyToManyField(Target, related_name="id")
- m2m_2 = models.ManyToManyField(Target, related_name="src_safe")
- self.assertEqual(
- Model.check(),
- [
- Error(
- "Reverse accessor 'Target.id' for "
- "'invalid_models_tests.Model.foreign_1' clashes with field "
- "name 'invalid_models_tests.Target.id'.",
- hint=(
- "Rename field 'invalid_models_tests.Target.id', or "
- "add/change a related_name argument to the definition for "
- "field 'invalid_models_tests.Model.foreign_1'."
- ),
- obj=Model._meta.get_field("foreign_1"),
- id="fields.E302",
- ),
- Error(
- "Reverse query name for 'invalid_models_tests.Model.foreign_1' "
- "clashes with field name 'invalid_models_tests.Target.id'.",
- hint=(
- "Rename field 'invalid_models_tests.Target.id', or "
- "add/change a related_name argument to the definition for "
- "field 'invalid_models_tests.Model.foreign_1'."
- ),
- obj=Model._meta.get_field("foreign_1"),
- id="fields.E303",
- ),
- Error(
- "Reverse accessor 'Target.id' for "
- "'invalid_models_tests.Model.foreign_1' clashes with reverse "
- "accessor for 'invalid_models_tests.Model.m2m_1'.",
- hint=(
- "Add or change a related_name argument to the definition "
- "for 'invalid_models_tests.Model.foreign_1' or "
- "'invalid_models_tests.Model.m2m_1'."
- ),
- obj=Model._meta.get_field("foreign_1"),
- id="fields.E304",
- ),
- Error(
- "Reverse query name for 'invalid_models_tests.Model.foreign_1' "
- "clashes with reverse query name for "
- "'invalid_models_tests.Model.m2m_1'.",
- hint=(
- "Add or change a related_name argument to the definition "
- "for 'invalid_models_tests.Model.foreign_1' or "
- "'invalid_models_tests.Model.m2m_1'."
- ),
- obj=Model._meta.get_field("foreign_1"),
- id="fields.E305",
- ),
- Error(
- "Reverse accessor 'Target.src_safe' for "
- "'invalid_models_tests.Model.foreign_2' clashes with reverse "
- "accessor for 'invalid_models_tests.Model.m2m_2'.",
- hint=(
- "Add or change a related_name argument to the definition "
- "for 'invalid_models_tests.Model.foreign_2' or "
- "'invalid_models_tests.Model.m2m_2'."
- ),
- obj=Model._meta.get_field("foreign_2"),
- id="fields.E304",
- ),
- Error(
- "Reverse query name for 'invalid_models_tests.Model.foreign_2' "
- "clashes with reverse query name for "
- "'invalid_models_tests.Model.m2m_2'.",
- hint=(
- "Add or change a related_name argument to the definition "
- "for 'invalid_models_tests.Model.foreign_2' or "
- "'invalid_models_tests.Model.m2m_2'."
- ),
- obj=Model._meta.get_field("foreign_2"),
- id="fields.E305",
- ),
- Error(
- "Reverse accessor 'Target.id' for "
- "'invalid_models_tests.Model.m2m_1' clashes with field name "
- "'invalid_models_tests.Target.id'.",
- hint=(
- "Rename field 'invalid_models_tests.Target.id', or "
- "add/change a related_name argument to the definition for "
- "field 'invalid_models_tests.Model.m2m_1'."
- ),
- obj=Model._meta.get_field("m2m_1"),
- id="fields.E302",
- ),
- Error(
- "Reverse query name for 'invalid_models_tests.Model.m2m_1' "
- "clashes with field name 'invalid_models_tests.Target.id'.",
- hint=(
- "Rename field 'invalid_models_tests.Target.id', or "
- "add/change a related_name argument to the definition for "
- "field 'invalid_models_tests.Model.m2m_1'."
- ),
- obj=Model._meta.get_field("m2m_1"),
- id="fields.E303",
- ),
- Error(
- "Reverse accessor 'Target.id' for "
- "'invalid_models_tests.Model.m2m_1' clashes with reverse "
- "accessor for 'invalid_models_tests.Model.foreign_1'.",
- hint=(
- "Add or change a related_name argument to the definition "
- "for 'invalid_models_tests.Model.m2m_1' or "
- "'invalid_models_tests.Model.foreign_1'."
- ),
- obj=Model._meta.get_field("m2m_1"),
- id="fields.E304",
- ),
- Error(
- "Reverse query name for 'invalid_models_tests.Model.m2m_1' "
- "clashes with reverse query name for "
- "'invalid_models_tests.Model.foreign_1'.",
- hint=(
- "Add or change a related_name argument to the definition "
- "for 'invalid_models_tests.Model.m2m_1' or "
- "'invalid_models_tests.Model.foreign_1'."
- ),
- obj=Model._meta.get_field("m2m_1"),
- id="fields.E305",
- ),
- Error(
- "Reverse accessor 'Target.src_safe' for "
- "'invalid_models_tests.Model.m2m_2' clashes with reverse "
- "accessor for 'invalid_models_tests.Model.foreign_2'.",
- hint=(
- "Add or change a related_name argument to the definition "
- "for 'invalid_models_tests.Model.m2m_2' or "
- "'invalid_models_tests.Model.foreign_2'."
- ),
- obj=Model._meta.get_field("m2m_2"),
- id="fields.E304",
- ),
- Error(
- "Reverse query name for 'invalid_models_tests.Model.m2m_2' "
- "clashes with reverse query name for "
- "'invalid_models_tests.Model.foreign_2'.",
- hint=(
- "Add or change a related_name argument to the definition "
- "for 'invalid_models_tests.Model.m2m_2' or "
- "'invalid_models_tests.Model.foreign_2'."
- ),
- obj=Model._meta.get_field("m2m_2"),
- id="fields.E305",
- ),
- ],
- )
- def test_clash_parent_link(self):
- class Parent(models.Model):
- pass
- class Child(Parent):
- other_parent = models.OneToOneField(Parent, models.CASCADE)
- errors = [
- (
- "fields.E304",
- "accessor",
- " 'Parent.child'",
- "parent_ptr",
- "other_parent",
- ),
- ("fields.E305", "query name", "", "parent_ptr", "other_parent"),
- (
- "fields.E304",
- "accessor",
- " 'Parent.child'",
- "other_parent",
- "parent_ptr",
- ),
- ("fields.E305", "query name", "", "other_parent", "parent_ptr"),
- ]
- self.assertEqual(
- Child.check(),
- [
- Error(
- "Reverse %s%s for 'invalid_models_tests.Child.%s' clashes with "
- "reverse %s for 'invalid_models_tests.Child.%s'."
- % (attr, rel_name, field_name, attr, clash_name),
- hint=(
- "Add or change a related_name argument to the definition "
- "for 'invalid_models_tests.Child.%s' or "
- "'invalid_models_tests.Child.%s'." % (field_name, clash_name)
- ),
- obj=Child._meta.get_field(field_name),
- id=error_id,
- )
- for error_id, attr, rel_name, field_name, clash_name in errors
- ],
- )
- @isolate_apps("invalid_models_tests")
- class M2mThroughFieldsTests(SimpleTestCase):
- def test_m2m_field_argument_validation(self):
- """
- ManyToManyField accepts the ``through_fields`` kwarg
- only if an intermediary table is specified.
- """
- class Fan(models.Model):
- pass
- with self.assertRaisesMessage(
- ValueError, "Cannot specify through_fields without a through model"
- ):
- models.ManyToManyField(Fan, through_fields=("f1", "f2"))
- def test_invalid_order(self):
- """
- Mixing up the order of link fields to ManyToManyField.through_fields
- triggers validation errors.
- """
- class Fan(models.Model):
- pass
- class Event(models.Model):
- invitees = models.ManyToManyField(
- Fan, through="Invitation", through_fields=("invitee", "event")
- )
- class Invitation(models.Model):
- event = models.ForeignKey(Event, models.CASCADE)
- invitee = models.ForeignKey(Fan, models.CASCADE)
- inviter = models.ForeignKey(Fan, models.CASCADE, related_name="+")
- field = Event._meta.get_field("invitees")
- self.assertEqual(
- field.check(from_model=Event),
- [
- Error(
- "'Invitation.invitee' is not a foreign key to 'Event'.",
- hint=(
- "Did you mean one of the following foreign keys to 'Event': "
- "event?"
- ),
- obj=field,
- id="fields.E339",
- ),
- Error(
- "'Invitation.event' is not a foreign key to 'Fan'.",
- hint=(
- "Did you mean one of the following foreign keys to 'Fan': "
- "invitee, inviter?"
- ),
- obj=field,
- id="fields.E339",
- ),
- ],
- )
- def test_invalid_field(self):
- """
- Providing invalid field names to ManyToManyField.through_fields
- triggers validation errors.
- """
- class Fan(models.Model):
- pass
- class Event(models.Model):
- invitees = models.ManyToManyField(
- Fan,
- through="Invitation",
- through_fields=("invalid_field_1", "invalid_field_2"),
- )
- class Invitation(models.Model):
- event = models.ForeignKey(Event, models.CASCADE)
- invitee = models.ForeignKey(Fan, models.CASCADE)
- inviter = models.ForeignKey(Fan, models.CASCADE, related_name="+")
- field = Event._meta.get_field("invitees")
- self.assertEqual(
- field.check(from_model=Event),
- [
- Error(
- "The intermediary model 'invalid_models_tests.Invitation' has no "
- "field 'invalid_field_1'.",
- hint=(
- "Did you mean one of the following foreign keys to 'Event': "
- "event?"
- ),
- obj=field,
- id="fields.E338",
- ),
- Error(
- "The intermediary model 'invalid_models_tests.Invitation' has no "
- "field 'invalid_field_2'.",
- hint=(
- "Did you mean one of the following foreign keys to 'Fan': "
- "invitee, inviter?"
- ),
- obj=field,
- id="fields.E338",
- ),
- ],
- )
- def test_explicit_field_names(self):
- """
- If ``through_fields`` kwarg is given, it must specify both
- link fields of the intermediary table.
- """
- class Fan(models.Model):
- pass
- class Event(models.Model):
- invitees = models.ManyToManyField(
- Fan, through="Invitation", through_fields=(None, "invitee")
- )
- class Invitation(models.Model):
- event = models.ForeignKey(Event, models.CASCADE)
- invitee = models.ForeignKey(Fan, models.CASCADE)
- inviter = models.ForeignKey(Fan, models.CASCADE, related_name="+")
- field = Event._meta.get_field("invitees")
- self.assertEqual(
- field.check(from_model=Event),
- [
- Error(
- "Field specifies 'through_fields' but does not provide the names "
- "of the two link fields that should be used for the relation "
- "through model 'invalid_models_tests.Invitation'.",
- hint=(
- "Make sure you specify 'through_fields' as "
- "through_fields=('field1', 'field2')"
- ),
- obj=field,
- id="fields.E337",
- ),
- ],
- )
- def test_superset_foreign_object(self):
- class Parent(models.Model):
- a = models.PositiveIntegerField()
- b = models.PositiveIntegerField()
- c = models.PositiveIntegerField()
- class Meta:
- unique_together = (("a", "b", "c"),)
- class Child(models.Model):
- a = models.PositiveIntegerField()
- b = models.PositiveIntegerField()
- value = models.CharField(max_length=255)
- parent = models.ForeignObject(
- Parent,
- on_delete=models.SET_NULL,
- from_fields=("a", "b"),
- to_fields=("a", "b"),
- related_name="children",
- )
- field = Child._meta.get_field("parent")
- self.assertEqual(
- field.check(from_model=Child),
- [
- Error(
- "No subset of the fields 'a', 'b' on model 'Parent' is unique.",
- hint=(
- "Mark a single field as unique=True or add a set of "
- "fields to a unique constraint (via unique_together or a "
- "UniqueConstraint (without condition) in the model "
- "Meta.constraints)."
- ),
- obj=field,
- id="fields.E310",
- ),
- ],
- )
- def test_intersection_foreign_object(self):
- class Parent(models.Model):
- a = models.PositiveIntegerField()
- b = models.PositiveIntegerField()
- c = models.PositiveIntegerField()
- d = models.PositiveIntegerField()
- class Meta:
- unique_together = (("a", "b", "c"),)
- class Child(models.Model):
- a = models.PositiveIntegerField()
- b = models.PositiveIntegerField()
- d = models.PositiveIntegerField()
- value = models.CharField(max_length=255)
- parent = models.ForeignObject(
- Parent,
- on_delete=models.SET_NULL,
- from_fields=("a", "b", "d"),
- to_fields=("a", "b", "d"),
- related_name="children",
- )
- field = Child._meta.get_field("parent")
- self.assertEqual(
- field.check(from_model=Child),
- [
- Error(
- "No subset of the fields 'a', 'b', 'd' on model 'Parent' is "
- "unique.",
- hint=(
- "Mark a single field as unique=True or add a set of "
- "fields to a unique constraint (via unique_together or a "
- "UniqueConstraint (without condition) in the model "
- "Meta.constraints)."
- ),
- obj=field,
- id="fields.E310",
- ),
- ],
- )
|