Bladeren bron

Skip remaining python3 tests for swift contrib module.

Jelmer Vernooij 8 jaren geleden
bovenliggende
commit
03b55c97aa
3 gewijzigde bestanden met toevoegingen van 6 en 4 verwijderingen
  1. 3 0
      NEWS
  2. 2 4
      dulwich/contrib/swift.py
  3. 1 0
      dulwich/contrib/test_swift.py

+ 3 - 0
NEWS

@@ -5,6 +5,9 @@
   * Fix regression removing untouched refs when pushing over SSH.
     (Jelmer Vernooij #441)
 
+  * Skip Python3 tests for SWIFT contrib module, as it has not yet
+    been ported.
+
 0.14.0	2016-07-03
 
  BUG FIXES

+ 2 - 4
dulwich/contrib/swift.py

@@ -530,14 +530,14 @@ class SwiftPackReader(object):
         if self.base_offset + end > self.pack_length:
             data = self.buff[self.offset:]
             self.offset = end
-            return b"".join(data)
+            return data
         if end > len(self.buff):
             # Need to read more from swift
             self._read(more=True)
             return self.read(length)
         data = self.buff[self.offset:end]
         self.offset = end
-        return b"".join(data)
+        return data
 
     def seek(self, offset):
         """Seek to a specified offset
@@ -584,8 +584,6 @@ class SwiftPackData(PackData):
     def get_object_at(self, offset):
         if offset in self._offset_cache:
             return self._offset_cache[offset]
-        assert isinstance(offset, long) or isinstance(offset, int),\
-            'offset was %r' % offset
         assert offset >= self._header_size
         pack_reader = SwiftPackReader(self.scon, self._filename,
                                       self.pack_length)

+ 1 - 0
dulwich/contrib/test_swift.py

@@ -428,6 +428,7 @@ class TestSwiftRepo(TestCase):
 
 
 @skipIf(missing_libs, skipmsg)
+@skipIfPY3
 class TestPackInfoLoadDump(TestCase):
     def setUp(self):
         conf = swift.load_conf(file=StringIO(config_file %