Stop checking for ref validity client-side.

NEWS

@@ -2,6 +2,9 @@
 
  * Strip superfluous <> around email. (monnerat)
 
+ * Stop checking for ref validity client-side. Users can
+   still call check_wants manually. (Jelmer Vernooij)
+
 0.19.13	2019-08-19
 
  BUG FIXES

dulwich/client.py

@@ -832,7 +832,6 @@ class TraditionalGitClient(GitClient):
             if not wants:
                 proto.write_pkt_line(None)
                 return FetchPackResult(refs, symrefs, agent)
-            check_wants(wants, refs)
             (new_shallow, new_unshallow) = self._handle_upload_pack_head(
                 proto, negotiated_capabilities, graph_walker, wants, can_read,
                 depth=depth)
@@ -1652,7 +1651,6 @@ class HttpGitClient(GitClient):
             return FetchPackResult(refs, symrefs, agent)
         if self.dumb:
             raise NotImplementedError(self.send_pack)
-        check_wants(wants, refs)
         req_data = BytesIO()
         req_proto = Protocol(None, req_data.write)
         (new_shallow, new_unshallow) = self._handle_upload_pack_head(

dulwich/tests/test_client.py

@@ -193,20 +193,6 @@ class GitClientTests(TestCase):
         self.assertEqual({}, ret.symrefs)
         self.assertEqual(self.rout.getvalue(), b'0000')
 
-    def test_fetch_pack_sha_not_in_ref(self):
-        self.rin.write(
-            b'008855dcc6bf963f922e1ed5c4bbaaefcfacef57b1d7 HEAD\x00multi_ack '
-            b'thin-pack side-band side-band-64k ofs-delta shallow no-progress '
-            b'include-tag\n'
-            b'0000')
-        self.rin.seek(0)
-        self.assertRaises(
-                InvalidWants, self.client.fetch_pack,
-                b'bla',
-                lambda heads: ['aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'],
-                None, None,
-                None)
-
     def test_send_pack_no_sideband64k_with_update_ref_error(self):
         # No side-bank-64k reported by server shouldn't try to parse
         # side band data