Fix TypeError when passing refspec to clone()

Filter kwargs before passing to get_transport_and_path() to prevent
TypeError. The clone(), push(), and pull() functions accept **kwargs
that can include parameters like 'refspec' which are not accepted by
get_transport_and_path().

dulwich/porcelain.py

@@ -107,6 +107,7 @@ from typing import (
     Callable,
     Optional,
     TextIO,
+    TypedDict,
     TypeVar,
     Union,
     cast,
@@ -120,6 +121,8 @@ else:
     from typing_extensions import Buffer, override
 
 if TYPE_CHECKING:
+    import urllib3
+
     from .filter_branch import CommitData
     from .gc import GCStats
     from .maintenance import MaintenanceResult
@@ -229,6 +232,21 @@ T = TypeVar("T", bound="BaseRepo")
 RepoPath = Union[str, os.PathLike[str], Repo]
 
 
+class TransportKwargs(TypedDict, total=False):
+    """Keyword arguments accepted by get_transport_and_path."""
+
+    operation: Optional[str]
+    thin_packs: bool
+    report_activity: Optional[Callable[[int, str], None]]
+    quiet: bool
+    include_tags: bool
+    username: Optional[str]
+    password: Optional[str]
+    key_filename: Optional[str]
+    ssh_command: Optional[str]
+    pool_manager: Optional["urllib3.PoolManager"]
+
+
 @dataclass
 class CountObjectsResult:
     """Result of counting objects in a repository.
@@ -1054,6 +1072,30 @@ def init(
         return Repo.init(path, symlinks=symlinks)
 
 
+def _filter_transport_kwargs(**kwargs: object) -> TransportKwargs:
+    """Filter kwargs to only include parameters accepted by get_transport_and_path.
+
+    Args:
+      **kwargs: Arbitrary keyword arguments
+
+    Returns:
+      Dictionary containing only the kwargs that get_transport_and_path accepts
+    """
+    valid_params = {
+        "operation",
+        "thin_packs",
+        "report_activity",
+        "quiet",
+        "include_tags",
+        "username",
+        "password",
+        "key_filename",
+        "ssh_command",
+        "pool_manager",
+    }
+    return cast(TransportKwargs, {k: v for k, v in kwargs.items() if k in valid_params})
+
+
 def clone(
     source: Union[str, bytes, Repo],
     target: Optional[Union[str, os.PathLike[str]]] = None,
@@ -1134,7 +1176,10 @@ def clone(
         path = source.path
     else:
         source_str = source.decode() if isinstance(source, bytes) else source
-        (client, path) = get_transport_and_path(source_str, config=config, **kwargs)  # type: ignore[arg-type]
+        transport_kwargs = _filter_transport_kwargs(**kwargs)
+        (client, path) = get_transport_and_path(
+            source_str, config=config, **transport_kwargs
+        )
 
     filter_spec_bytes: Optional[bytes] = None
     if filter_spec:
@@ -2890,10 +2935,11 @@ def push(
                     refspecs_bytes.append(spec)
 
         # Get the client and path
+        transport_kwargs = _filter_transport_kwargs(**kwargs)
         client, path = get_transport_and_path(
             remote_location,
             config=r.get_config_stack(),
-            **kwargs,  # type: ignore[arg-type]
+            **transport_kwargs,
         )
 
         selected_refs = []
@@ -3058,10 +3104,11 @@ def pull(
                 and remote_refs[lh] not in r.object_store
             ]
 
+        transport_kwargs = _filter_transport_kwargs(**kwargs)
         client, path = get_transport_and_path(
             remote_location,
             config=r.get_config_stack(),
-            **kwargs,  # type: ignore[arg-type]
+            **transport_kwargs,
         )
         if filter_spec:
             filter_spec_bytes: Optional[bytes] = filter_spec.encode("ascii")

tests/test_porcelain.py

@@ -1492,6 +1492,34 @@ class CloneTests(PorcelainTestCase):
         with open(cloned_sub_file) as f:
             self.assertEqual(f.read(), "submodule content")
 
+    def test_clone_with_refspec_kwarg(self) -> None:
+        """Test that clone accepts refspec as a kwarg without TypeError.
+
+        This reproduces a bug where passing refspec as a kwarg to clone()
+        would cause a TypeError because it was being passed to
+        get_transport_and_path() which doesn't accept that parameter.
+        """
+        f1_1 = make_object(Blob, data=b"f1")
+        commit_spec = [[1]]
+        trees = {1: [(b"f1", f1_1)]}
+
+        (c1,) = build_commit_graph(self.repo.object_store, commit_spec, trees)
+        self.repo.refs[b"refs/heads/master"] = c1.id
+        target_path = tempfile.mkdtemp()
+        errstream = BytesIO()
+        self.addCleanup(shutil.rmtree, target_path)
+
+        # This should not raise TypeError
+        r = porcelain.clone(
+            self.repo.path,
+            target_path,
+            checkout=False,
+            errstream=errstream,
+            refspec="refs/heads/master",
+        )
+        self.addCleanup(r.close)
+        self.assertEqual(r.path, target_path)
+
 
 class InitTests(TestCase):
     def test_non_bare(self) -> None: