Browse Source

Merge pull request #1021 from jelmer/shutil-rmtree-gpgagent

Ignore errors when deleting GNUGPG home directory
Jelmer Vernooij 2 years ago
parent
commit
6b5f614d10
1 changed files with 4 additions and 1 deletions
  1. 4 1
      dulwich/tests/test_porcelain.py

+ 4 - 1
dulwich/tests/test_porcelain.py

@@ -277,7 +277,10 @@ ya6JVZCRbMXfdCy8lVPgtNQ6VlHaj8Wvnn2FLbWWO2n2r3s=
         super(PorcelainGpgTestCase, self).setUp()
         self.gpg_dir = os.path.join(self.test_dir, "gpg")
         os.mkdir(self.gpg_dir, mode=0o700)
-        self.addCleanup(shutil.rmtree, self.gpg_dir)
+        # Ignore errors when deleting GNUPGHOME, because of race conditions
+        # (e.g. the gpg-agent socket having been deleted). See
+        # https://github.com/jelmer/dulwich/issues/1000
+        self.addCleanup(shutil.rmtree, self.gpg_dir, ignore_errors=True)
         self._old_gnupghome = os.environ.get("GNUPGHOME")
         os.environ["GNUPGHOME"] = self.gpg_dir
         if self._old_gnupghome is None: