123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173 |
- # test_config.py -- Tests for reading and writing configuration files
- # Copyright (C) 2011 Jelmer Vernooij <jelmer@jelmer.uk>
- #
- # SPDX-License-Identifier: Apache-2.0 OR GPL-2.0-or-later
- # Dulwich is dual-licensed under the Apache License, Version 2.0 and the GNU
- # General Public License as public by the Free Software Foundation; version 2.0
- # or (at your option) any later version. You can redistribute it and/or
- # modify it under the terms of either of these two licenses.
- #
- # Unless required by applicable law or agreed to in writing, software
- # distributed under the License is distributed on an "AS IS" BASIS,
- # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- # See the License for the specific language governing permissions and
- # limitations under the License.
- #
- # You should have received a copy of the licenses; if not, see
- # <http://www.gnu.org/licenses/> for a copy of the GNU General Public License
- # and <http://www.apache.org/licenses/LICENSE-2.0> for a copy of the Apache
- # License, Version 2.0.
- #
- """Tests for reading and writing configuration files."""
- import os
- import sys
- import tempfile
- from io import BytesIO
- from unittest import skipIf
- from unittest.mock import patch
- from dulwich.config import (
- CaseInsensitiveOrderedMultiDict,
- ConfigDict,
- ConfigFile,
- StackedConfig,
- _check_section_name,
- _check_variable_name,
- _escape_value,
- _format_string,
- _parse_string,
- apply_instead_of,
- parse_submodules,
- )
- from . import TestCase
- class ConfigFileTests(TestCase):
- def from_file(self, text):
- return ConfigFile.from_file(BytesIO(text))
- def test_empty(self) -> None:
- ConfigFile()
- def test_eq(self) -> None:
- self.assertEqual(ConfigFile(), ConfigFile())
- def test_default_config(self) -> None:
- cf = self.from_file(
- b"""[core]
- \trepositoryformatversion = 0
- \tfilemode = true
- \tbare = false
- \tlogallrefupdates = true
- """
- )
- self.assertEqual(
- ConfigFile(
- {
- (b"core",): {
- b"repositoryformatversion": b"0",
- b"filemode": b"true",
- b"bare": b"false",
- b"logallrefupdates": b"true",
- }
- }
- ),
- cf,
- )
- def test_from_file_empty(self) -> None:
- cf = self.from_file(b"")
- self.assertEqual(ConfigFile(), cf)
- def test_empty_line_before_section(self) -> None:
- cf = self.from_file(b"\n[section]\n")
- self.assertEqual(ConfigFile({(b"section",): {}}), cf)
- def test_comment_before_section(self) -> None:
- cf = self.from_file(b"# foo\n[section]\n")
- self.assertEqual(ConfigFile({(b"section",): {}}), cf)
- def test_comment_after_section(self) -> None:
- cf = self.from_file(b"[section] # foo\n")
- self.assertEqual(ConfigFile({(b"section",): {}}), cf)
- def test_comment_after_variable(self) -> None:
- cf = self.from_file(b"[section]\nbar= foo # a comment\n")
- self.assertEqual(ConfigFile({(b"section",): {b"bar": b"foo"}}), cf)
- def test_comment_character_within_value_string(self) -> None:
- cf = self.from_file(b'[section]\nbar= "foo#bar"\n')
- self.assertEqual(ConfigFile({(b"section",): {b"bar": b"foo#bar"}}), cf)
- def test_comment_character_within_section_string(self) -> None:
- cf = self.from_file(b'[branch "foo#bar"] # a comment\nbar= foo\n')
- self.assertEqual(ConfigFile({(b"branch", b"foo#bar"): {b"bar": b"foo"}}), cf)
- def test_closing_bracket_within_section_string(self) -> None:
- cf = self.from_file(b'[branch "foo]bar"] # a comment\nbar= foo\n')
- self.assertEqual(ConfigFile({(b"branch", b"foo]bar"): {b"bar": b"foo"}}), cf)
- def test_from_file_section(self) -> None:
- cf = self.from_file(b"[core]\nfoo = bar\n")
- self.assertEqual(b"bar", cf.get((b"core",), b"foo"))
- self.assertEqual(b"bar", cf.get((b"core", b"foo"), b"foo"))
- def test_from_file_multiple(self) -> None:
- cf = self.from_file(b"[core]\nfoo = bar\nfoo = blah\n")
- self.assertEqual([b"bar", b"blah"], list(cf.get_multivar((b"core",), b"foo")))
- self.assertEqual([], list(cf.get_multivar((b"core",), b"blah")))
- def test_from_file_utf8_bom(self) -> None:
- text = "[core]\nfoo = b\u00e4r\n".encode("utf-8-sig")
- cf = self.from_file(text)
- self.assertEqual(b"b\xc3\xa4r", cf.get((b"core",), b"foo"))
- def test_from_file_section_case_insensitive_lower(self) -> None:
- cf = self.from_file(b"[cOre]\nfOo = bar\n")
- self.assertEqual(b"bar", cf.get((b"core",), b"foo"))
- self.assertEqual(b"bar", cf.get((b"core", b"foo"), b"foo"))
- def test_from_file_section_case_insensitive_mixed(self) -> None:
- cf = self.from_file(b"[cOre]\nfOo = bar\n")
- self.assertEqual(b"bar", cf.get((b"core",), b"fOo"))
- self.assertEqual(b"bar", cf.get((b"cOre", b"fOo"), b"fOo"))
- def test_from_file_with_mixed_quoted(self) -> None:
- cf = self.from_file(b'[core]\nfoo = "bar"la\n')
- self.assertEqual(b"barla", cf.get((b"core",), b"foo"))
- def test_from_file_section_with_open_brackets(self) -> None:
- self.assertRaises(ValueError, self.from_file, b"[core\nfoo = bar\n")
- def test_from_file_value_with_open_quoted(self) -> None:
- self.assertRaises(ValueError, self.from_file, b'[core]\nfoo = "bar\n')
- def test_from_file_with_quotes(self) -> None:
- cf = self.from_file(b'[core]\nfoo = " bar"\n')
- self.assertEqual(b" bar", cf.get((b"core",), b"foo"))
- def test_from_file_with_interrupted_line(self) -> None:
- cf = self.from_file(b"[core]\nfoo = bar\\\n la\n")
- self.assertEqual(b"barla", cf.get((b"core",), b"foo"))
- def test_from_file_with_boolean_setting(self) -> None:
- cf = self.from_file(b"[core]\nfoo\n")
- self.assertEqual(b"true", cf.get((b"core",), b"foo"))
- def test_from_file_subsection(self) -> None:
- cf = self.from_file(b'[branch "foo"]\nfoo = bar\n')
- self.assertEqual(b"bar", cf.get((b"branch", b"foo"), b"foo"))
- def test_from_file_subsection_invalid(self) -> None:
- self.assertRaises(ValueError, self.from_file, b'[branch "foo]\nfoo = bar\n')
- def test_from_file_subsection_not_quoted(self) -> None:
- cf = self.from_file(b"[branch.foo]\nfoo = bar\n")
- self.assertEqual(b"bar", cf.get((b"branch", b"foo"), b"foo"))
- def test_from_file_includeif_hasconfig(self) -> None:
- """Test parsing includeIf sections with hasconfig conditions."""
- # Test case from issue #1216
- cf = self.from_file(
- b'[includeIf "hasconfig:remote.*.url:ssh://org-*@github.com/**"]\n'
- b" path = ~/.config/git/.work\n"
- )
- self.assertEqual(
- b"~/.config/git/.work",
- cf.get(
- (b"includeIf", b"hasconfig:remote.*.url:ssh://org-*@github.com/**"),
- b"path",
- ),
- )
- def test_write_preserve_multivar(self) -> None:
- cf = self.from_file(b"[core]\nfoo = bar\nfoo = blah\n")
- f = BytesIO()
- cf.write_to_file(f)
- self.assertEqual(b"[core]\n\tfoo = bar\n\tfoo = blah\n", f.getvalue())
- def test_write_to_file_empty(self) -> None:
- c = ConfigFile()
- f = BytesIO()
- c.write_to_file(f)
- self.assertEqual(b"", f.getvalue())
- def test_write_to_file_section(self) -> None:
- c = ConfigFile()
- c.set((b"core",), b"foo", b"bar")
- f = BytesIO()
- c.write_to_file(f)
- self.assertEqual(b"[core]\n\tfoo = bar\n", f.getvalue())
- def test_write_to_file_section_multiple(self) -> None:
- c = ConfigFile()
- c.set((b"core",), b"foo", b"old")
- c.set((b"core",), b"foo", b"new")
- f = BytesIO()
- c.write_to_file(f)
- self.assertEqual(b"[core]\n\tfoo = new\n", f.getvalue())
- def test_write_to_file_subsection(self) -> None:
- c = ConfigFile()
- c.set((b"branch", b"blie"), b"foo", b"bar")
- f = BytesIO()
- c.write_to_file(f)
- self.assertEqual(b'[branch "blie"]\n\tfoo = bar\n', f.getvalue())
- def test_same_line(self) -> None:
- cf = self.from_file(b"[branch.foo] foo = bar\n")
- self.assertEqual(b"bar", cf.get((b"branch", b"foo"), b"foo"))
- def test_quoted_newlines_windows(self) -> None:
- cf = self.from_file(
- b"[alias]\r\n"
- b"c = '!f() { \\\r\n"
- b' printf \'[git commit -m \\"%s\\"]\\n\' \\"$*\\" && \\\r\n'
- b' git commit -m \\"$*\\"; \\\r\n'
- b" }; f'\r\n"
- )
- self.assertEqual(list(cf.sections()), [(b"alias",)])
- self.assertEqual(
- b'\'!f() { printf \'[git commit -m "%s"]\n\' "$*" && git commit -m "$*"',
- cf.get((b"alias",), b"c"),
- )
- def test_quoted(self) -> None:
- cf = self.from_file(
- b"""[gui]
- \tfontdiff = -family \\\"Ubuntu Mono\\\" -size 11 -overstrike 0
- """
- )
- self.assertEqual(
- ConfigFile(
- {
- (b"gui",): {
- b"fontdiff": b'-family "Ubuntu Mono" -size 11 -overstrike 0',
- }
- }
- ),
- cf,
- )
- def test_quoted_multiline(self) -> None:
- cf = self.from_file(
- b"""[alias]
- who = \"!who() {\\
- git log --no-merges --pretty=format:'%an - %ae' $@ | uniq -c | sort -rn;\\
- };\\
- who\"
- """
- )
- self.assertEqual(
- ConfigFile(
- {
- (b"alias",): {
- b"who": (
- b"!who() {git log --no-merges --pretty=format:'%an - "
- b"%ae' $@ | uniq -c | sort -rn;};who"
- )
- }
- }
- ),
- cf,
- )
- def test_set_hash_gets_quoted(self) -> None:
- c = ConfigFile()
- c.set(b"xandikos", b"color", b"#665544")
- f = BytesIO()
- c.write_to_file(f)
- self.assertEqual(b'[xandikos]\n\tcolor = "#665544"\n', f.getvalue())
- def test_windows_path_with_trailing_backslash_unquoted(self) -> None:
- """Test that Windows paths ending with escaped backslash are handled correctly."""
- # This reproduces the issue from https://github.com/jelmer/dulwich/issues/1088
- # A single backslash at the end should actually be a line continuation in strict Git config
- # But we want to be more tolerant like Git itself
- cf = self.from_file(
- b'[core]\n\trepositoryformatversion = 0\n[remote "origin"]\n\turl = C:/Users/test\\\\\n\tfetch = +refs/heads/*:refs/remotes/origin/*\n'
- )
- self.assertEqual(b"C:/Users/test\\", cf.get((b"remote", b"origin"), b"url"))
- self.assertEqual(
- b"+refs/heads/*:refs/remotes/origin/*",
- cf.get((b"remote", b"origin"), b"fetch"),
- )
- def test_windows_path_with_trailing_backslash_quoted(self) -> None:
- """Test that quoted Windows paths with escaped backslashes work correctly."""
- cf = self.from_file(
- b'[core]\n\trepositoryformatversion = 0\n[remote "origin"]\n\turl = "C:\\\\Users\\\\test\\\\"\n\tfetch = +refs/heads/*:refs/remotes/origin/*\n'
- )
- self.assertEqual(b"C:\\Users\\test\\", cf.get((b"remote", b"origin"), b"url"))
- self.assertEqual(
- b"+refs/heads/*:refs/remotes/origin/*",
- cf.get((b"remote", b"origin"), b"fetch"),
- )
- def test_single_backslash_at_line_end_shows_proper_escaping_needed(self) -> None:
- """Test that demonstrates proper escaping is needed for single backslashes."""
- # This test documents the current behavior: a single backslash at the end of a line
- # is treated as a line continuation per Git config spec. Users should escape backslashes.
- # This reproduces the original issue - single backslash causes line continuation
- cf = self.from_file(
- b'[remote "origin"]\n\turl = C:/Users/test\\\n\tfetch = +refs/heads/*:refs/remotes/origin/*\n'
- )
- # The result shows that line continuation occurred
- self.assertEqual(
- b"C:/Users/testfetch = +refs/heads/*:refs/remotes/origin/*",
- cf.get((b"remote", b"origin"), b"url"),
- )
- # The proper way to include a literal backslash is to escape it
- cf2 = self.from_file(
- b'[remote "origin"]\n\turl = C:/Users/test\\\\\n\tfetch = +refs/heads/*:refs/remotes/origin/*\n'
- )
- self.assertEqual(b"C:/Users/test\\", cf2.get((b"remote", b"origin"), b"url"))
- self.assertEqual(
- b"+refs/heads/*:refs/remotes/origin/*",
- cf2.get((b"remote", b"origin"), b"fetch"),
- )
- def test_from_path_pathlib(self) -> None:
- import tempfile
- from pathlib import Path
- # Create a temporary config file
- with tempfile.NamedTemporaryFile(mode="w", suffix=".config", delete=False) as f:
- f.write("[core]\n filemode = true\n")
- temp_path = f.name
- self.addCleanup(os.unlink, temp_path)
- # Test with pathlib.Path
- path_obj = Path(temp_path)
- cf = ConfigFile.from_path(path_obj)
- self.assertEqual(cf.get((b"core",), b"filemode"), b"true")
- def test_write_to_path_pathlib(self) -> None:
- import tempfile
- from pathlib import Path
- # Create a config
- cf = ConfigFile()
- cf.set((b"user",), b"name", b"Test User")
- # Write to pathlib.Path
- with tempfile.NamedTemporaryFile(suffix=".config", delete=False) as f:
- temp_path = f.name
- try:
- path_obj = Path(temp_path)
- cf.write_to_path(path_obj)
- # Read it back
- cf2 = ConfigFile.from_path(path_obj)
- self.assertEqual(cf2.get((b"user",), b"name"), b"Test User")
- finally:
- # Clean up
- os.unlink(temp_path)
- def test_include_basic(self) -> None:
- """Test basic include functionality."""
- with tempfile.TemporaryDirectory() as tmpdir:
- # Create included config file
- included_path = os.path.join(tmpdir, "included.config")
- with open(included_path, "wb") as f:
- f.write(
- b"[user]\n name = Included User\n email = included@example.com\n"
- )
- # Create main config with include
- main_config = self.from_file(
- b"[user]\n name = Main User\n[include]\n path = included.config\n"
- )
- # Should not include anything without proper directory context
- self.assertEqual(b"Main User", main_config.get((b"user",), b"name"))
- with self.assertRaises(KeyError):
- main_config.get((b"user",), b"email")
- # Now test with proper file loading
- main_path = os.path.join(tmpdir, "main.config")
- with open(main_path, "wb") as f:
- f.write(
- b"[user]\n name = Main User\n[include]\n path = included.config\n"
- )
- # Load from path to get include functionality
- cf = ConfigFile.from_path(main_path)
- self.assertEqual(b"Included User", cf.get((b"user",), b"name"))
- self.assertEqual(b"included@example.com", cf.get((b"user",), b"email"))
- def test_include_absolute_path(self) -> None:
- """Test include with absolute path."""
- with tempfile.TemporaryDirectory() as tmpdir:
- # Use realpath to resolve any symlinks (important on macOS and Windows)
- tmpdir = os.path.realpath(tmpdir)
- # Create included config file
- included_path = os.path.join(tmpdir, "included.config")
- with open(included_path, "wb") as f:
- f.write(b"[core]\n bare = true\n")
- # Create main config with absolute include path
- main_path = os.path.join(tmpdir, "main.config")
- with open(main_path, "wb") as f:
- # Properly escape backslashes in Windows paths
- escaped_path = included_path.replace("\\", "\\\\")
- f.write(f"[include]\n path = {escaped_path}\n".encode())
- cf = ConfigFile.from_path(main_path)
- self.assertEqual(b"true", cf.get((b"core",), b"bare"))
- def test_includeif_hasconfig(self) -> None:
- """Test includeIf with hasconfig conditions."""
- with tempfile.TemporaryDirectory() as tmpdir:
- # Create included config file
- work_included_path = os.path.join(tmpdir, "work.config")
- with open(work_included_path, "wb") as f:
- f.write(b"[user]\n email = work@company.com\n")
- personal_included_path = os.path.join(tmpdir, "personal.config")
- with open(personal_included_path, "wb") as f:
- f.write(b"[user]\n email = personal@example.com\n")
- # Create main config with hasconfig conditions
- main_path = os.path.join(tmpdir, "main.config")
- with open(main_path, "wb") as f:
- f.write(
- b'[remote "origin"]\n'
- b" url = ssh://org-work@github.com/company/project\n"
- b'[includeIf "hasconfig:remote.*.url:ssh://org-*@github.com/**"]\n'
- b" path = work.config\n"
- b'[includeIf "hasconfig:remote.*.url:https://github.com/opensource/**"]\n'
- b" path = personal.config\n"
- )
- # Load config - should match the work config due to org-work remote
- # The second condition won't match since url doesn't have /opensource/ path
- cf = ConfigFile.from_path(main_path)
- self.assertEqual(b"work@company.com", cf.get((b"user",), b"email"))
- def test_includeif_hasconfig_wildcard(self) -> None:
- """Test includeIf hasconfig with wildcard patterns."""
- with tempfile.TemporaryDirectory() as tmpdir:
- # Create included config
- included_path = os.path.join(tmpdir, "included.config")
- with open(included_path, "wb") as f:
- f.write(b"[user]\n name = IncludedUser\n")
- # Create main config with hasconfig condition using wildcards
- main_path = os.path.join(tmpdir, "main.config")
- with open(main_path, "wb") as f:
- f.write(
- b"[core]\n"
- b" autocrlf = true\n"
- b'[includeIf "hasconfig:core.autocrlf:true"]\n'
- b" path = included.config\n"
- )
- # Load config - should include based on core.autocrlf value
- cf = ConfigFile.from_path(main_path)
- self.assertEqual(b"IncludedUser", cf.get((b"user",), b"name"))
- def test_includeif_hasconfig_no_match(self) -> None:
- """Test includeIf hasconfig when condition doesn't match."""
- with tempfile.TemporaryDirectory() as tmpdir:
- # Create included config
- included_path = os.path.join(tmpdir, "included.config")
- with open(included_path, "wb") as f:
- f.write(b"[user]\n name = IncludedUser\n")
- # Create main config with non-matching hasconfig condition
- main_path = os.path.join(tmpdir, "main.config")
- with open(main_path, "wb") as f:
- f.write(
- b"[core]\n"
- b" autocrlf = false\n"
- b'[includeIf "hasconfig:core.autocrlf:true"]\n'
- b" path = included.config\n"
- )
- # Load config - should NOT include since condition doesn't match
- cf = ConfigFile.from_path(main_path)
- with self.assertRaises(KeyError):
- cf.get((b"user",), b"name")
- def test_include_circular(self) -> None:
- """Test that circular includes are handled properly."""
- with tempfile.TemporaryDirectory() as tmpdir:
- # Create two configs that include each other
- config1_path = os.path.join(tmpdir, "config1")
- config2_path = os.path.join(tmpdir, "config2")
- with open(config1_path, "wb") as f:
- f.write(b"[user]\n name = User1\n[include]\n path = config2\n")
- with open(config2_path, "wb") as f:
- f.write(
- b"[user]\n email = user2@example.com\n[include]\n path = config1\n"
- )
- # Should handle circular includes gracefully
- cf = ConfigFile.from_path(config1_path)
- self.assertEqual(b"User1", cf.get((b"user",), b"name"))
- self.assertEqual(b"user2@example.com", cf.get((b"user",), b"email"))
- def test_include_missing_file(self) -> None:
- """Test that missing include files are ignored."""
- with tempfile.TemporaryDirectory() as tmpdir:
- # Create config with include of non-existent file
- config_path = os.path.join(tmpdir, "config")
- with open(config_path, "wb") as f:
- f.write(
- b"[user]\n name = TestUser\n[include]\n path = missing.config\n"
- )
- # Should not fail, just ignore missing include
- cf = ConfigFile.from_path(config_path)
- self.assertEqual(b"TestUser", cf.get((b"user",), b"name"))
- def test_include_depth_limit(self) -> None:
- """Test that excessive include depth is prevented."""
- with tempfile.TemporaryDirectory() as tmpdir:
- # Create a chain of includes that exceeds depth limit
- for i in range(15):
- config_path = os.path.join(tmpdir, f"config{i}")
- with open(config_path, "wb") as f:
- if i == 0:
- f.write(b"[user]\n name = User0\n")
- f.write(f"[include]\n path = config{i + 1}\n".encode())
- # Should raise error due to depth limit
- with self.assertRaises(ValueError) as cm:
- ConfigFile.from_path(os.path.join(tmpdir, "config0"))
- self.assertIn("include depth", str(cm.exception))
- def test_include_with_custom_file_opener(self) -> None:
- """Test include functionality with a custom file opener for security."""
- with tempfile.TemporaryDirectory() as tmpdir:
- # Create config files
- included_path = os.path.join(tmpdir, "included.config")
- with open(included_path, "wb") as f:
- f.write(b"[user]\n email = custom@example.com\n")
- restricted_path = os.path.join(tmpdir, "restricted.config")
- with open(restricted_path, "wb") as f:
- f.write(b"[user]\n email = restricted@example.com\n")
- main_path = os.path.join(tmpdir, "main.config")
- with open(main_path, "wb") as f:
- f.write(b"[user]\n name = Test User\n")
- f.write(b"[include]\n path = included.config\n")
- f.write(b"[include]\n path = restricted.config\n")
- # Define a custom file opener that restricts access
- allowed_files = {included_path, main_path}
- def secure_file_opener(path):
- path_str = os.fspath(path)
- if path_str not in allowed_files:
- raise PermissionError(f"Access denied to {path}")
- return open(path_str, "rb")
- # Load config with restricted file access
- cf = ConfigFile.from_path(main_path, file_opener=secure_file_opener)
- # Should have the main config and included config, but not restricted
- self.assertEqual(b"Test User", cf.get((b"user",), b"name"))
- self.assertEqual(b"custom@example.com", cf.get((b"user",), b"email"))
- # Email from restricted.config should not be loaded
- def test_unknown_includeif_condition(self) -> None:
- """Test that unknown includeIf conditions are silently ignored (like Git)."""
- with tempfile.TemporaryDirectory() as tmpdir:
- # Create included config file
- included_path = os.path.join(tmpdir, "included.config")
- with open(included_path, "wb") as f:
- f.write(b"[user]\n email = included@example.com\n")
- # Create main config with unknown includeIf condition
- main_path = os.path.join(tmpdir, "main.config")
- with open(main_path, "wb") as f:
- f.write(b"[user]\n name = Main User\n")
- f.write(
- b'[includeIf "unknowncondition:foo"]\n path = included.config\n'
- )
- # Should not fail, just ignore the unknown condition
- cf = ConfigFile.from_path(main_path)
- self.assertEqual(b"Main User", cf.get((b"user",), b"name"))
- # Email should not be included because condition is unknown
- with self.assertRaises(KeyError):
- cf.get((b"user",), b"email")
- def test_missing_include_file_logging(self) -> None:
- """Test that missing include files are logged but don't cause failure."""
- import logging
- from io import StringIO
- # Set up logging capture
- log_capture = StringIO()
- handler = logging.StreamHandler(log_capture)
- handler.setLevel(logging.DEBUG)
- logger = logging.getLogger("dulwich.config")
- logger.addHandler(handler)
- logger.setLevel(logging.DEBUG)
- try:
- with tempfile.TemporaryDirectory() as tmpdir:
- config_path = os.path.join(tmpdir, "test.config")
- with open(config_path, "wb") as f:
- f.write(b"[user]\n name = Test User\n")
- f.write(b"[include]\n path = nonexistent.config\n")
- # Should not fail, just log
- cf = ConfigFile.from_path(config_path)
- self.assertEqual(b"Test User", cf.get((b"user",), b"name"))
- # Check that it was logged
- log_output = log_capture.getvalue()
- self.assertIn("Invalid include path", log_output)
- self.assertIn("nonexistent.config", log_output)
- finally:
- logger.removeHandler(handler)
- def test_invalid_include_path_logging(self) -> None:
- """Test that invalid include paths are logged but don't cause failure."""
- import logging
- from io import StringIO
- # Set up logging capture
- log_capture = StringIO()
- handler = logging.StreamHandler(log_capture)
- handler.setLevel(logging.DEBUG)
- logger = logging.getLogger("dulwich.config")
- logger.addHandler(handler)
- logger.setLevel(logging.DEBUG)
- try:
- with tempfile.TemporaryDirectory() as tmpdir:
- config_path = os.path.join(tmpdir, "test.config")
- with open(config_path, "wb") as f:
- f.write(b"[user]\n name = Test User\n")
- # Use null bytes which are invalid in paths
- f.write(b"[include]\n path = /invalid\x00path/file.config\n")
- # Should not fail, just log
- cf = ConfigFile.from_path(config_path)
- self.assertEqual(b"Test User", cf.get((b"user",), b"name"))
- # Check that it was logged
- log_output = log_capture.getvalue()
- self.assertIn("Invalid include path", log_output)
- finally:
- logger.removeHandler(handler)
- def test_unknown_includeif_condition_logging(self) -> None:
- """Test that unknown includeIf conditions are logged."""
- import logging
- from io import StringIO
- # Set up logging capture
- log_capture = StringIO()
- handler = logging.StreamHandler(log_capture)
- handler.setLevel(logging.DEBUG)
- logger = logging.getLogger("dulwich.config")
- logger.addHandler(handler)
- logger.setLevel(logging.DEBUG)
- try:
- with tempfile.TemporaryDirectory() as tmpdir:
- config_path = os.path.join(tmpdir, "test.config")
- with open(config_path, "wb") as f:
- f.write(b"[user]\n name = Test User\n")
- f.write(
- b'[includeIf "futurefeature:value"]\n path = other.config\n'
- )
- # Should not fail, just log
- cf = ConfigFile.from_path(config_path)
- self.assertEqual(b"Test User", cf.get((b"user",), b"name"))
- # Check that it was logged
- log_output = log_capture.getvalue()
- self.assertIn("Unknown includeIf condition", log_output)
- self.assertIn("futurefeature:value", log_output)
- finally:
- logger.removeHandler(handler)
- def test_custom_file_opener_with_include_depth(self) -> None:
- """Test that custom file opener is passed through include chain."""
- with tempfile.TemporaryDirectory() as tmpdir:
- # Use realpath to resolve any symlinks
- tmpdir = os.path.realpath(tmpdir)
- # Create a chain of includes
- final_config = os.path.join(tmpdir, "final.config")
- with open(final_config, "wb") as f:
- f.write(b"[feature]\n enabled = true\n")
- middle_config = os.path.join(tmpdir, "middle.config")
- with open(middle_config, "wb") as f:
- f.write(b"[user]\n email = test@example.com\n")
- escaped_final_config = final_config.replace("\\", "\\\\")
- f.write(f"[include]\n path = {escaped_final_config}\n".encode())
- main_config = os.path.join(tmpdir, "main.config")
- with open(main_config, "wb") as f:
- f.write(b"[user]\n name = Test User\n")
- escaped_middle_config = middle_config.replace("\\", "\\\\")
- f.write(f"[include]\n path = {escaped_middle_config}\n".encode())
- # Track file access order
- access_order = []
- def ordering_file_opener(path):
- path_str = os.fspath(path)
- access_order.append(os.path.basename(path_str))
- return open(path_str, "rb")
- # Load config
- cf = ConfigFile.from_path(main_config, file_opener=ordering_file_opener)
- # Verify all values were loaded
- self.assertEqual(b"Test User", cf.get((b"user",), b"name"))
- self.assertEqual(b"test@example.com", cf.get((b"user",), b"email"))
- self.assertEqual(b"true", cf.get((b"feature",), b"enabled"))
- # Verify access order
- self.assertEqual(
- ["main.config", "middle.config", "final.config"], access_order
- )
- class ConfigDictTests(TestCase):
- def test_get_set(self) -> None:
- cd = ConfigDict()
- self.assertRaises(KeyError, cd.get, b"foo", b"core")
- cd.set((b"core",), b"foo", b"bla")
- self.assertEqual(b"bla", cd.get((b"core",), b"foo"))
- cd.set((b"core",), b"foo", b"bloe")
- self.assertEqual(b"bloe", cd.get((b"core",), b"foo"))
- def test_get_boolean(self) -> None:
- cd = ConfigDict()
- cd.set((b"core",), b"foo", b"true")
- self.assertTrue(cd.get_boolean((b"core",), b"foo"))
- cd.set((b"core",), b"foo", b"false")
- self.assertFalse(cd.get_boolean((b"core",), b"foo"))
- cd.set((b"core",), b"foo", b"invalid")
- self.assertRaises(ValueError, cd.get_boolean, (b"core",), b"foo")
- def test_dict(self) -> None:
- cd = ConfigDict()
- cd.set((b"core",), b"foo", b"bla")
- cd.set((b"core2",), b"foo", b"bloe")
- self.assertEqual([(b"core",), (b"core2",)], list(cd.keys()))
- self.assertEqual(cd[(b"core",)], {b"foo": b"bla"})
- cd[b"a"] = b"b"
- self.assertEqual(cd[b"a"], b"b")
- def test_items(self) -> None:
- cd = ConfigDict()
- cd.set((b"core",), b"foo", b"bla")
- cd.set((b"core2",), b"foo", b"bloe")
- self.assertEqual([(b"foo", b"bla")], list(cd.items((b"core",))))
- def test_items_nonexistant(self) -> None:
- cd = ConfigDict()
- cd.set((b"core2",), b"foo", b"bloe")
- self.assertEqual([], list(cd.items((b"core",))))
- def test_sections(self) -> None:
- cd = ConfigDict()
- cd.set((b"core2",), b"foo", b"bloe")
- self.assertEqual([(b"core2",)], list(cd.sections()))
- def test_set_vs_add(self) -> None:
- cd = ConfigDict()
- # Test add() creates multivars
- cd.add((b"core",), b"foo", b"value1")
- cd.add((b"core",), b"foo", b"value2")
- self.assertEqual(
- [b"value1", b"value2"], list(cd.get_multivar((b"core",), b"foo"))
- )
- # Test set() replaces values
- cd.set((b"core",), b"foo", b"value3")
- self.assertEqual([b"value3"], list(cd.get_multivar((b"core",), b"foo")))
- self.assertEqual(b"value3", cd.get((b"core",), b"foo"))
- class StackedConfigTests(TestCase):
- def test_default_backends(self) -> None:
- StackedConfig.default_backends()
- @skipIf(sys.platform != "win32", "Windows specific config location.")
- def test_windows_config_from_path(self) -> None:
- from dulwich.config import get_win_system_paths
- install_dir = os.path.join("C:", "foo", "Git")
- self.overrideEnv("PATH", os.path.join(install_dir, "cmd"))
- with patch("os.path.exists", return_value=True):
- paths = set(get_win_system_paths())
- self.assertEqual(
- {
- os.path.join(os.environ.get("PROGRAMDATA"), "Git", "config"),
- os.path.join(install_dir, "etc", "gitconfig"),
- },
- paths,
- )
- @skipIf(sys.platform != "win32", "Windows specific config location.")
- def test_windows_config_from_reg(self) -> None:
- import winreg
- from dulwich.config import get_win_system_paths
- self.overrideEnv("PATH", None)
- install_dir = os.path.join("C:", "foo", "Git")
- with patch("winreg.OpenKey"):
- with patch(
- "winreg.QueryValueEx",
- return_value=(install_dir, winreg.REG_SZ),
- ):
- paths = set(get_win_system_paths())
- self.assertEqual(
- {
- os.path.join(os.environ.get("PROGRAMDATA"), "Git", "config"),
- os.path.join(install_dir, "etc", "gitconfig"),
- },
- paths,
- )
- class EscapeValueTests(TestCase):
- def test_nothing(self) -> None:
- self.assertEqual(b"foo", _escape_value(b"foo"))
- def test_backslash(self) -> None:
- self.assertEqual(b"foo\\\\", _escape_value(b"foo\\"))
- def test_newline(self) -> None:
- self.assertEqual(b"foo\\n", _escape_value(b"foo\n"))
- class FormatStringTests(TestCase):
- def test_quoted(self) -> None:
- self.assertEqual(b'" foo"', _format_string(b" foo"))
- self.assertEqual(b'"\\tfoo"', _format_string(b"\tfoo"))
- def test_not_quoted(self) -> None:
- self.assertEqual(b"foo", _format_string(b"foo"))
- self.assertEqual(b"foo bar", _format_string(b"foo bar"))
- class ParseStringTests(TestCase):
- def test_quoted(self) -> None:
- self.assertEqual(b" foo", _parse_string(b'" foo"'))
- self.assertEqual(b"\tfoo", _parse_string(b'"\\tfoo"'))
- def test_not_quoted(self) -> None:
- self.assertEqual(b"foo", _parse_string(b"foo"))
- self.assertEqual(b"foo bar", _parse_string(b"foo bar"))
- def test_nothing(self) -> None:
- self.assertEqual(b"", _parse_string(b""))
- def test_tab(self) -> None:
- self.assertEqual(b"\tbar\t", _parse_string(b"\\tbar\\t"))
- def test_newline(self) -> None:
- self.assertEqual(b"\nbar\t", _parse_string(b"\\nbar\\t\t"))
- def test_quote(self) -> None:
- self.assertEqual(b'"foo"', _parse_string(b'\\"foo\\"'))
- class CheckVariableNameTests(TestCase):
- def test_invalid(self) -> None:
- self.assertFalse(_check_variable_name(b"foo "))
- self.assertFalse(_check_variable_name(b"bar,bar"))
- self.assertFalse(_check_variable_name(b"bar.bar"))
- def test_valid(self) -> None:
- self.assertTrue(_check_variable_name(b"FOO"))
- self.assertTrue(_check_variable_name(b"foo"))
- self.assertTrue(_check_variable_name(b"foo-bar"))
- class CheckSectionNameTests(TestCase):
- def test_invalid(self) -> None:
- self.assertFalse(_check_section_name(b"foo "))
- self.assertFalse(_check_section_name(b"bar,bar"))
- def test_valid(self) -> None:
- self.assertTrue(_check_section_name(b"FOO"))
- self.assertTrue(_check_section_name(b"foo"))
- self.assertTrue(_check_section_name(b"foo-bar"))
- self.assertTrue(_check_section_name(b"bar.bar"))
- class SubmodulesTests(TestCase):
- def testSubmodules(self) -> None:
- cf = ConfigFile.from_file(
- BytesIO(
- b"""\
- [submodule "core/lib"]
- \tpath = core/lib
- \turl = https://github.com/phhusson/QuasselC.git
- """
- )
- )
- got = list(parse_submodules(cf))
- self.assertEqual(
- [
- (
- b"core/lib",
- b"https://github.com/phhusson/QuasselC.git",
- b"core/lib",
- )
- ],
- got,
- )
- def testMalformedSubmodules(self) -> None:
- cf = ConfigFile.from_file(
- BytesIO(
- b"""\
- [submodule "core/lib"]
- \tpath = core/lib
- \turl = https://github.com/phhusson/QuasselC.git
- [submodule "dulwich"]
- \turl = https://github.com/jelmer/dulwich
- """
- )
- )
- got = list(parse_submodules(cf))
- self.assertEqual(
- [
- (
- b"core/lib",
- b"https://github.com/phhusson/QuasselC.git",
- b"core/lib",
- )
- ],
- got,
- )
- class ApplyInsteadOfTests(TestCase):
- def test_none(self) -> None:
- config = ConfigDict()
- self.assertEqual(
- "https://example.com/", apply_instead_of(config, "https://example.com/")
- )
- def test_apply(self) -> None:
- config = ConfigDict()
- config.set(("url", "https://samba.org/"), "insteadOf", "https://example.com/")
- self.assertEqual(
- "https://samba.org/", apply_instead_of(config, "https://example.com/")
- )
- def test_apply_multiple(self) -> None:
- config = ConfigDict()
- config.add(("url", "https://samba.org/"), "insteadOf", "https://blah.com/")
- config.add(("url", "https://samba.org/"), "insteadOf", "https://example.com/")
- self.assertEqual(
- [b"https://blah.com/", b"https://example.com/"],
- list(config.get_multivar(("url", "https://samba.org/"), "insteadOf")),
- )
- self.assertEqual(
- "https://samba.org/", apply_instead_of(config, "https://example.com/")
- )
- def test_apply_preserves_case_in_subsection(self) -> None:
- """Test that mixed-case URLs (like those with access tokens) are preserved."""
- config = ConfigDict()
- # GitHub access tokens have mixed case that must be preserved
- url_with_token = "https://ghp_AbCdEfGhIjKlMnOpQrStUvWxYz1234567890@github.com/"
- config.set(("url", url_with_token), "insteadOf", "https://github.com/")
- # Apply the substitution
- result = apply_instead_of(config, "https://github.com/jelmer/dulwich.git")
- expected = "https://ghp_AbCdEfGhIjKlMnOpQrStUvWxYz1234567890@github.com/jelmer/dulwich.git"
- self.assertEqual(expected, result)
- # Verify the token case is preserved
- self.assertIn("ghp_AbCdEfGhIjKlMnOpQrStUvWxYz1234567890", result)
- class CaseInsensitiveConfigTests(TestCase):
- def test_case_insensitive(self) -> None:
- config = CaseInsensitiveOrderedMultiDict()
- config[("core",)] = "value"
- self.assertEqual("value", config[("CORE",)])
- self.assertEqual("value", config[("CoRe",)])
- self.assertEqual([("core",)], list(config.keys()))
- def test_multiple_set(self) -> None:
- config = CaseInsensitiveOrderedMultiDict()
- config[("core",)] = "value1"
- config[("core",)] = "value2"
- # The second set overwrites the first one
- self.assertEqual("value2", config[("core",)])
- self.assertEqual("value2", config[("CORE",)])
- def test_get_all(self) -> None:
- config = CaseInsensitiveOrderedMultiDict()
- config[("core",)] = "value1"
- config[("CORE",)] = "value2"
- config[("CoRe",)] = "value3"
- self.assertEqual(
- ["value1", "value2", "value3"], list(config.get_all(("core",)))
- )
- self.assertEqual(
- ["value1", "value2", "value3"], list(config.get_all(("CORE",)))
- )
- def test_delitem(self) -> None:
- config = CaseInsensitiveOrderedMultiDict()
- config[("core",)] = "value1"
- config[("CORE",)] = "value2"
- config[("other",)] = "value3"
- del config[("core",)]
- self.assertNotIn(("core",), config)
- self.assertNotIn(("CORE",), config)
- self.assertEqual("value3", config[("other",)])
- self.assertEqual(1, len(config))
- def test_len(self) -> None:
- config = CaseInsensitiveOrderedMultiDict()
- self.assertEqual(0, len(config))
- config[("core",)] = "value1"
- self.assertEqual(1, len(config))
- config[("CORE",)] = "value2"
- self.assertEqual(1, len(config)) # Same key, case insensitive
- def test_subsection_case_preserved(self) -> None:
- """Test that subsection names preserve their case."""
- config = CaseInsensitiveOrderedMultiDict()
- # Section names should be case-insensitive, but subsection names should preserve case
- config[("url", "https://Example.COM/Path")] = "value1"
- # Can retrieve with different case section name
- self.assertEqual("value1", config[("URL", "https://Example.COM/Path")])
- self.assertEqual("value1", config[("url", "https://Example.COM/Path")])
- # But not with different case subsection name
- with self.assertRaises(KeyError):
- config[("url", "https://example.com/path")]
- # Verify the stored key preserves subsection case
- stored_keys = list(config.keys())
- self.assertEqual(1, len(stored_keys))
- self.assertEqual(("url", "https://Example.COM/Path"), stored_keys[0])
- config[("other",)] = "value3"
- self.assertEqual(2, len(config))
- def test_make_from_dict(self) -> None:
- original = {("core",): "value1", ("other",): "value2"}
- config = CaseInsensitiveOrderedMultiDict.make(original)
- self.assertEqual("value1", config[("core",)])
- self.assertEqual("value1", config[("CORE",)])
- self.assertEqual("value2", config[("other",)])
- def test_make_from_self(self) -> None:
- config1 = CaseInsensitiveOrderedMultiDict()
- config1[("core",)] = "value"
- config2 = CaseInsensitiveOrderedMultiDict.make(config1)
- self.assertIs(config1, config2)
- def test_make_invalid_type(self) -> None:
- self.assertRaises(TypeError, CaseInsensitiveOrderedMultiDict.make, "invalid")
- def test_get_with_default(self) -> None:
- config = CaseInsensitiveOrderedMultiDict()
- config[("core",)] = "value"
- self.assertEqual("value", config.get(("core",)))
- self.assertEqual("value", config.get(("CORE",)))
- self.assertEqual("default", config.get(("missing",), "default"))
- # Test default_factory behavior
- config_with_factory = CaseInsensitiveOrderedMultiDict(
- default_factory=CaseInsensitiveOrderedMultiDict
- )
- result = config_with_factory.get(("missing",))
- self.assertIsInstance(result, CaseInsensitiveOrderedMultiDict)
- self.assertEqual(0, len(result))
- def test_setdefault(self) -> None:
- config = CaseInsensitiveOrderedMultiDict()
- # Set new value
- result1 = config.setdefault(("core",), "value1")
- self.assertEqual("value1", result1)
- self.assertEqual("value1", config[("core",)])
- # Try to set again with different case - should return existing
- result2 = config.setdefault(("CORE",), "value2")
- self.assertEqual("value1", result2)
- self.assertEqual("value1", config[("core",)])
- def test_values(self) -> None:
- config = CaseInsensitiveOrderedMultiDict()
- config[("core",)] = "value1"
- config[("other",)] = "value2"
- config[("CORE",)] = "value3" # Overwrites previous core value
- self.assertEqual({"value3", "value2"}, set(config.values()))
- def test_items_iteration(self) -> None:
- config = CaseInsensitiveOrderedMultiDict()
- config[("core",)] = "value1"
- config[("other",)] = "value2"
- config[("CORE",)] = "value3"
- items = list(config.items())
- self.assertEqual(3, len(items))
- self.assertEqual((("core",), "value1"), items[0])
- self.assertEqual((("other",), "value2"), items[1])
- self.assertEqual((("CORE",), "value3"), items[2])
- def test_str_keys(self) -> None:
- config = CaseInsensitiveOrderedMultiDict()
- config["core"] = "value"
- self.assertEqual("value", config["CORE"])
- self.assertEqual("value", config["CoRe"])
- def test_nested_tuple_keys(self) -> None:
- config = CaseInsensitiveOrderedMultiDict()
- config[("branch", "master")] = "value"
- # Section names are case-insensitive
- self.assertEqual("value", config[("BRANCH", "master")])
- self.assertEqual("value", config[("Branch", "master")])
- # But subsection names are case-sensitive
- with self.assertRaises(KeyError):
- config[("branch", "MASTER")]
- class ConfigFileSetTests(TestCase):
- def test_set_replaces_value(self) -> None:
- # Test that set() replaces the value instead of appending
- cf = ConfigFile()
- cf.set((b"core",), b"sshCommand", b"ssh -i ~/.ssh/id_rsa1")
- cf.set((b"core",), b"sshCommand", b"ssh -i ~/.ssh/id_rsa2")
- # Should only have one value
- self.assertEqual(b"ssh -i ~/.ssh/id_rsa2", cf.get((b"core",), b"sshCommand"))
- # When written to file, should only have one entry
- f = BytesIO()
- cf.write_to_file(f)
- content = f.getvalue()
- self.assertEqual(1, content.count(b"sshCommand"))
- self.assertIn(b"sshCommand = ssh -i ~/.ssh/id_rsa2", content)
- self.assertNotIn(b"id_rsa1", content)
|