Browse Source

Eslint - fix location of storybook folder & remove eslint ignore

LB 4 months ago
parent
commit
3697ee1f2a
4 changed files with 7 additions and 6 deletions
  1. 5 5
      .eslintrc.js
  2. 1 0
      CHANGELOG.txt
  3. 0 1
      client/storybook/middleware.js
  4. 1 0
      docs/releases/6.4.md

+ 5 - 5
.eslintrc.js

@@ -132,14 +132,14 @@ module.exports = {
       files: [
         'client/extract-translatable-strings.js',
         'client/tests/**',
-        'webpack.config.js',
         'tailwind.config.js',
-        'storybook/**/*',
-        '*.test.ts',
-        '*.test.tsx',
-        '*.test.js',
+        'webpack.config.js',
         '*.stories.js',
         '*.stories.tsx',
+        '*.test.js',
+        '*.test.ts',
+        '*.test.tsx',
+        '**/storybook/**',
       ],
       rules: {
         '@typescript-eslint/no-empty-function': 'off',

+ 1 - 0
CHANGELOG.txt

@@ -50,6 +50,7 @@ Changelog
  * Maintenance: Update `PreviewController` usage to leverage Stimulus actions instead of calling `preventDefault` manually (Ayaan Qadri)
  * Maintenance: Various performance optimizations to page publishing (Jake Howard)
  * Maintenance: Remove unnecessary DOM canvas.toBlob polyfill (LB (Ben) Johnston)
+ * Maintenance: Ensure Storybook core files are correctly running through Eslint (LB (Ben) Johnston)
 
 
 6.3.1 (19.11.2024)

+ 0 - 1
client/storybook/middleware.js

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-var-requires, import/no-extraneous-dependencies */
 const middleware = require('storybook-django/src/middleware');
 
 // Target the Django server with IPV4 address explicitly to avoid DNS resolution of localhost to IPV6.

+ 1 - 0
docs/releases/6.4.md

@@ -69,6 +69,7 @@ depth: 1
  * Update `PreviewController` usage to leverage Stimulus actions instead of calling `preventDefault` manually (Ayaan Qadri)
  * Various performance optimizations to page publishing (Jake Howard)
  * Remove unnecessary DOM canvas.toBlob polyfill (LB (Ben) Johnston)
+ * Ensure Storybook core files are correctly running through Eslint (LB (Ben) Johnston)
 
 
 ## Upgrade considerations - changes affecting all projects