Home Explore Help
Sign In
CityApper
/
wagtail
mirror of https://github.com/wagtail/wagtail
2
0
Fork 0
Files Issues 0 Wiki
Browse Source

move branding_title to the end of page title

Ensure the title of the Web page first identifies the topic of the page, then shows the group name followed by the name of the parent organisation.
* fixes #9054
* https://www.w3.org/WAI/WCAG21/Techniques/general/G88
* https://www.w3.org/WAI/WCAG21/Understanding/page-titled.html
Mehrdad Moradizadeh 2 years ago
parent
167a923fb1
commit
a0f038af14
8 changed files with 14 additions and 12 deletions
Split View Show Diff Stats
  1. 1 0
      CHANGELOG.txt
  2. 1 1
      client/tests/integration/groups.test.js
  3. 1 1
      client/tests/integration/listing.test.js
  4. 1 0
      docs/releases/4.1.md
  5. 1 1
      wagtail/admin/templates/wagtailadmin/skeleton.html
  6. 1 1
      wagtail/admin/tests/pages/test_edit_page.py
  7. 4 4
      wagtail/admin/tests/pages/test_preview.py
  8. 4 4
      wagtail/snippets/tests/test_preview.py

+ 1 - 0
CHANGELOG.txt
View File 

@@ -12,6 +12,7 @@ Changelog
 
  * Optimise the performance of the Wagtail userbar to remove duplicated queries, improving page loads when viewing live pages while signed in (Jake Howard)
 
  * Remove legacy `unbutton` styling for buttons (Paarth Agarwal)
 
  * Add button variations to the pattern library (Paarth Agarwal)
 
+ * Provide a more accessible page title where the unique information is shown first and the CMS name is shown last (Mehrdad Moradizadeh)
 
  * Fix: Prevent `PageQuerySet.not_public` from returning all pages when no page restrictions exist (Mehrdad Moradizadeh)

+ 1 - 1
client/tests/integration/groups.test.js
View File 

@@ -4,7 +4,7 @@ describe('Groups', () => {
 
   }, 10000);
 
 
   it('has the right heading', async () => {
 
-    expect(await page.title()).toContain('Wagtail - Editing Editors');
 
+    expect(await page.title()).toContain('Editing Editors - Wagtail');
 
   });
 
 
   it('axe', async () => {

+ 1 - 1
client/tests/integration/listing.test.js
View File 

@@ -5,7 +5,7 @@ describe('Listing', () => {
 
 
   it('has the right heading', async () => {
 
     expect(await page.title()).toContain(
 
-      'Wagtail - Exploring Welcome to your new Wagtail site!',
 
+      'Exploring Welcome to your new Wagtail site! - Wagtail',
 
     );
 
   });

+ 1 - 0
docs/releases/4.1.md
View File 

@@ -20,6 +20,7 @@ Wagtail 4.1 is designated a Long Term Support (LTS) release. Long Term Support r
 
  * Optimise the performance of the Wagtail userbar to remove duplicated queries, improving page loads when viewing live pages while signed in (Jake Howard)
 
  * Remove legacy `unbutton` styling for buttons (Paarth Agarwal)
 
  * Add button variations to the pattern library (Paarth Agarwal)
 
+ * Provide a more accessible page title where the unique information is shown first and the CMS name is shown last (Mehrdad Moradizadeh)
 
 
 ### Bug fixes

+ 1 - 1
wagtail/admin/templates/wagtailadmin/skeleton.html
View File 

@@ -5,7 +5,7 @@
 
 <html lang="{{ LANGUAGE_CODE }}" dir="{% if LANGUAGE_BIDI %}rtl{% else %}ltr{% endif %}">
 
     <head>
 
         <meta charset="utf-8" />
 
-        <title>{% block branding_title %}Wagtail{% endblock %} - {% block titletag %}{% endblock %}</title>
 
+        <title>{% block titletag %}{% endblock %} - {% block branding_title %}Wagtail{% endblock %}</title>
 
         <meta name="description" content="" />
 
         <meta name="viewport" content="width=device-width, initial-scale=1.0" />
 
         <meta name="robots" content="noindex" />

+ 1 - 1
wagtail/admin/tests/pages/test_edit_page.py
View File 

@@ -862,7 +862,7 @@ class TestPageEdit(TestCase, WagtailTestUtils):
 
         # We should have an error page because we are unable to
 
         # preview; the page key was not in the session.
 
         self.assertContains(
 
-            response, "<title>Wagtail - Preview not available</title>", html=True
 
+            response, "<title>Preview not available - Wagtail</title>", html=True
 
         )
 
         self.assertContains(
 
             response,

+ 4 - 4
wagtail/admin/tests/pages/test_preview.py
View File 

@@ -149,7 +149,7 @@ class TestPreview(TestCase, WagtailTestUtils):
 
         self.assertTemplateUsed(response, "wagtailadmin/generic/preview_error.html")
 
         self.assertContains(
 
             response,
 
-            "<title>Wagtail - Preview not available</title>",
 
+            "<title>Preview not available - Wagtail</title>",
 
             html=True,
 
         )
 
         self.assertContains(
 
@@ -188,7 +188,7 @@ class TestPreview(TestCase, WagtailTestUtils):
 
         self.assertTemplateUsed(response, "wagtailadmin/generic/preview_error.html")
 
         self.assertContains(
 
             response,
 
-            "<title>Wagtail - Preview not available</title>",
 
+            "<title>Preview not available - Wagtail</title>",
 
             html=True,
 
         )
 
         self.assertContains(
 
@@ -345,7 +345,7 @@ class TestPreview(TestCase, WagtailTestUtils):
 
         self.assertTemplateUsed(response, "wagtailadmin/generic/preview_error.html")
 
         self.assertContains(
 
             response,
 
-            "<title>Wagtail - Preview not available</title>",
 
+            "<title>Preview not available - Wagtail</title>",
 
             html=True,
 
         )
 
         self.assertContains(
 
@@ -380,7 +380,7 @@ class TestPreview(TestCase, WagtailTestUtils):
 
         self.assertTemplateUsed(response, "wagtailadmin/generic/preview_error.html")
 
         self.assertContains(
 
             response,
 
-            "<title>Wagtail - Preview not available</title>",
 
+            "<title>Preview not available - Wagtail</title>",
 
             html=True,
 
         )
 
         self.assertContains(

+ 4 - 4
wagtail/snippets/tests/test_preview.py
View File 

@@ -50,7 +50,7 @@ class TestPreview(TestCase, WagtailTestUtils):
 
         self.assertTemplateUsed(response, "wagtailadmin/generic/preview_error.html")
 
         self.assertContains(
 
             response,
 
-            "<title>Wagtail - Preview not available</title>",
 
+            "<title>Preview not available - Wagtail</title>",
 
             html=True,
 
         )
 
         self.assertContains(
 
@@ -81,7 +81,7 @@ class TestPreview(TestCase, WagtailTestUtils):
 
         self.assertTemplateUsed(response, "wagtailadmin/generic/preview_error.html")
 
         self.assertContains(
 
             response,
 
-            "<title>Wagtail - Preview not available</title>",
 
+            "<title>Preview not available - Wagtail</title>",
 
             html=True,
 
         )
 
         self.assertContains(
 
@@ -220,7 +220,7 @@ class TestPreview(TestCase, WagtailTestUtils):
 
         self.assertTemplateUsed(response, "wagtailadmin/generic/preview_error.html")
 
         self.assertContains(
 
             response,
 
-            "<title>Wagtail - Preview not available</title>",
 
+            "<title>Preview not available - Wagtail</title>",
 
             html=True,
 
         )
 
         self.assertContains(
 
@@ -250,7 +250,7 @@ class TestPreview(TestCase, WagtailTestUtils):
 
         self.assertTemplateUsed(response, "wagtailadmin/generic/preview_error.html")
 
         self.assertContains(
 
             response,
 
-            "<title>Wagtail - Preview not available</title>",
 
+            "<title>Preview not available - Wagtail</title>",
 
             html=True,
 
         )
 
         self.assertContains(