Fix Javascript alerts reported by LGTM

client/src/components/Explorer/actions.js

@@ -86,7 +86,7 @@ export function pushPage(id) {
 
     dispatch(pushPagePrivate(id));
 
-    if (page && !page.isFetching && !page.children.count > 0) {
+    if (page && !page.isFetching && !(page.children.count > 0)) {
       dispatch(getChildren(id));
     }
   };

gulpfile.js/lib/simplyCopy.js

@@ -1,5 +1,4 @@
 var gulp = require('gulp');
-var rename = require('gulp-rename');
 var gutil = require('gulp-util');
 var path = require('path');
 var config = require('../config');

wagtail/admin/static_src/wagtailadmin/js/blocks/sequence.js

@@ -52,7 +52,7 @@ CODE FOR SETTING UP SPECIFIC UI WIDGETS, SUCH AS DELETE BUTTONS OR MENUS, DOES N
             self.container.slideDown();
 
             // focus first suitable input found
-            var timeout = setTimeout(function() {
+            setTimeout(function() {
               var $input = $('.input', self.container);
               var $firstField = $('input, textarea, [data-hallo-editor], [data-draftail-input]', $input).first();
 
@@ -93,9 +93,6 @@ CODE FOR SETTING UP SPECIFIC UI WIDGETS, SUCH AS DELETE BUTTONS OR MENUS, DOES N
             return opts.prefix + '-' + newIndex;
         }
 
-        function setInitialMoveUpDownState(newMember) {
-        }
-
         function postInsertMember(newMember) {
             /* run any supplied initializer functions */
             if (opts.onInitializeMember) {

wagtail/admin/static_src/wagtailadmin/js/core.js

@@ -105,10 +105,6 @@ $(function() {
     // Resize nav to fit height of window. This is an unimportant bell/whistle to make it look nice
     var fitNav = function() {
         $('.nav-wrapper').css('min-height', $(window).height());
-        $('.nav-main').each(function() {
-            var thisHeight = $(this).height();
-            var footerHeight = $('#footer', $(this)).height();
-        });
     };
 
     fitNav();
@@ -271,7 +267,7 @@ $(function() {
         }
 
         function getURLParam(name) {
-            var results = new RegExp('[\?&]' + name + '=([^]*)').exec(window.location.search);
+            var results = new RegExp('[\\?&]' + name + '=([^]*)').exec(window.location.search);
             if (results) {
                 return results[1];
             }
@@ -471,8 +467,6 @@ wagtail = (function(document, window, wagtail) {
         },
 
         _handleClick: function(e) {
-            var el = this.el;
-
             if (!this.state.isOpen) {
                 this.openDropDown(e);
             } else {

wagtail/admin/static_src/wagtailadmin/js/modal-workflow.js

@@ -75,7 +75,7 @@ function ModalWorkflow(opts) {
 
     self.respond = function(responseType) {
         if (responseType in responseCallbacks) {
-            args = Array.prototype.slice.call(arguments, 1);
+            var args = Array.prototype.slice.call(arguments, 1);
             responseCallbacks[responseType].apply(self, args);
         }
     };

wagtail/admin/static_src/wagtailadmin/js/page-chooser-modal.js

@@ -67,7 +67,7 @@ PAGE_CHOOSER_MODAL_ONLOAD_HANDLERS = {
         function ajaxifySearchResults() {
             $('.page-results a.choose-page', modal.body).on('click', function() {
                 var pageData = $(this).data();
-                modal.respond('pageChosen', $(this).data());
+                modal.respond('pageChosen', pageData);
                 modal.close();
 
                 return false;
@@ -96,7 +96,7 @@ PAGE_CHOOSER_MODAL_ONLOAD_HANDLERS = {
             $('a.choose-page', modal.body).on('click', function() {
                 var pageData = $(this).data();
                 pageData.parentId = jsonData['parent_page_id'];
-                modal.respond('pageChosen', $(this).data());
+                modal.respond('pageChosen', pageData);
                 modal.close();
 
                 return false;

wagtail/admin/static_src/wagtailadmin/js/page-editor.js

@@ -1,13 +1,13 @@
 'use strict';
 
-var halloPlugins = {};
-function registerHalloPlugin(name, opts) {
+var halloPlugins = {};  // lgtm[js/unused-local-variable]
+function registerHalloPlugin(name, opts) {  // lgtm[js/unused-local-variable]
     /* Obsolete - used on Wagtail <1.12 to register plugins for the hallo.js editor.
     Defined here so that third-party plugins can continue to call it to provide Wagtail <1.12
     compatibility, without throwing an error on later versions. */
 }
 
-function InlinePanel(opts) {
+function InlinePanel(opts) {  // lgtm[js/unused-local-variable]
     var self = {};
 
     self.setHasContent = function() {

wagtail/contrib/forms/templates/wagtailforms/index_submissions.html

@@ -24,7 +24,6 @@
 
             var selectAllCheckbox = document.getElementById('select-all');
             var deleteButton = document.getElementById('delete-submissions');
-            var selectedSubmissions = {};
 
             function updateActions() {
                 var submissionCheckboxes = $('input[type=checkbox].select-submission');

wagtail/contrib/styleguide/templates/wagtailstyleguide/base.html

@@ -867,7 +867,7 @@
                 var to = setTimeout(function(){
                     runprogress();
                     clearTimeout(to);
-                    var to2 = setTimeout(function(){
+                    setTimeout(function(){
                         $('#progress-example .bar').css('width', '20%');
                     }, 2000);
                 }, 3000);

wagtail/contrib/table_block/static/table_block/js/table.js

@@ -28,7 +28,6 @@ function initTable(id, tableOptions) {
         var tableParent = $('#' + id).parent();
         return tableParent.find('.htCore').height() + (tableParent.find('.input').height() * 2);
     };
-    var height = getHeight();
     var resizeTargets = ['.input > .handsontable', '.wtHider', '.wtHolder'];
     var resizeHeight = function(height) {
         var currTable = $('#' + id);

wagtail/documents/static_src/wagtaildocs/js/document-chooser-modal.js

@@ -46,6 +46,7 @@ DOCUMENT_CHOOSER_MODAL_ONLOAD_HANDLERS = {
             return false;
         };
         function setPage(page) {
+            var dataObj;
 
             if($('#id_q').val().length){
                 dataObj = {q: $('#id_q').val(), p: page};
@@ -82,7 +83,7 @@ DOCUMENT_CHOOSER_MODAL_ONLOAD_HANDLERS = {
                 dataType: 'text',
                 success: modal.loadResponseText,
                 error: function(response, textStatus, errorThrown) {
-                    message = jsonData['error_message'] + '<br />' + errorThrown + ' - ' + response.status;
+                    var message = jsonData['error_message'] + '<br />' + errorThrown + ' - ' + response.status;
                     $('#upload').append(
                         '<div class="help-block help-critical">' +
                         '<strong>' + jsonData['error_label'] + ': </strong>' + message + '</div>');

wagtail/images/static_src/wagtailimages/js/image-chooser-modal.js

@@ -47,7 +47,7 @@ IMAGE_CHOOSER_MODAL_ONLOAD_HANDLERS = {
         }
 
         function setPage(page) {
-            params = {p: page};
+            var params = {p: page};
             if ($('#id_q').val().length){
                 params['q'] = $('#id_q').val();
             }
@@ -81,7 +81,7 @@ IMAGE_CHOOSER_MODAL_ONLOAD_HANDLERS = {
                     dataType: 'text',
                     success: modal.loadResponseText,
                     error: function(response, textStatus, errorThrown) {
-                        message = jsonData['error_message'] + '<br />' + errorThrown + ' - ' + response.status;
+                        var message = jsonData['error_message'] + '<br />' + errorThrown + ' - ' + response.status;
                         $('#upload').append(
                             '<div class="help-block help-critical">' +
                             '<strong>' + jsonData['error_label'] + ': </strong>' + message + '</div>');
@@ -135,8 +135,6 @@ IMAGE_CHOOSER_MODAL_ONLOAD_HANDLERS = {
     },
     'select_format': function(modal) {
         $('form', modal.body).on('submit', function() {
-            var formdata = new FormData(this);
-
             $.post(this.action, $(this).serialize(), modal.loadResponseText, 'text');
 
             return false;

wagtail/images/static_src/wagtailimages/js/image-url-generator.js

@@ -40,7 +40,7 @@ $(function() {
 
                 if (filterSpec == 'fill') {
                     $closenessField.prop('disabled', false);
-                    filterSpec += '-' + $widthField.val() + 'x' + $heightField.val() + '-c' + $closenessField.val()
+                    filterSpec += '-' + $widthField.val() + 'x' + $heightField.val() + '-c' + $closenessField.val();
                 } else {
                     $closenessField.prop('disabled', true);
                     filterSpec += '-' + $widthField.val() + 'x' + $heightField.val();

wagtail/search/static_src/wagtailsearch/js/query-chooser-modal.js

@@ -30,6 +30,7 @@ QUERY_CHOOSER_MODAL_ONLOAD_HANDLERS = {
             return false;
         }
         function setPage(page) {
+            var dataObj;
 
             if($('#id_q').val().length){
                 dataObj = {q: $('#id_q').val(), p: page};

wagtail/snippets/static_src/wagtailsnippets/js/snippet-multiple-select.js

@@ -1,6 +1,6 @@
 var updateRow = function(id, newValue) {
-    $row = $('table.listing tr#snippet-row-' + id);
-    $checklist = $row.find('input[type=checkbox].toggle-select-row');
+    var $row = $('table.listing tr#snippet-row-' + id);
+    var $checklist = $row.find('input[type=checkbox].toggle-select-row');
     $checklist.prop('checked', newValue);
     if (newValue) {
         $row.addClass('selected');
@@ -37,8 +37,8 @@ var updateSelectAllCheckbox = function(value) {
 
 var buildSelectedState = function() {
     // prepare the selected state -- {3: true, 4: false}
-    state = {};
-    $rows = $('table.listing tbody tr input[type=checkbox].toggle-select-row');
+    var state = {};
+    var $rows = $('table.listing tbody tr input[type=checkbox].toggle-select-row');
     $.each($rows, function (index, row) {
         var $row = $(row);
         var selected = $row.prop('checked');