Sfoglia il codice sorgente

Fix error insertion logic for modal upload forms

Fixes #9019

* The `[data-field]` element (not the input) should be queried to find the `[data-field-errors]` element
* The code should not assume the presence of an icon element
Matt Westcott 2 anni fa
parent
commit
323dfe49e9
1 ha cambiato i file con 5 aggiunte e 2 eliminazioni
  1. 5 2
      client/src/includes/chooserModal.js

+ 5 - 2
client/src/includes/chooserModal.js

@@ -13,8 +13,11 @@ const validateCreationForm = (form) => {
         input.setAttribute('aria-invalid', 'true');
         const field = input.closest('[data-field]');
         field.classList.add('w-field--error');
-        const errors = input.querySelector('[data-field-errors]');
-        errors.querySelector('.icon').removeAttribute('hidden');
+        const errors = field.querySelector('[data-field-errors]');
+        const icon = errors.querySelector('.icon');
+        if (icon) {
+          icon.removeAttribute('hidden');
+        }
         const errorElement = document.createElement('p');
         errorElement.classList.add('error-message');
         errorElement.innerHTML = gettext('This field is required.');